Commit Graph
3 Commits
Author SHA1 Message Date
5a7e8fea2f [MIRROR] Fixes an odd bug with record consoles (#26968)
* Fixes an odd bug with record consoles (#82103)

## About The Pull Request

1. Record computers never had ``character_preview_view`` set because it
was never returned, and it was additionally never deleted. This caused
an odd bug that, if you joined a round, ghosted, sent yourself back to
lobby, then rejoined, record consoles would no longer have a character
preview view. This fixes that, and also adds a define because I didn't
like the copypasta it had going on.

Security records currently have a big difference from the previous
version in that every person on the UI sees their own thing (it's local
instead of shared), which is a bigger problem that affects the whole
computer and really should be addressed.

This PR compliments https://github.com/tgstation/tgstation/pull/82105 -
This was a bug I found while working on that.

## Why It's Good For The Game

Fixes an odd bug with security records that I've been trying to find out
the cause to for a while.

## Changelog

🆑
fix: Clients joining a round twice as a crewmember (via admins or
otherwise) no longer break security/medical record consoles permanently.
/🆑

* Fixes an odd bug with record consoles

---------

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2024-03-23 16:49:28 -04:00
964fc99589 [MIRROR] Feature: bitrunner, a new supply role (READY) [MDB IGNORE] (#23865)
* Feature: bitrunner, a new supply role (READY)

* Delete bepis.dm

* Conflicts

* Update dynamic_rulesets_midround.dm

* Fixing this invalid icon file path

It was trying to use the aesthetics one

* Bepis is dead

* New digi sprites courtesy of CandleJaxx!!

Now in the correct branch!

* Fixing merge conflict

* bitrunning hotfixes [NO GBP]

* Modular health adjustments

* Revert "Modular health adjustments"

This reverts commit 0ff3c48d398f6c1aac51cdf8fecaf869491bbc86.

* Modular health adjustments

Only this one should be necessary

* The screenshot test

* Bitrunner den for voidraptor (FOR #23865) (#23891)

* no shower in sight

* lets bitrunners actually get to their room and spawn there

* New digi sprites courtesy of CandleJaxx!!

* Revert "New digi sprites courtesy of CandleJaxx!!"

This reverts commit eea9f47de256dd407c78450bc8f2a09b814f93e9.

---------

Co-authored-by: Giz <13398309+vinylspiders@users.noreply.github.com>

* Removes bitrunning unit tests (#78607)

## About The Pull Request
Removes the fraction of unit tests I thought would be safe.
Not thrilled that I have to exclude ALL unit tests now, but hey.

The issue is that atmos attempts to process on a turf which hasn't
initialized yet.
## Why It's Good For The Game
Other PRs can pass checks now
## Changelog
N/A

* Update birdshot.dmm

* Tweaks the BEPIS category of the bitrunning order console

* Adds back the flashdark that we had skyrat edited in

* Update tgstation.dme

* Fixes Voidraptor bitrunning den not being connected to the powergrid

---------

Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
Co-authored-by: Giz <13398309+vinylspiders@users.noreply.github.com>
Co-authored-by: Paxilmaniac <82386923+Paxilmaniac@users.noreply.github.com>
Co-authored-by: Profakos <profakos@gmail.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2023-09-29 20:53:36 -04:00
SkyratBotandGitHub 6756631e75 [MIRROR] The Mining vendor now works like the Chef produce console (has to go through Cargo) [MDB IGNORE] (#17852) 2022-12-01 14:34:56 -08:00