## About The Pull Request
The original implementation was flawed as it added all particle holders
to vis_contents and displayed/masked all of them at once if the z-level
had any weather present. This caused "bleed-through" if two z-levels
with the same z-stack offset had particle weather running at the same
time (such as ash storm on lavaland and a weather anomaly rain on
station's first z-level) causing particles from both z-stacks to display
on both z-levels. By tracking holder's assigned z-levels we can filter
holders not affecting any levels in the current plane z-stack, which
solves this issue. There's still the problem of multiple particle
weathers running on the same z-level, but this is so insanely rare (and
also some other code would break anyways) I don't think its worth
currently bothering with as it would require some insane code to
resolve.
## Changelog
🆑
fix: Fixed particle weather bleeding through z-levels when different
weathers are present
/🆑
## About The Pull Request
This achieved opposite of the desired effect, making the overlay render
only with the particle weather pref ON, not OFF
## Changelog
🆑
fix: Fixed rain overlay rendering (only) with particle weather enabled
/🆑
## About The Pull Request
Closes#96601
Also fixes pref button breaking one of the modes permanently when
swapped within a round, rain not displaying (due to missing overlay
states) when particle weather is disabled, and weather particle plates
having the same name as weather planes (causes dupe entries in the
planecube debugger)
## Changelog
🆑
fix: Radstorms (and other weather) no longer go over your hud on multi-z
maps
fix: Rain is no longer invisible when you have particle weather disabled
fix: Changing the particle weather pref no longer permanently breaks
some weathers for the round
/🆑
## About The Pull Request
Due to a BYOND bug, large amounts of particles will cause immense lag
and framedrops on AMD GPUs, no matter how good the GPU itself is.
Unfortunately this is most noticeable with new particle weather, to the
point where storms reduce framerate to single digits for players who
haven't invested into NVIDIA before the AI market boom.
By rendering overlays twice and only enabling one of the planes, we can
allow players to toggle between new particle weather (semi-transparent
overlays + particles) and old (fully opaque overlays)
Unfortunately we don't have a way to check the player's GPU (at least
not easily) so players will have to change it themselves
https://github.com/user-attachments/assets/0c36fca4-c8a4-42ed-895f-42e853b10f44
(Particle weather is a bit more dense without ghost vision but i'm too
lazy to re-record)
Closes#96460 (Sort of)
## Changelog
🆑
qol: Particle weather can now be disabled in favor of old weather. !!!
AMD GPU USERS NEED TO SWITCH TO OLD WEATHER TO FIX THE LAG!!!
/🆑
## About The Pull Request
Missing END_STAGE check caused mask overlays to remain when the weather
ended and bleed through the blackness if you did not have mesons
equipped (which i did during testing, and did not spot the issue. Oops)
## Changelog
🆑
fix: Fixed broken area overlays for particle weather
/🆑
## About The Pull Request
Refactors random reagent spawning to be divided into bitflags. This mean
you can now decide from which random sources a reagent is allowed to
spawn. Rejoice, now maintenance pills can have fun reagents without
having to deal with the balance implications of a botanist producing
1000u of it!
**SO NOW MAINTPILLS CAN HAVE CYBORG NANITES AND XENOMORPH MICROBES!!
REJOICE, MY ABOMINATIONS!!!**
Code stuff:
CAN_SYNTH is now only for copying reagents, which is what it was
originally intended for. A new randomized_spawns var has been added to
reagents that decided where it can spawn.
I've also changed some unsanitary reagent spawners to obey the spawn
flags. This was the beebox kit (which could spawn literally every
reagent in the game, including adminordrazine) and traitor bees, which
now can't spawn the two spider toxins and gatfruit toxin (why do we even
have gatfruit toxin?? shit does nothing).
Balance overview:
- Beeboxes no longer spawn everything
- Traitor bees no longer spawn venom, viper venom and gatfruit toxin
- Maintenance pills now spawn cyborg nanites and xenomorph microbes
When I say maintpills, I mean REAL maintpills. The ones of which only a
few spawn per round in maintenance, and not the fake ones that feature
creepers added to cargo, blackmarket and that got mapped in
## Why It's Good For The Game
We're limited to which reagents we can spawn randomly because sources
like strange seeds, geysers and fake maintpills are infinitely
reproducible, and can be used to get an infinite amount of every random
spawnable reagent in every round (to be fair this is quite labor
intensive, but never underestimate autism).
Only about 3-6 maintenance pills spawn per round and there's about 700
spawnable reagents. There's simply no way to force the odds to get the
reagent you want. I think the crew can have a little maintxenomicrobes
and a little maintpill borgnanites
As to why these two specifically:
borgnanites are already only randomly obtainable, are cured easily and
the effects of it are just one more cyborg player. It's a fun story, and
not particularly disruptive to the round
Xenomicrobes are admin only, so I would not be lessening any other
features. Otherwise it's pretty much gonna cause an incident in-game
when this happens, but who cares!!!
I can make maintpills secretely reroll if the reagents are extracted
instead of eaten to keep these always contained to the person eating
them, but our playerbase so prefers eating over grinding that I think
it's fine
I have not included inverse reagents, blob spores etc because I respect
them as their own features. I would however like to add some new, wacky
maintpill reagents that can lead to some fun stories.
## Changelog
🆑
fix: Fixes beebox and traitor bees not obeying the reagent blacklist
balance: Maintenance pills (the achievement variety that only spawns in
maint) can now generate with xenomorph microbes and cyborg nanites
/🆑
---------
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
## About The Pull Request
- Removed global list `fake_reagent_blacklist` in favour of
`abstract_type`. Saved memory
- Removed proc `get_chemical_reaction()` in favor of
`GLOB.chemical_reaction_list`. No proc overhead and faster access
- Remove unused proc `remove_chemical_reaction()`
- Removed proc `find_reagent()` in favour of
`GLOB.chemical_reagents_list`. No proc overhead and faster access
- Directly access name of reagents via `::` operator from typepaths
instead of looking up the datum in global chemical reagents list for
some operations. Faster variable access
- Removed unit test `reagent_id_typos`. The typepaths will error at
compile time because they aren't strings so there's no need for this
test
## Changelog
🆑
code: cleaned up code pertaining to reagent & reaction lookup
/🆑
## About The Pull Request
A weather anomaly can spawn on the station, causing a sandstorm,
snowstorm, or rainstorm to affect the room (and nearby rooms). These
weathers range from "harmless" to "mildly damaging".
They last for around five minutes.
The weather doesn't start immediately, giving people time to neutralize
it before it causes damage.
Neutralizing the anomaly stops the weather.
If they detonate, it just throw objects away from itself.
<img width="407" height="225" alt="image"
src="https://github.com/user-attachments/assets/2de1b797-2b17-442c-9023-11085b4849cf"
/>
<img width="991" height="674" alt="image"
src="https://github.com/user-attachments/assets/afe5a21d-9cf8-4e9d-95ec-adef6fd12a93"
/>
A rarer version of the anomaly can also occur, which brings a lightning
storm, which may damage the station itself.
Also, reactive weather armor. When you are hit, it summons a lightning
strike below nearby assailants.
## Why It's Good For The Game
With the added rain mechanics I wanted to use them, but it's kinda hard
to shoe them into the station because, "why is it raining on a space
station that makes no sense"
However, anomalies are weird, so this fits perfectly
## Changelog
🆑 Melbert
add: Weather anomalies, in four variants: Rain, snow, sand, and the rare
lightning storm.
add: Reactive Weather Armor
/🆑
## About The Pull Request
It's just a partial cleanup of
anti-[STYLE](https://github.com/tgstation/tgstation/blob/master/.github/guides/STYLE.md)
code from /tg/'s ancient history. I compiled & tested with my helpful
assistant and damage is still working.
<img width="1920" height="1040" alt="image"
src="https://github.com/user-attachments/assets/26dabc17-088f-4008-b299-3ff4c27142c3"
/>
I'll upload the .cs script I used to do it shortly.
## Why It's Good For The Game
Just minor code cleanup.
Script used is located at https://metek.tech/camelTo-Snake.7z
EDIT 11/23/25: Updated the script to use multithreading and sequential
scan so it works a hell of a lot faster
```
/*
//
Copyright 2025 Joshua 'Joan Metekillot' Kidder
This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
You should have received a copy of the GNU General Public License along with this program. If not, see <https://www.gnu.org/licenses/>.
//
*/
using System.Text.RegularExpressions;
class Program
{
static async Task Main(string[] args)
{
var readFile = new FileStreamOptions
{
Access = FileAccess.Read,
Share = FileShare.ReadWrite,
Options = FileOptions.Asynchronous | FileOptions.SequentialScan
};
FileStreamOptions writeFile = new FileStreamOptions
{
Share = FileShare.ReadWrite,
Access = FileAccess.ReadWrite,
Mode = FileMode.Truncate,
Options = FileOptions.Asynchronous
};
RegexOptions regexOptions = RegexOptions.Multiline | RegexOptions.Compiled;
Dictionary<string, int> changedProcs = new();
string regexPattern = @"(?<=\P{L})([a-z]+)([A-Z]{1,2}[a-z]+)*(Brute|Burn|Fire|Tox|Oxy|Organ|Stamina)(Loss)([A-Z]{1,2}[a-z]+)*";
Regex camelCaseProcRegex = new(regexPattern, regexOptions);
string snakeify(Match matchingRegex)
{
var vals =
matchingRegex.Groups.Cast<Group>().SelectMany(_ => _.Captures).Select(_ => _.Value).ToArray();
var newVal = string.Join("_", vals.Skip(1).ToArray()).ToLower();
string logString = $"{vals[0]} => {newVal}";
if (changedProcs.TryGetValue(logString, out int value))
{
changedProcs[logString] = value + 1;
}
else
{
changedProcs.Add(logString, 1);
}
return newVal;
}
var dmFiles = Directory.EnumerateFiles(".", "*.dm", SearchOption.AllDirectories).ToAsyncEnumerable<string>();
// uses default ParallelOptions
// https://learn.microsoft.com/en-us/dotnet/api/system.threading.tasks.paralleloptions?view=net-10.0#main
await Parallel.ForEachAsync(dmFiles, async (filePath, UnusedCancellationToken) =>
{
var reader = new StreamReader(filePath, readFile);
string oldContent = await reader.ReadToEndAsync();
string newContent = camelCaseProcRegex.Replace(oldContent, new MatchEvaluator((Func<Match, string>)snakeify));
if (oldContent != newContent)
{
var writer = new StreamWriter(filePath, writeFile);
await writer.WriteAsync(newContent);
await writer.DisposeAsync();
}
reader.Dispose();
});
var logToList = changedProcs.Cast<KeyValuePair<string, int>>().ToList();
foreach (var pair in logToList)
{
Console.WriteLine($"{pair.Key}: {pair.Value} locations");
}
}
}
```
## Changelog
🆑 Bisar
code: All (Brute|Burn|Fire|Tox|Oxy|Organ|Stamina)(Loss) procs now use
snake_case, in-line with the STYLE guide. Underscores rule!
/🆑
## About The Pull Request
/area/station/ai_monitored's behaviour was isolated into a component,
`/datum/component/monitored_area`, which itself uses
`/datum/motion_group`s to query cameras. Functionally, it (should) work
identically to the old implementation. I'm sure that behaviour could
have been further cleaned up, camera code is quite dreadful, but it's
better to focus on isolating the behaviour first. Baby steps.
Areas that want to opt into monitoring can set `var/motion_monitored` to
TRUE (this approach was taken to make subtyping easier).
The following non-AI areas were changed:
- /area/station/ai_monitored/security/armory ->
/area/station/security/armory
- /area/station/ai_monitored/command/nuke_storage ->
/area/station/command/vault
- /area/station/ai_monitored/command/storage/eva ->
/area/station/command/eva
All other `/area/station/ai_monitored` subtypes were repathed into
`/area/station/ai` and cleaned up in a way that I thought made logical
sense. It is **much** more readable now. For example:
- /area/station/ai_monitored/turret_protected/aisat ->
/area/station/ai/satellite
- /area/station/ai_monitored/command/storage/satellite ->
/area/station/ai/satellite/maintenance/storage
- /area/station/ai_monitored/turret_protected/ai ->
/area/station/ai/satellite/chamber
## About The Pull Request
- Status Displays update automatically for emergency alerts and show
round start logos by default instead of a blank screen.
- Tested in game with manual graphics and with triggered events.
- There is also a priority system, some emergencies will display
temporarily if a higher priority (shuttle call) is in progress.
- It also has checks on when something ends, i.e if radiation storm
happens, the alert for that goes away after the storm passes instead of
staying on the display.
- The manual buttons on the comms console to update the screens are
still there and work with this.
- BLOB file tweaks - All blob features works but with non blocking
cleanup as Linter threw errors.
- Also found a nicer sprite from AI core to use for the NT logo on the
displays since we'll be seeing it on more, the current one is just a bit
too bright
| Default logo | Alert Level Auto Switch | Events "can" interrupt
shuttle call display but only for 30 seconds |
|--------|--------|--------|
| <img width="443" height="182" alt="image"
src="https://github.com/user-attachments/assets/4027d8cc-041a-4e26-8120-742bf38f9c8a"
/>| <img width="444" height="181" alt="image"
src="https://github.com/user-attachments/assets/267363be-7f3a-4b63-a412-ea74c9d23c60"
/> | <img width="432" height="172" alt="image"
src="https://github.com/user-attachments/assets/842b9bfd-6e32-4833-8c06-42518dd8c0d2"
/> |
**Nanotrasen Logo Replacement - Left is original - Right is new**
<img width="181" height="82" alt="image"
src="https://github.com/user-attachments/assets/ac78d1c2-059b-4ab5-9d2c-3e59bec87620"
/>
## Why It's Good For The Game
- Status displays leave an empty void on the walls in rounds, this adds
a bit more value to them
- Should make the screens feel busier/more dynamic and the game a little
more engaging
## Changelog
🆑
add: Status displays now show logo at round start - Status displays now
change more often for alerts and other key events
fix: Blob non blocking cleanup - Should have no change in player
experience
image: Replaces bright blue NT logo with the more subtle slightly
animated sprite from AI core, fits nicer.
/🆑
---------
Co-authored-by: loganuk <falseemail@aol.com>
## About The Pull Request
Adds a number of new capabilities to glitter.
- It can be any colour.
<img width="657" height="398" alt="image"
src="https://github.com/user-attachments/assets/60e80c04-8eee-470c-8953-47f6eda9f83e"
/>
- It can be made in chemistry and dyed by combining it with acetone and
other reagents to give it the average colour of the non-glitter,
not-acetone reagents.
- Multiple colours can be mixed into one reagent datum, randomly
depositing a colour from those in the datum on the floor.
<img width="554" height="507" alt="image"
src="https://github.com/user-attachments/assets/9cc7d1d5-9bec-4b28-af06-310ffb24de49"
/>
- Anyone with glitter reagent in them will cough glitter onto the floor
- Glittery crates will leave a trail of appropriately coloured glitter
when moved
<img width="960" height="259" alt="image"
src="https://github.com/user-attachments/assets/71cc1176-23f9-4ae7-b500-1744b752c014"
/>
Resprited glitter to support these changes and make it not look like gas
(or ass).
## Why It's Good For The Game
It looks cool and raises the bar for chemists maximally pissing off the
janitor as they fill a room with multicoloured glitter and all the
occupants run off to cough more up all over the surrounding area.
## Changelog
🆑
add: Glitter can now be made from plastic polymers and aluminium.
add: Plastic polymer can be made at any temperature, and then heated to
produce sheets.
add: Glitter can now be made any colour, mix 10 units each of glitter
and acetone to change its colour to that of the other reagents in the
beaker.
add: Mixing different colours of glitter will cause a random selection
of those colours to appear on the floor when released.
add: Being exposed to glitter in reagent form causes you to cough up
more glitter onto the floor
add: Dragging glittery crates will now spread a trail of glitter and
angry janitors behind them.
image: Added new glitter sprites (that don't look like gasses)
/🆑
## About The Pull Request
Adds a number of new capabilities to glitter.
- It can be any colour.
<img width="657" height="398" alt="image"
src="https://github.com/user-attachments/assets/60e80c04-8eee-470c-8953-47f6eda9f83e"
/>
- It can be made in chemistry and dyed by combining it with acetone and
other reagents to give it the average colour of the non-glitter,
not-acetone reagents.
- Multiple colours can be mixed into one reagent datum, randomly
depositing a colour from those in the datum on the floor.
<img width="554" height="507" alt="image"
src="https://github.com/user-attachments/assets/9cc7d1d5-9bec-4b28-af06-310ffb24de49"
/>
- Anyone with glitter reagent in them will cough glitter onto the floor
- Glittery crates will leave a trail of appropriately coloured glitter
when moved
<img width="960" height="259" alt="image"
src="https://github.com/user-attachments/assets/71cc1176-23f9-4ae7-b500-1744b752c014"
/>
Resprited glitter to support these changes and make it not look like gas
(or ass).
## Why It's Good For The Game
It looks cool and raises the bar for chemists maximally pissing off the
janitor as they fill a room with multicoloured glitter and all the
occupants run off to cough more up all over the surrounding area.
## Changelog
🆑
add: Glitter can now be made from plastic polymers and aluminium.
add: Plastic polymer can be made at any temperature, and then heated to
produce sheets.
add: Glitter can now be made any colour, mix 10 units each of glitter
and acetone to change its colour to that of the other reagents in the
beaker.
add: Mixing different colours of glitter will cause a random selection
of those colours to appear on the floor when released.
add: Being exposed to glitter in reagent form causes you to cough up
more glitter onto the floor
add: Dragging glittery crates will now spread a trail of glitter and
angry janitors behind them.
image: Added new glitter sprites (that don't look like gasses)
/🆑
## About The Pull Request
Fixes and tweaks to the radiation storm event.
- Actually enables/revokes emergency maintenance access like the
announcement says
- Removes the part of the announcement telling people to go to medbay at
the START of the radstorm
- Adjusts the announcement text to match the audio
- Fixes a check in minimum_security_level to ignore if emergency access
is already enabled
- Updated our alert proc with a new arg added by TG
- The weather alert sound plays to people on the impacted Z level,
making you aware the weather event started
- Deletes a duplicate radiation.ogg that exists for some reason
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
Shorter event announcement (No more 'please go to medbay')
https://github.com/user-attachments/assets/552e4eeb-a09e-4467-b69c-f10add7ecdb1
</details>
## Changelog
🆑 LT3
fix: Radiation storm event actually enables maintenance access
qol: Improved feedback and notifications for the radiation storm event
/🆑
## About The Pull Request
So Thor was very displeased with this one particular CI run, and decided
to strike the same turf with lightning four consecutive times.
This resulted in trying to hit the same wire that already had been long
since nuked by an initial blast. _three more times_.
Fixes that from happening in the future.
## Why It's Good For The Game
Less flaky CI failures from the wrathful gods
## Changelog
Nothing player facing
---------
Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com>
## About The Pull Request
Closes#91040 by making the check on the ash storm be inside of the
recursive parent checking, makes power miners (holoparasites) spawned
from the dusty shard ash and snowstorm immune
## Why It's Good For The Game
Fixes bug, latter makes you take double damage if you don't have
protection, and if you do it prevents your miner from going outside of
your body during a storm. Them having protection from storms is kinda
fitting.
## Changelog
🆑
balance: Power Miners are now ash and snowstorm immune
fix: Holoparasites no longer take damage from ash storms inside of
storm-protected hosts
/🆑
## About The Pull Request
So Thor was very displeased with this one particular CI run, and decided
to strike the same turf with lightning four consecutive times.
This resulted in trying to hit the same wire that already had been long
since nuked by an initial blast. _three more times_.
Fixes that from happening in the future.
## Why It's Good For The Game
Less flaky CI failures from the wrathful gods
## Changelog
Nothing player facing
---------
Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com>
## About The Pull Request
Closes#91040 by making the check on the ash storm be inside of the
recursive parent checking, makes power miners (holoparasites) spawned
from the dusty shard ash and snowstorm immune
## Why It's Good For The Game
Fixes bug, latter makes you take double damage if you don't have
protection, and if you do it prevents your miner from going outside of
your body during a storm. Them having protection from storms is kinda
fitting.
## Changelog
🆑
balance: Power Miners are now ash and snowstorm immune
fix: Holoparasites no longer take damage from ash storms inside of
storm-protected hosts
/🆑
## About The Pull Request
Weather subsystem code mixed up defines and indexes resulting in broken
behavior when you only had mobs and thunder defined in a subsystem.
Solved this by converting currentpart from define to active task index
Closes#90677
## Changelog
🆑
fix: Ash storms do damage again
/🆑
## About The Pull Request
Adds a new wizard event - Magical Rain
This selects a random reagent from a curtailed list that is rained down
on the station. The only safe spaces are in maintenance and containers
like lockers. Of course the wizard is not directly affected by the
reagent, although side effects may still apply. For example, if it is
raining lube, it will cause turfs to get slippery which can slip the
wizard. You can also collect the rain in containers, which might be
funny or useful depending on what it is. (Alcoholics love booze rain)
I did have to trim down the list of reagents since there are over +700
and most of them do nothing to mobs/turfs when they `TOUCH`. The list is
~50 reagents that are:
```dm
// most medicine do nothing when it comes into contact with turfs or mobs (via TOUCH) except for a few
var/list/allowed_medicine = list(
/datum/reagent/medicine/c2/synthflesh,
/datum/reagent/medicine/adminordrazine,
/datum/reagent/medicine/strange_reagent,
// include a random medicine
pick(subtypesof(/datum/reagent/medicine)),
)
GLOB.wizard_rain_reagents |= allowed_medicine
// One randomized type is allowed so the whitelist isn't spammed with subtypes
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent/glitter))
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent/carpet))
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent/mutationtoxin))
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent/plantnutriment))
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent/uranium))
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent/luminescent_fluid))
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent/impurity))
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent/drug))
GLOB.wizard_rain_reagents |= pick(typesof(/datum/reagent/water))
GLOB.wizard_rain_reagents |= pick(typesof(/datum/reagent/fuel))
GLOB.wizard_rain_reagents |= pick(typesof(/datum/reagent/colorful_reagent))
GLOB.wizard_rain_reagents |= pick(typesof(/datum/reagent/ants))
GLOB.wizard_rain_reagents |= pick(typesof(/datum/reagent/lube))
GLOB.wizard_rain_reagents |= pick(typesof(/datum/reagent/space_cleaner))
// lots of toxins do nothing so we need to be picky
var/list/allowed_toxins = list(
/datum/reagent/toxin/itching_powder,
/datum/reagent/toxin/polonium, // radiation
/datum/reagent/toxin/mutagen,
// all the acids
/datum/reagent/toxin/acid,
/datum/reagent/toxin/acid/fluacid,
/datum/reagent/toxin/acid/nitracid,
// include a random toxin
pick(subtypesof(/datum/reagent/toxin)),
)
GLOB.wizard_rain_reagents |= allowed_toxins
// too many food & drinks so blacklist most of them
var/list/allowed_food_drinks = list(
/datum/reagent/consumable/ethanol/wizz_fizz,
/datum/reagent/consumable/condensedcapsaicin,
/datum/reagent/consumable/frostoil,
// include a random food or drink
pick(subtypesof(/datum/reagent/consumable)),
// include a random regular drink (vodka, wine, beer, etc.)
pick(/obj/machinery/chem_dispenser/drinks/beer::beer_dispensable_reagents),
)
GLOB.wizard_rain_reagents |= allowed_food_drinks
var/list/allowed_exotic_reagents = list(
// fire
/datum/reagent/clf3,
/datum/reagent/phlogiston,
/datum/reagent/napalm,
// cosmetic
/datum/reagent/hair_dye,
/datum/reagent/barbers_aid,
/datum/reagent/baldium,
/datum/reagent/mulligan,
/datum/reagent/growthserum,
// op shit
/datum/reagent/romerol,
/datum/reagent/gondola_mutation_toxin,
/datum/reagent/metalgen,
/datum/reagent/flightpotion,
/datum/reagent/eigenstate,
/datum/reagent/magillitis,
/datum/reagent/pax,
/datum/reagent/gluttonytoxin,
/datum/reagent/aslimetoxin,
// misc
/datum/reagent/blood,
/datum/reagent/hauntium,
/datum/reagent/copper,
)
GLOB.wizard_rain_reagents |= allowed_exotic_reagents
// add a few randomized reagents not listed above so they at least have a chance
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent))
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent))
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent))
```
## Why It's Good For The Game
More interesting effects for weather. The wizard events are always
supposed to be silly and wacky, so having stuff like raining ants or
booze is hilarious. Several OP chems are included like napalm, strange
reagent, and flight potion which can lead to some chaos.
## Changelog
🆑
add: Add wizard magical rain event. A random reagent is selected to rain
down across the station. The only places to escape are in maintenance
and inside containers such as lockers. The wizard is not directly
affected by the reagent, but the side effects might still apply. (ie.
raining lube, will make the floors slippery, which can slip the wizard)
/🆑
---------
Co-authored-by: Jacquerel <hnevard@gmail.com>
## About The Pull Request
This adds `THUNDER_CHANCE_VERY_RARE` for a thunder strike to occur on
lavaland during ash storms. The chance is 1 in 50,000, which is rare
enough for it to occur a few times during an ash storm. The emberfalls
storm does not have thunder strikes applied. I also went ahead and
colored the thunder red, to go with the red color of the mining turf
colors as requested by:
## Why It's Good For The Game
Fun little rare event to make ash storms cool.
You might wonder why we don't increase the chance? Since lavaland is
really only used by a few players during a round, it is a good idea to
minimize the amount of turf processing that is done. By making it very
rare, the calculations average about ~`1.18` turfs being processed per
tick for the entire z-level.
## Changelog
🆑
add: Add rare chance of thunder strikes during ash storms on lavaland
/🆑
Introducing more weather types! And yes, you can now have rain be
reagent based!
<details>
<summary>Regular Rain</summary>
</details>
<details>
<summary>Blood Rain</summary>
</details>
<details>
<summary>Acid Rain</summary>
</details>
You can even make it rain ants, plasma, or drugs. All of their effects
get applied to turfs, objects, and mobs depending on the weather options
you select.
Did I mention... there is thunder?
<details>
<summary>Thunder Strikes</summary>
</details>
<details>
<summary>Sand Storms</summary>
</details>
Despite all this new stuff, none of it has been directly added to the
game but the code can be used in the future for:
- Wizard event - Similar to lava on floor, but this time make the
reagent random or picked from a list and give wizard immunity
- Chaplain ability - Maybe make this a benefit or ability once enough
favor has been obtained
- Admin events - I have added a BUNCH of admin tooling to run customized
weather events that let you control a lot of options
- New station maps/biomes for downstreams (Jungle Station, etc.)
- Change Ion storms to use the new weather system that triggers
EMP/thunder effects across the station
- IceBox could get plasma rain
- Lavaland could get thunder effects applied to ash storms
Relevant PRs that removed/added some of the weather stuff I used:
- #60303
- #25222
---
- Rain sprites were added via [novaepee](https://github.com/novaepee) in
https://github.com/tgstation/TerraGov-Marine-Corps/pull/9675
- Sand sprites were added via [TiviPlus](https://github.com/TiviPlus)
(who commissioned them from bimmer) in
https://github.com/tgstation/TerraGov-Marine-Corps/pull/4645
- Rain sounds [already existed on
tg](https://github.com/tgstation/tgstation/pull/25222#discussion_r106794579)
and were provided by provided by Cuboos, using Royalty Free sounds,
presumed under default tg sound license - Creative Commons 3.0 BY-SA
- Siren sound is from siren.wav by IFartInUrGeneralDirection --
[Freesound](https://freesound.org/s/46092/) -- License: Attribution 4.0
The original `siren.ogg` sound used on a lot of SS13 servers doesn't
seem to have any attribution that I could locate. The sound was added
about 15 years ago. So I just looked for a somewhat similar sounding
siren noise on Freesound.
More weather customization!
🆑
add: Added new weather types for rain and sandstorms. Rain now uses a
reagent that gets exposed to the turfs, mobs, and objects. There is also
a thunder strike setting you can apply to any weather.
add: Hydro trays and soil will now add reagents to their trays when
exposed to a chemical reaction. (weather, shower, chem spills, foam
grenades, etc.)
add: Weather temperature now affects weather reagents and mobs body
temperature.
bal: Snowstorm temperature calculations were tweaked to allow universal
weather temperature effects.
sound: Added weather sounds from TGMC for rain and sirens (attributed to
Cuboos and IFartInUrGeneralDirection )
image: Added weather images from TGMC for rain and sand storms
(attributed to Novaepee and Bimmer)
refactor: Refactored a lot of the weather code to be more robust
admin: Admins can now control more weather related options when running
weather events. The weather admin verbs have been moved to their own
"Weather" category under the Admin tab.
/🆑
---------
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
## About The Pull Request
Weather subsystem code mixed up defines and indexes resulting in broken
behavior when you only had mobs and thunder defined in a subsystem.
Solved this by converting currentpart from define to active task index
Closes#90677
## Changelog
🆑
fix: Ash storms do damage again
/🆑
## About The Pull Request
Adds a new wizard event - Magical Rain
This selects a random reagent from a curtailed list that is rained down
on the station. The only safe spaces are in maintenance and containers
like lockers. Of course the wizard is not directly affected by the
reagent, although side effects may still apply. For example, if it is
raining lube, it will cause turfs to get slippery which can slip the
wizard. You can also collect the rain in containers, which might be
funny or useful depending on what it is. (Alcoholics love booze rain)
I did have to trim down the list of reagents since there are over +700
and most of them do nothing to mobs/turfs when they `TOUCH`. The list is
~50 reagents that are:
```dm
// most medicine do nothing when it comes into contact with turfs or mobs (via TOUCH) except for a few
var/list/allowed_medicine = list(
/datum/reagent/medicine/c2/synthflesh,
/datum/reagent/medicine/adminordrazine,
/datum/reagent/medicine/strange_reagent,
// include a random medicine
pick(subtypesof(/datum/reagent/medicine)),
)
GLOB.wizard_rain_reagents |= allowed_medicine
// One randomized type is allowed so the whitelist isn't spammed with subtypes
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent/glitter))
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent/carpet))
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent/mutationtoxin))
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent/plantnutriment))
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent/uranium))
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent/luminescent_fluid))
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent/impurity))
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent/drug))
GLOB.wizard_rain_reagents |= pick(typesof(/datum/reagent/water))
GLOB.wizard_rain_reagents |= pick(typesof(/datum/reagent/fuel))
GLOB.wizard_rain_reagents |= pick(typesof(/datum/reagent/colorful_reagent))
GLOB.wizard_rain_reagents |= pick(typesof(/datum/reagent/ants))
GLOB.wizard_rain_reagents |= pick(typesof(/datum/reagent/lube))
GLOB.wizard_rain_reagents |= pick(typesof(/datum/reagent/space_cleaner))
// lots of toxins do nothing so we need to be picky
var/list/allowed_toxins = list(
/datum/reagent/toxin/itching_powder,
/datum/reagent/toxin/polonium, // radiation
/datum/reagent/toxin/mutagen,
// all the acids
/datum/reagent/toxin/acid,
/datum/reagent/toxin/acid/fluacid,
/datum/reagent/toxin/acid/nitracid,
// include a random toxin
pick(subtypesof(/datum/reagent/toxin)),
)
GLOB.wizard_rain_reagents |= allowed_toxins
// too many food & drinks so blacklist most of them
var/list/allowed_food_drinks = list(
/datum/reagent/consumable/ethanol/wizz_fizz,
/datum/reagent/consumable/condensedcapsaicin,
/datum/reagent/consumable/frostoil,
// include a random food or drink
pick(subtypesof(/datum/reagent/consumable)),
// include a random regular drink (vodka, wine, beer, etc.)
pick(/obj/machinery/chem_dispenser/drinks/beer::beer_dispensable_reagents),
)
GLOB.wizard_rain_reagents |= allowed_food_drinks
var/list/allowed_exotic_reagents = list(
// fire
/datum/reagent/clf3,
/datum/reagent/phlogiston,
/datum/reagent/napalm,
// cosmetic
/datum/reagent/hair_dye,
/datum/reagent/barbers_aid,
/datum/reagent/baldium,
/datum/reagent/mulligan,
/datum/reagent/growthserum,
// op shit
/datum/reagent/romerol,
/datum/reagent/gondola_mutation_toxin,
/datum/reagent/metalgen,
/datum/reagent/flightpotion,
/datum/reagent/eigenstate,
/datum/reagent/magillitis,
/datum/reagent/pax,
/datum/reagent/gluttonytoxin,
/datum/reagent/aslimetoxin,
// misc
/datum/reagent/blood,
/datum/reagent/hauntium,
/datum/reagent/copper,
)
GLOB.wizard_rain_reagents |= allowed_exotic_reagents
// add a few randomized reagents not listed above so they at least have a chance
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent))
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent))
GLOB.wizard_rain_reagents |= pick(subtypesof(/datum/reagent))
```
## Why It's Good For The Game
More interesting effects for weather. The wizard events are always
supposed to be silly and wacky, so having stuff like raining ants or
booze is hilarious. Several OP chems are included like napalm, strange
reagent, and flight potion which can lead to some chaos.
## Changelog
🆑
add: Add wizard magical rain event. A random reagent is selected to rain
down across the station. The only places to escape are in maintenance
and inside containers such as lockers. The wizard is not directly
affected by the reagent, but the side effects might still apply. (ie.
raining lube, will make the floors slippery, which can slip the wizard)
/🆑
---------
Co-authored-by: Jacquerel <hnevard@gmail.com>
## About The Pull Request
This adds `THUNDER_CHANCE_VERY_RARE` for a thunder strike to occur on
lavaland during ash storms. The chance is 1 in 50,000, which is rare
enough for it to occur a few times during an ash storm. The emberfalls
storm does not have thunder strikes applied. I also went ahead and
colored the thunder red, to go with the red color of the mining turf
colors as requested by:
## Why It's Good For The Game
Fun little rare event to make ash storms cool.
You might wonder why we don't increase the chance? Since lavaland is
really only used by a few players during a round, it is a good idea to
minimize the amount of turf processing that is done. By making it very
rare, the calculations average about ~`1.18` turfs being processed per
tick for the entire z-level.
## Changelog
🆑
add: Add rare chance of thunder strikes during ash storms on lavaland
/🆑
## About The Pull Request
##### Disclaimer - Some of the code/icons/sounds were ported from TMGC.
Introducing more weather types! And yes, you can now have rain be
reagent based!
<details>
<summary>Regular Rain</summary>
</details>
<details>
<summary>Blood Rain</summary>
</details>
<details>
<summary>Acid Rain</summary>
</details>
You can even make it rain ants, plasma, or drugs. All of their effects
get applied to turfs, objects, and mobs depending on the weather options
you select.
Did I mention... there is thunder?
<details>
<summary>Thunder Strikes</summary>
</details>
<details>
<summary>Sand Storms</summary>
</details>
Despite all this new stuff, none of it has been directly added to the
game but the code can be used in the future for:
- Wizard event - Similar to lava on floor, but this time make the
reagent random or picked from a list and give wizard immunity
- Chaplain ability - Maybe make this a benefit or ability once enough
favor has been obtained
- Admin events - I have added a BUNCH of admin tooling to run customized
weather events that let you control a lot of options
- New station maps/biomes for downstreams (Jungle Station, etc.)
- Change Ion storms to use the new weather system that triggers
EMP/thunder effects across the station
- IceBox could get plasma rain
- Lavaland could get thunder effects applied to ash storms
Relevant PRs that removed/added some of the weather stuff I used:
- #60303
- #25222
---
#### Attribution
- Rain sprites were added via [novaepee](https://github.com/novaepee) in
https://github.com/tgstation/TerraGov-Marine-Corps/pull/9675
- Sand sprites were added via [TiviPlus](https://github.com/TiviPlus)
(who commissioned them from bimmer) in
https://github.com/tgstation/TerraGov-Marine-Corps/pull/4645
- Rain sounds [already existed on
tg](https://github.com/tgstation/tgstation/pull/25222#discussion_r106794579)
and were provided by provided by Cuboos, using Royalty Free sounds,
presumed under default tg sound license - Creative Commons 3.0 BY-SA
- Siren sound is from siren.wav by IFartInUrGeneralDirection --
[Freesound](https://freesound.org/s/46092/) -- License: Attribution 4.0
The original `siren.ogg` sound used on a lot of SS13 servers doesn't
seem to have any attribution that I could locate. The sound was added
about 15 years ago. So I just looked for a somewhat similar sounding
siren noise on Freesound.
## Why It's Good For The Game
More weather customization!
## Changelog
🆑
add: Added new weather types for rain and sandstorms. Rain now uses a
reagent that gets exposed to the turfs, mobs, and objects. There is also
a thunder strike setting you can apply to any weather.
add: Hydro trays and soil will now add reagents to their trays when
exposed to a chemical reaction. (weather, shower, chem spills, foam
grenades, etc.)
add: Weather temperature now affects weather reagents and mobs body
temperature.
bal: Snowstorm temperature calculations were tweaked to allow universal
weather temperature effects.
sound: Added weather sounds from TGMC for rain and sirens (attributed to
Cuboos and IFartInUrGeneralDirection )
image: Added weather images from TGMC for rain and sand storms
(attributed to Novaepee and Bimmer)
refactor: Refactored a lot of the weather code to be more robust
admin: Admins can now control more weather related options when running
weather events. The weather admin verbs have been moved to their own
"Weather" category under the Admin tab.
/🆑
---------
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
## About The Pull Request
Unfortunately, the sound only plays when you're outside, under the
storm. I would love for it to play when you're near a window or
something, but that would vastly over-complicate things. Maybe later.
https://github.com/user-attachments/assets/6ca4bdb8-b1da-4644-bb71-6ca18cf3daec
## Why It's Good For The Game
Some free immersion. And in particular in the dark sometimes I don't
notice a snowstorm is raging so it adds some nice feedback.
## Changelog
🆑 Melbert
sound: Snowstorms now have sounds associated.
/🆑
## About The Pull Request
This converts many of the deciseconds numbers into using the proper time
defines `SECONDS` and `MINUTES`.
## Why It's Good For The Game
Cleaner code.
## Changelog
🆑
code: Convert weather duration to use time defines
/🆑
## About The Pull Request
Unfortunately, the sound only plays when you're outside, under the
storm. I would love for it to play when you're near a window or
something, but that would vastly over-complicate things. Maybe later.
https://github.com/user-attachments/assets/6ca4bdb8-b1da-4644-bb71-6ca18cf3daec
## Why It's Good For The Game
Some free immersion. And in particular in the dark sometimes I don't
notice a snowstorm is raging so it adds some nice feedback.
## Changelog
🆑 Melbert
sound: Snowstorms now have sounds associated.
/🆑
## About The Pull Request
This converts many of the deciseconds numbers into using the proper time
defines `SECONDS` and `MINUTES`.
## Why It's Good For The Game
Cleaner code.
## Changelog
🆑
code: Convert weather duration to use time defines
/🆑
## About The Pull Request
`boldannounce` is NOT for use ICly it's only for OOC stuff. `bolddanger`
is identical it just doesn't carry the same baggage
## Changelog
🆑 Melbert
fix: Stuff like the SM exploding will no longer output to your OOC tab
/🆑
3591 individual conflicts
Update build.js
Update install_node.sh
Update byond.js
oh my fucking god
hat
slow
huh
holy shit
we all fall down
2 more I missed
2900 individual conflicts
2700 Individual conflicts
replaces yarn file with tg version, bumping us down to 2200-ish
Down to 2000 individual conflicts
140 down
mmm
aaaaaaaaaaaaaaaaaaa
not yt
575
soon
900 individual conflicts
600 individual conflicts, 121 file conflicts
im not okay
160 across 19 files
29 in 4 files
0 conflicts, compiletime fix time
some minor incap stuff
missed ticks
weird dupe definition stuff
missed ticks 2
incap fixes
undefs and pie fix
Radio update and some extra minor stuff
returns a single override
no more dupe definitions, 175 compiletime errors
Unticked file fix
sound and emote stuff
honk and more radio stuff
## About The Pull Request
Same as https://github.com/Skyrat-SS13/Skyrat-tg/pull/29682, but on a
repo that is active.
Adds the Enhanced Roleplay Check protection to the radiation storm and
scrubber overflow events.
In the case of radiation storms, the protection is only triggered if the
dorm is occupied at the time of event init. (No cop-out running into a
dorm after you hear the announcement! Find a real maintenance hallway,
scrub.)
Additionally, only plays the giant red warning text only if you are in
an area that will be impacted by the radiation, so that people aren't
second guessing if the area they are in is protected or not.
## Why It's Good For The Game
Getting mutated and/or dying while in the middle of enhanced roleplay
tends to interrupt the intended roleplay
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑 LT3
code: Radiation storm warning only sent to players who are in an area
without radiation protection
balance: Occupied dorms are protected from radiation storms and
scrubbers
/🆑
## About The Pull Request
123 changed files and multiple crashes after writing broken regex, I
replaced most remains of direct spans with macros. This cleans up the
code and makes it easier to work with in general, see justification for
the original PR. I also fixed a bunch of broken and/or unclosed spans
here too.
I intentionally avoided replacing spans with multiple classes (in most
cases) and spans in the middle of strings as it would impact readability
(in my opinion at least) and could be done later if required.
## Why It's Good For The Game
Cleaner code, actually using our macros, fixes borked HTML in some
places. See original PR.
## Changelog
Nothing player-facing
## About The Pull Request
<details>
- renamed ai folder to announcer
-- announcer --
- moved vox_fem to announcer
- moved approachingTG to announcer
- separated the ambience folder into ambience and instrumental
-- ambience --
- created holy folder moved all related sounds there
- created engineering folder and moved all related sounds there
- created security folder and moved ambidet there
- created general folder and moved ambigen there
- created icemoon folder and moved all icebox-related ambience there
- created medical folder and moved all medbay-related ambi there
- created ruin folder and moves all ruins ambi there
- created beach folder and moved seag and shore there
- created lavaland folder and moved related ambi there
- created aurora_caelus folder and placed its ambi there
- created misc folder and moved the rest of the files that don't have a
specific category into it
-- instrumental --
- moved traitor folder here
- created lobby_music folder and placed our songs there (title0 not used
anywhere? - server-side modification?)
-- items --
- moved secdeath to hailer
- moved surgery to handling
-- effects --
- moved chemistry into effects
- moved hallucinations into effects
- moved health into effects
- moved magic into effects
-- vehicles --
- moved mecha into vehicles
created mobs folder
-- mobs --
- moved creatures folder into mobs
- moved voice into mobs
renamed creatures to non-humanoids
renamed voice to humanoids
-- non-humanoids--
created cyborg folder
created hiss folder
moved harmalarm.ogg to cyborg
-- humanoids --
-- misc --
moved ghostwhisper to misc
moved insane_low_laugh to misc
I give up trying to document this.
</details>
- [X] ambience
- [x] announcer
- [x] effects
- [X] instrumental
- [x] items
- [x] machines
- [x] misc
- [X] mobs
- [X] runtime
- [X] vehicles
- [ ] attributions
## Why It's Good For The Game
This folder is so disorganized that it's vomit inducing, will make it
easier to find and add new sounds, providng a minor structure to the
sound folder.
## Changelog
🆑 grungussuss
refactor: the sound folder in the source code has been reorganized,
please report any oddities with sounds playing or not playing
server: lobby music has been repathed to sound/music/lobby_music
/🆑
Alexis