All ui_act procs should call parent by default. All procs should preserve the value of the parent proc when it's TRUTHY and pass it down the call stack. No UI should be interactible when its flags or state indicate it should not be, except when explicity overriden by child procs intentionally disregarding parent return values to achieve a specific goal.
This gives instruments a selection of fitting instrument sounds, since we have a bunch that have been exclusive to the synth piano until now. For example, the harmonica can pick between the hardcoded and synthetized versions.
It might also add a new special and rare instrument
Fixes machines not referencing their circuits in their component parts when built manually, causing them to vomit out their circuit board when opened. This also fixes Runtime in _machinery.dm, line 607: Cannot read null.req_components from using the B/RPEDs.
Fixes computers not storing circuits in the contents.
Fixes smartfridges vending their components.
So yeah the multi-z pipe adapter was showing the big gmod error.
This fixes it and adds multiple directions and layers for the adapter.
Also RPD now can produce said manifold.
Also this reworks the painting mechanism so that it uses a variable+proc instead of checking for subtypes .
Removes the antennae part of the original moth wing sprites and adds them back as a mutant bodypart.
Seeing as they were then separated I made it a preference so that players can choose which antennae sprite they would like to have, instead of being restricted solely to the ones built into the wing sprite.
Admins now have the option to enable or disable the shuttle(located in the admin tab).
Disabling the shuttle will basically pause it where it is, regardless(unless game is over). Until the admins enable it again. It will resume exactly back to where it was and continue from there. This is great for events. You can't recall or call the shuttle while it's disabled.
Admins also now get the option when calling the shuttle to disable the recall of said shuttle unless they cancel it or select enable shuttle.
First, this removes 'The Whip' wheelchair as it doesn't show up anywhere or really do anything so it's kind of bloat. The other thing this does is make the metal and gold wheelchairs foldable into an item, like the rollerbeds. Motorized wheelchairs are not foldable. The metal wheelchair item does as much damage as a chair, and the gold one packs an extra oomph. Hiynastrike helped me with the sprites.
Gravitokinetic stands now give their user an immunity to their own gravity, and cannot apply it to their user.
Gravitokinetic stands now send out heavier gravity. Gravity applied to turfs will now damage lightly, gravity applied to people will damage twice as fast.
Issue 1: When your laws change in the middle of stating laws, things can get weird due to this being a proc that sleeps and may end stating early or some other undesired behaviour.
Issue 2: Issue's 1 behaviour can also runtime.
This caches all relevant vars when a law state starts so that it can continue uninterrupted and as expected.
This seemed the simplest solution and was a concept suggested by a couple of other maintainers. My implementation may be utterly terrible though, so please review.
There are a number of methods of assuming direct control of mobs or giving other players direct control. I have made sure these now appropriately update verbs.
Shamelessly ripped the functionality from /mob/dead/observer/verb/reenter_corpse() - It seemed to do what I wanted to accomplish in the same context.
I couldn't find any other method to refresh the verbs tab.
- Backtick-escape code samples which contain `[]` syntax.
- Fix all crosslinks to nonexistent symbols.
- Somewhat improve docs for qdel defines, research defines, dynamic mode, and others.
- Remove unused bloodcrawling defines.
Some crosslinks to defined but undocumented symbols remain. For BYOND builtins, a future dmdoc version may link those symbols to their entries in the DM reference. Other symbols could be documented by a future PR.
New "file" crosslinks as used in `research.dm` are slated for release in a future dmdoc version.
The block movement key now correctly locks turning like it used to.
Old save files are now migrated to Ctrl if they didn't bind it to anything before. This correctly replicates the old behavior.
heretic_monster antag datums nulled their own owner before calling code that relied on them having an owner to function. This has been fixed. Antag datum subtypes should not be modifying their own owners. Leave that to the parent code.
This could lead to situations where a mind has null antag datums sitting around in its list of antag_datums. This has also probably been fixed.
There are various checks dotted throughout the code to check if antag datums have owners. Most would either return early, continue in a for loop or silently skip over it. Antag datums should never be without an owner. These have all been removed.
When an ownerless antag datum is detected, it should not die silently. It should die loudly and proudly, declaring that something, somewhere went wrong and that there is a willing and necessary martyr to the cause of addressing WHY something runtimes instead of just having it silently skipped over.
During dismemberment from wounds, some scars would stick around even though the limb was no longer attached to the person. This was because I removed the scars from the person before removing the wounds, which itself would create more scars that would still be tied to the victim's scars. This fixes that, and tidies up some related code as well. Notably, you can now see which types of wounds a detached limb is suffering from by sight. Also, I have no clue what happened before when you attached a limb with existing wounds to someone, but I've made sure it applies the wounds to the person where they left off.
I also realized I made an order of operations error in the self-treatment for broken bones (with the bone gel and surgical tape) on the bone gel step, which made failing these treatments and briefly passing out/wasting a use of the gel 38 percentage points more likely than intended. This corrects that, so the base is 25%/45% failure for severe/critical blunt wounds. It also raises the bonuses to succeeding you get from painkillers a bit since you're going through a lot of trouble for all this already.
### Gameplay changes:
- Spacemen lose their ability to sculpt all minerals into statues barehanded, you need a chisel now.
- You can now create carving blocks out of 5 sheets of most materials.
- Using a chisel on the blocks you can designate what to carve in it (including the preset statues from before).
- Chisels can be printed at autolathe, there's also one in art storage.
### Code changes:
- Squeak component now squeaks on attack_hand for structures.
- Radials now accept atom paths automatically extracting the name with initial.
- Base and rigid stack recipes renamed appropriately.
- Statues now use custom materials.
About The Pull Request
Adds a bunch of sprites including:
A basic nullrod sprite
Belt sprites for the claymores lol nevermind
Backsprites for the cult blade and changed the chaplain's darkblade to fit on the back.
Suit storage sprites for the dark scythe, the cultblade, the spellblade, the claymores, katana and the nullrod
Suit storage sprites for a whole host of high powered firearms. You can visibly tell someone has shotguns or sniper rifles in their armor vest. How neat.
You can't conceal stunprods in armor suit storage anymore.
Nullrod cultsword (darkblade) also uses a uniquer inhand. Ye.
Also knives and a rolling pin belt sprite, hecc!
I also did some other stuff look there are a lot of sprites and I want to sleep please leave me alone nullrods are fucking stupid.
About The Pull Request
i made a PR just like this like a year or 2 ago and it got closed under dubious circumstances, especially since it had more upvotes than downvotes. this is a feature that the community wants. it is a 5 line change PR, not much to note on it, very simple.
Why It's Good For The Game
/tg/ is lacking in roleplay tailored mechanics and instead relies on the good graces of the players to interact politely with each other.
Changelog
🆑 imsxz
add: you can now pat carbon mobs on the head.
/🆑
