Commit Graph

38332 Commits

Author SHA1 Message Date
tralezab 1ac2779ef8 Bileworm Health Patch: Evolutionary Leap, Vileworms, Proximity Spawning Rules, Better Loot (#70321)
* bileworm health patch

- bileworms start off easier
- vileworms are how they are now + a little tougher
- fixes bileworms breaking proximity spawn rules
- adds gold to bileworm loot

* ssticker

* diagonals readded to attacks\, map fix

* d-delete this

* Update evolutionary_leap.dm

* DONE
2022-10-12 22:48:41 +02:00
GoldenAlpharex 10e3b98660 Fixes blood being left in a mob's bloodstream after insertion (#70439)
* Fixes blood being left in a mob's bloodstream after insertion
* Replaces baked-in typepath with type variable instead
2022-10-12 18:46:30 +00:00
san7890 91f6edee5a Fixes Unreadable APC Balloon Alerts for Ethereals (#70451)
* Fixes Unreadable APC Balloon Alerts as Ethereals

Hey there,

So basically, when an ethereal on combat mode would try and discharge an APC, they would get this, which is completely unreadable:

So, let's add a small sleep at the end of `togglelock()` for ethereals, and then proceed to continue on with the proc chain of whatever an ethereal might want to do with an APC.

* swaps the balloon alerts to add timers

less elegant, but it does do the job nicely
2022-10-12 12:43:26 -04:00
Sealed101 103a2d5016 Fixes AI Toggle Camera Lights (#70453)
check for eyeobj and not src
2022-10-12 12:41:22 -04:00
John Willard 41ca4962db Moves cleaning to an atom proc to afterattack signal (#70239)
* Hopefully fixes Cleaning

* Cleaning off window blood is now handled by the Window itself
* Cleanbots now have an advanced mop built into them, I am hoping in the future we can make cleanbots have their mops taken off, but I'm not good at spriting so it isn't a thing yet.
* Adds a pre_clean_callback to replace the should_clean arg (mostly)
* Removes the atom cleaning proc, replaces it with a signal for afterattack on a cleaning tool.

* Fixes and improvements

* adds a new define that allows pre_clean_callback to cancel cleaning entirely, used for mops to check for being wet or attacking buckets and such.
* Fixes cleanbots not properly working, removing their mop and just registering for a signal that bots send instead.
* Changes cleaner component to take proximity into account, that way we don't have to check it on each item's individual afterattacks, that way we don't have to call parent at the end either.
* Improves check_allowed_items a little bit because I hated how it was used for soap.

* Update cleaner.dm

* reviews
2022-10-12 11:22:04 +02:00
san7890 c1abc8984c S/Laughter Demon Spawning Cleanup + Logging (#70365)
Adds some game logging to whenever one spawns in a s/laughter demon, very cool indeed.
2022-10-12 11:18:51 +02:00
Hatterhat b74364bb40 organ fridges now freeze the organs in severed bodyparts e.g. heads (#70415)
* Putting bodyparts in organ fridges now freezes the organs contained inside of them, like the head's head organs.
2022-10-12 03:21:07 -04:00
Tim a2db4ab3fc Add chat notification for shoes & glove protection when mousetraps triggered (#70428)
* Being protected by Shoes or Gloves against a mousetrap will now give you a message in chat telling you such, removing a surprise for those caught off-guard by it.

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2022-10-12 03:10:38 -04:00
GoblinBackwards eced3408b2 Fixes permanent sechud from ablative trenchcoat hood (#70441)
Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2022-10-12 07:08:00 +00:00
tattle cf5cc040f3 Cargo pack code reorganizing (#70412)
* cargo pack reorganizing

* need the dme to compile

Co-authored-by: tattle <article.disaster@gmail.com>
2022-10-11 23:00:52 -04:00
GoblinBackwards 1c886d4324 Fixes mail changing existing nuke codes (#70435)
* Fixes mail changing existing nuke codes

* Fixes runtime if created without a self destruct

* Fix indent on admin message

* Makes default nuke code a define

* Rename define + autodoc

* Update code/game/objects/items/mail.dm

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2022-10-11 22:57:09 -04:00
ShizCalev c137b2f270 Fixes shields inhands (#70395)
Fixes #70377

Stobe shield has been broken for.... hell I don't even know how long lmao

cl ShizCalev
fix: Fixed some missing shield inhand icons.
fix: The strobe shield's inhand icon now plays the flashing animation when triggered again.
fix: The strobe shield will no longer blind the person holding it when it deflects a blow.
fix: The light from the strobe shield's flash no longer appears in your held inventory slot.
fix: Fixed the east facing left-handed strobe shield sprite being misaligned by two pixels.
/cl
2022-10-12 14:39:59 +13:00
ShizCalev 806e8863ae Fixes "Attempted to add a new component of type [/datum/component/convey] to a qdeleting parent of type" (#70352)
for(var/atom/A in get_turf(src)) includes qdel'ing atoms.
2022-10-12 14:39:17 +13:00
ShizCalev bb79294b2e Fixes weather listener and area sound manager runtime when brains are inserted into corpses. (#70343)
Essentially, the brain is set to nullspace for a second when inserted into a body, which was messing with brain mobs since z_level_change wasn't expecting the loc to be a null turf. (mobs in nullspace are bad.)

At this very same moment though, the brain obj's owner (carbon) is set, so we can just report that since that's going to be the loc sent to the signal again in half a moment anyway.
2022-10-12 14:38:57 +13:00
ShizCalev d26f370e11 Fixes away mission gateway runtime (#70342)
cl ShizCalev
fix: Fixed a runtime when clicking an away mission gateway without the partner gateway being active.
/cl
2022-10-12 14:38:41 +13:00
ShizCalev 3f0094597a Fixes runtime when ghosts press the deathgasp emote hotkey (#70334)
The following runtime has occurred 1 time(s).
runtime error: undefined variable /mob/dead/observer/var/death_message
proc name: run emote (/datum/emote/living/deathgasp/run_emote)
  source file: emote.dm,119
  usr: Jimmy Little (/mob/dead/observer)
  src: /datum/emote/living/deathgasp (/datum/emote/living/deathgasp)

#69007 removed the living sanity check.
2022-10-12 14:38:18 +13:00
ShizCalev c2e8fa6a4e Adds clearer modularity support to the inhands unit test. (#70440)
cl ShizCalev
server: Added clarified downstream modularity support for the inhands unit test.
/cl

Sorry to our downstreams for not being clear about how to add additional locations for the test.

You can now just set a var with the path (example provided) and add make sure you also add the path to your deploy.sh.

If you need additional locations ontop of that, just add another line with generate_possible_icon_states_list("your/inhands/folder/path"), and make sure that path is also in deploy.sh
2022-10-12 14:37:29 +13:00
MrMelbert e886195406 The Living Heart ritual kickstarts your heart for you, if it's not beating (#70358)
* Living Heart ritual kickstarts the heart for you
2022-10-12 01:57:14 +02:00
necromanceranne 3d63c8785e Regal Pipeguns can be stored in high-vis vests/wet floor signs (#70345) 2022-10-11 14:20:38 -07:00
John Willard dc5f5fb5f4 The curator's PDA now works in space (#70319)
* The curator's PDA is now long-ranged

The Curator's PDA is now long ranged and allows for it to be used while out in space.
I recently removed the modular computer parts that allowed PDAs to be upgraded to connect to NTNet while on different Z-levels, so thought this would be a good replacement since Curators are a space exploration job, so being able to still talk to other players or use the newscaster app while away, is something I think would be beneficial.
2022-10-11 14:20:20 -07:00
AnturK ed3bade706 Adds unit test to check for spritesheet issues (#70351)
* Adds a new spritesheet unit test to catch edge-cases that caused problems in the past.
2022-10-11 11:42:05 -04:00
MrMelbert f32678fb13 Having very very low sanity will rarely cause hallucintions (#70311)
* Being insane now causes you hallucinations, and hallucination immune has been renamed to RDS immune, since it only works for the quirk.
2022-10-11 11:41:09 -04:00
Sealed101 0a734a69ea Fixes research servers disappearing on deconstruction (#70394)
* Research servers (except for the Master one) now drops their circuit board on deconstruction, allowing you to properly deconstruct and move the servers.
2022-10-11 11:27:02 -04:00
Tim 67e9cc47e3 Add contextual screentips to jumpsuits (#70416) 2022-10-10 21:44:07 -07:00
ShizCalev d6ce53a288 fixes boxcutter n a couple other inhads (#70425)
fix: Boxcutters now have inhands again.
2022-10-10 20:30:56 -07:00
coldud13 6db02dca8d fixes holocarp fishsticks icon (#70410)
Sprite was previously an error / it messed up the reports at the end of the round.
2022-10-10 20:29:20 -07:00
Twaticus d1582bf1b4 Sec Resprite Fixes (#70030)
Sec helmets have been slightly reduced in size.
Normal sec helmet chin strap has returned.
Alt sec helmet will keep the no-chinstrap look.
Sec wintercoat hood now looks like a hood for a wintercoat.
New sec armor has been slightly reduced in size.
Black splotches on sec pants have been removed.
All sec personnel shoulder patches are now on both arms.
Sec uniform belt buckle is now black for a better distinction between sec and warden.
Fixes secskirt skirt size.
Fixes gold trim on hos uniforms.
Adds sec helmet inhands to match the new sprites.
Adds sec wintercoat inhands to match the new sprites.
Adds sec helmet obj icons to match the new sprites.
Fixes squished secskirt obj icon.
2022-10-10 23:54:20 -03:00
John Willard 4b13f892f0 Changeling lesserforms doesn't break when you monkify yourself from genetics (#70335)
Changeling's monkey form and returning back human now uses the monkify/humanify signals instead of sting_action stuff, meaning it now takes genetic species changings into account, so the power doesn't break if a changeling manually (or forcefully by someone else) turns into a monkey.
2022-10-10 13:28:41 -05:00
MrMelbert ced20c8e63 Converts silent to status effect + small cleanup of can_speak / can_speak_basic / IsVocal, and sign language (#69963)
* Gets rid of a lot of weird vocal checks
- unifies all vocal checks under can_speak and try_speak
- de-spaghettis a bit of sign language stuff
- introduce a silence status effect
2022-10-09 23:46:57 -04:00
arnociiroc 2b02bf103b nerfs shotgun darts (#70112)
* Shotgun darts now only hold up to 15 units, with the nukie-variation being able to hold up to 30. This puts it on-par with the Syringe gun.
2022-10-09 23:33:15 -04:00
GoblinBackwards 94a3f53e31 Fixes removing objects embedded in yourself (#70389)
Fixes removing objects embedding in yourself, as it was ref'ed to the wrong items since the bodypart refactors.
2022-10-09 23:24:18 -04:00
Gamer025 2aaaf4692a Exclude statbrowser from seconds topic limiter (#70386)
* Exclude statbrowser from seconds topic limiter

* Update code/modules/client/client_procs.dm

Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>

Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
2022-10-10 05:45:25 +03:00
vincentiusvin db83f6498d Simplifies SM damage calculation, tweaks the numbers. (#70347)
About The Pull Request

We apply the damage hardcap individually now, split off the old flat 1.8 into individual caps for heat, moles, and power.

Set it to 1.5 for heat, 1 for mole and 1 for power. This means for most delams it'll be a tad slower! But its possible to make SM delam nearly twice as fast if you combine all 3. (3.5). Be pretty hard tho.

Set the heat healing to -1 so you can counteract one factor at most (except heat since you'll never get both heat healing and heat damage at the same time anyway).

I'm not hell bent on any of the numbers, just picked round even ones and ones that i think will make sense. If you want them changed lmk.

Got rid of the cascade mole and power multipliers since there's probably like three people that are aware that it even exists. Ideally we just add another entry to the CIMS but its already pretty crowded. Figured nobody is gonna miss it anyway? Sorry ghil.

Got rid of the moles multiplier thing since its nicer to keep the temp damage fully based on temp damage instead of adding another multiplier. I just applied the .25 to the damage flatly, meaning it slows down delams again!

And some space exposure stuff: #70347 (comment)
Why It's Good For The Game

Hardcap: Discrete, less randomly interconnected factors are easier to present and remember. The calculation procs are also made to be additive so we had to hack a bit and do some rescaling to accomodate the old behavior in my original PR #69240. Can remove the hack if this pr goes through.

Cascade and mole multiplier: The rest are just getting rid of underutilized factors so we have a cleaner behavior to maintain, present, and understand. (In a perfect world modifiers that aren't visible to the players shouldn't have been merged in the first place smh smh)
Changelog

🆑
fix: Fixed sm space exposure damage going through walls
del: got rid of the molar multiplier for sm heating damage. It will now only impact molar damage and temp limit. We apply the lowest value directly so this slows down sm delams a tiny bit.
del: got rid of cascades making sm delam at 450 moles and 1250 mev. It delams normally now.
balance: Applied the sm damage hardcap of 1.8 individually to heat (1.5), moles (1), power (1). Meaning most sm delams are slower now, but the really bad ones can be faster.
balance: Halved sm temp healing across the board. Temp limits are still the same though so you shouldn't notice it that much.
balance: Halved SM power damage across the board.
balance: Changed sm space exposure damage to just check for the current tile and adjacent atmos connected tiles.
/🆑
2022-10-09 14:12:59 -07:00
Time-Green 6bfaadc6cf Removes inappropriate golden wheelchair usage (#70384) 2022-10-09 13:03:25 -07:00
lessthanthree 595a5e6a54 Tramstation crossing signals won't turn red when it's on the other side of the station (#70234)
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2022-10-09 07:55:10 +00:00
itseasytosee e0b706c36c Put clothing on people by clicking on them with clothing inhand + targeting correct area. (#69560)
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2022-10-08 18:51:29 -07:00
necromanceranne a97c68a6df Infiltrator Suit Rework: MODsuit edition (#70303)
* Reconfigures the Infiltrator armor set into the Infiltrator modsuit. Comes with a brain agony demoralizer device, and makes it literally impossible to examine you.
2022-10-08 22:05:07 +00:00
TiviPlus 80c09c7cc5 Fix an edge case where holding down multiple clicks at once would register attacks as the wrong click (#70369)
Co-authored-by: TiviPlus <572233640+TiviPlus@users.noreply.com>
2022-10-08 14:42:27 -07:00
MMMiracles 3388d5bae0 Cameras and lights now take power from adjacent walls if placed in external areas without power (#69975)
* cameras and lights can now be powered by adjacent walls if placed in areas where power normally isn't available.
2022-10-08 16:56:38 -04:00
RikuTheKiller fc7c186957 Brains can now be healed with mannitol without being fully decayed among other quality of life tweaks (#70357)
Removed the minimum amount of mannitol required to pour it since limiting this made barely any sense in the first place. Why oh why must we coders implement useless restrictions? (Useless restrictions caused the decay bug anyways.)

Brains no longer care about whether or not they're fully decayed when checking if they can be healed by pouring mannitol on them. They instead check if they're damaged at all and if they are, they'll let you pour mannitol on them.

The amount of time it takes to pour mannitol onto a brain is now 3 seconds instead of 6 seconds as it was way too slow. (Especially since something like a surgery step takes less time than 6 seconds.)

The solution is now only partially consumed as well, meaning if you need 20u of mannitol to fix a brain and you have a mixture of 40u of mannitol and 40u of mercury for example, pouring it will consume 40u of the mixture since you can't magically separate out the mannitol. This is rounded up, by the way. (Before this it simply consumed all of the mannitol, somehow you apparently can't stop pouring even while slowly pouring, according to the text.)

I've also very slightly increased the consistency of the pouring messages.

Fixes #70355
2022-10-08 16:30:26 +01:00
RikuTheKiller a2fcec6a33 BCIs are now stored in the manipulation chamber's contents, instead of nullspace (#70350)
Fixes a bug where MMIs would be sent into the nullspace room when in an MMI component inside of a BCI that is inserted into a BCI manipulation chamber.

Stores the BCI in the chamber's contents, instead of nullspace, allowing the MMI to talk, the BCI to still act as it would normally and overall just solves the issue and maybe some others alongside it.

Fixes #70349
2022-10-08 15:24:31 +01:00
ShizCalev ea50854570 Fixes camerachunk runtime + AI camera lights not working (#70328)
* Fixes camerachunk runtime

* camera lights fix
2022-10-07 23:49:09 -04:00
MrMelbert bc9ba63717 Adds a few (very) basic hallucinations, to keep people on their toes (#70251)
Spoiler alert!

    Adds a few extra "weird" fake body hallucinations.
        These just pop up a weird sprite somewhere in the view of the player.
        Another fun thing: Body hallucinations will appear to be floating if they spawn in nograv areas.
    Adds a "watcher" hallucination, a strange static figure that sticks on your screen until either a few minutes elapse. If you step out of view of it, then return, it will disappear.
    Adds a variant of the "fake death" hallucination which appears as if you were dusted.
    Adds two delusion - One that makes everyone appear to be ghosts, and one that makes everyone appear to be syndicates.
2022-10-07 20:18:21 -07:00
ShizCalev 7048110298 Inhands var hardsetting (#70364) 2022-10-07 19:08:09 -07:00
Tim 52acae4cd7 Easter Egg DLC - Captain's log and WGW (#68411)
This adds two easter eggs that have been apart of SS13 lore since the game was created:

    Captain's Log - Broken tape recorder that (spawns on the derelict station)
    Woody's Got Wood - Used spellbook that makes a person go temporary blind if they read it (spawns in curators forbidden knowledge bookcase)

Why It's Good For The Game

These have been apart of SS13 lore for a long time. It would be cool to have some "official" easter eggs for players to discover.
Changelog

cl
add: Add mail goodies for curator. (random books)
add: Adds easter egg - Captain's Log. Tape recorder that spawns on derelict station.
add: Adds easter egg - Woody's Got Wood. Will rarely appear as a mail goodie for curator.
/cl
2022-10-08 10:47:56 +13:00
sadkris fc842f7428 Trans Thigh-high and Knee-highs (#70295)
This literally just adds the sprites and entries for transgender thigh-highs and knee-highs as clothing options for socks.
Why It's Good For The Game

Inclusivity, as we already have nonbinary and asexual-related clothing.
Changelog

cl
add: Transgender-themed thigh-highs and knee-highs to the clothing options for socks
/cl
2022-10-08 10:46:52 +13:00
ShizCalev 11f77af52d Fixes hallucination runtime (#70330) 2022-10-07 13:32:25 -05:00
pizzie11 7f97330b48 Updates the Reagent Name unit test to also ensure searching by reagent name returns the correct reagent (#70223) 2022-10-06 21:51:29 -07:00
Twaticus c7dde06668 [MDB Ignore]Hats DMI split (#70060)
Splits head dmi into separate files for both mob and obj icons. Kept similar to suit split categorization + some more. New files include beanie, bio, chaplain, costume, cowboy, default, hats(softcaps, fedoras, head caps, generic hats), helmet(helmets and other armored headgear/hoods), spacehelm, utility(hardhats, mostly work related hats), wizard.
Moves animal/pet head sitting icons to 1 folder, pets_head.dmi
Renames PAI head sitting icon file to pai_head.dmi
2022-10-06 21:37:06 -07:00
kawoppi 2aac871603 [NO GBP] adds axolotl inhand sprites (#70290) 2022-10-06 22:28:01 +00:00