* Lets construction bags be put in pockets like they were intended to (#60460)
* Lets construction bags be put in pockets like they were intended to
Co-authored-by: jughu <melvin2626@live.nl>
* Fix wallet ID access (#60449)
* Fix wallets ID access
* Refactor id_card code to be simple
* Refactor id_card even further
* Fix wallet ID access
Co-authored-by: Tim <timothymtorres@gmail.com>
* removes some uses of var in world (#60407)
Co-authored-by: Watermelon914 <37270891+Watermelon914@ users.noreply.github.com>
* removes some uses of var in world
Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Co-authored-by: Watermelon914 <37270891+Watermelon914@ users.noreply.github.com>
* Add plasma xeno statue (#60408)
The sprite existed for a long time but was never added to the code for some reason.
* Add plasma xeno statue
Co-authored-by: Tim <timothymtorres@gmail.com>
* Makes only mapload foods require players to pick them up to decompose (#60392)
Co-authored-by: Changelogs <action@ github.com>
* Makes only mapload foods require players to pick them up to decompose
Co-authored-by: Wallemations <66052067+Wallemations@users.noreply.github.com>
Co-authored-by: Changelogs <action@ github.com>
* Spraycans actually empty if used below 2 units while colouring lights. (#60395)
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* Spraycans actually empty if used below 2 units while colouring lights.
Co-authored-by: DomitiusKnack <56321744+DomitiusKnack@users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* Fixes difficulties with placing lattices on multiz maps. (#60124)
Title. Because of mob and object visuals under open space being able to be hovered over with the cursor and examined and in general acting as entities distint from the turf holding them it tends to be hard or even impossible to build floor and catwalks over these turfs. This PR aims to fix it with a basically simple, more-convenient-than-a-painstaking-refactor and easy to apply element (edit: and proc).
* Fixes difficulties with placing lattices on multiz maps.
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
* ANTI-TIDER-2500 (#60016)
Straight from CentComm's R&D lab, the
ANTI-TIDER-2500
is the ULTIMATE crowd-control device.
Tired of being harassed by the crew for petty reasons? Sick of permabrigged prisoners constantly rioting over soggy tofu rations? The ANTI-TIDER-2500 is for YOU! For the modest sum of 710 credits you'll finally be able to hose clowns and whiners alike in pepper spray!
Co-authored-by: coiax <yellowbounder@ gmail.com>
* ANTI-TIDER-2500
Co-authored-by: Malgover <56408561+Malgover@users.noreply.github.com>
Co-authored-by: coiax <yellowbounder@ gmail.com>
* Merge the Ruins module into the Mapping module
I was always confused which to use soooo now theyre just the same
* Re-mapping + Files
THIS ISNT WORKING HELPHELPHELP
* wow thats a bad typo
fun fact, missing a single / can keep all ruins from spawning :)
* Ruins atmos + adds
There's probably a better way to do this. I'll probably have to revert the atmos things with this. Oh well.
* fixefixe
hngh
* fix that little pre-spawned ruin
hnngh
* fixes that pre-spawned ruin
hnngh OCD
* Delete quicksand.dmi
whoops
* Apply suggestions from code review
Co-authored-by: Tom <tomforde4@gmail.com>
* makes var-edited turfs into subtypes
i fucking hate it
* adds whiteship LZ (hopefully they all fit?)
* RENAMES ANY CODE MENTION TO "ROCKPLANET" FROM "ASTEROID"
Fixes having to differentiate between Asteroid(Mining planet) and Asteroid(Space object)
* rocklblnbglb
mapp p
* renames asteroid.txt to rockplanet.txt in config
* "sorts" files in the mapping module
while I'm here im gonna tidy it up ok
* fixes map conflicts
* missed a bit
* few gulag tweaks
hehe
* fix random space tile/area fuckery/aaaaaaa
* move mobs stuff about/rename/prep for The Lost
* pretty stuff.,.,.,
MY METAL POLES ARE HERE POG
* lz lz lz
* shower fix ree
Co-authored-by: Tom <tomforde4@gmail.com>
* changed the links for bartender and cook guides to the new wiki pages (#60313)
* Change the links for bartender and cook guides to the new wiki pages
Co-authored-by: dragomagol <66640614+dragomagol@users.noreply.github.com>
* Change maintenance loot spawns to be invisible post-spawn (#60294)
A previous commit made maintenance loot spawn effects visibile to
observers, but transparent.
However, in practice this is a lot of visual noise for very little
benefit for observers, so after they've spawned, they disappear, akin to
the old behaviour.
(They are still there, just hidden, but it looks the same to the end
user.)
* Change maintenance loot spawns to be invisible post-spawn
Co-authored-by: coiax <yellowbounder@gmail.com>
* EVEN MORE HARDDEL FIXES (#60228)
Fixes a ton of harddels, sourced from #59996
I think this brings us down to like, ~100 per round from ~200, with only like 20 of those being proper hell failures. I've seen harddel profiles below 1 second of total cost. Feeling good.
See you on the other side
Makes the cryopod control computer into a weakref, never trust bee code
Converts brig door timer internal lists to weakrefs
Fixes a harddel caused by qdeling a motion sensitive camera after it had left its source area, jesus christ why didn't we do this already holy shit
Converts the radio implant ref held by the antenna mutation to weakrefs because it isn't reliably cleaned up, makes the radio implant actually qdel its fucking radio
Removes the target var from the throwing datum, it does literally nothing and just exists to cause harddels, mostly for the singularity
Fixes a cable harddel sourced from things that try to enter blueprints after smoothing, but before roundstart. IE, shuttles. Removes shuttles from the blueprints
Fixes emmisive blockers being added post qdel
Removes some manual ghosting from cryopods, I initially did this for harddel reasons, but I figured out a better fix for that. I'm now doing it because it's got this really strange logic for like "re-entering the game" that doesn't actually link to what the ghostize proc does. We should remove this at some point
Fixes robot hud objects harddeling due to hanging refs
Fixes buildmode related hanging refs, I'm coming for you admin team
Fixes a few instances of trying to add the forensics component post qdel, hhhhhhhhhhh
Fixes some split personality harddels/weirdness
Replaces a use of disconnect_duct with an init qdel hint, I suspect there's more issues with duct harddels, I've seen some odd logs about ahhh the area_contents list, but we can worry about that later
Makes teleporter targets into weakrefs, properly types them as /atom
Makes frequency devices into weakrefs
Makes cameras remove themselves from camera nets on Destroy
Makes tgui ui datums implement destroy, this means if I ever see one hang a ref to user or whatever, I know there's an error with calling close() properly. I've seen this harddel once, but not after this change so I assume there was some error with close(). IDK maybe this is a papering over? Would have to ask @ stylemistake
I've seen logs of beartraps being in world post del, putting a return there just in case. The same is true of nerf darts, but I haven't really looked into that yet
Makes a shoe's ref to untying alerts a weakref, yes this is needed.
Moves clearing client_in_contents to the Login of the new mob. This prevents doing things like ghosting someone before a mob qdel causing harddels
Fixes a harddel set sourced from adding a status effect to a qdeleted thing. Is this an error? I'm honestly not sure.
Converts bsa code to weakrefs
Converts the partner var of heat exchangers to weakrefs
Converts camera assemblies to weakrefs
Fixes some dumb behavior with ammo casings and assuming you'll be on a turf post Destroy parent call
Fixes? merger related harddels, you were never cleared from your own members list, so origin objects would end up making a new list, creating harddels. Potential input from @ ninjanomnom about the logic
Chasms store a static list of "falling atoms", which only exists for chasms that go somewhere else. This list wasn't being cleared of qdeleted objects, which is what happens when you fall in most chasms. Fixes this, and converts the list to weakrefs.
Fixes some runtimes in both sheet code, and the weather listener element. This is here because runtime spam made testing more of a pain, didn't think it needed its own pr
Fixes colorful reagent harddels sourced from reagents that were qdel'd before roundstart. I'm only like 50% sure this actually got it, but the issue may have been solved by #60174, so eh
Turns the nuke op antag datum's ref to the war button into a weakref
Fixes some holopad code that was not nulling refs all the time
Converts camera bugs to weakrefs, this was the result of the bug being "reworked" like 6 years back without taking the existing ref clearing into account. Whole item needs a redo, but this'll do for now.
Ensures that the both pulling and pullee refs are cleared on Destroy
The crew monitor held all users in a non clearing list, makes that list a weakref because I hate everything
Oh and I removed all sources of gas_mixture qdeletion, I'm kinda unsure on this since it's not technically supported, but any harddels from it might? indicate something going wrong with like, gas passing logic. I'd like @ MrStonedOne's thoughts, since I trust him to call me an idiot if I'm wrong.
<!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. -->
## Why it's not good for the game
I crashed sybil like 10 times to get this data, I'm gonna put it to good use. Don't think you're safe sybilites, I'm coming for you.
* EVEN MORE HARDDEL FIXES
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
* Fixes tracking implants that cannot be used as teleporter beacons erroneously being described as usable as teleporter beacons in the implant pad. (#60269)
* Fixes tracking implants that cannot be used as teleporter beacons erroneously being described as usable as teleporter beacons in the implant pad.
Co-authored-by: interestingusernam3 <51925758+interestingusernam3@users.noreply.github.com>
* Carrying people works again (#60272)
Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
* Carrying people works again
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
* Rework maintenance loot spawners to fire at roundstart (#59913)
Maintenance loot spawners now fire at roundstart, rather than during the initialization of the Atoms subsystem.
Maintenance loot spawners do not qdel themselves during the spawning process, but persist, and merely hide themselves from living players.
As a cute side effect, this lets preround observers look at the colourful maintenance loot dice icons before the round starts. Observers can continue to see the loot dice post-round, but they are deliberately
very faint.
* Rework maintenance loot spawners to fire at roundstart
* fixafix
Co-authored-by: coiax <yellowbounder@gmail.com>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
* Changes overlay lighting vis contents objs -> underlays (#60239)
Previously what it would do is create up to three objects; a cone, a lighting image and a holder
Then whenever the lighting image was placed into the holders vis contents and the holder would be teleported several times when the parent would to turn or move, and the cone would be spun when the parent spun
Instead of doing that it now just translates a single overlay every time that something is updated
* Mirror!
Co-authored-by: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Co-authored-by: Funce <funce.973@gmail.com>
* Improves item's action button updating code (#60149)
This PR improves item action button updating code by introducing a proc to update all item's associated action buttons, which simplifies the process and reduces code duplication.
I also fixed a relevant bug where a PDA's action button icon did not properly update upon light toggle because it did not force the button update. Forcing the button update is needed in this case due to how light overlay operates, where the button icon state stays the same, so the code thought updating the action button icon was unnecessary.
* Improves item's action button updating code
* Mirror!
Co-authored-by: Arkatos1 <43862960+Arkatos1@users.noreply.github.com>
Co-authored-by: Funce <funce.973@gmail.com>
* Replace a number of New() overrides with Initialize() (#60223)
* Replace a number of New() overrides with Initialize()
Co-authored-by: coiax <yellowbounder@gmail.com>
* Adds missing space in medical ERT plushie box description (#60238)
* Adds missing space in medical ERT plushie box description
Co-authored-by: aaaa1023 <74441292+aaaa1023@users.noreply.github.com>
* Adds more variation in cricket bat desc (#60172)
Requested by @ RaveRadbury
* Adds more interesting cricket bat desc
Co-authored-by: bawhoppen <Bawhoppen@users.noreply.github.com>
* adds a suicide for space helmets, fixes some other suicides (#60173)
* adds a suicide for space helmets, fixes some other suicides
Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>
* OH BOY
* Not even dying harder than possible will save you from being revived.
* weh
* more improvements
* more fixes and improvements
* adds le vendor options
* Adds cortical stacks to cargo
* aaaa
* syndie cortical
* oops
* DELACE MACHINE GOES BRRT
* Are you a believer?
* buffs cortical stack remover on traitors
* Update code/game/objects/items/devices/scanners.dm
Co-authored-by: Tom <tomforde4@gmail.com>
* Update code/modules/mining/machine_vending.dm
Co-authored-by: Tom <tomforde4@gmail.com>
* Update code/game/objects/items/devices/scanners.dm
Co-authored-by: Tom <tomforde4@gmail.com>
* Update code/modules/mob/living/carbon/death.dm
Co-authored-by: Tom <tomforde4@gmail.com>
* Update modular_skyrat/modules/neural-lacing/code/delacer.dm
Co-authored-by: Tom <tomforde4@gmail.com>
* Update modular_skyrat/modules/neural-lacing/code/implanter.dm
Co-authored-by: Tom <tomforde4@gmail.com>
* Update modular_skyrat/modules/neural-lacing/code/stack.dm
Co-authored-by: Tom <tomforde4@gmail.com>
* Update modular_skyrat/modules/neural-lacing/code/stack.dm
Co-authored-by: Tom <tomforde4@gmail.com>
* Update modular_skyrat/modules/neural-lacing/code/stack.dm
Co-authored-by: Tom <tomforde4@gmail.com>
* Update modular_skyrat/modules/neural-lacing/code/stack.dm
Co-authored-by: Tom <tomforde4@gmail.com>
* Update delacer.dm
* aa
* a
* Update stack.dm
* weh
* More featureees
* Believer bundle
* i am deranged
* Update implanter.dm
Co-authored-by: Yawet330 <memeusniceus@gmail.com>
Co-authored-by: Tom <tomforde4@gmail.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
* Pain!
* pain2
* Multitude of fixes
* Update expeditionary_trooper.dm
* Update expeditionary_trooper.dm
* Update expeditionary_trooper.dm
* Auto stash before merge of "vanguard-classes" and "origin/vanguard-classes"
* aaaa
* Update advanced_choice_beacon.dm
* Update advanced_choice_beacon.dm
* Won't pass CI or shit
* ok, close to halfway done
* Shield stuff + proper kits
* code standards? met
* Maps + So much shit
* a single exclamation mark
* better marksmen pouches + cool stuff :)
* Black Mesa + Medic Bone Saw
* Astrum + Mesa (Again)
* Wild West IS DONE
* Clown fix
* Remove
* Sigh
* fucking BONER SAW
* I'm stuff
* chem dispenser
* Minor map edits
* wildwest better + mesa remove nade
* ye this
* Less gamer gear
removed a brhs from astrum and medics don't get two times the night vision
* Final map tweaks
BlackMesa has another barricade to convince HECU not to gamer it up / Astrum has clearer boobytraps / Wildwest has more non-gamer loot, and some additional ammo for the CFA replacement.
Co-authored-by: Gandalf <jzo123@hotmail.com>
