Commit Graph

6 Commits

Author SHA1 Message Date
Mothblocks
0f435d5dff Remove hideous inline tab indentation, and bans it in contributing guidelines (#56912)
Done using this command sed -Ei 's/(\s*\S+)\s*\t+/\1 /g' code/**/*.dm

We have countless examples in the codebase with this style gone wrong, and defines and such being on hideously different levels of indentation. Fixing this to keep the alignment involves tainting the blames of code your PR doesn't need to be touching at all. And ultimately, it's hideous.

There are some files that this sed makes uglier. I can fix these when they are pointed out, but I believe this is ultimately for the greater good of readability. I'm more concerned with if any strings relied on this.

Hi codeowners!

Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
2021-02-14 16:53:29 -08:00
TiviPlus
0eaab0bc54 Grep for space indentation (#54850)
#54604 atomizing
Since a lot of the space indents are in lists ill atomize those later
2020-11-30 12:48:40 -05:00
LemonInTheDark
fa394c253a Cleans up a mistake with baseturfs, prevents ref oddness (#54888)
When there's only one baseturf, we expect it to be stored not as a list, but as a single item.
I failed to support this in my string lists pr, which caused a few related issues.

Fixes #54880 , alt of #54883
2020-11-10 09:28:18 -05:00
LemonInTheDark
c102ad7e96 Makes the ChangeTurf same turf optimization work properly again, and converts baseturfs into a string_list (#54277)
I've converted baseturfs into a string list, I had to add a helper proc for baseturf stringlistifying, as the system expects single length baseturfs to not be a list, and I needed to support that. I added a length check of 100 to the helper proc, to help prevent more stuff like what got us into this mess in the first place, the kilo oom bug.

Makes ChangeTurf a lot faster in some cases, as it should be, and saves a lot of memory with cached lists.
2020-11-07 01:25:11 -03:00
L
853364227d tabs and whoops 2020-09-26 12:14:07 -03:00
Qustinnus
c6be808bf3 Moves over cakes to newfood and transfers reagents when crafting (#53316) 2020-09-07 15:04:14 -03:00