* Improve ID console name and assignment input (#56662)
reject_bad_name and reject_bad_text doesn't directly sanitize. It's
best not to rely on this proc to sanitize as that's not the point of
it, even though it can sanitize as part of its functioning. Instead,
we explicitly sanitize the input first, then we reject_bad_whatever
on the sanitized input.
It also offers improved feedback to the user instead of failing
silently, and allows numbers as some of our ID cards (For example,
prisoner IDs) have numbers in their registered_names and assignments.
I don't like creating the game world in a state that players cannot
also replicate themselves.
Also swings by the ancient HTML interfaces to bring them up to the
same standard through either sanitizing input or stripping input as
appropriate.
* Improve ID console name and assignment input
Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
* Double definition cleanup in reagent code (#56678)
Blood and holywater had a on_hydroponics_apply defined twice.
* Double definition cleanup on reagents
Co-authored-by: NightRed <nightred@gmail.com>
* Toggle suit sensors is now bound to right click (#56699)
Right clicking on a jumpsuit will act as if you pressed the "toggle
suit sensors" verb.
This is an extremely common action, and is perfect for right click
behavior. Also people are stripping in the halls right now, forgetting
to shift right click. How embarrassing.
* Toggle suit sensors is now bound to right click
Co-authored-by: Mothblocks <35135081+Jared-Fogle@users.noreply.github.com>
* Fixes N2O & Healium Euphoria (#56673)
N2O and Healium have a simple else statement on the end if there arent enough partial pressure, so you need both to exceed the threshold to get euphoria. This fixes that.
* Fixes N2O & Healium Euphoria
Co-authored-by: vincentiusvin <54709710+vincentiusvin@users.noreply.github.com>
* reinforcement nukies and borgs get droppodded (#56682)
reinforcements now get droppodded instead of appearing out of nowhere
fixes contractor drop pods having the wrong icon
* reinforcement nukies and borgs get droppodded
Co-authored-by: Fikou <piotrbryla@onet.pl>
* Fixes CTF runtimes / hard del (#56681)
* Remove mob from spawned_mobs on qdel
* Clear current mind when brain gets deleted
* Fixes CTF runtimes / hard del
Co-authored-by: Gamer025 <33846895+Gamer025@users.noreply.github.com>
* Delete remove_embedded_object.dm (#56675)
File is no longer included in tgstation.dme
* Delete remove_embedded_object.dm
Co-authored-by: Fikou <piotrbryla@onet.pl>
* Make all emp_proof cells emp proof (#56677)
For some reason only empty emp proof cells were emp proof. Now all emp proof cells are actually emp proof.
Co-authored-by: Sparkezel <1haslo4@ gmail.com>
* makes all emp_proof cells emp proof
Co-authored-by: Sparkezel <53384660+Sparkezel@users.noreply.github.com>
Co-authored-by: Sparkezel <1haslo4@ gmail.com>
* Change shears to check for incapacitation instead of stunned status effect (#56674)
Amputation shears now check for incapacitation instead of specifically
the stunned status effect to determine if you can get a 0.5x multiplier
for the time required to cut off a patient's limb despite the patient
not being unconscious, critted, or dead. This means that
staminacritting and paralysis can now count for this check.
In addition, the 1.5x time multiplier for the patient/victim being
jittery is now no longer mutually exclusive with the above 0.5x
multiplier (previously, the 0.5x multiplier would take priority).
Note that this penalty does not apply if the patient is dead, as
having a nonzero jitteriness variable only causes a jittering
animation if you're not dead.
* amputation shears now check for incapatation instead of specifically the stunned status effect
Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>
* Remove string from snow golem species colour (#56664)
Instead of trying to use the string `"null"` as a colour, we just
use `null` to indicate the absence of species colour for snow golems.
* removes "null"
Co-authored-by: Fikou <piotrbryla@onet.pl>
* Update the Nanite Dermal Button icon set (#56588)
The PR replaces the standard set of Nanite icons (number, plus, minus,
power) in different colors with an extended set of icons in a single
color.
The current icon set is very limited, the numbers don't provide much
context and some colors are barely visible on certain UI backgrounds
(yellow in particular).
The new set has bigger variety of icons, but removes the color
selection option to improve icon visibility.
* Updated the Nanite Dermal Button icon set
Co-authored-by: Andrew <mt.forspam@gmail.com>
* Small fix for reset_pull_offsets() (that you probably won't even notice) (#56671)
* Small fix for reset_pull_offsets() (that you probably won't even notice)
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
* Various crew tracking fixes (#56591)
Nanite Monitoring program now makes people trackable as if they have enabled their suit sensors, as stated in the program description.
Now you can track people with Nanites Monitoring program using following devices:
Crew pinpointer (arrow)
Crew pinpointer - contractor version (arrow)
Crew pinpointer (proximity)
Lifeline radar (modular computers software)
Also fixed multi-Z tracking for the first three devices. When the target is on different Z of the same station, it shows "?" icon.
Also, the stationary crew monitor will now work properly on multi-Z stations.
* Various crew tracking fixes
Co-authored-by: Andrew <mt.forspam@gmail.com>
* Add alternate attack procs (#56663)
Adds alternate attack procs for right-clicking. Updates the gunpoint code to use this new proc as an example (though I suspect this is being changed soon, so oops).
This makes it easier to add new behavior to right click, which we should be doing.
* Add alternate attack procs
Co-authored-by: Mothblocks <35135081+Jared-Fogle@users.noreply.github.com>
* You can no longer shoot and melee with guns at the same time (#56647)
* You can no longer shoot and melee with guns at the same time
Co-authored-by: Qustinnus <Floydje123@hotmail.com>
* Energy katana now uses right click to teleport instead of toggling (#56636)
Energy katana now uses right click to teleport instead of toggling by activating in hand.
Right click is the new standard for minor interactions. This feels much more fluid than switching, and ensures you'll never mess it up.
Right clicking being the new method of minor interactions starts now.
* Energy katana now uses right click to teleport instead of toggling
Co-authored-by: Mothblocks <35135081+Jared-Fogle@users.noreply.github.com>
* renames metal sheets to iron sheets
* Merge branch 'master' into upstream-merge-56643
* yay metal
* Update DeltaStation2_skyrat.dmm
* a
* Update CentCom_skyrat_z2.dmm
* a
* a
Co-authored-by: Fikou <piotrbryla@onet.pl>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
* You no longer need to hold shift to open the context menu as a ghost (#56646)
* You no longer need to hold shift to open the context menu as a ghost
Co-authored-by: Qustinnus <Floydje123@hotmail.com>
* makes blast cannons not seem like an innocent item before a bomb is loaded (#56645)
* makes blast cannons not seem like an innocent item before a bomb is loaded
Co-authored-by: Fikou <piotrbryla@onet.pl>
* Tend wound fix and minor refactor. (#56599)
* fixes tend wounds healing damage that wasnt specified by it.
fixes the tend wounds that should heal one damage you choose i.e.: burn randomly heal some brute while not healing burn or heal burn and brute at the same time.
* Tend wound fix and minor refactor.
Co-authored-by: manofpepsi <71612753+manofpepsi@users.noreply.github.com>
* hauntium is now properly applied to the photo (#56615)
* hauntium is now properly applied to the photo.
Co-authored-by: Qustinnus <Floydje123@hotmail.com>
* disables godmode for some vendors and adds missing refills (#56570)
* disables godmode for some vendors and adds missing refills
Co-authored-by: Tlaltecuhtli <33834933+Tlaltecuhtli@users.noreply.github.com>
* Makes reinforced plasma windows block heatspreading, mostly so the sm delams properly, and partially so mappers have a tool for this sort of thing (#56545)
* Makes reinforced plasma windows block heatspreading
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
* You can now remove embedded objects directly with a hemostat (#56637)
* You can now remove embedded objects directly with a hemostat
Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
Removes the capital X going to KSS from the forked tongue hiss, this allows lizards and other people who have taken the forked tongue to say things like RDX instead of RDKSS, and overall improves readability. This does not affect lowercase x's.
* A Big Hydroponics Update: A Rose by any other name (2 new plants, 4 new traits, new genes, and more!)
* Update grafts.dm
* Update grafts.dm
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
* Heretic void cloak no longer deletes itself when you unequip it. (#56619)
* Heretic void cloak no longer deletes itself when you unequip it.
Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
