Commit Graph

2 Commits

Author SHA1 Message Date
SkyratBot
50fae8d01c [MIRROR] Adds a smaller size targeting strategy, makes crabs use them [MDB IGNORE] (#25603)
* Adds a smaller size targeting strategy, makes crabs use them (#80246)

## About The Pull Request

The PR that added crabs said crabs are now small creatures, and will
hunt tiny creatures. However, their targeting strategy was
`our_our_smaller`, so a group of crabs ended up eating each other. This
PR creates a new targeting strategy, and applies it to the crab AI.

## Why It's Good For The Game

Puts an end to crabbibalism.

## Changelog

🆑
fix: Crabs will properly only target Tiny creatures
/🆑

* Adds a smaller size targeting strategy, makes crabs use them

---------

Co-authored-by: Profakos <profakos@gmail.com>
2023-12-13 15:34:46 -06:00
SkyratBot
bbd547ec95 [MIRROR] Targeting Datums Renamed (and global) [MDB IGNORE] (#24885)
* Targeting Datums Renamed (and global) (#79513)

## About The Pull Request

[Implements the backend required to make targeting datums
global](6901ead12e)

It's inconsistent with the rest of basic ai for these to have a high
degree of state, plus like, such a waste yaknow?

[Implements
GET_TARGETING_STRATEGY](d79c29134d)

Regexes used:
new.*(/datum/targetting_datum[^,(]*)\(*\)* -> GET_TARGETING_STRATEGY($1)

Renamed all instances of targetting to targeting (also targetting datum
-> targeting strategy)

I've used GET_TARGETING_STRATEGY at the source where the keys are
actually used, rather then in the listing. This works out just fine.

## Why It's Good For The Game

Not a misspelled name through the whole codebase, very slightly less
memory load for basically no downside (slight cpu cost maybe but not a
significant one.

---------

Co-authored-by: John Willard <53777086+JohnFulpWillard@ users.noreply.github.com>

* Targeting Datums Renamed (and global)

* Update dogs.dm

* Modular

* Modular

* Modular

* Merge skew?

* Revert "Merge skew?"

This reverts commit 0889389ab5cb5c56655f1860d9173ba87efe9a22.

---------

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: John Willard <53777086+JohnFulpWillard@ users.noreply.github.com>
Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com>
2023-11-09 16:37:48 -05:00