Commit Graph

15 Commits

Author SHA1 Message Date
SkyratBot
be721efcbe [MIRROR] Logging fixes and catches [MDB IGNORE] (#25537)
* Logging fixes and catches (#79621)

THIS IS A REDO BECAUSE GITHUB SUCKS ASS

## About The Pull Request

Hardens logging against sudden and unexpected cases where we try to log
to a category that is not initialized or the file goes missing.

## Why It's Good For The Game

Logging needs to be robust and bullet proof

* Logging fixes and catches

---------

Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com>
2023-12-09 21:59:23 -05:00
SkyratBot
e06ec3e714 [MIRROR] Bumps compile to 515 [MDB IGNORE] (#25257)
* Bumps compile to 515 (#79134)

## About The Pull Request

LSP supports it, let's GOOOOOO
I've removed the 515 tests since they're stable, alongside the libcall
wrapper. left the rustgcall wrapper cause yaknow memes
Just removed all the 515 and 514 particular define wrappers. gaming

## Changelog
🆑
server: Minimum compile version has been bumped to 515. clients still
support 514 but we're gonna start using 515 restricted features for
serverside now.
/🆑

---------

Co-authored-by: John Willard <53777086+JohnFulpWillard@ users.noreply.github.com>

* Bumps compile to 515

* Fixes a TGS regression in its API

---------

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: John Willard <53777086+JohnFulpWillard@ users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2023-12-02 21:48:21 -05:00
SkyratBot
c0e4fc3c03 [MIRROR] Fix refresh button in log viewer [MDB IGNORE] (#24810)
* Fix refresh button in log viewer (#79520)

## About The Pull Request

`re-render` is a typo?
137aa7dc60/tgui/packages/tgui/interfaces/LogViewer.tsx (L66)

## Changelog

🆑
fix: Fix refresh button in log viewer
/🆑

* Fix refresh button in log viewer

---------

Co-authored-by: vvvv-vvvv <136390975+vvvv-vvvv@users.noreply.github.com>
Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com>
2023-11-22 01:06:18 -05:00
SkyratBot
7cf7be4b7b [MIRROR] Tram v6/Transport Subsystem [MDB IGNORE] (#24399)
* Tram v6/Transport Subsystem

* Update icon_smoothing.dm

* Update utility.dm

* defines/icon

* Update airlock.dm

* Update door.dm

* Update airlock.dm

* Update airlock.dm

---------

Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
2023-10-17 15:16:46 -07:00
SkyratBot
e2938ac88c [MIRROR] splits out tgui from the debug master category [MDB IGNORE] (#22368)
* splits out tgui from the debug master category (#76428)

Splits out tgui from the debug master category at the request of @ Fikou
Removes pointless overrides of internal_format since the default is now
FALSE and also adds an additional comment about ensuring the shit works
if you change the default.

I believe the original reason was that fikou didnt want to sort through
the entire debug log for tgui stuff.

* splits out tgui from the debug master category

---------

Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com>
2023-07-11 15:44:53 -07:00
SkyratBot
7f6890c1f5 [MIRROR] Add check for illegally formatted unix timestamp for logging [MDB IGNORE] (#22103)
* Add check for illegally formatted unix timestamp for logging (#76193)

This runtiming is bad

* Add check for illegally formatted unix timestamp for logging

---------

Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com>
Co-authored-by: hugmeorelse <52105542+hugmeorelse@users.noreply.github.com>
2023-07-11 16:43:59 -05:00
SkyratBot
bb5ef264c1 [MIRROR] don't infinitely recurse on attempting to log after shutdown [MDB IGNORE] (#22026)
* don't infinitely recurse on attempting to log after shutdown (#76229)

* don't infinitely recurse on attempting to log after shutdown

---------

Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com>
Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
2023-07-01 16:17:59 -04:00
SkyratBot
957e5101bd [MIRROR] Re-add missing categories to externally formatted log files [MDB IGNORE] (#21844)
* Re-add missing categories to externally formatted log files (#76051)

## About The Pull Request
Currently externally-formatted log files (handled by rust-g) do not
include categories. This seems erroneous, and causes a discrepancy
between the internal and externally formatted files as external
formatting only seems to add the timestamp and some newline handling.

Currently:

![image](https://github.com/tgstation/tgstation/assets/10467687/a8979eca-833a-4c44-9d0b-82b9925ddde4)

With this PR:

![image](https://github.com/tgstation/tgstation/assets/10467687/eeeb87ee-3395-4ecc-b97c-ec35f965eac0)

## Why It's Good For The Game

Resolves a disparity between external and internal formatting made
evident by #75972.
## Changelog
🆑 bobbahbrown
server: Fix log categories being erroneously excluded from log files.
/🆑

* Re-add missing categories to externally formatted log files

---------

Co-authored-by: Brett <bobbahbrown@gmail.com>
2023-06-18 15:00:46 +01:00
SkyratBot
8e907a61e3 [MIRROR] all logs are now externally formatted [MDB IGNORE] (#21761)
* all logs are now externally formatted (#75972)

Internal formatting should only be used for logs that include their own
timestamp or don't want one printed.

atm internal formatting does not add the continuation market to newlines
which is an issue that is causing info leak of private loglines.

two logs that always used newlines were manually moved to external
formatting in the original pr, this now makes that the default. a log
type must have a valid reason to format internally now and specifically
request this.

(None of this impacts json logs)

🆑
server: fix logging infoleak from the lack of continuation markets on
new lines.
/🆑

* all logs are now externally formatted

---------

Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
2023-06-10 22:55:51 +01:00
SkyratBot
f05e2cfae3 [MIRROR] Adds a new front end for viewing logs | fixes the manifest log message too [MDB IGNORE] (#21525)
* Adds a new front end for viewing logs | fixes the manifest log message too

* Update code/modules/admin/admin_verbs.dm

---------

Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2023-05-31 19:59:55 -04:00
SkyratBot
120041c693 [MIRROR] Converts del logging to proper json, using json objects instead of building a text file [MDB IGNORE] (#21448)
* Reverts qdel logging to a raw text file (#75632)

## About The Pull Request

We log this information once, on SSgarbage shutdown. Putting it in a
json is kinda pointless, it exists to be read when we see massive
overtime from ssgarbage, that's all.

Something something reee my workflow.

## Changelog
🆑
server: qdel statistics are once again logged in qdel.log, instead of
the otherwise typical json logging system
/🆑

* Converts del logging to proper json, using json objects instead of building a text file (#75636)

## About The Pull Request

It's easier to parse, and makes more sense when you read it. This way
I'll never have to add yet another case to my parser for someone
changing where a space goes or something.

Moves qdel into its own category cause the old name looked ugly (yell if
this is dumb)
Added a bitfield to entries pulled from categories, adds a new flag that
enables pretty printing json lists.


## Why It's Good For The Game

IMPROVES my workflow

## Changelog
🆑
server: del logging is now done by outputting to a json file again, but
this time we're using ACTUAL json and not just a big text string with
newlines and shit
/🆑

---------

Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com>

---------

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com>
2023-05-31 17:05:23 -04:00
SkyratBot
649c250702 [MIRROR] JSON Logging Take Two [MDB IGNORE] (#21329)
* JSON Logging Take Two

* Fixes the conflicts and makes our logs all comply with the new logging framework, hopefully.

---------

Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2023-05-28 18:10:07 -04:00
SkyratBot
abf148d62b [MIRROR] World Initialization Refactor [MDB IGNORE] (#20755)
* World Initialization Refactor

* Update .github/CODEOWNERS

* Update code/__HELPERS/global_lists.dm

* Add logging for manually changing your targeted zone (#72814)

See title.
Surgery hud is exempt from this.

Requested by @Mothblocks

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: dragomagol <66640614+dragomagol@users.noreply.github.com>

* eee

* Update tgstation.dme

---------

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: Jordan Dominion <Cyberboss@users.noreply.github.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: dragomagol <66640614+dragomagol@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2023-04-26 22:46:55 +01:00
SkyratBot
e8df6da548 [MIRROR] Fixes silo logging + add log file based logging to silo [MDB IGNORE] (#20748)
* Fixes silo logging + add log file based logging to silo

* Update logging.dm

* Update logging.dm

---------

Co-authored-by: Gamer025 <33846895+Gamer025@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2023-04-26 21:23:25 +01:00
Tom
6435018ba7 Add logging for manually changing your targeted zone (#72814) (#20787)
* Add logging for manually changing your targeted zone (#72814)

See title.
Surgery hud is exempt from this.

Requested by @Mothblocks

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: dragomagol <66640614+dragomagol@users.noreply.github.com>

* Delete 

---------

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: dragomagol <66640614+dragomagol@users.noreply.github.com>
2023-04-26 10:44:01 -07:00