* Removes download restrictions for NIRN tablets and allows QMs to buy things directly (#59691)
Everyone can now download the NIRN program on computers which allows you to buy or request to buy stuff. QMs now also get to buy things directly. All other people will still only be able to request to purchase something.
* Removes download restrictions for NIRN tablets and allows QMs to buy things directly
Co-authored-by: RandomGamer123 <31096837+RandomGamer123@users.noreply.github.com>
* Ghoul Moodlet + Max HP fix (#59682)
Adds ghoul moodlet.
Fixes a undocumented issue with ghouls dying and being revived with 25/50 max health.
* Ghoul Moodlet + Max HP fix
Co-authored-by: eeSPee <robotdevilinside@gmail.com>
* Adds the airlock shell, refactors USB code to be easier to use, implements USB cables for the binary valve and more. (#59728)
Adds the airlock shell. The circuit has full control over the airlock.
Refactors USB code to be easier to use for less experienced coders.
Implements USB cables for the binary valve to be able to open/close the valve.
Adds a private channel for radios that only lets circuits with the same owner's ID to interact with it.
* Adds the airlock shell, refactors USB code to be easier to use, implements USB cables for the binary valve and more.
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
* Fixes heretic books created by the ritual coming with free charges. (#59761)
Creates a new subtype of the Codex Cicatrix spawned by the ritual, that doesn't have any charges.
At the moment, you get a free point each time you make a new one.
* Fixes heretic books created by the ritual coming with free charges.
Co-authored-by: SpaceVampire <46720418+SpaceVampire@users.noreply.github.com>
* Adds the MMI circuit component. Allows inputting signals into circuit component ports (#59743)
Adds the MMI component which outputs signals whenever they click somewhere/try to move.
Allows inputting signals into ports, making it easier to debug integrated components.
* Adds the MMI circuit component. Allows inputting signals into circuit component ports
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
* Fixes collapsed or burnt paper bins from voiding new papers added (#59732)
* Stops collapsed or burnt paper bins from voiding new paper added afterwards
* Replaces papers.Remove and paper.Add
LAZYADD and LAZYREMOVE are much more useful.
* Fixes collapsed or burnt paper bins from voiding new papers added
Co-authored-by: Ed640 <Ed.640@hotmail.com>
* Added circuit component UI details, added multiplexer and allowed inserting components directly into shells. (#59635)
Adds the multiplexer circuit component - en.wikipedia.org/wiki/Multiplexer
Circuit components can now be directly inserted into shells rather than having to take the integrated circuit out.
Special information can be accessed from components now through the "Info" button besides the eject button on a component.
* Added circuit component UI details, added multiplexer and allowed inserting components directly into shells.
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
* Converts tippable behavior from cows and medibots to a component (tip over anything with adminbus) (#59705)
This PR converts cow-tipping and medibot-tipping into a component, /datum/component/tippable. Cows and medibots now use the tippable component to control their tipping behaviors.
This PR also goes through a few atom_attack_hand signals and makes them all send the same arguments.
* Converts tippable behavior from cows and medibots to a component (tip over anything with adminbus)
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
* fix a lot of shit
* i hate you
* firealarm/cyborg
* amend
* more fixes
* why is this FUCKING needed
* Update code/modules/detectivework/detective_work.dm
Co-authored-by: Funce <funce.973@gmail.com>
* Update code/modules/detectivework/detective_work.dm
* Update code/modules/detectivework/detective_work.dm
Co-authored-by: Funce <funce.973@gmail.com>
Co-authored-by: Funce <funce.973@gmail.com>
* Admin QOL: Adds a speech prefix for ghosted admins to talk through their linked body (#59762)
One of the more annoying parts of sending in a centcom official or ERT as an admin is the fact that sometimes you need to keep in touch with them- especially when you're supporting a response team with multiple people, and sending them headset messages one-by-one or using command reports won't cut it. In these cases, I spawn myself in at centcom (or use the body I made for briefing) and talk on the Centcom radio freq, but this sucks because while you're in the body, you can't watch what they're doing because you're not a ghost!
So this PR adds a special speech prefix for admin ghosts, :j, which tries to relay your chat message to your linked body if one exists, instead of sending it to deadchat.
* Admin QOL: Adds a speech prefix for ghosted admins to talk through their linked body
Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
* Makes turfs persist their signals, uses this to optimize connect_loc (#59608)
* Makes turfs persist signals
* Splits connect_loc up into two elements, one for stuff that wishes to connect on behalf of something, and one for stuff that just wants to connect normally. Connecting on behalf of someone has a significant amount of overhead, so let's do this to keep things clear
* Converts all uses of connect_loc over to the new patterns
* Adds some comments, actually makes turfs persist signals
* There's no need to detach connect loc anymore, since all it does is unregister signals. Unregisters a signal from formorly decal'd turfs, and makes the changeturf signal persistance stuff actually work
* bro fuck documentation
* Changes from a var to a proc, prevents admemems and idiots
* Extra detail on why we do the copy post qdel
* Makes turfs persist their signals, uses this to optimize connect_loc
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
* Fixes infinite dispenser power (#59710)
Fixes an issue where update_total() could recurse and wind up double-counting a bunch of reagents.
Fixes an issue where reagent dispensers could withdraw negative power from their power cell. (Fixes#59663) (Pretty much just the two problems described here but in issue form)
* Fixes infinite dispenser power
Co-authored-by: TemporalOroboros <TemporalOroboros@gmail.com>
* Converts the enemies list to weakrefs (#59694)
This has some minor overhead, but listtargets isn't exactly a hot proc, so we should be just fine
* Converts the enemies list to weakrefs
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
* Fixes explosions having a higher chance of delimbing you if they're weaker (#59662)
Don't know if it's an oversight or not, but currently, explosions delimb you if they're weaker. This PR fixes that by removing the division in the probability calculations and replacing it with a multiplication, whilst also changing the base probability value.
The value 16.6 was chosen because at devastation 3, aka max devastation, that will equal out to approximately 50%
* Fixes explosions having a higher chance of delimbing you if they're weaker
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Adds set_density()
Fixes one instance of a duplicate density assignment on an object.
Comments two hacky usages of density which will have to forgo using the setter for now.
Lets us append code to the event of density changing.
Pretty sure this is leading up to some multitile object thing -Lemon
Co-authored-by: Rohesie <rohesie@gmail.com>
* Admins hiding music title will hide it from the music player too
* Update playsound.dm
Co-authored-by: Jonathan Rubenstein <jrubcop@gmail.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
* Refactors dbcore and limits the maximum amount of concurrent async queries to a variable amount (#59676)
Refactors dbcore to work off a subsystem if executed async and limits the maximum amount of concurrent async queries to 25.
This has been tested locally on a mysql docker image and there were no crashes (as long as you didn't run it with debug extools) + data was getting recorded fine.
Why It's Good For The Game
May or may not resolve terry crashes, however, each query creates a new thread which takes up 2mb, preventing the game from using that 2mb. This can lead to ooms if they stack up, e.g. due to poor connectivity. This solves that issue.
maintainer note: this did not actually resolve the crashes, but has value anyway. Crashes were sidestepped fixed by finding out Large Address Awareness works
cl
refactor: Refactors dbcore.dm to possibly resolve the crashes that happen on Terry.
/cl
* Refactors dbcore and limits the maximum amount of concurrent async queries to a variable amount
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
* Refactors mail and delivery code (#59730)
- Mail now uses weakreferences to minds, which means the presence of
mail will not cause harddels, and persist between mindswaps or cloning
or whatever horrible mob transfer things you've got going on.
- The code for creating a crate of mail has been refactored into a
single proc, rather than having the same code twice.
- Instead of special casing reagents being delivered, instead
reagent mail goodies are just regular bottle items like any other.
* Refactors mail, delivery and goodies code
Co-authored-by: coiax <yellowbounder@gmail.com>
* I put this egg back together (#59744)
Uhhh, I made it so yolks give 5u instead of 4 when cracked into a beaker. Pretty much that
It's weird to not get enough yolk to make a cake when cracked into a beaker. Having to crack a 4th egg because you did it in the wrong container kinda sucks.
* Yolk issue fix
Co-authored-by: carshalash <carshalash@gmail.com>
* Fixes nuke ops lobby meta exploit(#59716)
This pr fixes#56332 (Being able to meta nukie spawn. There was a linked solution which amounted to telling the equip to not make noise, but this code is pain)
Nuke ops leaders are given their paper during the memorize_code proc.
Nuke ops are moved to spawn after memorize_code is called.
So: nuke ops leaders got their paper before they were moved to the nuke ops spawn - allowing anyone to hear it that's nearby the spawn box.
This PR just moves the memorize_code call to after nuke ops are moved to their spawn, so it prevents the lobby from hearing the sound of the paper.
* Fixes nuke ops lobby meta exploit
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
* Fixed signal ports receiving signals when a signal is not actually sent (#59745)
It's an oversight that signals are sent when ports are connected between each other. Signal ports should only receive updates when triggered.
* Fixed signal ports receiving signals when a signal is not actually sent
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
* overheating of the laser minigun doesnt care about burst size anymore (#59733)
with autofire, burst size is always 1
* overheating of the laser minigun doesnt care about burst size anymore
Co-authored-by: Fikou <piotrbryla@onet.pl>
* Improves H.A.U.L. gauntlets and /datum/component/strong_pull code, fixing a couple of little issues in the process (#59550)
Does a bit of a logic re-write on the cargo gauntlets and their strong_pull component.
Cargo gauntlets themselves have been converted to use signals for equipping and unequipping.
Their component reference has been changed to a weakref so if the component is ever Destroy()ed for any reason outside of the gauntlets it doesn't hard del.
The strong_pull component now registers signals with parent in RegisterWithParent() instead of Init() and removing the strong grip is no longer a SIGNAL_HANDLER proc. It is now called by the signal handler for no longer pulling things and in Destroy(). This stops instances where pulling things and removing the gloves didn't remove the pull effect appropriately.
* Improves H.A.U.L. gauntlets and /datum/component/strong_pull code, fixing a couple of little issues in the process
Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
* During unit tests, does extra verification on text based overlays (#59553)
This makes it so during unit tests, adding a text based overlay to something will runtime if the icon does not have an icon state matching that text. I would do this during normal compiles as well but getting the icon states from an icon is surprisingly expensive.
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@ users.noreply.github.com>
* During unit tests, does extra verification on text based overlays
Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com>
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@ users.noreply.github.com>
* Fix tachyon across z-levels (#59696)
Tachyon-doppler arrays now work when on a different z-level than the RD server provided both of them are on a station z.
Same applies for all things using the experiment handler component in fact.
* Fix tachyon across z-levels
Co-authored-by: RandomGamer123 <31096837+RandomGamer123@users.noreply.github.com>
* Digitigrade Paralysis BugFix (#59697)
* Fixing Digitigrade Legs, Adding Sanity Checks
- A limb's attach_limb proc now uses the set_owner() proc instead of setting the owner manually, fixing problems where limbs that were meant to be paralyzed were not
- Added a sanity check to set_usable_legs to ensure the value isn't set lower than 0
* Adds A Stack Trace to Set_Usable_Legs
- set_usable_legs now calls stack_trace() whenever it is provided with a negative value
* Digitigrade Paralysis BugFix
Co-authored-by: Beatrice <83368538+SpaceDragon00@users.noreply.github.com>
* Makes mafia roleblocks actually end (#59673)
Fixes a bug where if you were roleblocked one night by a lawyer in mafia you would be roleblocked FOREVER by adding a single missed character ~
* Makes mafia roleblocks actually end
Co-authored-by: RandomGamer123 <31096837+RandomGamer123@users.noreply.github.com>
* (Hopefully) Stops cryopodded contract targets from breaking contractor uplinks (#59742)
This PR aims to stop contractor uplinks from breaking due to having a target cryopod. When a contract target enters cryosleep, it now manually rerolls the contract.
This PR is admittedly somewhat bandaid-y, as contractors are slotted for removal soon, apparently.
* (Hopefully) Stops cryopodded contract targets from breaking contractor uplinks
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
* Fixes custom emotes not working with slimes (#59680)
Allows slimes to use hotkey emotes and custom emotes by removing /mob/living/simple_animal/slime from mob_type_blacklist_typecache in code/modules/mob/living/emote.dm, added by #22405
* Fixes custom emotes not working with slimes
Co-authored-by: Bytube <40742162+Bytube@users.noreply.github.com>
* Converts suspenders to GAGS. (#59537)
Suspenders were already basically given a greyscale sprite by me in the past, this converts them to GAGS allowing custom recolors of them through existing code already in place.
* Converts suspenders to GAGS.
Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
* tgui input list improvements (#59668)
pressing enter or space now selects the selected button
duplicate keys no longer cause input lists to break
* tgui input list improvements
Co-authored-by: LatteKat <56778689+jupyterkat@users.noreply.github.com>
* Fixes OOC heart commendations (#59543)
At some point in the last few weeks, the OOC heart commendations that players were polled for during the shuttle's return trip at the end of the round stopped appearing for people on the live servers, even though admin logs showed it was still calculating how many people were supposed to be asked, and it seemed to be working fine on my local server. My only guess is it might somehow be related to #58419 since that was the last PR to touch hearted.dm, even if it's not clear how it might've broken it.
I also neaten up the code for commendations a bit, making it so the procs are easier to follow and have less unnecessary checks. Also, the proc nominate_heart has been reworked to receive_heart, since it makes more sense for it to run on the person receiving the commendation as opposed to the person sending it. It will also properly cancel polling if the "how many to ask" check returns 0 people, rather than always polling at least one.
Edit: Figured it out, #58419 was indeed the culprit, it blindly replaced src with usr without considering that src and usr aren't necessarily the same thing (as it was here, since query_heart() was called by the ticker SS)
* Fixes OOC heart commendations
Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
* AAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
* Ads
* dddd
* a
* a
* a
* Update uniform_digi.dmi
* Update uniform_digi.dmi
* Update uniform_digi.dmi
* Some random new potted plants!
* a
* Update flora.dm
* a
* fixes
* a
* a
* e
* Converts the new span_ procs to macros, fixing a few oversights/errors along the way (#59685)
This is a partial re-implementation of #59645
oranges has expressed a desire for the span_ procs to instead be macros.
I agree. Even though it's a small micro-optimisation, a well contained macro can be self-linting. I've already caught one edge case thanks to this in launch_pad.dm
Similarly, there was an edge case where a [ was escaped inappropriately (that errored out) in watercloset.dm and a case where a ] that should probably have been escaped actually wasn't in robot_defense.dm
I have opted to make an exception to the ALLCAPS convention for these macros.
I have guaraded these macros in parenthesis. In doing so, additional error states can be captured as part of the build process as malformed inputs will then cause errors and prompt further investigation.
* Converts the new span_ procs to macros, fixing a few oversights/errors along the way
Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
* Defibrillator Fixes + Code Cleanup (#59615)
Cleans up some of the defib code by reducing repeated code blocks, renaming certain procs, reducing unnecessary if statements, and adding flexability to certain aspects, like cooldown time. Additionally fixes some issues with the code, like visible messages not showing up for mobs who are wearing the source and shock_touching not using its provided damage values.
I have defined the combat paddles' emp_act change as a "Fix" because the comment appended to the combat variable, as well as the lack of sprites/clarity for emped syndicate defibs, made me feel this was unintentional. However, if this is seen as intentional, I will revert those changes to keep this a purely fix/cleanup-based PR
* Defibrillator Fixes + Code Cleanup
Co-authored-by: Beatrice <83368538+SpaceDragon00@users.noreply.github.com>
* POLICE TAPE WOO
hmmgh
* Much things, read desc
Placed tape is a structure now instead of an item, door sprites are actually torn, all code besides destruction works (mostly)
* TAPE WORKS 99%
just need to have a visual for lifted tape..
* Adds lifted visual + starts on making tape obtainable
ahgghbkaghb
* finishes the vendors. 100% complete(?)
AAAAAAAAAAAAAAAAAAA
* detdrobe vending
abghb
* lifted alpha is better
hbgb
* change opacity hngh
* indentation bhgjknbg
im so tired
* walking can crumple the tape too
* desc
* Modify surgical apron to hold additional medical items (#59622)
Exactly what it says on the tin. This PR makes surgical aprons hold more things.
Presently, surgical aprons only hold surgery tools, which any medical doctor would store in their medical belt/medkit. This PR aims to make surgical aprons a more viable (and fashionable) choice for doctors looking at their wardrobes.
Co-authored-by: GuillaumePrata <55374212+GuillaumePrata@ users.noreply.github.com>
* Surgical Apron can now hold more things.
Co-authored-by: OHJ4Y <64231520+OHJ4Y@users.noreply.github.com>
Co-authored-by: GuillaumePrata <55374212+GuillaumePrata@ users.noreply.github.com>
* Fixes powerfist randomly not working when using mixed gas types (#59234)
Adds a bit of wiggleroom so QUANTIZE being called on gas_mixture.remove() doesn't randomly and occasionally makes the powerfist think there isn't enough gas. This seems to be the only feasible way of fixing it.
Adds a helper proc to do this generically
* Fixes powerfist randomly not working when using mixed gas types
Co-authored-by: RandomGamer123 <31096837+RandomGamer123@users.noreply.github.com>
