Commit Graph
17566 Commits
Author SHA1 Message Date
2a355aeed2 [MIRROR] Ice cream now gives a chilling food effect (plus small food haste buff) (#26914)
* Ice cream now gives a chilling food effect (plus small food haste buff) (#81719)

## About The Pull Request
We have a `crafted_food_buff` in the code meant for specific food buffs
(and perhaps one day, debuffs) that has gone unused ever since it was
created during the 'Foodening' PR.

Anyway, yeah, this PR takes the fire step to implement it with ice cream
and other frozen treats.

Frozen treats (all food found in the `food/frozen.dm` file) have it by
default. Other ice cream holders such as waffles cones (and now regular
waffles too!) can aquire it when filled with ice cream. Using the ice
cream vat also adds the 'Chef Made' trait now, which is required for
food effects to happen.

Also very slight food effect refactor. There's no need to have five
different alert screen objects when only have to switch icon states.

This PR also adds an action speed modifier to the generic 'haste' food
effect. I'm confident the original creator would have done that too, but
action speed modifiers aren't as well-known.

## Why It's Good For The Game
People tend to make one feature, call it a day and then move on to the
next. Food effects are nice, however they're barely implemented, and I
don't like food being all the same-ish in the end.

## Changelog

🆑
add: Ice cream and frozen treats now have a chilling effect.
add: You can add a scoop of ice cream on waffles.
balance: added an action speed modifier to the generic food haste effect
(you do things, and not just run, an itsy bitsy faster)
/🆑

* Ice cream now gives a chilling food effect (plus small food haste buff)

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
2024-03-16 22:50:16 -04:00
7374ff4ca2 [MIRROR] Training in heavy gravity gives you more experience points (#26920)
* Training in heavy gravity gives you more experience points (#81990)

## About The Pull Request

If you use exercise equipment in an area with unusually high gravity,
you will get tired faster but will also earn a greater amount of fitness
experience points.
As far as I am aware the only particularly reliable way for regular crew
to gain access to high gravity is the bone-crushing strength (and
radiation?) of the gravity generator, but you could also use
gravitational anomalies or gravitational holoparasites for this if they
are available.

Conversely, if you lift weights when there's no gravity it won't cost
you any stamina at all!

## Why It's Good For The Game

I'll be honest this is a largely pointless and trivial change which
interacts with a similarly useless system, but I thought it would be a
cute interaction.
Training by wearing heavily weighted clothing or in an area where
gravity is increased are _somewhat_ common tropes in fiction (I have no
idea if people do this in real life) and I think our players would
appreciate the incredibly niche circumstances where they can benefit
from this.

I also think if even one round features someone building a gym in the
gravity generator room and encouraging people to get buff while it
crushes them into paste then this was a good addition.

## Changelog

🆑
balance: If you work out under heavier-than-earth gravity, you will get
gains faster.
/🆑

* Training in heavy gravity gives you more experience points

---------

Co-authored-by: Jacquerel <hnevard@gmail.com>
2024-03-16 17:18:22 -04:00
9b3c87533a [MIRROR] Posters return to your hand when cut down/not hung up, abductor posters more resilient to wirecutters (#26909)
* Posters return to your hand when cut down/not hung up, abductor posters more resilient to wirecutters (#81924)

## About The Pull Request

Posters now drop into your hand when you cancel the hanging process, or
snip them down with wirecutters. If they can't drop into your hands,
they go to the floor.

Oh, also, this makes it so that abductor wirecutters (or any wirecutters
with a toolspeed better than 0.2 in case of varedits/future additions)
are too weak to cut down abductor posters.
## Why It's Good For The Game

Posters getting dropped to the ground when cancelling the hanging
process has always really annoyed me and I want it to not happen
anymore.

If you want to get those unsightly abductor posters out of your
department you'll have to loot the abductor scientist first (or just
take the wall down but that's admitting defeat).
## Changelog
🆑 Rhials
qol: Posters now return to your hand when the hanging process is
cancelled, or they are snipped down.
qol: Abductor posters can now only be cut down with abductor-tier
wirecutters.
/🆑

* Posters return to your hand when cut down/not hung up, abductor posters more resilient to wirecutters

---------

Co-authored-by: Rhials <28870487+Rhials@users.noreply.github.com>
2024-03-16 05:00:55 -04:00
b7f4873e1c [MIRROR] Adds a collar bomb to the black market. (#26907)
* Adds a collar bomb to the black market. (#81898)

## About The Pull Request
Originally part of the other blackmarket PR, but it seemed a tad awkward
to have it mandatorily installed on mobs rescued from the holding
facility.

But yeah, this PR adds a neck item that causes the wearer's death with a
5 seconds countdown when triggered, which can be bought from the market
uplinks. The box comes with a yellow button to trigger it, but it can
also hold a signaler (which the wearer cannot tamper) if you wish to use
assemblies. Take note that, upon being worn, the item cannot be removed
by any mean beside beheading iirc (so HARS should counter it), and
fire/acid if you have a ton of patience because of its high armor
values.

## Why It's Good For The Game
More mean and evilish stuff to populate the black market with.

## Changelog

🆑
add: Added a collar bomb to the black market.
add: Added a possible kit to the special syndie bundle B, which also has
uses these collars.
/🆑

---------

Co-authored-by: san7890 <the@ san7890.com>

* Adds a collar bomb to the black market.

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Co-authored-by: san7890 <the@ san7890.com>
2024-03-15 22:02:18 -04:00
d0eb82b27c [MIRROR] now spiders get extra damage by fly swatter (#26898)
* now young spiders get extra damage by fly swatter (#82010)

## About The Pull Request

Closes https://github.com/tgstation/tgstation/issues/81981

## Why It's Good For The Game

Allows flyswatter to act as we would imagine. Takes 1 to 4 hits
depending on its type. Makes list static so we don't have to make it
every flyswatter.

## Changelog

🆑
fix: now young spiders get extra damage by fly swatter
/🆑

---------

Co-authored-by: Jacquerel <hnevard@ gmail.com>
Co-authored-by: san7890 <the@ san7890.com>

* now spiders get extra damage by fly swatter

---------

Co-authored-by: Bilbo367 <163439532+Bilbo367@users.noreply.github.com>
Co-authored-by: Jacquerel <hnevard@ gmail.com>
Co-authored-by: san7890 <the@ san7890.com>
2024-03-15 21:54:50 -04:00
ef760e10cd [MIRROR] Revamps irradiated meteor effects (#26881)
* Revamps irradiated meteor effects (#81941)

## About The Pull Request

Irradiated meteors have been given a little tune-up, because they are
kind of underwhelming right now.

Presently, they do less damage than a standard meteor. At some point its
impact effect was reduced to a single radiation pulse (which does
absolutely nothing).

Now, they hit harder, deeper, and leave behind a pile of radioactive
sludge. Let's see how it looks:

![image](https://github.com/tgstation/tgstation/assets/28870487/d4670bc7-fe42-4f6b-ab1b-b56f55b1b12e)

Oof, wouldn't want that hitting MY department!

You'll have to clean up the radioactive sludge, and should probably wear
protective equipment while doing so. Also, they will show up slightly
less often now, as they are more threatening now.
## Why It's Good For The Game

Re-implements Flavor for an effect that lost its taste since being added
10 years ago. An irradiated meteor doesn't do anything besides look
pretty and green right now.

Currently irradiated meteors are really boring and not threatening --
antithetical to the idea of a "radioactive meteor". Now, there's a much
more interactive and measurable impact when one hits.
## Changelog
🆑 Rhials
balance: Irradiated meteors now hit harder and leave behind radioactive
goop.
/🆑

* Revamps irradiated meteor effects

---------

Co-authored-by: Rhials <28870487+Rhials@users.noreply.github.com>
Co-authored-by: Pinta <68373373+softcerv@users.noreply.github.com>
2024-03-15 16:12:13 -04:00
b42d49c174 [MIRROR] Adds logging to SSore_generation on subsystem initialize (#26891)
* Adds logging to SSore_generation on subsystem initialize (#81488)

This PR adds a new logging category and a logging message specific to
SSore_generation's initialize, logging the number of vents of each size,
as well as the number of random and proximity based ore spawns due to
cave generation and map generation.

Currently drafted as I could use some feedback as to why I'm not seeing
the logger.log() messages not appearing on any of the current in-game
log files 👍

Useful for data logging to determine how many of each type of ore is
spawned on the map, for the purposes of determining how much ore is
being spawned manually over the automatic amounts based on the vents,
with the quantity of ores spawning being a product of the ore vent sizes
being logged as well.

* Adds logging to SSore_generation on subsystem initialize

---------

Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
2024-03-15 14:22:19 -04:00
8e8cc93958 [MIRROR] Buffs the SC/FISHER Saboteur Handgun. (#26875)
* Buffs the SC/FISHER Saboteur Handgun. (#81553)

## About The Pull Request
The saboteur gun will now silence pAIs, toggle off radio broadcasting
(won't auto-relay nearby speech), disable turrets, chill out secbots a
little, and turn off APCs like power outages do.
The disrupt duration has also been buffed from 10/20 to 15/25 for ranged
and point-blank respectively.
Removed a conspicious chat message from an otherwise inconspicious gun.
Brought the code up to date.

## Why It's Good For The Game
The concept is cool, alas it's also undermined by how much of a joke
it's right now, and the game has plenty already.
The amount of interactions it has with things is underwhelming, so you
could barely consider it a stealth tool. The duration is also quite
scarce, I pointed that out in the original PR too.

Basically, I want to make the item cooler.

## Changelog

🆑
balance: Buffed the duration of the SC/FISHER Saboteur Handgun's
disruption effects. It's also stealthier and it won't conspiciously
alert living mobs hit by it.
add: Added saboteur interactions with radios, pAIs, turrets, secbots and
APCs.
/🆑

---------

Co-authored-by: Jacquerel <hnevard@ gmail.com>

* Buffs the SC/FISHER Saboteur Handgun.

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Co-authored-by: Jacquerel <hnevard@ gmail.com>
2024-03-13 19:47:45 -04:00
e5bae97fc8 [MIRROR] Gulag boulder mining adjustments (#26867)
* Gulag boulder mining adjustments (#81971)

## About The Pull Request

This PR does two fairly simple things.
Firstly, it triples the gulag point value of every material except
glass.
Secondly, it allows mining skill increases to effect the speed of
boulder breaking and reduce the stamina "exertion" you take.

I tried this out personally on Lavaland and Icebox and while this is
very much dependent on RNG (and storm timing) this got earning 1000
points purely from mining and smashing boulders down to _about_ ten
minutes of work, which I believe is the rough estimate of how much
effort it was before that. It may skew a bit higher than that if the ash
storm happens at a bad time or the game gives you predominantly iron,
but not a _lot_ higher.

The mining skill = faster smashing thing is... barely perceptible after
ten minutes of mining to be honest but it's saving _some_ time and I
think if it gives you the exp it might as well benefit from it too.

I didn't do anything for _glass_ because you can just pick that up off
the ground in Lavaland and I didn't want to make _that_ the ideal route
to getting your sentence finished.

## Why It's Good For The Game

Since ArcMining was merged, the gulag has changed to a system primarily
about digging up boulders and smashing them with a pickaxe for random
rewards. I think the chain gang thing is pretty flavourful, but the
inability to just target high-value materials (because you could see
them on the mining scanner) and the overall decrease in output has made
it take a lot longer to get a similar amount of points.

People are sending prisoners out to mine for 1000 points of materials
assuming this is about 10 minutes work, when in reality it was more like
30-35 minutes. Longer on Lavaland, where you need to take breaks for ash
storms.

This was not an intentional "nerf" to prisoner miners and should
hopefully bring it back down to somewhere closer to the previous level.

## Changelog

🆑
balance: All materials except glass are now worth more gulag points than
before.
balance: Mining skill decreases the time it takes to break boulders, and
makes it less tiring.
/🆑

* Gulag boulder mining adjustments

---------

Co-authored-by: Jacquerel <hnevard@gmail.com>
2024-03-13 19:44:44 -04:00
232ac4b6ee [MIRROR] Making the fuck you coupon trigger only once, take two (#26866)
* Making the fuck you coupon trigger only once, take two (#81953)

## About The Pull Request

So a previous pr attempted to fix the fuck you coupon, by adding 1 to
the arguments.
```dm
(tgstation/code/modules/cargo/coupon.dm, line 87)
cursed.AddComponent(/datum/component/omen, 1)
```
But this was setting the `vessel` rather than the `incidents_left`
argument to 1.
```dm
(tgstation/code/datums/components/omen.dm, line 20)
/datum/component/omen/Initialize(obj/vessel, incidents_left, luck_mod, damage_mod)
```
Moving this argument over one fixes the issue.
```dm
cursed.AddComponent(/datum/component/omen, null, 1)
```

However! We're now skipping over the `vessel` value, which is used to
burn up a curse's vessel once the curse is expended.
Setting this to `src` rather than `null` means the fuck you coupon
actually gets 'expended', which I think it better than just using `null`
or `incidents_left = 1`. The coupon's useless once it's done, and this
way it's cooler anyway.
For consistency, we then also add this behaviour to when the coupon
gives you a heart attack instead.

Then! I noticed there was a _second_ bug with fuck you coupons, where it
would stop prematurely if the location wasn't a mob.
```dm
(tgstation/code/modules/cargo/coupon.dm, line 80-81)
if(!ismob(loc))
	return FALSE
```
However, this also happens when you don't have a free hand for it to put
the coupon in, and thus entirely negating the curse and just giving you
a useless fuck you coupon.
We fix this by just adding a `user` argument to `generate`, which it
prefers to use when available, and is set to the user ripping off the
coupon in the first place.
## Why It's Good For The Game

Fixes #81946.
As fuck you coupons are pretty much useless after expending their curse,
and we have to add the vessel value anyway, I thought it'd be more
fitting to add the coupon as the vessel rather than just putting in
null. Then, for consistency, I felt it'd be best to make them *also*
burn when giving you a heart attack when you already have a curse.
Y'know, it's expending the coupon for it's one-time fuck you!

Also fixes fuck you coupons not actually applying their curse if you
didn't have any free hands for it to put the coupon in when ripping it
off.
## Changelog
🆑
fix: Fuck you coupons ACTUALLY trigger only once again. As a
consequence, they also burn up when expended for their one-time fuck
you.
fix: Fuck you coupons work regardless of whether you had a free hand or
not.
/🆑

* Making the fuck you coupon trigger only once, take two

---------

Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com>
2024-03-13 19:42:55 -04:00
d53ced4e8d [MIRROR] Ore vent fixes to spawning multiple megafauna. (#26862)
* Ore vent fixes to spawning multiple megafauna. (#81935)

## About The Pull Request

Ore vents can now no longer be scanned multiple times to spawn multiple
nodes, nor can they be used to duplicate lavaland bosses.

Vents now call for a `can_interact` check, as well as against the
cooldown timer, which has been moved a bit in the order of operations in
order to check things correctly when there's possibly multiple prompts
open for starting the defense waves.

Additionally, boss waves actually do what they're supposed to do, and
don't spawn in a node drone on boss summoning, but instead summon the
drone afterwards, which sets up the vent, then takes off visually. This
is reflected in the tgui alert before starting waves.

## Why It's Good For The Game

Fixes #81817. Improves visual clarity when doing boss vents so that
players don't get the wrong idea that they need to protect the drone as
well when fighting bosses.

## Changelog

🆑
fix: Ore vents have to be scanned while standing next to them.
fix: Menacing ore vents now correctly only spawn in a node drone after
the boss is defeated, instead of before.
/🆑

* Ore vent fixes to spawning multiple megafauna.

---------

Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
2024-03-13 19:40:43 -04:00
608652bba0 [MIRROR] Dynamic material colors applied for insertion animation into lathes (#26854)
* Dynamic material colors applied for insertion animation into lathes (#81692)

## About The Pull Request
So you've noticed that when we insert say uranium into a techfab it
shows us the proper green sheet getting consumed as the animation but
when you insert that same uranium into an autolathe is shows us a blue
sheet animation instead?

Yup not realistic, this is because the autolathe has only 2 animation
types one for inserting iron & the other for glass. Every material type
would have to share these 2 animations making it look bland.

Now the material color is blended on the icon itself allowing for the
right color to be applied on the insertion animation

Plus this also trims the sizes of our dmi files so it's a win overall

https://github.com/tgstation/tgstation/assets/110812394/bb643691-8d3b-4822-8371-346c2d5e5be3

## Changelog
🆑
fix: inserting a material sheet into an lathes should show the correct
animation color
/🆑

* Dynamic material colors applied for insertion animation into lathes

---------

Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com>
2024-03-13 19:37:00 -04:00
0e217eab7b [MIRROR] Sticker resprite and rewrite (#26853)
* Sticker resprite and rewrite (#81893)

Stealing from Goon is bad, but stickers are actually a good feature, and
loosing those will be a disappointment. This project aims to recreate
'em from scratch without using Jimmyl's and Goon's code. Also,
suspicious icons were resprited and renamed.

* Sticker resprite and rewrite

---------

Co-authored-by: Interception&? <137328283+intercepti0n@users.noreply.github.com>
2024-03-13 19:35:59 -04:00
a11b7103a7 [MIRROR] [NO GBP] The museum piggy bank now spawns with at least 400 creds in it. (#26850)
* [NO GBP] The museum piggy bank now spawns with at least 400 creds in it. (#81895)

## About The Pull Request
Used the wrong operator in a control statement.

## Why It's Good For The Game
Title.

## Changelog

🆑
fix: The museum piggy bank now spawns with at least 400 creds in it.
/🆑

* [NO GBP] The museum piggy bank now spawns with at least 400 creds in it.

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
2024-03-13 19:32:43 -04:00
28d3109816 Ai law stuff (#26838)
* Emperor Ai Module

Emperor ai module writen wiht useroth help

* Update ai_laws.dm

* Update modular_skyrat/master_files/code/modules/research/designs/AI_module_designs.dm

---------

Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
2024-03-13 06:33:12 +01:00
8196e26aff [MIRROR] NEW TRAIT ROLE: Veteran Advisor (#26667)
* NEW TRAIT ROLE: Veteran Advisor

* Oh, right

---------

Co-authored-by: vinylspiders <13398309+vinylspiders@users.noreply.github.com>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
2024-03-13 06:32:59 +01:00
+1 3b134f2e85 Missingmirrors (#26743)
* [NO GBP] Extremely tiny stupid nitpick changes to the smoking room ruin (#81767)

## About The Pull Request

Ok so this just does some really really tiny changes to the smoking room
of the smoking room ruin. I added this way back during march mapness and
have always wanted to touch up this last area.

These are basically just touch-ups that are two years too late because
they felt so insignificant and small that making an entire PR to change
them felt excessive. I still feel that way but I'm also a perfectionist
and this would linger in my head until the day I die.

Anyways, there should be slightly less awkwardly placed spawners, decals
blocked from view. You also have to walk past the smoky remains to reach
the second special lighter, instead of the first.

That's it, that's everything. You don't even get screenshots here.
Sorry.
## Why It's Good For The Game

I have an obsession with revisiting and completing old, unfinished work.
## Changelog
🆑 Rhials
fix: Some tiny tiny changes to the smoking room ruin to make it a little
less ugly.
/🆑

* Tram tile/bench fixes (#81798)

## About The Pull Request

- Tram benches can be rebuilt after deconstruction
- Tram tiles build the correct amount inhand
- Tram tiles available in the engineering protolathe with other items
- Tram tiles create the right stack type when pulled up
- Tram tiles have inhand/obj icons for both types

## Changelog

🆑 LT3
fix: Tram floor tiles constructed inhand provides 4 instead of 1
fix: Tram floor tiles provide correct stack item when pulled up
image: Tram floor tiles have their own inhand icons
qol: Tram floor tiles available in the engineering protolathe
fix: You can reconstruct deconstructed tram benches
/🆑

* Tram icon cleanup (#81797)

## About The Pull Request

- Deletes an unused tram_wall.dmi
- Renames tram frame to tram girder
- Tram girder looks like girder, not lattice


![image](https://github.com/tgstation/tgstation/assets/83487515/328c2455-def0-41a1-be9a-87a3ec0dcee7)

## Why It's Good For The Game

More straightforward for players. Since it acts like a girder, it should
look like a girder not a lattice.

## Changelog

🆑 LT3
image: Tram frame is now tram girder, because it acts like one
/🆑

* Autotucking On Map Load (#81782)

## About The Pull Request

Doesn't really do much currently but without it wallening beds look
fuckin DUMB
Plus I think this better matches what is intended

## Why It's Good For The Game


![image](https://github.com/tgstation/tgstation/assets/58055496/d5e4c372-3e84-435a-88b9-b5be442049b2)

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Co-authored-by: san7890 <the@san7890.com>

* Makes Ethereal Charging Loop Just About Everywhere (#81775)

## About The Pull Request
Basically,


For APCs.

![dreamseeker_bfZeNmkOPh](https://github.com/tgstation/tgstation/assets/12636964/39eddc7b-7389-4586-a392-4a8d2437e93b)


For recharging APCs.

![dreamseeker_mlKuDR2JJW](https://github.com/tgstation/tgstation/assets/12636964/1f28850c-57a7-43b2-9663-81b2f3b34ce9)


For recharging from cells. The Ethereal offscreen was blue, you'll just
have to trust me that this was a color-coded PR.

![dreamseeker_bcP0126NlF](https://github.com/tgstation/tgstation/assets/12636964/c20eff96-3112-4b9b-a733-c320528adb5e)

## Why It's Good For The Game
It's kind of CBT as-is right now to have to click this stuff over and
over, especially when light tubes have it that much more convenient than
everything else. I figure some while loops would make the situation
better for them.

## Changelog
🆑
qol: Ethereal charging now loops when they're charging (from) APCs or
from power cells!
/🆑

* Lots of description changes and grammar fixes for heretics (#81761)

## About The Pull Request

Changes a lot of text. Apart from grammar fixes, here are the notable
changes:

- Ash jaunt description just said it is a "short range jaunt" without
explaining what exactly a jaunt is. I believe it is better to describe
without comparing to another spell the player may not have experience
with.
- Cosmic grasp now explains what the deal is with star marks and cosmic
fields. It is still possible to crosspath into a star mark spell,
skipping this description, but I assume a player like that is
experienced enough to know what the star mark does anyway...
- The knowledge for ash spirits no longer refers to them as "Ash Men" -
"Ash Spirit" is the mob's actual name. If you think "Ash Man" is a
better name, I can change it around so that the mob gets renamed that
instead.
- Removes the lines from paradoxical curio's description about causing
brain damage on examination - many heretic items cause adverse effects
to heathens who try to interact with them, and there is never a need to
clutter the description with them.
- Changes the eldritch coin description, because the old one was, in my
opinion, awkward. I changed it to be more inline with the other items'
descriptions, and to not tell non-heretics what its purpose is. If you
liked the old one better, I can revert this change.
## Why It's Good For The Game

Grammar good. Accurate descriptions good.
## Changelog
🆑
fix: made some heretic descriptions more accurate
spellcheck: improved english of the heretical eldritch patrons
/🆑

* Makes Medbay surgery on Metastation a bit more inline with other maps (#81786)

## About The Pull Request

Makes it so paramedics can't access the surgery theater in Metastation

## Why It's Good For The Game
Paramedics can't access surgery on the other maps, and can't use the
front door to the surgery theater, They shouldn't have access to it
through maints

## Changelog
🆑

fix: Makes Metastation surgery access more consistent with other maps

/🆑

---------

Co-authored-by: Rhials <28870487+Rhials@users.noreply.github.com>
Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Co-authored-by: san7890 <the@san7890.com>
Co-authored-by: Nerevar <12636964+Nerev4r@users.noreply.github.com>
Co-authored-by: ViktorKoL <44502667+ViktorKoL@users.noreply.github.com>
Co-authored-by: starrm4nn <139372157+starrm4nn@users.noreply.github.com>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
2024-03-13 04:07:27 +01:00
e46274fc7e [MIRROR] Spider web graphics (#26775)
* Spider web graphics

* Update icon_smoothing.dm

---------

Co-authored-by: Jacquerel <hnevard@gmail.com>
Co-authored-by: jjpark-kb <55967837+jjpark-kb@users.noreply.github.com>
2024-03-12 00:06:38 -04:00
e178821ac4 [MIRROR] General maintenance for grilling related stuff. (#26835)
* General maintenance for grilling related stuff.

* Update grill.dm

---------

Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com>
Co-authored-by: jjpark-kb <55967837+jjpark-kb@users.noreply.github.com>
2024-03-12 00:01:24 -04:00
e5652ecc24 [MIRROR] Add compile option for compiling in MAP_TEST mode, which disables common annoyances when testing new maps (#26792)
* Add compile option for compiling in `MAP_TEST` mode, which disables common annoyances when testing new maps (#81697)

## About The Pull Request

Adds `MAP_TEST` compile flag.

This compile flag blocks common things which make it difficult to test a
map.

Things this applies to:

- Rats no longer spawn.
- Rat spawning will (obviously) break up the powernet, which is
INCREDIBLY annoying when trying to test if all the rooms of the station
are wired correctly (or testing which rooms lose power first, etc)

- Light tubes no longer break on initialize.
- Random light breakages can easily cause mappers to accidentally over
light a room.

- Roundstart command report is not printed.
- Might be a personal preference, but it's kinda annoying to hear the
alert over and over again.

- Random events do not trigger.
- Some events such as gravity generator outage can trigger with 0
population.
   - Random camera breakage event can cause over-placement of cameras.
   - Other stuff tends to just get in the way.

- Station traits do not trigger.
- Probably the biggest annoyance. Many traits modify the map in some way
which disrupts testing.

- Roundstart landmarks don't self deletes.
   - Allows mappers to use sdql to find them.

- Mapping verbs start enabled.

Obviously more things can be added if they come up.

* Add compile option for compiling in `MAP_TEST` mode, which disables common annoyances when testing new maps

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
2024-03-11 23:00:30 -04:00
9bd67f0203 [MIRROR] Adds and improves logging for various shit. (#26831)
* Adds and improves logging for various shit. (#81738)

## About The Pull Request
Adds logging for RCD construction and deconstruction. Hallucinated
projectiles no longer causes logs. Flamethrowers log gas mixture
information, the flamethrower, the gas tank, tank distribution pressure
and whether it was lit. Adds a lot more logging to records consoles.
Frozen objects now log when they get shattered.
## Why It's Good For The Game
Closes #68452
Closes #71798
Closes #78008
Closes #81098
Closes #81130
## Changelog
🆑 Pickle-Coding and Rhials
admin: RCD construction and deconstruction are logged.
admin: Hallucinated projectiles no longer log.
admin: Gives more detail to flamethrower logging.
admin: More actions are logged for records consoles usage.
admin: Frozen object shattering is logged.
/🆑

---------

Co-authored-by: Rhials <Datguy33456@ gmail.com>

* Adds and improves logging for various shit.

---------

Co-authored-by: Pickle-Coding <58013024+Pickle-Coding@users.noreply.github.com>
Co-authored-by: Rhials <Datguy33456@ gmail.com>
2024-03-11 22:35:39 -04:00
f8b87b994b [MIRROR] Overlay Lighting Color/Intensity Pass (#26825)
Overlay Lighting Color/Intensity Pass

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
2024-03-11 22:26:46 -04:00
4461938742 [MIRROR] Nerfs flare and glowstick burn durations (#26827)
* Nerfs flare and glowstick burn durations (#81424)

## About The Pull Request

Who the fuck made flares burn for 35 minutes. These things are never
gonna burn out, people will just assume they last forever.

Flares now burn for between 10 and 15 minutes down from 25 to 35. Nerfs
glowsticks too, fuckin 60 MINUTES WHAT, from 50/60 to 20/25
This should be enough time to make proper use of them (particularly for
the crashed miner) but not so long they feel everlasting

Glowsticks also hide their action button when they are lit (since they
can't really be unlit)

Oh and glowsticks actually burn now. The old code assumed attack_hand
would return TRUE if it did anything, but it just... didn't.
Let's deal with that.

## Why It's Good For The Game

Flares and glowsticks will feel more like flares and glowsticks (I hope)
Also I'll have an excuse to make them brighter (coming soon)

## Changelog
🆑
balance: Nerfs the burn times of flares and glowsticks, from 25/35 to
10/15 and 50/60! to 20/25.
balance: Glowsticks now dim as they burn
add: Glowsticks no longer leave an unusable action button sitting around
then they're lit
fix: Glowsticks actually burn down now (The code was broken)
/🆑

* Nerfs flare and glowstick burn durations

---------

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
2024-03-11 22:24:58 -04:00
a9668bebb3 [MIRROR] Fix mode-toggle examine in simple health analyzers (#26820)
* Fix mode-toggle examine in simple health analyzers (#81902)

## About The Pull Request
Simple health analyzers (i.e. wound and disease analyzers) had a message
about alt-clicking to toggle their mode, but could not actually toggle
modes.

![image](https://github.com/tgstation/tgstation/assets/152340324/83cdb7ba-9657-43ce-8294-2c02908975c9)
This message now only appears on analyzers that can actually toggle
between modes.
## Why It's Good For The Game
Bugs bad
## Changelog
🆑 PapaMichael
fix: Removed erroneous information on some health analyzer's examine
text.
/🆑

* Fix mode-toggle examine in simple health analyzers

---------

Co-authored-by: PapaMichael <papa.michael.1996@gmail.com>
2024-03-09 19:30:17 -05:00
e04cd7d8bb [MIRROR] Adds more syndie-kits! 3 of them to be exact. (#26816)
* Adds more syndie-kits! 3 of them to be exact. (#81510)

## About The Pull Request
Adds 3 syndie-kits, two are in the special pool and the other in the
tactical pool. Below are the kits content:

Tactical:
1. Revolutionary (28TC), which contains:
- Hypnotic Flash (7TC)
- Radioactive Microlaser (3TC)
- LSD pills (~1TC)
- Sleepypen (4TC)
- Nagant Revolver (13TC, Comparable to 357. Revolvers (far harder to get
ammo though))
- Megaphone
- Revolutionary bedsheet
- Russian warcoat
- Ushanka
- Contraband poster boxes

![image](https://github.com/tgstation/tgstation/assets/127663818/2fde2a65-edb1-45b7-9d9e-6b19e3239dbd)

Special:
2. Prophunt (29TC), which contains:
- Chameleon Projector (7TC)
- Doorjack (3TC)
- Stealth Implant (8TC)
- Makarov (7TC)
- Thermal Glasses (4TC)

![image](https://github.com/tgstation/tgstation/assets/127663818/f17317fb-b852-4a25-a4b8-57f22365afb4)

3. Sam Fisher (32TC), which contains:
- Spec Ops suit (~6TC comparable to infiltrator suit)
- Night Vision Googles (~3TC)
- Assault belt with assorted items (18TC, refer to image)
- Combat Gloves + Krav Maga (5TC)

![image](https://github.com/tgstation/tgstation/assets/127663818/b903f978-4e77-40b5-9213-21a5d67edbd8)
## Why It's Good For The Game
I use syndie-kits a lot whenever I roll traitor, always found them to be
a quick and easy way to figure out what i'm going to do for the traitor
round. but there's only so much kits that eventually you'd get bored of
getting the same old kits. This PR fixes that! adds 3 different
syndie-kits each with their own little unique gimmick that weren't
present in the kits before.

 more kits = more gimmicks = more fun and engaging gameplay

The Revolutionary kit is centered around it being a budget
revolutionary, you're given a hypnoflash and various other gadgets to
help you get your own small army to do your bidding, also comes with a
drippy (do anyone still use that word anymore?) russian armor and
revolver for self defense.

Prophunt kit is self-explanatory, be the little gremlin you are,
stealing and sneaking your way through a greentext.

Meanwhile the Sam Fisher kit essentially allows you to be an spec ops
agent, getting a myriad of gear that's designed for sabotage and quick
assasinations. comes with a cool armor set
## Changelog
🆑
add: Adds 3 new kits into the syndie-kit spawn pool, 2 for special and
another for tactical
/🆑

* Adds more syndie-kits! 3 of them to be exact.

---------

Co-authored-by: Singul0 <127663818+Singul0@users.noreply.github.com>
2024-03-09 14:25:42 -05:00
5563e27f14 [MIRROR] Shuttle gibbing code improvements (#26814)
* Shuttle gibbing code improvements (#81726)

## About The Pull Request

Adds a resistance flag, `SHUTTLE_CRUSH_PROOF`, adds it to the existing
things that have it, and adds it to the immortality spectres.

## Why It's Good For The Game

Gets rid of some hardcoded checks, making it easier for future code (or
admins) to make things immune to shuttle crushing.

Also makes it so immortality spectres are immune to being shuttle
crushed, as that kinda ruins the whole "immortality" thing...

## Changelog
🆑
refactor: Improved shuttle gibbing code, adding a new resistance flag,
`SHUTTLE_CRUSH_PROOF`.
fix: Immortality revival spectres can no longer be crushed by shuttles.
add: The ghost of Poly can no longer be shuttle-crushed, nor can
anything incorporeal.
/🆑

Co-authored-by: san7890 <the@ san7890.com>

* Shuttle gibbing code improvements

---------

Co-authored-by: Lucy <lucy@absolucy.moe>
Co-authored-by: san7890 <the@ san7890.com>
2024-03-09 14:25:05 -05:00
fcc36827a5 [MIRROR] Adjusts some of the contraband weights for Contraband Crates. (#26813)
* Adjusts some of the contraband weights for Contraband Crates. (#81771)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

This makes getting Contraband Plus (the better stuff with more
interesting effects), slightly higher in probability out of contraband
crates.

It also removes the completely redundant narcotics roll, and the truly
awful permabrig contraband roll, from Contraband Plus.

Some of the more interesting narcotics are now directly in Contraband
Plus.

## Why It's Good For The Game

The weights were a little uninteresting. You rarely if ever saw the
effects of the contraband crate change with the current values. It was
kind of lame to see a shiv in a contraband crate knowing that it was a
wasted Contraband Plus roll. This hopefully stops that from happening
too often.

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑
balance: Adjusts the values and contents of the Contraband Crate's item
loot table.
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: san7890 <the@ san7890.com>

* Adjusts some of the contraband weights for Contraband Crates.

---------

Co-authored-by: necromanceranne <40847847+necromanceranne@users.noreply.github.com>
Co-authored-by: san7890 <the@ san7890.com>
2024-03-09 14:24:41 -05:00
95029e839a [MIRROR] Curtains behave like curtains should, by not being a wall (#26811)
* Curtains behave like curtains should, by not being a wall (#81843)

## About The Pull Request
This has bothered more for far too long that curtains suddenly become
solid objects instead of, well, behaving like curtains in any form do
and just bend out of your way. They function the same from an opacity
POV but i just removed the density toggle so they'll always allow
passthrough.

![image](https://github.com/tgstation/tgstation/assets/22140677/9311242f-fb5d-4640-b7f3-82ad243133f2)

![image](https://github.com/tgstation/tgstation/assets/22140677/fd3d5a5d-8458-4595-9e2e-2b83426d8e61)

## Why It's Good For The Game

You can have your privacy and have realistic curtains

## Changelog
:cl:Zergspower
qol: Curtains and shower curtains are no longer solid objects that defy
common sense
/🆑

* Curtains behave like curtains should, by not being a wall

---------

Co-authored-by: Zergspower <Griffinj88@yahoo.com>
2024-03-09 14:05:10 -05:00
61585119bf [MIRROR] Fixes that one id card context runtime (#26807)
* Fixes that one id card context runtime (#81882)

## About The Pull Request

https://github.com/tgstation/tgstation/pull/80906#discussion_r1449233294

* Fixes that one id card context runtime

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
2024-03-09 14:04:25 -05:00
2dc0bd272a [MIRROR] fix ore vents spawning the wrong wolves and remove simple wolves (#26791)
* fix ore vents spawning the wrong wolves and remove simple wolves (#81864)

## About The Pull Request
wolves got refactored but the ore vents were still spawning the old
versions, this fixes it and removes the old wolves from the code

## Why It's Good For The Game
fixes ore vents spawning old wolves

## Changelog
🆑
fix: fixes ore vent spawned wolves being untammable
/🆑

* fix ore vents spawning the wrong wolves and remove simple wolves

---------

Co-authored-by: Ben10Omintrix <138636438+Ben10Omintrix@users.noreply.github.com>
2024-03-08 19:17:53 -05:00
2eac95b7a1 [MIRROR] Adds a small cafeteria behind the right wing shutters of the museum. (#26766)
* Adds a small cafeteria behind the right wing shutters of the museum. (#81465)

## About The Pull Request
I was thinking to contribute something to the new away mission map to
make it better. Mapping and all takes too much time for me, so I could
do little. Though it comes with its own unique gimmicks.

To reach the cafeteria, one has to complete a couple puzzles.
The first set is opened by inputing the correct PIN on the password
panel beside it. There're several clues to help you guess this fairly
easy puzzle, in the form of several number graffitis, a scrapped piece
of paper full of numbers, and a board filled with colored dots also
found just beside the panel.
The second one is opened by a keycard, and is generally lazier. To find
it, you'll need to do a bit of (toilet) searching.

As for the unique things this PR adds:
- A fire extinguisher... that actually contains welding fuel
- A (dirt-cheap) hotdog vending machine*
- A completely ornamental maneki-neko (that's the name of the
luck-bringing, paw-waving cat figurine)
- A piggy bank that carries money between rounds. It has a cap of 10k
credits worth of holochips, cash and coins, which is pretty high, but
I'm confident people will just destroy it for its contents the moment
they find it. His name is Pigston Swinelord VI.
- More, totally legit and not actually fake bombable walls :^)

*By the by, you can also find it during the national hotdog day.

Screenshots of the new location:
![museum
cafe](https://github.com/tgstation/tgstation/assets/42542238/1c0d93b7-90d5-4459-a48d-81430f0d3613)
![museum
restrooms](https://github.com/tgstation/tgstation/assets/42542238/5a9e049d-6acc-464b-998d-901e43154bae)

## Why It's Good For The Game
You know how most away missions are not that special at all? Yeah,
@ mc-oofert set an example of a pretty decent one actually, if not a tad
small. I thought it could use a touch of another mind actually
contributing to it too, because it deserves it.

Also, this sets the basis for other persistent piggy banks. I don't
think they should all have that 10k cap like this one, perhaps 1k is
enough. Beside, the code that mothblocks did for json database datum is
pretty good, so there is not a whole lot of shitcode here.

## Changelog

🆑
add: Added a cafeteria to the museum away mission, with a few special
things to it. To reach it, you'll have to complete a couple puzzles
however.
map: The museum away mission now has a couple restrooms.
add: Hotdog vending machines may spawn during the National Hot Dog Day.
/🆑

* Adds a small cafeteria behind the right wing shutters of the museum.

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
2024-03-07 08:53:28 -06:00
6221130798 [MIRROR] Arcargo: Vendor Cargo and Vending Machine Update (#26782)
* Arcargo: Vendor Cargo and Vending Machine Update (#81582)

Another one.

## About The Pull Request
This pull request originally had a design doc that @ Fikou and I worked
on, but that was never really polished up for publishing quality so I'll
forgo it for now and be as descript as possible here.

### Core changes
- This pull request adds a new NTOS app to the game, the restock
tracker. The restock tracker shows a comprehensive list of vending
machines across the station, as long as there is a need for that vending
machine to get restocked.
- This has also been pre-installed into the cargo data disks.
(`/obj/item/computer_disk/quartermaster`)
- Vending machines now store a total of 20% of the cost of any purchase
made within themselves into a small pool of cash. This only applies to
premium and normal purchases, not to contraband, as they're technically
not sanctioned by the company.
- The restock tracker app will also track which vending machines have
the most credits stored internally inside them.
- By refilling a vending machine, the stored credits within are paid out
to any crewmember who goes and restocks the station, while also paying
out *half that amount to the cargo budget*, serving as a basic but
otherwise easy tertiary money making method on the same level of
complexity as doing bounties, with the added benefit of actually helping
to assist the station for jobs like... assistant.

![image](https://github.com/tgstation/tgstation/assets/41715314/59cee2d9-7e60-4733-8a76-d88fe5b8c3f2)

### Break Stuff
- Anyway, when you try and smash a vending machine open with a melee
weapon of choice, it can now pay out 50 credits at a time as a way to
make money at zero risk to yourself.
- ~~Except for the horrible risk to yourself.~~

![image](https://github.com/tgstation/tgstation/assets/41715314/23208bf0-8484-40b9-b753-0ffdb57d770f)

### Cargo Specific Changes
- Restock units may now be sold for a small profit as well, to
incentivize cargo to keep the station stocked further.
- The `STATION_TRAIT_VENDING_SHORTAGE` trait will now add a small amount
of existing credits into the vending machines on station, to incentivize
cargo to fix the issue during the round and not just push for an early
shuttle call. Or, more accurately, provide the crew with a money making
scheme to engage better with the station trait as it stands.

### This also refactors behavior on vending machines
- This pull request also finally changes it so that vending machines now
use the payment component, which as a consequence allows for the
following improvements:
* Vending machines may now pull from physical credits on your person,
not just requiring you to have money on your ID card.
* Vending machines may also use credits being pulled by the player
interacting with the vending machine, allowing for handless mobs to be
able to purchase items from a vending machine.
* Finally makes the "use-for-everything buying things component" used by
the most utilized component of the in-game economy, to reduce the
quantity of unique implementations of purchasing things in the code.
- Existing vending specific checks are retained on before handing off
behavior to the payment component, for behavior such as purchasing
cigarettes/alcohol under the age of 18/21.

Notes:
- Vending machines will lose their internal credits stored when
deconstructed, as a security measure.
- Vending machines will now show the total amount of credits that a mob
has on their person, combining physical credits as well as credits held
in their ID card to accurately portray their total wealth across the mob
in question.

## Why It's Good For The Game

First off, this is largely an excuse to move vending machine behavior
over to the payment component for the purposes to less code copy-paste,
and to try and make the implementation more wide-spread.

Second, this implements a new tertiary economy method to the game, in
the same design space as bounties, which serve as common methods of
making money without necessarily being specific to their job in
question, with the primary goal of providing small amounts of work to
the crew and a basic interaction with the economy system.

Additionally, it gives cargo more things they can do to assist the
station, and a way to know which parts of the station need support as a
result.
It improves the interaction between the vending shortage station trait
as well, making it a challenge with depth as opposed to a more
oppressive round change that players would rather reroll the game over.

Additionally, this makes a few price tweaks to vending restock modules
as well to help incentivize buying some of the more minor restock kits,
and a few select bumps on restocks that cover wide enough territory to
necessitate fewer restocks.

* Arcargo: Vendor Cargo and Vending Machine Update

---------

Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
2024-03-06 22:29:57 -05:00
32c9fdd55f [MIRROR] Lockers and crates shake when someone is trying to break out of them (#26764)
* Lockers and crates shake when someone is trying to break out of them (#81801)

## About The Pull Request

Makes lockers and crates do a little shake when someone is trying to
resist out of them.

https://github.com/tgstation/tgstation/assets/40921881/94703c79-a22c-43e6-ac31-8621173a0953

## Why It's Good For The Game

A little bit of visual flair, lets players know if someone is trying to
get out of a locker.

## Changelog

🆑 Seven
add: Lockers and crates now shake when someone is attempting to resist
out of them.
/🆑

---------

Co-authored-by: san7890 <the@ san7890.com>

* Lockers and crates shake when someone is trying to break out of them

---------

Co-authored-by: Lufferly <40921881+Lufferly@users.noreply.github.com>
Co-authored-by: san7890 <the@ san7890.com>
2024-03-06 22:15:55 -05:00
e21ee685d1 [MIRROR] Fixes station trait jobs and bank accounts ignoring the concept of jobs being singletons (#26720)
* Fixes station trait jobs and bank accounts ignoring the concept of jobs being singletons (#81756)

## About The Pull Request

Jobs are singletons don't make new ones!!

Also this tweaks job station traits slightly so that traits in the
future support multiple slots without breaking

* Fixes station trait jobs and bank accounts ignoring the concept of jobs being singletons

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
2024-03-05 17:31:32 -05:00
6cb52ccd22 [MIRROR] Remove 2 instances of duplicate argument names (#26716)
* Remove 2 instances of duplicate argument names (#81757)

## About The Pull Request

I fixed 2 instances of procs having multiple arguments with the same
name. BYOND does not error on these, instead ignoring all but the last.
It's best to remove these for clarity.

## Why It's Good For The Game

N/A

---------

Co-authored-by: san7890 <the@ san7890.com>

* Remove 2 instances of duplicate argument names

---------

Co-authored-by: wixoa <wixoag@gmail.com>
Co-authored-by: san7890 <the@ san7890.com>
2024-03-05 17:31:04 -05:00
677828a3fc [MIRROR] Medical/improvised gauze icons (#26744)
* Medical/improvised gauze icons (#81802)

## About The Pull Request

Adds icons for stacks of medical gauze and improvised gauze, so that
they can be differentiated from stacks of cloth. Currently all 3 look
the same. Medical gauze is blue tinted like the medical tape, improvised
gauze is grey and a smaller size than medical gauze. Both have
attachment clips at the edge of the roll.

![image](https://github.com/tgstation/tgstation/assets/83487515/47bcd42e-7270-498e-aacb-15d5a39fd432)

## Why It's Good For The Game

Easier to tell three different items apart at a glance.

## Changelog

🆑 LT3
image: medical and improvised gauze are visibly different from cloth
/🆑

* Medical/improvised gauze icons

---------

Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
2024-03-04 16:13:50 -05:00
a5b8028a9d [MIRROR] Fishes love kronkaine + Examining fishing spots. (#26717)
* Fishes love kronkaine + Examining fishing spots. (#81519)

## About The Pull Request
Food items with kronkaine in it now count as great baits (this is the
case of the "all-natural" bait from that overpriced cargo pack I'm
converting into a less expensive goodie in another PR)

Sufficiently high fishing skill (and the relative skillchip) allows you
to list fishes in a fishing spot by examining it twice.

## Why It's Good For The Game
Little fishing things off the top of my head before I move on bigger
stuff.

## Changelog

🆑
add: Fishes love kronkaine.
qol: Examining a fishing spot twice with sufficiently high fishing skill
(or the skillchip) will get you a list of fishes that can be caught.
/🆑

---------

Co-authored-by: san7890 <the@ san7890.com>

* Fishes love kronkaine + Examining fishing spots.

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Co-authored-by: san7890 <the@ san7890.com>
2024-03-03 12:47:04 -05:00
b35cf43069 [MIRROR] Fixes custom pizzas magically generating dairy products and vegetables. (#26722)
* Fixes custom pizzas magically generating dairy products and vegetables. (#81683)

## About The Pull Request
This fix is for pizzabreads being made into a custom pizza that
magically become dairy and vegetable based foods, even if you added
neither.
## Why It's Good For The Game
People with dairy allergies and those that may not like vegetables, I
guess?

(This one has vegetables, 'cause I added tofu)

![image](https://github.com/tgstation/tgstation/assets/53197594/20624972-6cf8-42b5-be6a-06ba123e5aee)

## Changelog
🆑
fix: makes custom pizzas dairy and vegetable free, unless you choose to
add them.
/🆑

* Fixes custom pizzas magically generating dairy products and vegetables.

---------

Co-authored-by: xXPawnStarrXx <53197594+xXPawnStarrXx@users.noreply.github.com>
2024-03-03 12:42:40 -05:00
68d12ca569 [MIRROR] New Shields and Sprites for them (#26713)
* New Shields and Sprites for them (#81615)

## About The Pull Request
Updates shield sprites to new more polished and 3/4 perspective ones.

<details>

![shielding
show](https://github.com/tgstation/tgstation/assets/42353186/823d1d24-6fdd-40c9-84b4-2b9b61d70813)

</details>

Adds 2 new shield types:
- **Improvised Shield.** Made out of 10 iron sheets and 2 sticky tape
pieces. Weaker then buckler shield and breaks after 2 gunshots or 4
baton hits, but has a 50% (BASE FOR ALL OTHER SHIELDS) blocking chance
instead of 30% that buckler has. Bulky
- **Ballistic Shield.** Printed at Security Techfab for a lot of
titanium after getting weapon research. Strong against projectiles, but
weaker than riot shield against melee. Bulky

Both of these shields break, and both of them are their own subtype. As
such you can still only craft strobe shield with a riot shield.
## Why It's Good For The Game

The sprites of shields were very ancient and extremely flat, this gives
them a more refreshed look.

Ballistic Shield is added because Riot Shield was weakened against
projectiles, Ballistic Shield gives the crew a way to get access to
protection against projectiles at some point in the round.
Improvised Shield adds a second improvised shield in the game (after
Buckler Shield). It's balanced by being weaker than Buckler, but higher
block chance, this adds an interesting choice for players on which
shield to craft.
## Changelog
🆑
add: Adds 2 new shields to the game! Ballistic Shield - researched by
Science, and Improvised Shield - made out of iron and sticky tape
image: Riot, Strobe, Telescopic, Energy shields got new less flat
sprites!
/🆑

* New Shields and Sprites for them

* This should do the trick

* uh oh

---------

Co-authored-by: DrTuxedo <42353186+DrDiasyl@users.noreply.github.com>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
2024-03-01 21:31:56 +01:00
32ca7f5816 [MIRROR] virtual pets (#26692)
Virtual pets

Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
2024-03-01 19:05:23 +01:00
deac009edf [MIRROR] Fixed the floortile crate, adds them to blackmarket (#26710)
Fixed the floortile crate, adds them to blackmarket  (#81742)

https://github.com/tgstation/tgstation/pull/81512

i accidentally added it to the emagged console it should be on
contraband now.
also added a backpack to present it from interfering.
and its available in uplink

🆑
add: box with a set of floortile camo, which can be ordered in black
market uplink
add: also adds a backpack to camouflage
fix: i had the crate under emagged console, should be fixed now.
/🆑

---------

Co-authored-by: bigfatbananacyclops <angelwut@gmail.com>
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
2024-03-01 19:05:08 +01:00
5638c1f642 [MIRROR] Don't use turf icons for abilities (#26712)
* Don't use turf icons for abilities (#81720)

## About The Pull Request

Fixes https://github.com/wall-nerds/wallening/issues/100
Replaces a couple of instances of abilities using the icons of walls or
floors with different, somewhat more descriptive icons.

I will be honest I do not understand why two of these were even using
iron walls as an icon.
Both of these instances were cases of "I want to surround something" so
I have replaced them with this icon:

![image](https://github.com/tgstation/tgstation/assets/7483112/264da818-5c33-4093-b993-45ee1b06c24f)

I have also replaced the "freeze floors" ability icon with the ice cube
icon, rather than a 32x32 ice floor icon.

![image](https://github.com/tgstation/tgstation/assets/7483112/524af0ac-4128-4bd3-a3f0-f82583f6cbcb)

I removed a bunch of old copies of goggles items from the `robot-items`
dmi and made them just reference the corresponding item sprites that
they were copies of, because they were out of date with the items and
using deprecated sprites. X-Ray now just looks like the red sam fisher
goggles instead of a caution sign (not that it is obtainable in game).

Oh also I added a tooltip to Ice Demon afterimages because it didn't
have one.

## Why It's Good For The Game

The previous icons don't even look like anything.

## Changelog

🆑
image: Bubblegum Hallucination Surround Charge, Wendigo Shockwave
Scream, and Ice Demon Floor Freeze all have more appropriate action
icons.
qol: Adds a tooltip to Ice Demon Afterimages ability.
image: Cyborg view items now use the same sprites as their corresponding
goggles instead of old versions of those sprites.
/🆑

* Don't use turf icons for abilities

---------

Co-authored-by: Jacquerel <hnevard@gmail.com>
2024-03-01 18:38:37 +01:00
51b8ac1431 [MIRROR] pipebomb (#26704)
* pipebomb (#81529)

## About The Pull Request

![image](https://github.com/tgstation/tgstation/assets/70376633/2c2a8ddf-d210-468b-9403-f7de4fa1fd9b)

removes IEDs, these are its replacement

![image](https://github.com/tgstation/tgstation/assets/70376633/95cc67d7-ed41-481b-9b9d-f31897fdb46d)

this recipe produces a finished pipebomb

you can craft pipes (of the atmos kind) with some metal
then you can make it into a pair of halved pipes with a welder
then you stuff in items for extra effect (optional, only works if it
does something)
then you put in welding fuel OR gunpowder (no other options as of now,
gunpowder is a better explosive)
cable finishes that part
after that, you can attach an unsecured assembly to finish the bomb

also this is the math for the explosion, power is decided by fuel

![image](https://github.com/tgstation/tgstation/assets/70376633/95ac3101-a2af-4bdc-9730-6c9c20195b59)

using it in-hand activates the assembly, using it off-hand allows you to
configure the assembly

## Why It's Good For The Game

IEDs suck and stuff and this would be a better upgrade/replacement
because with assemblies you could make a circuit sentient pipebomb or
gift a pipebomb via cargo or something and gimmicks i guess
## Changelog
🆑
add: Pipebombs
del: Improvised Firebombs
/🆑

* pipebomb

---------

Co-authored-by: jimmyl <70376633+mc-oofert@users.noreply.github.com>
2024-02-29 23:24:18 +01:00
427b465e5c [MIRROR] Logs holosign swatting. (#26690)
* Logs holosign swatting. (#81733)

Logs holosign swatting.
## About The Pull Request
Logs holosign swatting.
## Why It's Good For The Game
Closes #81729
## Changelog
🆑
admin: Logs holosign swatting.
/🆑

* Logs holosign swatting.

---------

Co-authored-by: Pickle-Coding <58013024+Pickle-Coding@users.noreply.github.com>
2024-02-29 22:59:08 +01:00
a4b6b05149 [MIRROR] fixes inability to create material airlocks (#26684)
* fixes inability to create material airlocks (#81711)

## About The Pull Request

Fixes https://github.com/tgstation/tgstation/issues/81710

runtime due to parent proc not returning the airlock
also added an update_appearance()
## Changelog
🆑
fix: You can build material airlocks again
/🆑

* fixes inability to create material airlocks

---------

Co-authored-by: 13spacemen <46101244+13spacemen@users.noreply.github.com>
2024-02-29 22:55:53 +01:00
651e480576 [MIRROR] Temporary bees animate on death and no longer produce corpses (#26683)
* Temporary bees animate on death and no longer produce corpses (#81714)

## About The Pull Request

I requested this as a change on the Hive Head PR but Ghommie didn't
notice and merged it anyway so I had to do it myself instead of forcing
the underclass to do it for me 😔

![dreamseeker_d8pI4uCCqt](https://github.com/tgstation/tgstation/assets/7483112/bff1a2d7-98c7-49d2-854b-a16f709520ab)

Anyway now bees created by the "beesplosion" reaction and by the Hive
Head changeling power no longer produce corpses, and have a death
animation.

## Why It's Good For The Game

It looks better.
It was weird that the bees would create corpses if killed but not if
they expired.

## Changelog

🆑
image: adds a visual effect for hive head bees despawning
/🆑

* Temporary bees animate on death and no longer produce corpses

---------

Co-authored-by: Jacquerel <hnevard@gmail.com>
2024-02-29 22:55:26 +01:00
028f3077c4 [MIRROR] Removes the old toolbox arena code (#26681)
* Removes the old toolbox arena code (#81707)

## About The Pull Request

This machine was added 5 years ago to be used for events like the
toolbox tournament, but it has since been deprecated and unused (toolbox
tournament has made their own version of the console that works much
better and uses TGUI), making this machine not worth touching.
After some discussions in discord, we said the better option would be to
remove this machine and leave the toolbox tournament branch keep using
their machine, rather than to port the toolbox version to TG where it
will continue to not be used in-game.

fun fact: This used to have a feature where it gave antag hud icons to
the members of each team, it was removed when antag huds got refactored
3 years ago, hence why I'm removing an antag hud icon.

## Why It's Good For The Game

Already explained, this machine has no purpose as it is now, and a new
tgui UI won't save it.

## Changelog

Nothing player-facing.

* Removes the old toolbox arena code

---------

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2024-02-29 22:54:47 +01:00
3e649b511a [MIRROR] Grilles dont break by just walking into them under any circumstances (#26678)
* Grilles dont break by just walking into them under any circumstances (#81594)

## About The Pull Request

you can no longer just walk into a grille to destroy it rather fast
also single letter variable cleanup from that proc

## Why It's Good For The Game

this is a bug and bugs are bad

## Changelog
🆑
fix: Grilles dont break by just walking into them under any
circumstances
/🆑

* Grilles dont break by just walking into them under any circumstances

---------

Co-authored-by: jimmyl <70376633+mc-oofert@users.noreply.github.com>
2024-02-29 22:53:23 +01:00
fc6565e475 [MIRROR] [NO GBP] Fixes spurious CI failures from museum ash spawns (for real this time) (#26665)
* [NO GBP] Fixes spurious CI failures from museum ash spawns (for real this time) (#81690)

## About The Pull Request

I saw this runtime again despite thinking I fixed it and then realized I
needed to be calling `ispath()` since we are not working with an
instantiated object with these lists. Oops

## Why It's Good For The Game

Working code is good

## Changelog

Nothing player facing

* [NO GBP] Fixes spurious CI failures from museum ash spawns (for real this time)

---------

Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com>
2024-02-26 23:18:32 -05:00
34f67a1e57 [MIRROR] Adds a multi-dimensional bomb payload to the black market. (#26663)
* Adds a multi-dimensional bomb payload to the black market. (#81562)

## About The Pull Request
This PR adds a !!!FUN!!! bomb payload to the blackmarket, which, upon
detonation, transmutates all terrain in a range like the dimensional
anomaly would. You can also select the dimensional theme to use by using
it in your hand.

I believe however, this thing should cost a fuckton to get and only show
up occasionally. 8k to 10k was my original idea, but I think that's
perhaps not high enough given its flagrant potential. Perhaps I should
also make it so the more dangerous themes yield a shorter range than
others. Suggestions are welcome.

Screenshot of what happens when you don't set the theme:

![chaotic_mess](https://github.com/tgstation/tgstation/assets/42542238/e4c3264d-17e0-45b6-90c2-3c30a592ae2d)

This PR also turns dimension themes into singletons so we access them
more easily. Nothing to write home about.

## Why It's Good For The Game
The black market could always use some extra thingy or two anyway, and
this thing could either be a source of emergent gameplay, or a recipe
for a disaster. Perhaps second to the Big Slappy for how funny it could
be.

## Changelog

🆑
add: Added a multi-dimensional bomb payload to the black market. It's
very expensive.
/🆑

* Adds a multi-dimensional bomb payload to the black market.

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
2024-02-26 23:15:58 -05:00