* fixes nuke core throwing (#53972)
The typepath was wrong, due to an improper feature from a couple months ago, this means that nothing actually happen, and a nonexistent type had a fun new dust. This has been resolved here.
* fixes supermatter sliver throwing
Co-authored-by: Fikou <piotrbryla@onet.pl>
* Merge pull request #52576 from TheVekter/sm-tongs-icon-fix
Fixes the SM sliver tongs sprite being nulled after picking up the sliver
* Fixes the SM sliver tongs sprite being nulled after picking up the sliver
Co-authored-by: 81Denton <32391752+81Denton@users.noreply.github.com>
* Renames a few variables. Also reorders fallback order again.
Renames item_state to inhand_icon_state
Renames mob_overlay_icon to worn_icon
Renames mob_overlay_state to worn_icon_state
worn_icon_state/mob_overlay_state now never gets used for inhands.
* Fixes some comments
* Fixes map issue
* Restart lints
* Properly resolves conflicts
* update_icon() improvements
Fixes some update_icon() calls to properly call parent and use update_overlays() and update_icon_state().
The rest of obj/item fuck it
* Suggested fixes, also passes the linter
* I always forget . = ..() is faster than return ..() FOR SOME FUCKING REASON
* Actually this is better
* Signilzes datum/action to update its icon when its connected item does.
* Reverts italics-span back to no color.
* Cleans up many extra spaces and indents.
* Adds 'hear' span class.
* Replaces all 'italics' used in heard messages with 'hear'.
About The Pull Request
Converts every single usage of playsound's vary parameter to use the boolean define instead of 1 or 0. I'm tired of people copypasting the incorrect usage.
Also changes a couple of places where a list was picked from instead of using get_sfx internal calls
This was done via regex:
(playsound\(.+,.+,.+, ?)1( ?\)| ?,.+\)) to match 1
(playsound\(.+,.+,.+, ?)0( ?\)| ?,.+\)) to match 0
full sed commands:
/(playsound\(.+,.+,.+, ?)1( ?\)| ?,.+\))/\1TRUE\2/ 1 to TRUE
/(playsound\(.+,.+,.+, ?)0( ?\)| ?,.+\))/\1FALSE\2/ 0 to FALSE
I'm not very good with regex and these could probably be optimized, but they worked.
Why It's Good For The Game
Code usability
* Passes thrownthing to hitby
* Items now also pass thrownthing
* No longer uses default arguments
Also fixes bananium shield
* Adds more arguments to hitby calls
* Standardises throw_impact
* Clears up some loose ends
* Adds back wacky comment
* Reinstates can_push=FALSE on bananium shield
* adds signal and modifies each call of afterattack to call it's inherited proc
* uses new macro for sendsignal()
* map fuck
* skip precommithooks
* combine and negate 2 ifs
* Unfucks supermatter extraction
* Redoes it
* moves it to src so it doesn't rely on a user
* neat
* Makes it random because it was requested even though it makes little sense to
* Dedupes some code and removes \the
* Removes \the, add message on break.
* First part of Assmos
* Adds tritium synthesis and basic in-body effects.
* Begins adding the higher tier gases. Removes Freon(not completely yet) adds new gases to scrubers. Fixes some dumb bugs.
* Whoops
* Adds effects and synthesis reactions for pluoxium and stimulum
* Kills Freon.
* Adds sprites
* Removes the magic numbers
* Hyper-Nobelium formation
* Removes Freon from maps.
* Initial Dunc Review changes
* Should ACTUALLY fix the maps this time.
* Dunc Final Review
* Debugging part 1
* Fixes brown gas synthesis
* Auto stash before merge of "assmos-pathconflicts" and "origin/master"
* fix compile errors
* Moves defines. Fixes stimulum coefficents.
* Reworks how Stim and brown gas work, adds tritium to tile fires, fixes a lot of general reaction bugs.
* fixes typo
* Hopefully fixes UI
* compiles tgui
* Tritium balance.
* radiation rework and subsystem
* moves a few things to initialize and adds radiation insulation
* adds a radiation contamination mechanic and makes requested changes
I'm terrified by the possibilities from this
* radiated objects give off light
and hopefuly contamination is balanced
* fixes runtimes and an mc crash kek
removed the lighting part of contaminated objects
attempted some more balancing
* Collectors output power in process() gradualy
And some more balancing tweaks
* Excludes a bunch of things from becoming radioactive
* Ready for testmerge balancing
* Inverse square law was swapped
* testmerge balancing
fixes the geiger counter
buffs collector power gen
nerfs sm radiation
slightly buffs rad insulation
nerfs rad damage (and its burn)
raised the minimum radiation
* disabling the radiation subsystem won't build up rad wave datums forever
* rewrites how mobs handle radiation
upgrades geiger counter functionality
and more balance tweaks
* cleans up stuff and removes debug message
* Slight contamination buff
* Major rad wave performance boost
Also improves rad insulation
Buffs contamination, again
* Fixes insulation runtime
More balance and performance tweaks
* fixes rad collectors not receiving power
* The final balance commit
Fixes a major bug causing radiation to underperform
More geiger counter changes that will be changed more to add sounds
* Monkey business
* Geiger counter sounds
* cleanup and move components to their own initialize
* Some code cleanup
And forgotten changes
* Cleans up some trailing returns
* Mapping changes
* Adds a new steal objective, the Supermatter Sliver.
* actually commits theft_tools honke
* i actually dk what this is
* fixes v1
* Supersmatter sliver requested changes
* you know what I fucking hate is unchecking shit
* please does this fix it fucking dme clown shit
* placates the cyberboss and the lziard
* fucking clownery
* I forgot to fucking check it
* Hope this fixes it
* will my children inherit this PR
* reeeeeeeeeeeeeeee
* Let's put this horse to rest now....
