Commit Graph

10 Commits

Author SHA1 Message Date
Tastyfish
b4d7516657 [MANUAL MIRROR] Refactor /ui_state/new_player_state to what it's designed for (#71959) (#18610)
Refactor /ui_state/new_player_state to what it's designed for (#71959)

`/datum/ui_state/new_player_state` now no longer lets users with R_ADMIN
permission see the UI. Changed `/datum/interview` to return always_state
when an admin watches an interview because it is important there.
`/datum/latejoin_menu` now uses new_player_state instead of its own
solution.

`/datum/ui_state/new_player_state` is designed to let lobby players
interact with the UI, so it does not make sense for it to make a weird
exception for admins too. My theory is that this was an oversight when
this was first implemented, since only `/datum/interview` used this
ui_state. It doesn't and it shouldn't be like this though. Code clarity.

No playerfacing changes.

Co-authored-by: distributivgesetz <distributivgesetz93@gmail.com>
2023-01-09 10:12:22 -08:00
Gandalf
b389a03745 Revert "[MIRROR] Refactor /ui_state/new_player_state to what it's designed for [MDB IGNORE]" (#18541)
Revert "[MIRROR] Refactor /ui_state/new_player_state to what it's designed for [MDB IGNORE] (#18175)"

This reverts commit d12ee8c506.
2023-01-06 16:39:44 +00:00
SkyratBot
d12ee8c506 [MIRROR] Refactor /ui_state/new_player_state to what it's designed for [MDB IGNORE] (#18175)
Refactor /ui_state/new_player_state to what it's designed for

Co-authored-by: distributivgesetz <distributivgesetz93@gmail.com>
2023-01-06 15:35:20 +00:00
Zonespace
f7c26bbf25 515 Compat (#17465)
* ONLY SKYRAT CHANGES

* ACTUALLY SKYRAT CHANGES

* yolo, revert later

* Update alternate_byond_versions.txt

Co-authored-by: AnturK <AnturK@users.noreply.github.com>
2022-11-15 06:59:06 +00:00
SkyratBot
a840d4e205 [MIRROR] fixes admin ticket linking bad href [MDB IGNORE] (#13587)
* fixes admin ticket linking bad href

* Update adminhelp.dm

Co-authored-by: magatsuchi <88991542+magatsuchi@users.noreply.github.com>
Co-authored-by: Zonespace <41448081+Zonespace27@users.noreply.github.com>
2022-05-15 19:43:12 -07:00
SkyratBot
7d1d0e1fad [MIRROR] Refactors most spans into span procs (#6315)
* Refactors most spans into span procs

* AA

* a

* AAAAAAAAAAAAAAAAAAAAAA

* Update species.dm

Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-06-16 00:24:49 +01:00
SkyratBot
9f6c63c095 [MIRROR] Requested Interview Features Update (Rave Radbury Edition) (#6289)
* Requested Interview Features Update (Rave Radbury Edition) (#59621)

Added a few things that were requested by RaveRadbury to be added to the interview system:
* Where appropriate clickable links are now added to open a interview in similar fashion to tickets
* Changed fields to be read-only for admins looking at interviews while they're being written
* Added the ability to include markdown-style links to interview welcome messages and interview questions
* Updated the default questions to add a question about if the user has read the rules to demonstrate the ability to include links

* Requested Interview Features Update (Rave Radbury Edition)

Co-authored-by: Bobbahbrown <bobbahbrown@gmail.com>
2021-06-14 18:37:54 +12:00
SkyratBot
b332b46b65 [MIRROR] Remove hideous inline tab indentation, and bans it in contributing guidelines (#3394)
* Remove hideous inline tab indentation, and bans it in contributing guidelines

* a

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
2021-02-15 15:32:02 +00:00
SkyratBot
c487c73f39 [MIRROR] Grep for space indentation (#1969)
* Grep for space indentation

* aa

* Update species.dm

* Update species.dm

* Update maps.dm

* Update examine.dm

Co-authored-by: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Co-authored-by: Azarak <azarak10@gmail.com>
2020-12-01 12:26:41 +01:00
SkyratBot
91773c46da [MIRROR] Interview System / Soft Panic Bunker (#1458)
* Interview System / Soft Panic Bunker

* a

Co-authored-by: Bobbahbrown <bobbahbrown@gmail.com>
Co-authored-by: Azarak <azarak10@gmail.com>
2020-10-26 08:32:37 +01:00