Commit Graph

2 Commits

Author SHA1 Message Date
SkyratBot
aa8d114bff [MIRROR] Wraps all instances of invoking Fail() into the TEST_FAIL Macro [MDB IGNORE] (#19384)
* Wraps all instances of invoking Fail() into the TEST_FAIL Macro (#73407)

We shouldn't really be invoking the proc itself because then we don't
pass along the failing line/file to our consumers, let's use the macro
in all instances that really need it.

I noticed people were invoking the `Fail()` proc directly rather than
using `TEST_FAIL` instead, so they weren't getting those neat
annotations on their failing code because we never passed along the
failing line/file to actually apply those annotations. That's silly. We
don't even return on `TEST_FAIL` either, so there's no reason to not do
this (only upsides wahoo).

* Wraps all instances of invoking Fail() into the TEST_FAIL Macro

* Correct macro in opfor unit test

---------

Co-authored-by: san7890 <the@san7890.com>
Co-authored-by: Tastyfish <crazychris32@gmail.com>
2023-02-16 19:41:29 -05:00
Zonespace
1a84c196bc [MODULAR] OPFOR Expansion - Odds and Ends (#11956)
* standing here on the edge

* the irony of my own unit tests failing on me is not lost

* will this work? god knows

* okay, now that this works

* Update code/modules/unit_tests/_unit_tests.dm

* aye

* weh, fixed

* tired me is not a good coder

* correct this

* max_count + flashbang

* testing a change to the unit test

* weh

* i give up

* Update code/modules/unit_tests/_unit_tests.dm
2022-03-12 18:50:54 +00:00