Commit Graph

3067 Commits

Author SHA1 Message Date
vuonojenmustaturska
40657c9ccd removes a bunch of unused/bad helpers (#48969)
* a commit

* Update code/controllers/subsystem/persistence.dm

Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>

* Update code/__HELPERS/text.dm

Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>

* Update advance.dm

* Update security_officer.dm

* Update text.dm

* Update unsorted.dm

Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com>
2020-01-28 16:22:20 +01:00
AnturK
ac4f25e563 Cross server comms update. (#48850)
* Makes cross server config easier to manage and lets you send messages to specific stations.

* No need for fancy copy
2020-01-18 19:04:23 -05:00
MrPerson
f7eb2c905b Unicode awareness Part 2 -- copytext() (#48512)
* Unicode support Part 2 -- copytext()

This is the transition of all copytext() calls to be unicode aware and also some nearby calls in the same functions. Most things are just replacing copytext() with copytext_char() as a terrible character limiter but a few others were slightly more involved.

I replaced a ton of
````
var/something = sanitize(input())
something = copytext(something, 1, MAX_MESSAGE_LEN)
````

with a single stripped_input() call. stripped_input() already calls html_encode(), trim(), and some other sanitization so there shouldn't be any major issues there.

This is still VERY rough btw; DNA is a mess, the status displays are complete ass, there's a copytext() in code\datums\shuttles.dm that I'm not sure what to do with, and I didn't touch anything in the tools folder. I haven't tested this much at all yet, I only got it to compile earlier this morning. There's also likely to be weird bugs until I get around to fixing length(), findtext(), and the rest of the string procs.

* Makes the code functional

* Assume color hex strings are always # followed by ascii.
Properly encodes and decodes the stuff in mob_helpers.dm which fixes some issues there.

* Removes ninjaspeak since it's unused
2020-01-18 13:07:22 +13:00
Nick
e7a9bf4a6d Yet another db tickets bugfix #48854 2020-01-18 11:18:38 +13:00
Nick
c758bdd51c [Ready] Database Tickets (#48727)
* DB ticket procs

* Schema changes for DB tickets

* Schema version update

* Fixes requested by Jordie

* SQL updates

Adds a recipient column

* Still one dangling issue where this DOESN'T WORK

* Alright, this should work

* Requested SQL fixes

* Rogue changes

* less bad defaults

* utf8 for the utf8 gods

* aaaaaa

* Update tgstation_schema_prefixed.sql

* Update tgstation_schema.sql

* Update database_changelog.txt

Co-authored-by: Jordie <4343468+Jordie0608@users.noreply.github.com>
2020-01-17 05:35:16 +11:00
spookydonut
3195ceaa22 Update SpacemanDMM suite to 1.2 (#48785)
* Update SpacemanDMM suite to 1.2

* Fix new lint errors
2020-01-16 11:49:39 -05:00
nemvar
828ebb20cf Allows calling procs in SDQL update queries without storing the return anywhere. (#48690)
* Adds everything that's needed for SDQL varedit macros

* Removes unused proc

* Allows calling procs in update queries without setting the return anywhere.

* Readds a line

* Removes file wrapper
2020-01-13 19:52:20 -05:00
Kyle Spier-Swenson
ecd2622a75 Don't recheck connected clients in isbanned() (and other isbanned() dos mitigations) (#48583)
dos mitigation that likely won't fully work but let's see anyways.

backstory:

byond's ban system will automatically ban world/Topic flooders. Sadly updating byond's internal ban list causes isbanned() to get called on all connected clients. Also sadly: it does this every time it sees the world/Topic flood on the same ip, causing every connected client gets checked repeatedly for every flood message world/Topic sees.
2020-01-14 11:23:32 +13:00
Fikou
8eee742734 [Ready] Adds ERP (#48699)
Adds a new emergency response team, the ERP! It stands for Emergency Response Party

the ERP includes:
-the coordinator: basically the captain of the operation, armed with a birthday cake, balloon and lots of fireworks to start the celebration
-the bouncer: the big boy, has a telebaton and an armor vest (if youre a loser you get a police hat too)
-the constructor: has tools, materials to build the party, disco tiles and an ethereal disco ball planter
-the cleaning service: your normal jannie, with his trusty mop, trash bag and cleaning grenades
-the comedian: a clown, armed with instruments, a bananium shield and chameleon suit/hat, for some comedy at the party
2020-01-12 13:31:13 +13:00
skoglol
03b4540cbc Merge pull request #48708 from ExcessiveUseOfCobblestone/im-not-new-ok
Waypoint Finders now properly pull living playtime
2020-01-11 05:41:03 +01:00
ExcessiveUseOfCobblestone
fe40dfea6e b 2020-01-09 22:29:50 -05:00
AnturK
6a62a139a8 Basic auto profiler (#48672)
* Basic auto profiler

* Makes it update periodically in case of crash.

* informative comment.

* Early start & config upgrades.

* Fixup
2020-01-09 19:32:57 -05:00
skoglol
135251ece3 Fixes admin disease naming, basic disease trigger (#48628) 2020-01-07 09:54:55 -05:00
skoglol
8206b1e1cb Map rotation touchup, automatic map votes (#48602)
* Map rotation touchup, automatic map votes

* votes already running

* Pre-init vote restrictions

* No rotation for rounds less than 10 minutes.

* Splits voting preferred map check

* Fixed comment
2020-01-07 09:46:49 -05:00
MrPerson
d5b98c4d8d Unicode support Part 1 (#48304)
* Unicode support Part 1

Makes all calls to ascii2text() and text2ascii() unicode aware as well as all calls in code/__HELPERS/text.dm.

Adds defines for the footext_char() procs to maintain 512 support.

I did some cleanup on the text helpers since a lot of them were really, really bad.

reject_bad_text() and reject_bad_name() have an arg to reject non-ascii chars which defaults to TRUE.

* Give travis a more recent beta

* Ultimate compat
Added the _char procs I was missing
Test the build instead of the version because Lummox is a goddamn moron

* Suggested fixes, removes the last of the dd_ helpers

* Reading the reference is very important!

* Minor code improvements and a comment

* Typo
2020-01-07 09:25:47 +01:00
oranges
15c59a51cd Revert "Only allow one call to IsBanned to process at a time (#48529)"
This reverts commit b4e84ddadf.
2020-01-04 15:43:09 +13:00
oranges
b4e84ddadf Only allow one call to IsBanned to process at a time (#48529)
Potential improvements, store the list on a subsystem, also include
ip/ckey

Clear on a timed basis instead of after finishing
2020-01-03 21:15:49 +01:00
skoglol
5de437ff1c Adds specified give control option to mob VV (#48290)
* Adds specified give control option to VV

* click ckey to run

* Safer, less nullspacey.

* logging fixed

* review
2019-12-30 08:53:30 +01:00
skoglol
2bbebc084e Adds non-localhost reboot world confirmation (#48291) 2019-12-29 17:31:17 +01:00
skoglol
b4843bd7a9 Adds new direct mob sound admin verb (#48171)
Adds the "Play Direct Mob Sound" for (b)admins to enjoy. Pick a sound and a mob, and only the chosen mob will hear it. Button also available in the player panel.

Happy admins happy life
2019-12-27 10:34:54 +13:00
skoglol
1f3791a0c4 Fixes stealth mode ghost name reset. (#48343) 2019-12-22 19:39:55 -05:00
JJRcop
af4cb5ddc3 SDQL2 dynamically gets subsystems (#48335)
As opposed to a static switch statement
This means all present and future subsystems are supported
without needing to add them to the switch
2019-12-22 15:33:39 -05:00
spookydonut
175439f63a Removes unreachable code (#48143)
About The Pull Request

As detected by SpaceManiac/SpacemanDMM#123
2019-12-10 20:52:13 +13:00
spookydonut
6b5433eb23 Fixes new linter errors (#48126)
About The Pull Request

This fixes the errors raised by the new feature I'm adding to the linter: SpaceManiac/SpacemanDMM#119
2019-12-09 20:53:24 +13:00
Ryll Ryll
75af862fee Buffs immersion, adds manual blinking and inhale/exhale checks (#47704)
* *blink *inhale *exhale *blink *inhale *blink *exhale

* rapidly blinks

* mass immersion

* how was that even working

* manual blinking today, manual breathing tomorrow

* b

* cleansed

* more neatening

* minus check

* Update code/modules/admin/verbs/randomverbs.dm

Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>

* un-nom's my code

Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>

* un-nom's my code

* less
2019-12-04 16:02:42 +00:00
skoglol
3e7139e12c The Start Now verb now has undo options (#47998)
* The Start Now verb now has a confirmation and undo options.

* Update code/modules/admin/admin.dm

Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>
2019-12-03 19:52:12 +00:00
Bobbahbrown
0d7ef73b17 Refactors References to IRC to be TGS (#47954)
* TGS updates round 1

* TGS updates round 2
2019-11-30 03:59:42 -08:00
actioninja
c8ec5bdd36 Revert "[SPEED MERGE NEEDED] removes cat (#47999)"
This reverts commit 345d2bf607.
2019-11-26 04:35:58 -08:00
pireamaineach
345d2bf607 [SPEED MERGE NEEDED] removes cat (#47999) 2019-11-26 04:35:25 -08:00
AnturK
a31c460dc0 Moves achievements from Hub to DB. (#47617)
Drops byond hub support and adds score and top 50 browsers.

Requires DB changes and manual creation of migration script if we want to keep old achievements so no random merges please.
2019-11-26 20:35:28 +13:00
SteelSlayer
304a196b7f Adds a new server restart option: regular restart with a custom delay time (#47870)
* Adds a new server restart option: soft restart with a custom delay time

* cancel returns
2019-11-20 03:11:21 -08:00
skoglol
ad0d270d58 Cleans up observer mind on control transfer, ghosting, DNR, suicide (#47826)
* Fixes admin ghost drag

* Covers more cases

* And assume control
2019-11-18 17:59:47 +00:00
Emmett Gaines
5481515dff Removes the non bitflag slot defines (#47742)
Removes the non bitflag slot defines
2019-11-17 17:52:11 -08:00
TheChosenEvilOne
a414d76718 Custom (station) map loading for admin use. (#47778)
* Custom Map Loading

Signed-off-by: TheChosenEvilOne <tceo-email@protonmail.com>

* hh

Signed-off-by: TheChosenEvilOne <tceo-email@protonmail.com>

* Use load_map_config instead of just setting next_map_config

Signed-off-by: TheChosenEvilOne <tceo-email@protonmail.com>

* Some small changes.

Signed-off-by: TheChosenEvilOne <tceo-email@protonmail.com>

* Checks if map is correct and don't return on empty shuttle.

Signed-off-by: TheChosenEvilOne <tceo-email@protonmail.com>

* Thank you VSCode, very cool

Signed-off-by: TheChosenEvilOne <tceo-email@protonmail.com>

* Added a map bounds check.

Signed-off-by: TheChosenEvilOne <tceo-email@protonmail.com>

* Moved the config reset and file removal to the end of loadWorld()

Signed-off-by: TheChosenEvilOne <tceo-email@protonmail.com>

* Actually set the next map to default.

Signed-off-by: TheChosenEvilOne <tceo-email@protonmail.com>
2019-11-16 19:56:01 +01:00
spookydonut
dd6fa5eded More spawn/sleep removals (#47634)
* remove more spawns

* more

* more

* varsets

* oops

* unfuck this
2019-11-13 03:07:59 -08:00
Shaps
e42c0591b8 Clean up admin moreinfo (#47681)
Agendered spessmen are no longer highlighted on the (?|F) more info 
thing. Also deletes a useless list in preferences file I forgot to 
remove a while ago.
2019-11-09 09:30:31 -08:00
Couls
971ef6a416 Custom movement hotkeys and restore macros for T, O and M (#47626)
* Custom movement hotkeys and restore macros for T, O and M

* stray comma

* update movement keys on SSinput initialize

* use cardinals
2019-11-07 18:07:17 -05:00
AnturK
c20b4d5ab2 Replaces lentext with length (#47585) 2019-11-07 11:42:33 -05:00
skoglol
ef2d2796bb Fixes disease outbreak secret (#47541)
* Fixed admin create virus, added target.

* Fixes random and simple disease outbreak.

* requested changes
2019-11-06 20:42:05 +01:00
spookydonut
2591ce17a6 Travis EOF newline detection v3 (#47539)
* scream

* aaa

* aaa

* new one
2019-11-04 19:16:50 -08:00
carlarctg
edd2bddd10 Different species now get different kinds of cookies. (#47243)
* cookies? helllo?

* helpies

* thank you, very cool!

else ifs and .names
2019-10-28 17:12:03 -04:00
Shaps
dafbb99f46 nice (#47404)
Simple transforms don't ask to delete old mob for observers
2019-10-27 09:03:52 -07:00
oranges
0c369dc547 Merge pull request #47407 from optimumtact/internswarm
ERT spawn no longer limited by spawnpoint available
2019-10-27 20:42:37 +13:00
Qustinnus
8a01398814 Adds achievement datums (#47058)
* First step

* achievements part 1

* epic

* done

* epic

* removes test datums

* adds minecraft achievement

* asss

* ass 2

* ass

* fix

* UPGRADE

* back-end partially

* back-end

* woops

* epic

* linted

* Achievements (#19)

* initialize SSachievements lists

* achievement ui actually tries to load

* witty commit description

* menu

* done

* done

* jesus christ

* ok linter

* Update code/datums/achievements/_achievement_data.dm

Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>

* Update _achievement_data.dm

* Update misc_achievements.dm

* Update achievements.dm

* Update

* And a space, goddamit!

* Rebuild tgui

* woops

* bruh moemnet

* ok conflicts

* finally
2019-10-26 05:57:42 -07:00
skoglol
ffc50cd259 Adds game mode panel to check antagonists window. (#47313)
About The Pull Request

Title. Also increased size of the game panel window slightly to avoid scrolling.
Why It's Good For The Game
Changelog

cl Skoglol
admin: Dynamic game mode panel can now be accessed from the Check Antagonists window.
/cl
2019-10-26 21:02:05 +13:00
oranges
85f2ff116d ERT spawn no longer limited by spawnpoint available 2019-10-26 07:26:41 +00:00
AnturK
e83da09890 Allows specifying amount in spawn verb (#47343)
* Allows specifying amount in spawn verb

* Same cap as create panel.
2019-10-25 02:37:41 -07:00
skoglol
2dd01611fc Some input() sorting fixes (#47354)
* dynamic gamemodes

* Some input fixes
2019-10-25 03:15:26 -04:00
81Denton
6b1161ecd9 Cleans up revive related procs (#47025)
* Cleans up revive related procs

* h

* fuck

* Fixes proc arguments

* Further fixes

* Unfucks line endings
2019-10-22 15:16:13 -07:00
skoglol
938e66f62c Adds sorting to most input() lists (#47117)
* Adds sorting to most input() lists.

* Sorted some global lists, added more input sorting

* Should now use correct sort everywhere.

* compiles

* Last fixes.
2019-10-22 04:28:42 -07:00