Commit Graph

535 Commits

Author SHA1 Message Date
SkyratBot
4b6c93f6b9 [MIRROR] Easy's Super Omega "unarmed strike based species var moved to limbs" refractor, unarmed strike striking with specific body parts rather than it just being flavor, and brain based attacking limb selection extra chunky edition. And also bodypart traits. [MDB IGNORE] (#17306)
* Easy's Super Omega  "unarmed strike based species var moved to limbs" refractor, unarmed strike striking with specific body parts rather than it just being flavor, and brain based attacking limb selection extra chunky edition. And also bodypart traits.

* Removed all the conflicts, and started converting all the arms and legs to the proper typepaths

* Actually makes the game compile :)

* Makes the maps compile too!

* Early mirror of #71143 because it's more relevant to us

Co-authored-by: itseasytosee <55666666+itseasytosee@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2022-11-11 11:44:49 -05:00
SkyratBot
2582117684 [MIRROR] NtOS Emojipedia - PDA Emoji Messaging For All [MDB IGNORE] (#17402)
* NtOS Emojipedia - PDA Emoji Messaging For All (#70829)

An Emojipedia app has been added to tablets, given to Mimes and Curators by default, allowing anyone to know all emojis. Additionally, emojis can be used in tablets by every job now.

* NtOS Emojipedia - PDA Emoji Messaging For All

* update emoji list to be valid

* animated emojis

Co-authored-by: san7890 <the@san7890.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
2022-11-06 21:53:25 -05:00
SkyratBot
1aefd210c5 [MIRROR] Fixes the messenger app not being responsive when certain buttons are clicked [MDB IGNORE] (#17393)
* Fixes the messenger app not being responsive when certain buttons are clicked (#71077)

## About The Pull Request
The buttons to toggle the ringer, to toggle the sending/receiving and
the button to see message history all stopped being responsive, because
the information they were changing when pressed was wrongly kept in
`ui_static_data()` rather than `ui_data()`. Now, they're back in
`ui_data()`, and behave as expected once again.

## Why It's Good For The Game
A non-responsive TGUI interface is probably the saddest thing to see.

## Changelog

🆑 GoldenAlpharex
fix: SpaceMessenger was now updated to 6.4.8, bringing you more
responsiveness than ever (so long as ever is shorter than seven days
ago)!
/🆑

* Fixes the messenger app not being responsive when certain buttons are clicked

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2022-11-06 16:40:26 -05:00
SkyratBot
f09268926c [MIRROR] Fixes detomatix's name [MDB IGNORE] (#17391)
* Fixes detomatix's name (#71075)

## About The Pull Request

I accidentally replaced it with 'attacking_item' because i am demented
and can't stop abusing my clipboard.

## Why It's Good For The Game

🛩️

## Changelog

🆑
fix: Detomatix cartridges are no longer called attacking items.
/🆑

* Fixes detomatix's name

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2022-11-06 16:26:08 -05:00
Zergspower
640dfccb20 Fixes missing Crew manifests on various tablets for roles, mostly service (#17338)
* Adds missing Crew manifests on various tablets for roles

* Modular for reals

* There go them duke bois
2022-11-04 12:08:06 -07:00
Tastyfish
4f5a8906c6 [MISSED MIRROR] Macro Defines the On-Station Year (#17236)
Missed mirror 70827
2022-10-29 20:46:09 -07:00
SkyratBot
36457f1a45 [MIRROR] Fixes & Improves ntnrc client & ntnet conversations [MDB IGNORE] (#17224)
* Fixes & Improves ntnrc client & ntnet conversations (#70854)

Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>

* Fixes & Improves ntnrc client & ntnet conversations

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
2022-10-29 07:16:29 -07:00
SkyratBot
7cab658b9b [MIRROR] Adds Station's Date To NTos Window (check the time+date on your tablet!) [MDB IGNORE] (#17191)
* Adds Station's Date To NTos Window (check the time+date on your tablet!) (#70754)

* The date and time is now displayed in NtOS tablets, showing the in-game date (540 years after current), bringing the feature from old PDAs over.

* Adds Station's Date To NTos Window (check the time+date on your tablet!)

Co-authored-by: san7890 <the@san7890.com>
2022-10-26 22:06:48 -04:00
SkyratBot
6a2a51a1d3 [MIRROR] sets pdas to use the pda worn icon again [MDB IGNORE] (#17181)
* sets pdas to use the pda worn icon again

* screeeeeenshooootss

Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
2022-10-26 17:36:27 -04:00
SkyratBot
097e913e4b [MIRROR] Removes tablet hard drives entirely (HDD & SSD) [MDB IGNORE] (#17164)
* Removes tablet hard drives entirely (HDD & SSD)

* map updates

* changes

* contractor uplink theme

* uplink improvements

* tab

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
2022-10-26 14:09:16 -04:00
SkyratBot
0c3965421e [MIRROR] Add AltClick removes pAIs for tablets [MDB IGNORE] (#17158)
* Add AltClick removes pAIs for tablets (#68251)

* Add AltClick removes pAIs

* Add context screentips for pAIs to tablets

* Fix screentip context syntax error

* Fix syntax error

* Merge remote-tracking branch 'upstream/master' into patch-10

* Refactor contextual screentips to work

* Fix runtimes

* Apply code review changes

Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>

* Add balloon alert to tablet items

* Refactor screentips to be more robust

* Change add_context to be more robust

* Add more balloon alerts

* Some idiot set user to null so I gotta remove this

* Change pen screentip to display inserted item

* Add screentip to insert items

Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>

* Add AltClick removes pAIs for tablets

Co-authored-by: Tim <timothymtorres@gmail.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
2022-10-25 14:13:07 -07:00
SkyratBot
9854cd8eeb [MIRROR] Fixes some inconsistencies with computers [MDB IGNORE] (#17084)
* Fixes some inconsistencies with computers (#70679)

* Modular computers now have their initial name if they don't have an idenfitication and job, which previously meant they would have the name ()
* Removes MACHINE modular computer's process, because all it did was update the name, then call computer's process. Now it just does what every computer does, BUT UpdateDisplay on ITEM modular computers will now update the machine's name.
* Additionally, I moved the modular computer processor's New to an Initialize, and removed the shutdown_computer code, because we already register update_icon signal to update the computer's appearance, why do we need to do it twice?

* Fixes some inconsistencies with computers

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2022-10-22 01:51:01 +01:00
SkyratBot
acfedf84fd [MIRROR] Screwdriver Pen [MDB IGNORE] (#17063)
* Screwdriver Pen (#70467)

* base

* bam

* icon and element fix

* terminate

* Update code/modules/paperwork/pen.dm

* Update code/modules/paperwork/pen.dm

* sigh

* Update code/_globalvars/lists/maintenance_loot.dm

Co-authored-by: MrMelbert <51863163+MrMelbert@ users.noreply.github.com>

* Update code/modules/paperwork/pen.dm

Co-authored-by: ShizCalev <ShizCalev@ users.noreply.github.com>

* Update code/modules/paperwork/pen.dm

Co-authored-by: Fikou <23585223+Fikou@ users.noreply.github.com>

* factoring

* escapism

* balloon notif

* bottom vars

* Update code/modules/paperwork/pen.dm

* Update code/modules/paperwork/pen.dm

* Apply suggestions from code review

* updates the sprite to be based on new pen icon

* pushes the comsig call to an attack_self

* Update code/modules/paperwork/pen.dm

* Update code/modules/paperwork/pen.dm

* imagos icon

Co-authored-by: etherware-novice <candy@ notarealaddr.com>
Co-authored-by: ShizCalev <ShizCalev@ users.noreply.github.com>
Co-authored-by: MrMelbert <51863163+MrMelbert@ users.noreply.github.com>
Co-authored-by: Fikou <23585223+Fikou@ users.noreply.github.com>
Co-authored-by: Candycaneannihalator <candycane@ thisisnotarealaddr.com>

* Screwdriver Pen

Co-authored-by: texan-down-under <73374039+etherware-novice@users.noreply.github.com>
Co-authored-by: etherware-novice <candy@ notarealaddr.com>
Co-authored-by: ShizCalev <ShizCalev@ users.noreply.github.com>
Co-authored-by: MrMelbert <51863163+MrMelbert@ users.noreply.github.com>
Co-authored-by: Fikou <23585223+Fikou@ users.noreply.github.com>
Co-authored-by: Candycaneannihalator <candycane@ thisisnotarealaddr.com>
2022-10-21 10:44:27 +01:00
SkyratBot
c023767b25 [MIRROR] Misc PDA code improvements [MDB IGNORE] (#17026)
* Misc PDA code improvements (#70555)

* How to conflict with PRs: A guide

* Removes unnecessary support for the now-removed job disks from Tablet's TGUI menu, and tablet's ui_act.
* Adds autodoc comments to computer files
* Removes the unused 'unsendable' var on computer files
* Generally improves code on tablets, now process isn't looping through every idle thread twice!
* Moves the check for program in idle_threads above checking if supported by hardware, because it's already running, so there's no need to check.

* eh

* revert a scipaper change

* Misc PDA code improvements

* updated contract_uplink

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Tastyfish <crazychris32@gmail.com>
2022-10-20 15:22:45 -04:00
SkyratBot
58752b0969 [MIRROR] Removes a ton of unused tablet vars, re-organizes the rest [MDB IGNORE] (#17014)
* Removes a ton of unused tablet vars, re-organizes the rest (#70344)

* Removes a ton of unused vars, re-organizes the rest

Removes a ton of unused vars from Modular computers
Re-organizes the rest, and adds autodoc comments to most of them
Moved 2 vars (saved_image and invisible) from the tablet to the messenger app, since that's where it was used. I didn't see the point of having these vars be on every computer anyways, only PDAs have the app.
Renames Clown's honk virus var
Makes Messenger app's saved image, actually used.

* static list and NODECONSTRUCT_1 check

* oops

* Removes a ton of unused tablet vars, re-organizes the rest

* cryopod

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
2022-10-20 02:28:27 -04:00
SkyratBot
612568daa0 [MIRROR] Swaps sleep() to use SECONDS define [MDB IGNORE] (#16973)
* Swaps sleep() to use SECONDS define

* merge conflicts and skyrat modules

Co-authored-by: san7890 <the@san7890.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
2022-10-19 19:43:24 -04:00
SkyratBot
bcfa54ed75 [MIRROR] Curator and Mime PDAs now start with their ringer off [MDB IGNORE] (#16985)
* Curator and Mime PDAs now start with their ringer off (#70604)

* Curator and Mime PDAs now start with their ringer off

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2022-10-19 10:56:40 +01:00
SkyratBot
d89adf597a [MIRROR] Modular computer fixes [MDB IGNORE] (#16966)
* Modular computer fixes (#70606)

* Moves a lot of modular computer attackbys to the cpu instead, which is what handles it all. This allows their parts to be removed and the console deconstructed/repaired once again.

* Modular computer fixes

Co-authored-by: GoblinBackwards <22856555+GoblinBackwards@users.noreply.github.com>
2022-10-19 00:31:36 +00:00
SkyratBot
9842bcbaee [MIRROR] PDA Ringtone Preference [MDB IGNORE] (#16907)
* PDA Ringtone Preference

* Updates our own text preferences to match the stuff I did upstream for this

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2022-10-16 19:11:58 -04:00
SkyratBot
15d5272ee0 [MIRROR] Fixes communication being nearly impossible (except over radio) when there's a null client in the global player list [MDB IGNORE] (#16851)
* Fixes communication being nearly impossible (except over radio) when there's a null client in the global player list (#70404)

* Fixes communication being nearly impossible (except over radio) when there's a null client in the global player list

* Updates our modular play_vox_word() proc

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2022-10-14 15:42:46 -04:00
SkyratBot
85217504dd [MIRROR] [NO GBP] Fix traitor PDA uplinks to be accessible by illiterate people [MDB IGNORE] (#16853)
* [NO GBP] Fix traitor PDA uplinks to be accessible by illiterate people (#70368)

* Illiterate people can now use a PDA in hand to open their uplink immediately if they are the owner of the uplink.

* [NO GBP] Fix traitor PDA uplinks to be accessible by illiterate people

Co-authored-by: Tim <timothymtorres@gmail.com>
2022-10-14 14:32:01 -04:00
SkyratBot
6f985f51bd [MIRROR] Fixes the formatting in the Messenger app's message history and makes the current ringtone appear in the input box when trying to change it [MDB IGNORE] (#16831)
* Fixes the formatting in the Messenger app's message history and makes the current ringtone appear in the input box when trying to change it (#70458)

* Changing your PDA ringtone now has your current ringtone in your input box, like the previous PDAs used to.
* The incoming Messenger messages are now HTML encoded in message history, allowing it to display apostrophes and such.
* The prompt to send a PDA message now shows you the person you're trying to send a PDA message to.

* Fixes the formatting in the Messenger app's message history and makes the current ringtone appear in the input box when trying to change it

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2022-10-13 00:11:41 -04:00
SkyratBot
bb0d9e71a4 [MIRROR] The curator's PDA now works in space [MDB IGNORE] (#16782)
* The curator's PDA now works in space (#70319)

* The curator's PDA is now long-ranged

The Curator's PDA is now long ranged and allows for it to be used while out in space.
I recently removed the modular computer parts that allowed PDAs to be upgraded to connect to NTNet while on different Z-levels, so thought this would be a good replacement since Curators are a space exploration job, so being able to still talk to other players or use the newscaster app while away, is something I think would be beneficial.

* The curator's PDA now works in space

* Gives vanguard PDA long range as well

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Tastyfish <crazychris32@gmail.com>
2022-10-11 23:55:44 -04:00
SkyratBot
73ae6472a7 [MIRROR] NT Pay app. Money send on distance, transaction log! [MDB IGNORE] (#16672)
* NT Pay app. Money send on distance, transaction log! (#70108)

* base

* reasons

* GetToken proc, with a many remarks

* Add a way to change reason in transfer_money proc. Add a reasons.

* Reason to use the app. Commission. Standard application.

* Apply suggestions from code review - Tralezab

Co-authored-by: tralezab <40974010+tralezab@ users.noreply.github.com>

* Tralezab & jlsnow301 advices. New format(everywhere)

* Nanotrasen

* Refactor TGUI(not me:( ). Fix useless capitalize

* Update code/modules/economy/account.dm

* Trans transforms in transaction

* coMmission. little autodoc mistalke. Translation != Transaction

* oops

* Merge Conflict

* ...

* back feats

* mistakes bye!

* ну да

Co-authored-by: tralezab <40974010+tralezab@ users.noreply.github.com>

* NT Pay app. Money send on distance, transaction log!

Co-authored-by: Yaroslav Nurkov <78199449+AnywayFarus@users.noreply.github.com>
Co-authored-by: tralezab <40974010+tralezab@ users.noreply.github.com>
2022-10-05 19:38:36 -04:00
SkyratBot
d3776105e5 [MIRROR] Fixes the DOS tool [MDB IGNORE] (#16673)
* Fixes the DOS tool (#70312)

* Fixes the tablet's emagged 'DOS' app, which wasn't checking ID properly.

* Fixes the DOS tool

Co-authored-by: Zonespace <41448081+Zonespace27@users.noreply.github.com>
2022-10-05 22:50:10 +00:00
SkyratBot
78f77e6463 [MIRROR] Assistant PDAs start with the bounty board app preinstalled [MDB IGNORE] (#16657)
* Assistant PDAs start with the bounty board app preinstalled

* Update code/modules/jobs/job_types/assistant.dm

Co-authored-by: Mickyan <38563876+Mickyan@users.noreply.github.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
2022-10-05 08:15:02 -07:00
SkyratBot
7144fe758c [MIRROR] Changed Supermatter Internal Math + UI Additions [MDB IGNORE] (#16603)
* Changed Supermatter Internal Math + UI Additions

* merge conflicts

Co-authored-by: vincentiusvin <54709710+vincentiusvin@users.noreply.github.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
2022-10-03 07:21:09 +01:00
SkyratBot
9bf006d189 [MIRROR] Multiz Rework: Human Suffering Edition (Contains PLANE CUBE) [MDB IGNORE] (#16472)
* Multiz Rework: Human Suffering Edition (Contains PLANE CUBE)

* skyrat changes

* bodyparts merge

* unres door floorlight fix

* Future upstream fix for blindness

* upcoming upstream airlock fix

* fix button emissive

* Fix FOV markings?

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
2022-10-02 23:30:09 -04:00
SkyratBot
1ce77983df [MIRROR] canUseTopic now uses TRUE/FALSE instead of defines that just say TRUE [MDB IGNORE] (#16586)
* canUseTopic now uses TRUE/FALSE instead of defines that just say TRUE

* etes

* eyes

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-10-02 15:54:46 +01:00
SkyratBot
32db6d2411 [MIRROR] Properly checks flags with & instead of == [MDB IGNORE] (#16487)
* Properly checks flags with & instead of ==

* merge fixed for changeling

* skyrat equipment updated

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Tastyfish <crazychris32@gmail.com>
2022-09-28 16:38:59 -04:00
SkyratBot
f0b2b19f2c [MIRROR] Increases the capacity of command disks [MDB IGNORE] (#16507)
* Increases the capacity of command disks (#70105)

* Increases the capacity of command disks

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2022-09-28 11:09:14 +01:00
SkyratBot
0339798a42 [MIRROR] Removes network cards and printers from tablets [MDB IGNORE] (#16451)
* Removes network cards and printers from tablets

* merge tablet_presets

* printer.dm should have been deleted, missed change

* update contractor tablet

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
2022-09-27 23:16:32 -04:00
SkyratBot
d0b706c041 [MIRROR] Removes AI and Charge parts from tablets, adds support for more later. [MDB IGNORE] (#16381)
* Removes AI and Charge parts from tablets, adds support for more later.

* merge conflict

* remove modular tablet loadout item

* fix SR maps referencing tablets, add clear PDA instead of modular tablet loadout

* remove pda loadout item

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
2022-09-27 17:52:24 -04:00
SkyratBot
d9a4aaf2cc [MIRROR] Demoralization fixes [MDB IGNORE] (#16402)
* Demoralization fixes (#69924)

* Demoralization fixes

Blind mobs will no longer be demoralized by posters and graffiti.
Illiterate mobs will no longer be demoralized by the words on posters.
Mobs will no longer be demoralized by posters & graffiti if it's too dark to see them.

Also makes can_read use reading check flags, one for literacy and one for light.

* Demoralization fixes

Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
2022-09-24 12:12:04 -07:00
SkyratBot
3ac03df1ae [MIRROR] adds inhand icons for tablets & pdas [MDB IGNORE] (#16365)
* adds inhand icons for tablets & pdas (#70038)

* adds inhand icons for tablets & pdas

Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
2022-09-23 02:33:52 +01:00
SkyratBot
049b19bb18 [MIRROR] Moves "catch this var/flag" code from obj/init and datum/new into the types that use it [MDB IGNORE] (#16091)
* Moves "catch this var/flag" code from obj/init and datum/new into the types that use it

* Update atoms_movable.dm

* Update airlock.dm

* SRCC

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: Zonespace <41448081+Zonespace27@users.noreply.github.com>
Co-authored-by: John Doe <gamingskeleton3@gmail.com>
2022-09-11 22:21:16 -07:00
SkyratBot
094f0cd46b [MIRROR] Fixes Signal Commander program breaking all signalers on default frequency [MDB IGNORE] (#16172)
* Fixes Signal Commander program breaking all signalers on default frequency (#69773)

* Fixes signalcommander program breaking all signalers on default frequency

* Fixes Signal Commander program breaking all signalers on default frequency

Co-authored-by: VexingRaven <msgerbs@users.noreply.github.com>
2022-09-11 20:00:17 -07:00
SkyratBot
7559990f20 [MIRROR] [MDB IGNORE] Shuttle engine code improvement and fixes [MDB IGNORE] (#16116)
* [MDB IGNORE] Shuttle engine code improvement and fixes

* what even happened in shuttlepanel.dm

* should be the last few

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Paxilmaniac <paxilmaniac@gmail.com>
2022-09-10 18:28:57 -04:00
SkyratBot
96761dae1a [MIRROR] [MDB IGNORE] APC controller and Power Monitor/AmpCheck fixes, aka How do I write PR titles [MDB IGNORE] (#15987)
* [MDB IGNORE] APC controller and Power Monitor/AmpCheck fixes, aka How do I write PR titles (#69146)

About The Pull Request

bgug fix stuff
APC controller UI has its elements section'ed off. The backend has been redone to make the behaviour of the APC controller a bit less janky. The console should be more stable, and all the soul has been removed from the code and the UI.

before this PR stales out from nobody wanting to review my pr, I should probably outline what exactly changed:

    APC controller consoles have had their APC code almost entirely reworked. They no longer have to hold a reference to the person using the controller currently, and APCs themselves no longer hold a reference to the controller, instead to the person directly. A lot of code was moved to APC themselves to make it a lot more stable.
    APC controller used to call toggle_breaker without passing args, causing a runtime. Fixed in

    Fixes the power flow control console not actually being able to toggle breakers #69343
    APC controller UI has had the Window.Content tags moved up to the top component, and a lot has been sectioned off to make the UI more sane.
    AmpCheck used to look for a wire on it's turf, or as a fallback look for the Area APC. A check to see if the APC has a terminal did so on a weakref, causing a runtime and preventing the program from ever finding a valid APC in it's area, making it show nothing. This has been fixed. On the other hand, the power monitor console did not store the ground wire or APC terminal as a weakref, this has been updated. As a fallback, if there are still no APCs in the powernet, the UI will show a dimmer popup.
    There was a "secret" power monitor variation in code so PDAs could not access monitors in hidden places. With the removal of PDAs, this control console is useless.

Why It's Good For The Game

Tiny bit of (much needed) polish on some useful tools in the engineering department.
Changelog

cl
fix: Fixed runtime when using AmpCheck without connecting the console with a wire.
fix: Fixed a few runtimes that could occur when using APC controller consoles.
qol: Sucked soul out of APC controller code and UI.
del: Removed "secret" power monitor console.
/cl

* [MDB IGNORE] APC controller and Power Monitor/AmpCheck fixes, aka How do I write PR titles

* update paths

Co-authored-by: distributivgesetz <distributivgesetz93@gmail.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
2022-09-05 17:59:42 -04:00
SkyratBot
1e416342ea [MIRROR] [IDB IGNORE] Renames the inhand/misc folder to inhand/items [MDB IGNORE] (#15956)
* [IDB IGNORE] Renames the inhand/misc folder to inhand/items (#69573)

Also adds balloons to inhand/items

* [IDB IGNORE] Renames the inhand/misc folder to inhand/items

* update modular

Co-authored-by: tattle <66640614+dragomagol@users.noreply.github.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
2022-09-04 15:29:47 +01:00
SkyratBot
bbd1afb772 [MIRROR] Add check for ordering permissions before using department account as payee for NIRN, also fixes #68765 [MDB IGNORE] (#15984)
* Add check for ordering permissions before using department account as payee for NIRN, also fixes #68765 (#69290)

About The Pull Request

See title
Why It's Good For The Game

Fixes #68765, also currently, while NIRN is meant to parallel the features of the cargo console for non-heads of staff, requests are also paid by the department account instead of the general cargo budget for non-heads of staff
Changelog

cl
fix: Putting a budget card into NIRN now gives the proper error message if you are trying to buy something privately, and treat you as a normal cargo request order by someone without any permissions otherwise
fix: NIRN orders should now charge the department that bought it only if a head of staff ordered it
/cl

* Add check for ordering permissions before using department account as payee for NIRN, also fixes #68765

Co-authored-by: RandomGamer123 <31096837+RandomGamer123@users.noreply.github.com>
2022-09-04 14:15:04 +01:00
SkyratBot
c05d5838ef [MIRROR] Adds more multiz support [MDB IGNORE] (#15957)
* Adds more multiz support (#69420)

* Adds more multiz support by making use of ``is_valid_z_level`` instead of simply checking if z is the same.

* Adds more multiz support

Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
2022-09-04 03:48:50 +01:00
SkyratBot
bbd2f69455 [MIRROR] Paper bins now create paper dynamically, rather than creating thousands of pieces of paper on init every round [MDB IGNORE] (#16038)
* Paper bins now create paper dynamically, rather than creating thousands of pieces of paper on init every round (#69586)

* Paper bins now create paper dynamically, rather than creating thousands of pieces of paper on init every round

* Fix hard del, fix static initialization

* Fix fire_act not using paper_stack

* Paper bins now create paper dynamically, rather than creating thousands of pieces of paper on init every round

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2022-09-04 03:34:48 +01:00
SkyratBot
dca8a70947 [MIRROR] Standardize and improve status display UI's [MDB IGNORE] (#15925)
* Standardize and improve status display UI's (#68976)

* Standardized and improves status display app, making it share the same UI as the Communication Console's version of it, and moves shared status display screens into global lists instead of vars.

Co-authored-by: John Willard <53777086+JohnFulpWillard@ users.noreply.github.com>

* Standardize and improve status display UI's

Co-authored-by: Tastyfish <crazychris32@gmail.com>
Co-authored-by: John Willard <53777086+JohnFulpWillard@ users.noreply.github.com>
2022-08-31 09:35:08 -07:00
SkyratBot
ee9a337efd [MIRROR] once again improves pda message immersion [MDB IGNORE] (#15942)
* once again improves pda message immersion (#69534)

About The Pull Request

Reimplements #37735 (add 1% chance to have "Sent from my PDA" appended to a message) as it was lost during the transition to tablets.

Why It's Good For The Game

Feature parity with previous system.

* once again improves pda message immersion

Co-authored-by: Coldud <coldud13@users.noreply.github.com>
2022-08-31 09:33:39 -07:00
SkyratBot
a8c10d1659 [MIRROR] Converts a shitload of istypes to their more concise macros [MDB IGNORE] (#15702)
Converts a shitload of istypes to their more concise macros

Co-authored-by: Seth Scherer <supernovaa41@gmx.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2022-08-27 16:23:44 -04:00
SkyratBot
ae708cd7b5 [MIRROR] Removes ComponentInitialize() [MDB IGNORE] (#15552)
* Removes ComponentInitialize()

* Fixes a leftover merge conflict marker

* Fixes the oversight that came from the upstream merge skew

* Fixes all of the instances where we used ComponentInitialize() when we shouldn't've been

* Fixes CI being broken because of the HEV suits

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2022-08-12 19:05:09 -04:00
SkyratBot
9a1cd0c107 [MIRROR] Removes the "proximity crew pinpointer" (the ones parameds spawn with), paramedic PDAs start with the lifeline app instead [MDB IGNORE] (#15461)
* Removes the "proximity crew pinpointer" (the ones parameds spawn with), paramedic PDAs start with the lifeline app instead (#68993)

* Parameds start with the Lifeline tablet app instead of a proximity pinpointer, with a Calomel bottle replacing their now empty medical belt slot.

* Removes the "proximity crew pinpointer" (the ones parameds spawn with), paramedic PDAs start with the lifeline app instead

* wew

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-08-08 01:51:25 +01:00
SkyratBot
6016cf97b4 [MIRROR] individual LOG_GAME [MDB IGNORE] (#15401)
* individual LOG_GAME

* e

* Update teleporter.dm

Co-authored-by: Mooshimi <85910816+Mooshimi@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-08-08 01:11:55 +01:00
SkyratBot
3d4cf438c4 [MIRROR] Merges ordnance data disks [MDB IGNORE] (#15397)
* Merges ordnance data disks (#68376)

JohnFulpWillard
Member
JohnFulpWillard commented 23 days ago
About The Pull Request

Merges ordnance data disk and frontier data disk, since the ordnance data disk's description says it is for ordnance-related stuff, yet doesnt have the main app people need to do Ordnance, which I found weird.

I additionally moved the NT Frontier app to the rest of the programs folder, and renamed it Frontier so it is easier to find.
Why It's Good For The Game

This allows the semi-public ordnance data disk (as they are found in vending machines) to actually contain the ordnance app it claims it provides, making it easier for an Atmospherics Technician (or anyone, really) to get the app needed to upload gasses they make, as experiments for their nodes.

This makes it easier for Engineering to do Engineering-related experiments to get Engineering-related tech nodes, much like Medical can by doing Dissection surgeries, while also giving more use to the Frontier's ability to put authors, since now Science and Atmospherics can see eachother completing experiments and maybe even try to outdo the other.
Changelog

cl
balance: Ordnance data disks now have the Frontier app on them, and has entirely replaced Frontier data disks.
/cl

* Merges ordnance data disks

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2022-08-05 01:01:14 +01:00