Commit Graph

41 Commits

Author SHA1 Message Date
Emmett Gaines
0943e56e08 Adds the signal origin as the first arg to all signals (#39861)
* Adds the signal origin as the first arg to all signals

* Fixes some storage and nanite procs
2018-08-28 18:28:29 +03:00
kevinz000
0038c9cafd exploitfix (#39842) 2018-08-24 12:40:11 +03:00
kevinz000
1bfa10d012 Fix bio bags not working for reproductive extracts (#39753)
> Take 1
> Length of cubes is above 1
> Cut(1)
> Wait that just cut the entire list to nothing

Now the signal should work properly instead of not working whenever there's
more of a thing than the requested amount.
2018-08-23 19:32:01 -07:00
Jared-Fogle
0308655a68 Hovering over storage slots with an item in your hand will show you if you can put the item in (#39661)
Quality of life. Sometimes I forget whether or not I can put an item in my suit storage/pockets. Note this doesn't trigger for hands.
2018-08-17 16:24:56 -07:00
Patrick Chieppe
2c8248575a Logging system refactor and improvement (#39521)
* Refactor several log lines to use datum_info_line and atom_loc_line

* Add default return strings from datum_info_line and atom_loc_line

* Add parentheses around atom_loc_line data

* Change more logs to use atom_loc_line

* Add check in atom_loc_line for turfs to avoid calling get_turf on them

* Re-add removed 'at'

* Replace datum_info_line with key_name and atom_loc_line with loc_name

* Refactor logging functions

* Avoid double-logging self-interactions

* Fallback to simple stringification if all else fails in key_name()

* Rewrite muscle spasm logging to use log_message

* Standardize logging of martial arts

* Tweak individual logging panel look

* Fix individual logging panel source

* When I typed || I really meant &&

* Fix Telecomms logging always showing client logs in the panel

* Reverts addition of buggy ownership log to panel

* Remove colon

* Fix missing log_directed_talk tag

* Add warning for missing type in log_direted_talk

* Change warnings to stack_traces

* Add square brackets around fallthrough key_name() case to help parsing

* Allow atom arguments/src in log_*() functions

* Change log_combat call with null argument to log_message

* Change mecha types' log_message() arguments to match atom and mob version

* Add key_name() case for atoms

* Fix resist_grab() unsetting pulledby before log_combat gets a chance to use it

* Fix log_globally logic

* Add logging for hitting objects with items

* Move log_combat() to atoms.dm

* Use utility functions for object stringification in log_combat()

* Use utility functions for object stringification in log_combat()

* Add missing logs for interacting with display cases

* Rewrite log_combat() comment

* Add missing space in log_combat()

* Add logging for hitting grilles barehanded

* Add missing ..()
2018-08-12 21:41:09 +02:00
ninjanomnom
befaa09c88 Removes a couple storage GetComponent calls 2018-08-02 00:52:12 -04:00
Emmett Gaines
44da4cb683 Makes magnetic catch cleaner in game (#38956)
Utilizes the new signal refactor to cancel throws before they happen. This prevents the silly spin even though the throw was stopped.
2018-07-13 10:31:30 +02:00
Emmett Gaines
34a3d2da4d Refactors component signals registration (#38798)
Datums know what signals are being listened for and components can now be registered to listen for signals on more than one object.
2018-07-05 00:56:39 +03:00
vuonojenmustaturska
34c70340f9 Makes tear in the fabric of reality inaccessible until a boh bomb is detonated (#38852)
* a commit message

* reviews addressed?
2018-07-03 18:02:16 -04:00
Dax Dupont
d577ab0372 Makes bags of holding gib the user on boh detonation (#38737)
It doesn't seem right the user of a boh explosion gets off scott free especially when they just climb the ladder and use a hand tele, mine a little or whatever.

At least with autocloners there needs to be a autocloner and some more effort than printing two bags.
2018-07-03 12:57:48 +12:00
Jordan Brown
26b6fab1fe Merge branch 'pr-38604'
Signed-off-by: Jordan Brown <Cyberboss@users.noreply.github.com>
2018-06-28 14:22:03 -04:00
Tad Hardesty
de205b5517 Fix pocket protectors (#38665) 2018-06-26 16:44:52 -04:00
ShizCalev
89752866aa Merge branch 'master' into spellcheck 2018-06-26 16:43:41 -04:00
ShizCalev
ff532a4ca4 Spellchecks TGStation 2018-06-19 18:57:44 -04:00
Tad Hardesty
870ac15480 Improve how vending machine restocking works 2018-06-16 23:02:41 -07:00
Tad Hardesty
2f8f166d88 Merge pull request #38287 from ninjanomnom/signal-define
Use a define to speed up sending signals to datums with no signals
2018-06-14 22:17:01 -07:00
ninjanomnom
d483ff3ef0 Regexes
`([^_\.])SendSignal\((.+?)\)` -> `\1SEND_SIGNAL(src, \2)`
`([\.\w]+?)\.SendSignal\((.+?)\)` -> `SEND_SIGNAL(\1, \2)`
2018-06-13 19:19:23 -04:00
Jordan Brown
7b06cbb63a [s] Fixes BoH loc being determined before warning prompt (#38459)
* This is clearly @kevinz000' fault

* Not even null checking properly, smh

* Speling

* Fax
2018-06-14 01:37:44 +03:00
kevinz000
a3d1581083 BoH bombs now forcefully stun anyone flying when they go off (#38397)
* Update bag_of_holding.dm

* Incorrect type.
2018-06-13 05:32:48 -04:00
Tad Hardesty
106f5af48b Fix lockboxes not actually being locked 2018-06-08 23:22:12 -07:00
Tad Hardesty
1ed3b1b589 Fix paradox bags (#38212)
* Fix linked storages not initializing correctly

* Rewrite CanReach to handle multiparent storages

* Fix being able to click anything
2018-06-08 13:47:30 +02:00
vuonojenmustaturska
c65a99f130 Move NODROP_1, DROPDEL_1, ABSTRACT_1 and NOBLUDGEON_1 to item_flags where they belong (#38171)
* (mostly) nodrop

* (mostly) dropdel

* (mostly) abstract

* nobludgeon

* things i missed

* forgot one

* unintended changes

* energy handcuffs
2018-06-01 11:36:31 +02:00
ShizCalev
c41d6ac965 Standardizes and cleans up some admin messages & logging (#38128)
* Improved logging

* Fixes & emitter logging

* ded
2018-05-30 21:57:06 -07:00
Dax Dupont
4efb660d8c Adds better admin messaging to boh and fixes summons happening in the wrong places (#38096)
* Adds better admin messaging to boh

* Same for the logs

* chumbis

* I'm a chumbis
2018-05-27 14:02:55 -07:00
KorPhaeron
f5e063414a Bag of Holding Rework (#38010)
* Bag of Holding Rework

* RCDs work on chasms

* No transit space nonsense

* Fixes runtimes

* No infinite chasm
2018-05-26 00:27:32 -04:00
Tad Hardesty
f53caac04a Refresh mob views when atoms enter/exit storage (#37954) 2018-05-21 12:45:52 +03:00
Dax Dupont
b10b31a53d The great bag of holding n e r f 2018-05-19 19:52:21 +02:00
kevinz000
85aef5755a Fixes EMPs (#37656) 2018-05-10 08:32:40 +02:00
kevinz000
2d91fdbd93 Fixes mousetraps not going off from being dumped out (#37447)
* mousetrap fix

* fix mousetraps

* Update storage.dm

* Combine checks
2018-05-04 11:42:55 +02:00
Tad Hardesty
e268d6fe52 Fix placing boxes in storage implants (#37579) 2018-05-01 08:29:41 -04:00
Jordan Brown
8ce7d19c9c Merge pull request #37565 from ninjanomnom/component-limbo
Modifies component transfer to make ChangeTurf able to transfer components
2018-04-30 22:16:47 -04:00
ninjanomnom
ff856e4bf5 Proper method fixes 2018-04-30 15:54:59 -04:00
ninjanomnom
c1e5150681 Purge references in /storage/concrete Destroy 2018-04-29 19:13:18 -04:00
ninjanomnom
5028239b35 Modifies the component transfer to make ChangeTurf work 2018-04-29 18:11:02 -04:00
kevinz000
1383b34a7b [syou can no longer insert a storage object into itself, and therefore, no longer bohbomb with one boh (#37410)
* paradox

* fine, byond.

* src.
2018-04-29 16:22:33 -04:00
Dax Dupont
52a7ebcbff Refactors and fixes RPEDs (#37380)
* Refactors and fixes RPEDs

* Fixes storage related memes

* beams should probably always play
2018-04-27 21:12:41 +03:00
Jordan Brown
a1b89c3643 Removes redundant COMPONENT_INCOMPATIBLE crashes (#37389) 2018-04-25 06:53:43 -04:00
Jordan Brown
d21f09a15e Merge pull request #37299 from ShizCalev/ghost-bag-fix
Fixes ghosts being unable to see into nonadjacent bags
2018-04-23 10:04:26 -04:00
Fox McCloud
057aa31cda Kills off /obj/item/device (#37297)
* Kills off /obj/item/device

* whoops

* whoops

* Fix
2018-04-23 15:00:23 +02:00
ShizCalev
57fce0d003 ghosts being unable to see into nonadjacent bags 2018-04-19 18:52:39 -04:00
kevinz000
ab993a117a Component Storage, Experimental attack_hand and [ui_]interact() refactors (#36696) 2018-04-12 14:46:14 +03:00