Commit Graph

27 Commits

Author SHA1 Message Date
SkyratBot 093d20a2df [MIRROR] Makes all CTF windows actually indestructible [MDB IGNORE] (#19922)
* Makes all CTF windows actually indestructible (#74021)

## About The Pull Request

Adds a spawner for indestructible shuttle windows
Replaces all "hardened windows" (which were actually not unbreakable)
with proper unbreakable windows

## Why It's Good For The Game

Fixes #73297, people shouldn't be breaking into space in CTF

## Changelog
🆑
fix: All CTF windows are now indestructible, fixes breaking into space
during CTF.
/🆑

* Makes all CTF windows actually indestructible

---------

Co-authored-by: jimmyl <70376633+mc-oofert@users.noreply.github.com>
2023-03-17 22:46:18 -04:00
SkyratBot 0af2aa035b [MIRROR] fixes hollow survival pod window spawners [MDB IGNORE] (#18178)
* fixes hollow survival pod window spawners (#72000)

## About The Pull Request
they used fulltile survival pods so it just spawned 4 full windows in
one place

## Why It's Good For The Game
i use them on my map and it upsets me

## Changelog
🆑
fix: fixes hollow survival pod window spawners
/🆑

* fixes hollow survival pod window spawners

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
2022-12-17 03:29:27 +00:00
SkyratBot 375fea374a [MIRROR] Optimizes qdel related things (slight init time savings) [MDB IGNORE] (#17240)
* Optimizes qdel related things (slight init time savings)

* lang holder

* cleanup custom spawners slightly

* ref update

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
2022-10-30 23:15:38 -04:00
SkyratBot 29e29b6375 [MIRROR] Save 2.2s minimum (with zero ruins, likely a good bit more in production) of atom init time [MDB IGNORE] (#15967)
* Save 2.2s minimum (with zero ruins, likely a good bit more in production) of atom init time (#69564)

Pre-sort smoothing_groups and canSmoothWith
Without any ruins, these sorts were taking more than 0.6s, and the bulk of the runtime cost of sortTim during init time.

This only happens on init and they are never changed apart from that, so pre-sorts everything and adds a unit test (in the form of #ifdef UNIT_TESTS, because you can't initial a list) to ensure that they are proper.

Keep visibilityChanged() to mapload only for turf/Initialize
Saves about 0.4s worst case scenario (e.g. with no ruins). Very expensive code (175k loop iterations) for 0 side effects.

Space areas now have the fullbright overlay, not the space turfs
Saves about 0.8s worst case scenario. Seems to work fine with starlight.

Remove is_station_level check for window spawners assigning RCD memory.
Saves about 0.3s worst case scenario. The logic for this isn't consistent since neither walls nor floors check this (for performance), plus some minor micro-opts to spawners.

Optimize is_station_level
Doubles in speed, used heavily in /turf/open/floor and in other initialization procs. Bit hard to tell exactly how much is saved, though.

* Save 2.2s minimum (with zero ruins, likely a good bit more in production) of atom init time

* Hopefully fixes the broken CI

* Okay now it shouldn't be failing CI anymore (hopefully)

* Fixes even more issues with smoothing_groups, this time hopefully for good

* Okay NOW it's going to pass CI, surely...

* Okay haha what if it passes this time? :)

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2022-09-15 19:57:33 -04:00
SkyratBot c2189d5818 [MIRROR] adds structure spawners for electrified grilles, adds greps for some fulltile window spawners [MDB IGNORE] (#15954)
* adds structure spawners for electrified grilles, adds greps for some fulltile window spawners (#69528)

* adds structure spawner for electrified grilles

* sdmm key cleanup

* adds structure spawners for electrified grilles, adds greps for some fulltile window spawners

* should fix blueshift lints lets see

* should resolve most if not all of the others

* damn you skyrat map reset

Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
Co-authored-by: Paxilmaniac <paxilmaniac@gmail.com>
2022-09-07 16:40:05 -04:00
SkyratBot 913c2a9877 [MIRROR] Kilo Chapel Fixes (And Tweaks) [MDB IGNORE] (#12192)
* Kilo Chapel Fixes (And Tweaks) (#65511)

* Kilo Chapel Fixes (And Tweaks)

Co-authored-by: BluBerry016 <50649185+unit0016@users.noreply.github.com>
2022-03-22 21:03:24 +00:00
GoldenAlpharex 3662a09285 Another 12 AM CI Fix (#11065)
* Possible fix for CI

* We're never too safe

Co-authored-by: jjpark-kb <55967837+jjpark-kb@users.noreply.github.com>
2022-01-28 05:30:15 +00:00
SkyratBot 4fc5079cdc [MIRROR] Moves atmos checking from Fire Alarms to Fire Locks, Fire Locks now close on their own rather than area-based, a bunch of related stuff. [MDB IGNORE] (#10893)
* Moves atmos checking from Fire Alarms to Fire Locks, Fire Locks now close on their own rather than area-based, a bunch of related stuff.

* Weeeee

Co-authored-by: zxaber <37497534+zxaber@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-01-27 02:21:18 +00:00
SkyratBot 13fe213621 [MIRROR] [MDB Ignore] Make shuttle windows deconstructable [MDB IGNORE] (#8463)
* [MDB Ignore] Make shuttle windows deconstructable

* E

* re

Co-authored-by: Mooshimi <85910816+Mooshimi@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-10-01 00:21:36 +01:00
SkyratBot c23bd1cb8c [MIRROR] every case of initialize that should have mapload, does (#8374)
* every case of initialize that should have mapload, does

* E

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-09-24 23:07:53 +01:00
Gandalf 0a3745796e Firelocks remastered (#6663)
* a

* Update firedoor.dm

* Update firedoor.dm

* Update firedoor.dm

* Update firedoor.dm
2021-07-03 22:27:28 +01:00
Gandalf 778a589555 Removes a lot of redundant non-modular changes and maybe fixes cleanbots (#6615)
* oof

* Update _ai_controller.dm

* no need for this anymore
2021-06-30 21:50:50 +02:00
Matthew J aac40d2ed3 [TM-ONLY][DNM] Attempts to remove all instances where a list is accessed with a '?' (#5932)
* I hate TGUI even if its better than what we had before

* this is why linters exist

* you need to be a Head or the Warden to get items

* does this please you linter?

* foundation

* basic interactions

* yea I can spell okay?

* linters please leave me alone

* begone debug code

* if you are dead, no interacting

* linters leave me alone

* linters are stealing my soul

* forgot to do this

* sound framework, probably wont work though

* max length, and interaction cooldowns

* message can now be a list and minor code improve

* I am a slave and linters are my master

* fix improper static reference

* add json loading/saving functionality

* default for message is now a list

* jsonize def interactions; implement requirements

* bad

* bug fix; CtrlShiftClick to interact

* minor qol fix

* fix CtrlShiftClick and remove debug code

* haha docker has security measures

* this was painful

* why are you in this branch

* begone

* bruh

* begone

Co-authored-by: Matthew <matthew@tfaluc.com>
Co-authored-by: Matthew J <GoldenKeyboard@users.noreply.github.com>
2021-05-25 16:26:39 +01:00
SkyratBot 5ed908387f [MIRROR] RCD now rebuilds existing constructs faster and with less resources (#4641)
* RCD now rebuilds existing constructs faster and with less resources (#58029)

* RCD now rebuilds faster

* Reconstructing now costs less

* Fix _

* Remove unused flag, use helper proc

* Add sound

* Remove previously useless, now inaccurate comment

* Add MIN_COMPILER_VERSION warning

* RCD now rebuilds existing constructs faster and with less resources

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2021-04-04 15:58:57 +01:00
SkyratBot e776d6a35b [MIRROR] Fixes fulltile pod window spawner (#2596)
* Fixes fulltile pod window spawner (#56033)

* Fixes fulltile pod window spawner

Co-authored-by: EgorDinamit <53223414+EgorDinamit@users.noreply.github.com>
2021-01-09 17:29:09 +00:00
SkyratBot b8d9874c27 [MIRROR] Converts all A && A.B into A?.B (#1292)
* Converts A && A.B into A?.B (#54342)

Implements the ?. operator, replacing code like A && A.B with A?.B

BYOND Ref:
When reading A?.B, it's equivalent to A && A.B except that A is only evaluated once, even if it's a complex expression like a proc call.

* Converts all A && A.B into A?.B

Co-authored-by: ZeWaka <zewakagamer@gmail.com>
2020-10-13 23:19:25 +02:00
Firecage b18e8ba52b Makes Plastitanium Windows deconstructable and children of Reinforced Windows. (#46679)
* Makes plastitanium windows children of reinforced windows.

* Unanchored variety isn't fully tooled in now.

* Path moved to plasma/reinforced/plastitanium

* Fixes a blunder about neglecting a mapping path change.
2019-09-25 18:25:48 -07:00
ShizCalev d77eb3df50 Adds new window spawners 2018-04-18 13:50:59 -05:00
Denton 50be282659 20 hours in notepad 2018-04-11 14:01:43 +02:00
Denton 1be4ecb804 fixes shuttle/hollow r-plasma window names 2018-04-05 13:27:54 +02:00
ShizCalev 395c0ee6a0 Cleans up some qdel(src)'s in Initialize() 2017-11-26 20:15:12 -06:00
ShizCalev 301528bc6e Window spawner refactor (#30747) 2017-09-16 17:34:01 -04:00
ShizCalev 922422a159 Window Spawners mk2 (#29792) 2017-08-10 08:17:30 -03:00
ShizCalev b3a2721590 Window Spawners (#29634) 2017-08-02 10:11:07 -04:00
Cyberboss 0f71ac6190 Fixes window spawners qdeling in New() (#25357) 2017-03-22 16:11:40 -03:00
francinum fbfb80a0e2 I after E
When you're spelling something not 1 line away.
2015-10-09 00:25:20 -04:00
KyrahAbattoir d6c0ebdc1b Mapping tool: adds a "structure" spawner that can be used to create "sets" of objects in a turf at runtime rather than having to stack objects in the map editor. Included are two presets for window and rwindow with a "wiring friendly" icon. 2015-06-05 11:39:23 +02:00