* Shoe storage can now fit box cutters, pills, and toy pistol magazines. (#74762)
## About The Pull Request
Shoe storage can now fit box cutters, pills, and toy pistol magazines.
All of these have better-or-equal similar items that can already be
fitted in.
Box cutters - Switchblades (Better in every way)
Pills - Syringes and Medipens (Mostly sidegrades)
Toy magazines - Actual pistol magazines
## Why It's Good For The Game
More stuff you can shove into your shoes, consistency with similar
items. Honestly I'm not too fond of this strange whitelist system,
wouldn't a blacklist be better and more intuitive?
If there's any items you want me to add, comment below with them.
## Changelog
🆑
qol: Shoe storage can now fit box cutters, pills, and toy pistol
magazines.
/🆑
* Shoe storage can now fit box cutters, pills, and toy pistol magazines.
---------
Co-authored-by: carlarctg <53100513+carlarctg@users.noreply.github.com>
* Fixes two bugs with removing cards from a tgc deck. (#74658)
## About The Pull Request
Fixes: #72697
Fixes transferring cards to a binder resulting in zero card decks.
Fixes transferring cards to the floor not working at all.
## Why It's Good For The Game
Bugfixes!
## Changelog
🆑
fix: Removing cards from TGC decks by pouring them on the floor/into
binders should now function correctly.
/🆑
* Fixes two bugs with removing cards from a tgc deck.
---------
Co-authored-by: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>
* Fixes belts not updating their overlays when transferring their contents to another storage item. (#73251)
## About The Pull Request
When you drag and drop a belt to another storage item it transfers all
its contents but retains its overlays. This PR calls update appearance
at the end of storage to storage transfers so this shouldn't occur
again.
## Why It's Good For The Game
Bug fix, belts appearing to have things on them which they don't is bad.
## Changelog
🆑
fix: Transferring objects from a belt to another storage object now
removes those objects from the belts visuals.
/🆑
* Fixes belts not updating their overlays when transferring their contents to another storage item.
---------
Co-authored-by: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>
* RPED can pick up & install circuit boards in machine frames (#72540)
* RPED can pick up & install circuit boards in machine frames
Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com>
* Right-clicking a Cigarette pack takes out a cigarette, while Alt-Clicking takes out a lighter (if there is one) (#72104)
## About The Pull Request
Right-clicking a Cigarette pack takes out a cigarette, while
Alt-Clicking takes out a lighter. If there's no lighter, then it just
takes out a cigarette instead.
## Why It's Good For The Game
Currently, if you put your lighter in the cigarette pack, then trying to
fish it out requires you to take out the packet and mill through all the
cigarettes until you get to the lighter.
This fixes that while still keeping the quick and easy functionality.
## Changelog
🆑 Wallem
qol: Smokers rejoice, you no longer need to mill through your cigarette
packet to get your lighter out. Alt-Click a cigarette packet to extract
a lighter from it, if you've put it in there. Right-Clicking will still
take out a cigarette.
/🆑
* Right-clicking a Cigarette pack takes out a cigarette, while Alt-Clicking takes out a lighter (if there is one)
Co-authored-by: Wallem <66052067+Wallemations@users.noreply.github.com>
* Save 0.6-0.7s of init time by splitting registering lists of signals into its own proc, and optimizing QDELETED
* modular RegisterSignals
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
* premium internals now increase the slots of your internals box (#71440)
## About The Pull Request
premium internals boxes from the station trait now get 2 more slots and
have a slightly bigger sprite
also lowers the trait's weight a bit, making it equal to most other
traits.
## Why It's Good For The Game
the main reason im doing this is because this trait messes with anything
people wanna do to survival boxes, cause it takes up 2 slots, so you
have to account for that whenever youre making a subtype that you wanna
fill with more stuff, you cant really do that (currently an issue with
the nukie medical pr)
the other reason is station traits should affect the gameplay a bit more
than "wow i have 2 items i can normally get from an emergency toolbox",
a larger box doesnt change that much but its something.
## Changelog
🆑
balance: premium internals station trait now increases the slots of your
internals box
/🆑
* premium internals now increase the slots of your internals box
Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
* RPED can now install certain stack components and display more verbose part information (#71102)
**Note :** Rehashed & cleaned up version of PR
[#71064](https://github.com/tgstation/tgstation/pull/71064). That one
contained unrelated commits and was so bad to the point it had be
labeled with DNM. This is the clean version of it.
## About The Pull Request
Rapid part exchange device RPED & Bluespace version of it BRPED can now
A) pick up 4 types of materials
- glass sheets[max 30]
- plasteel[max 30]
- cable coil[max 30]
- Bluespace[ore,refined,artificial,stack] total sum of all these should
not exceed 30
and install them in an incomplete machine frame
B)display more verbose part information[number of parts for each type
including for stack components]
## Why It's Good For The Game
A)Some machines types such as
- [thermo
machines](https://tgstation13.org/wiki/Machines#Freezer.2FHeater)
- [electrolyzers](https://tgstation13.org/wiki/Machines#Electrolyzer)
- crystallizer=10 cable pieces , 10 glass sheets , 5 plasteel sheets
All require either cable ,glass or plasteel. Usually you have to carry
these components inside your backpack which occupy space there and later
take it out from there and install it manually by hand and then use RPED
or BRPED on the machine frame.
This feature now combines these 2 steps into 1 step thus making
installing machine frames much faster and you also saves space inside
your backpack as these are now carried inside the RPED itself
You need to insert the exact stack type capacity available inside the
RPED for it to work i.e. if you pick up 5 glass sheets then later you
need a stack of exactly 25 glass sheets to complete the stack. This is
easier from a coding perspective so we don't have to deal with
subtracting & updating appearances of the remaining stack on the ground
or the user hand.
B) When using the RPED or BRPED to display machine part information
these are the new formats
Using an RPED on an thermo machine
Using an RPED on the crystallizer
##Change Log
🆑
add: checks while inserting stack materials into an RPED and their
amounts
code: sorting of RPED part components to sort stack materials by their
ratings
del: old way of displaying parts when clicking on an machine frame with
it
add:new way of displaying part info which displays number of parts
including for stack materials
/🆑
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* RPED can now install certain stack components and display more verbose part information
Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* [NO GBP] Add a 2 second cooldown for ore bag balloon alerts (#71133)
## About The Pull Request
And removes an extra `to_chat` message for when your ore bag is full and
can't put ore in using the `silent_for_user` system.
## Why It's Good For The Game
I have been moving the chat messages that miners get bombarded every
shift away from their chat bar and into balloon alerts with the goal of
making the chat be a cleaner place for miners, as it is their only way
to interact with the station while down at lavaland.
People have been complaining that it was too much, which is fair. I've
been work on a mini rework on how ore bags function and a cleaner
feedback with ore icons falling into the bag, but I'm just not happy
with how it works now so I will restart on it.
Until I get that sorted, I added a 2 second cooldown on the balloon
alerts for picking up ore as a middle ground, it provides good feedback
for new players while not being as distracting.
## Changelog
🆑 Guillaume Prata
qol: Ore bag balloon alerts have a 2 second cooldown now and a spammy
message (hopefully the last) it send to your chat about being full was
removed
/🆑
* [NO GBP] Add a 2 second cooldown for ore bag balloon alerts
Co-authored-by: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com>
* Adds a `silent_for_user` var to mute storage messages only for the user. (#70941)
## About The Pull Request
We have a `silent` var that makes storing/removing items from a backpack
not send a message to anyone's chat.
This adds a midway point, silent messages only for the user to cut on
spam/unnecessary messages while other players still keep them to prevent
free stealth shenanigans.
For now the only storage item I have given this new variable is the ore
bag for miners, as even with #70487 miners still have to deal with a lot
of pointless messages getting in the way of radio chatter.
## Why It's Good For The Game
Less pointless spam.
You mined the ore, you stepped on it, you get a balloon alert explaining
what happened.
There is no reason to also send the default storing/removing message to
your chat.
it can also be easily ported to other backpack/boxes/bags, I personally
would want it on basically any storage but that would hurt on new
player's feedback, so it is a conversation for another PR.
## Changelog
🆑 Guillaume Prata
qol: Ore bags are "silent" for the wearer and won't send pointless chat
messages about what has been stored/removed from it. Other players will
still get a chat message, so miners can't get away with surprise plasma
ore bombs.
/🆑
* Adds a `silent_for_user` var to mute storage messages only for the user.
Co-authored-by: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com>
* Allows flasks to be stored in shoe pockets (#70680)
* Added flasks to pocket.dm shoes
Adds flasks to the valid item storage list for jackboots, clown shoes, and other similar shoes
* Added flasks to pockets.dm shoes
Adds flasks to the valid item list for storage inside jackboots, clown shoes, and similar shoes
Co-authored-by: AeronaDF <aeronadf@ gmail.com>
* Allows flasks to be stored in shoe pockets
Co-authored-by: DannyBoy3642 <98357253+DannyBoy3642@users.noreply.github.com>
Co-authored-by: AeronaDF <aeronadf@ gmail.com>
* Fixes mining modsuit storage breaking after recharging it with plasma (#70558)
* Adds QDELETED check to inserting items to storage
* Fixes mining modsuit storage breaking after recharging it with plasma
Co-authored-by: GoblinBackwards <22856555+GoblinBackwards@users.noreply.github.com>
* fix xenbio bag (#69518)
A little earlier, it was gone to use bags of xenobiology on reproductive extracts, but now, after this change, the possibility is completely returned.
* fix xenbio bag
Co-authored-by: Yaroslav Nurkov <78199449+AnywayFarus@users.noreply.github.com>
* Fixes storage mass transfer being generally broken, adds mass transferring onto griddles (#69084)
* - Fixes storage mass transfer
- Brings some sanity to storage procs
- Implements a griddle feature that never was
* Uncomment this
* Right-click attack fix
* Scoop fix
* Smartfridges use silent
* Restores some lost checks
* Fixes storage implants
* Fixes storage mass transfer being generally broken, adds mass transferring onto griddles
* update modular
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
* Fixes belts only getting their appearance updated when removing an item from it (#69066)
Fixes storage belts only getting their appearance updated when removing an item from it
* Fixes belts only getting their appearance updated when removing an item from it
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
* Fixes RPEDs being unable to pick up beakers and assemblies (#68822)
does the pr
* Fixes RPEDs being unable to pick up beakers and assemblies
Co-authored-by: Coffee <CoffeeDragon16@gmail.com>
* organ boxes now have a storage type (#68722)
* Organ boxes now have a storage type and, because of it, will once again prevent organ decay to organs stored inside of it.
* organ boxes now have a storage type
Co-authored-by: magatsuchi <88991542+magatsuchi@users.noreply.github.com>
* fixes not being able to click drag storage containers + rmb fix (#68557)
* On the storage datum, properly registers secondary singals to their own secondary procs to handle the different stuff they do.
* Fixes click & drag storage containers by calling them on where they are supposed to be moved to using atom_storage.
* fixes not being able to click drag storage containers + rmb fix
Co-authored-by: magatsuchi <88991542+magatsuchi@users.noreply.github.com>
* fixes TRAIT_NODROP items being able to be put into storage (#68516)
initial
* fixes TRAIT_NODROP items being able to be put into storage
Co-authored-by: magatsuchi <88991542+magatsuchi@users.noreply.github.com>
* Tsu's Brand Spanking New Storage: or, How I Learned To Pass Github Copilot As My Own Code
* Delete storage.dm
* yippee
* shit
* holy shit i am stupid
* more fixes
* fuck
* woops
