* Fixes ERT Briefing Officer Outfit pref (#57069)
I was dumb in #56345 and committed a suggestion from a maintainer without actually checking what it did, leading to the part where you select what outfit you want in your preferences to not actually let you select an outfit.
This also removes the can_be_admin_equipped var from outfit datums, apparently it was supposed to be used for outfits that were only supposed to be spawned in certain ways or some nonsense, but nothing actually used it so bye bye
* Fixes ERT Briefing Officer Outfit pref
* Update preferences.dm
Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
* Fix small oversight with a query deletion (#56997)
Just a tiny bug that can make a lot of screaming! "Undeleted SQL Query"
* Fixes a small SQL qdel being missing
Co-authored-by: Funce <funce.973@gmail.com>
* Hovering your mouse over things now shows their name on the top of the screen (#56729)
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* Hovering your mouse over things now shows their name on the top of the screen
* a
* Update preferences_savefile.dm
Co-authored-by: Qustinnus <Floydje123@hotmail.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
* Refactors ambience to a subsystem (#56723)
Ambience is now in a subsystem, and plays every now and then without you having to move to a new area for it to play
* Refactors ambience to a subsystem
Co-authored-by: Qustinnus <Floydje123@hotmail.com>
* Make keybinding conflict spans less loud (#56707)
Each time new keybindings are added, we receive a message at the
beginning of each round telling us about keybindings we've set that
conflict with what the new ones default to. This is desirable. However,
it could take up less space while still drawing the eye.
* Makes keybinding conflict messages use smaller spans
Co-authored-by: cacogen <25089914+cacogen@users.noreply.github.com>
* You no longer need to hold shift to open the context menu as a ghost (#56646)
* You no longer need to hold shift to open the context menu as a ghost
Co-authored-by: Qustinnus <Floydje123@hotmail.com>
* Re-balances quirk values to be less impossible to nuance (#56037)
negative quirks were impossible to create because there was zero nuance between how bad traits were, for example if you got light drinker and family heirloom, two relatively easy quirks to manage, you can get freerunner. This meant a ton of neutral quirks had to be neutral quirks because giving them even -1 points would make it too easy to get good traits. I've bumped up most quirks by x4 to allow for more nuance between what quirks are actually worth. With some of them being lowered (Like family heirloom and light drinker) as theyre not really supposed to be worth so much for so little.
quick log of changes for CB:
- Every quirk not mentioned had it's point value increased x4 (e.g. 1 -> 4, 4 -> 16)
- mime / clown fan is 2 points (change of -50% with this pr)
- musician is 2 points (change of -50% with this pr)
- depression goes from -1 to -3 points (change of -25% with this pr)
- nyctophobiagoes from -1 to -3 points (change of -25% with this pr)
- junkie from -2 to -6 points (change of 25% with this pr)
- frail from -2 to -6 points (change of 25% with this pr)
- smoker from -2 to -6 points (change of 25% with this pr)
- unstable -2 to -10 points (change of 25% with this pr)
* Re-balances quirk values to be less impossible to nuance
* Update tgstation.dme
* a
Co-authored-by: Qustinnus <Floydje123@hotmail.com>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
* [bounty code moment] Adds a way to view the 'Server's Last Round' (#55646)
* Adds "View Last Server Round Report" option.
* [bounty code moment] Adds a way to view the 'Server's Last Round'
Co-authored-by: Emmanuel S <mrdoomboyo@gmail.com>
* Disconnect and Reconnect messages for deadchat (#55395)
adds messages to deadchat when a client with a mob disconnects or reconnects
* Disconnect and Reconnect messages for deadchat
* aaa
Co-authored-by: Emmanuel S <mrdoomboyo@gmail.com>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
Co-authored-by: Azarak <azarak10@gmail.com>
* Fixes an oversight allowing players to list ckeys and the names of the mobs they're controlling under certain conditions (#55332)
About The Pull Request
• Resolves a probably unknown oversight allowing players to find out who plays who by using the ignore verb, which if the user is a ghost, will list the names of people's mobs alongside their ckey if they are also a ghost.
Why It's Good For The Game
Removes a potential method of metagrudging and addresses a privacy concern for those who wish to play anonymous characters. Yes, you can still see this stuff in the round-end report.
We don't lose anything here. If we're using this verb, we're doing it because we want to ignore someone's OOC messages. We don't need this additional information. I feel like this is just an oversight.
Changelog
🆑
fix: Players can no longer us the ignore verb to gather a list of people's characters and ckeys together.
/🆑
* Fixes an oversight allowing players to list ckeys and the names of the mobs they're controlling under certain conditions
Co-authored-by: KathrinBailey <53862927+KathrinBailey@users.noreply.github.com>
* Extends the IC chat filter to be checked in two major renaming procs (#55217)
About The Pull Request
Honestly, I'm not sure this is the... Correct solution? But people more familiar with this will likely show me da wae.
Prohibits creating names that can't actually be spoken in-character due to chat filters by adding CHAT_FILTER_CHECKs to the procs that handle sanitising them.
For admin-utilised renaming procs, they'll be given a simple alert box to warn them their chosen name contains words prohibited by the IC chat filter and be allowed to confirm or cancel out.
Why It's Good For The Game
If you can't speak the name IC, chances are the name shouldn't be allowed at all. Players may occasionally be forced to ahelp certain names because they contain words prohibited in chat filters.
* Extends the IC chat filter to be checked in two major renaming procs
Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
* Replace tgalert with tgui_alert, a new TGUI-based alert system
* a
* a
Co-authored-by: Bobbahbrown <bobbahbrown@gmail.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
* Capitalises Settings, Ghost and Sound menu titles at top (#54640)
This makes it so the Settings menu and the Ghost and Sound submenus have their names capitalised like the rest of the options on the menu bar at the top of the screen.
* Capitalises Settings, Ghost and Sound menu titles at top
Co-authored-by: cacogen <25089914+cacogen@users.noreply.github.com>
* Properly sanitizes the pixel scaling pref (#54592)
It was being rounded to 1, which breaks one of the options.
I've added a float sanitize proc that accepts a degree to round to, I've set it to 0.5 in this case.
* Properly sanitizes the pixel scaling pref
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
* fix fix chat (#54517)
Makes fix chat more robust as well as giving a more visible method to fix it.
Stand in while I investigate methods to hopefully make this unneeded.
* fix fix chat
Co-authored-by: Rob Bailey <actioninja@gmail.com>
* Converts A && A.B into A?.B (#54342)
Implements the ?. operator, replacing code like A && A.B with A?.B
BYOND Ref:
When reading A?.B, it's equivalent to A && A.B except that A is only evaluated once, even if it's a complex expression like a proc call.
* Converts all A && A.B into A?.B
Co-authored-by: ZeWaka <zewakagamer@gmail.com>
* Adds a living time config to the panic bunker (#54341)
* Adds a living time value to the panic bunker, so you can keep people out based on time spent playing the game
* updates the admin verb, and enables %minutes% as an option
* Makes a proc call more clear
Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@ users.noreply.github.com>
* than
Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@ users.noreply.github.com>
* Adds a living time config to the panic bunker
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@ users.noreply.github.com>
* Keybinding Conflicts now wait 5 seconds before being announced (#54152)
* Keybinding Conflicts now wait 5 seconds before being announced
* Update preferences_savefile.dm
Co-authored-by: Couls <coul422@gmail.com>
Co-authored-by: Azarak <azarak10@gmail.com>
* Merge pull request #54101 from Couls/silence-wench
unbinding movement and communication should work now
* unbinding movement and communication should work now
* Update preferences.dm
Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
Co-authored-by: Azarak <azarak10@gmail.com>
* adds a new default "dance" suicide. (#54040)
About The Pull Request
This adds a new default help intent suicide, a dance.
Why It's Good For The Game
I think fondly of our suicides getting more and more fun over time, and even the defaults go from "bites his tongue" to now "getting high on life" and I think this is a fun new default suicide.
Changelog
cl
add: adds a new default suicide, a dance.
/cl
* adds a new default "dance" suicide.
Co-authored-by: anconfuzedrock <anconfuzedrock@users.noreply.github.com>
