29 Commits

Author	SHA1	Message	Date
Lucy	d656f0f4ec	Refactor GLOB.admin/debug/fun_state into cached /datum/ui_state/admin_state instances (#89417) ... ## About The Pull Request So, some admin verbs/tools that used tguis, i.e edit/debug planes, were available to admins with +DEBUG... but the ui_state used `GLOB.admin_state`, which checks for +ADMIN - meaning that if they _only_ had +DEBUG, they would have the verb... but it would do nothing when they used it. I've refactored `GLOB.admin_state`, `GLOB.debug_state`, and `GLOB.fun_state` into a merged `/datum/ui_state/admin_state`, with a var for which specific permissions are being checked for. You now use the `ADMIN_STATE(perms)` macro to get the UI state for those specific perms, i.e `admin_state(R_ADMIN)` or `admin_state(R_DEBUG)`, and the resulting UI state will check for _those specific perms_. These are initialized and cached in `GLOB.admin_states` (which should never be directly accessed). So, I've went thru every single usage of `GLOB.admin_state`, `GLOB.fun_state`, and `GLOB.debug_state`, and made them all use `ADMIN_STATE()` with the actual permission flags needed to use said UI in the first place. ## Why It's Good For The Game Kinda dumb for specific admin permissions to be granted verbs that don't let them use it anyways. ## Changelog 🆑 admin: Certain UI-based tools (plane debugger, filter editor, etc) that were given to admins with only +VAREDIT or +DEBUG, but refused to open without +ADMIN, now actually work for admins that have the needed permission. /🆑	2025-02-17 00:54:00 +01:00
Penelope Haze	b67a0901f2	Fix issues discovered via TypeMaker (#87596) ... ## About The Pull Request Fixes issues with var typing and proc arguments, discovered using OpenDream's WIP TypeMaker feature (using improvements I haven't PR'd upstream yet). ## Why It's Good For The Game Codebase maintenance.	2024-11-19 15:24:52 -05:00
san7890	a4328ae1f9	Audits tgui_input_text() for length issues (#86741) ... Fixes #86784 ## About The Pull Request Although some of the issues found were a direct result from #86692 (c698196766), there was still 40% of length-related issues that wouldn't be covered anyways that are fixed in this PR. I.E.: * Name inputs without `MAX_NAME_LEN` * Desc inputs without `MAX_DESC_LEN` * Plaque inputs without `MAX_PLAQUE_LEN` * Some people just screwed up the arguments so it would prefill something like "40" in the `default` var because they didn't name their vars. To help me audit I added a lot of `max_length` named arguments to help people understand it better. I think it might be kinder to have a wrapper that handles adding `MAX_MESSAGE_LEN` in a lot of these cases but I think there is some reason for a coder to be cognitive about input texts? Let me know what you think. I didn't update anything admin-related from what I can recall, let me know if anything needs to be unlimited again. ## Why It's Good For The Game The change to `INFINITY` notwithstanding, there were still an abundance of issues that we needed to check up on. A lot of these are filtered on down the line but it is clear that there needs to be something to catch these issues. Maybe we could lint to make `max_length` a mandatory argument? I don't know if that's necessary at all but I think that the limit should be set by the invoker due to the wide arrangement of cases that this proc could be used in. This could all be a big nothingburger if the aforementioned PR is reverted but a big chunk of cases fixed in this PR need to be fixed regardless of that since people could put in 1024 character names for stuff like guardians (or more now with the change). Consider this "revert agnostic". ## Changelog 🆑 fix: A lot of instances where you could fill in 1024-character names (normal limit is 42) have been patched out, along with too-long plaque names, too-long descriptions, and more. /🆑	2024-09-20 22:46:41 +00:00
John Willard	1880003270	Reworks silicon/ai access checking & fixes some ui_act's (#84964) ... ## About The Pull Request Currently to check for Silicon access, we do: ``if is silicon or is admin ghost or has unlimited silicon privileges or has machine remote in hand`` What has unlimited silicon privileges? Bots, Drones, and admin ghosts. To check for AI access, it just checks for AI instead of silicon, and doesnt check for unlimited silicon privileges. This was kinda silly, so I thought I should make this a little easier to understand. Now all silicon/ai traits come from ``AI_ACCESS_TRAIT`` or ``SILICON_ACCESS_TRAIT``. I made a single exception to keep Admin ghost, since now instead of being a var on the client, we moved it to using the same trait but giving it to the client instead, but since we have to keep parity with previous functionality (admins can spawn in and not have this on, it only works while as a ghost), I kept previous checks as well. No more type checks, removes a silly var on the mob level and another on the client. Now while I was doing this, I found a lot of tgui's ``ui_act`` still uses ``usr`` and the wrong args, so I fixed those wherever I saw them, and used a mass replace for the args. Other changes: - machinery's ``ui_act`` from https://github.com/tgstation/tgstation/pull/81250 had ``isAI`` replaced with ``HAS_AI_ACCESS``, this has been reverted. Machine wands and admin ghosts no longer get kicked off things not on cameras. This was my fault, I overlooked this when adding Human AI. - Human AI's wand gives AI control as long as it's in your hand, you can swap to your offhand. I hope this doesn't end up going horribly, otherwise I'll revert this part. It should let human AIs not have their UI closed on them when swapping to eat food or use their door wand or whatnot. - Bots previously had special checks to scan reagents and be unobservant, I replaced this with giving them the trait. I also fixed an instance of unobservant not being used, so now statues don't affect the basic creature, whatever that is. ## Why It's Good For The Game This is an easier to understand way of handling silicon access and makes these mobs more consistent between eachother. Other than what I've mentioned above, this should have no impact on gameplay itself. ## Changelog 🆑 fix: Statues don't count as eyes to creatures. fix: Human AIs and Admin ghosts no longer get kicked off of machines that aren't on cameranets. /🆑	2024-08-19 10:43:45 +00:00
MrMelbert	ff6b41aa07	Afterattack is dead, long live Afterattack (#83818) ... ## About The Pull Request - Afterattack is a very simple proc now: All it does is this, and all it's used for is for having a convenient place to put effects an item does after a successful attack (IE, the attack was not blocked)  - An overwhelming majority of afterattack implementations have been moved to `interact_with_atom` or the new `ranged_interact_with_atom` I have manually tested many of the refactored procs but there was 200+ so it's kinda hard ## Why It's Good For The Game Afterattack is one of the worst parts of the attack chain, as it simultaneously serves as a way of doing random interactions NOT AT ALL related to attacks (despite the name) while ALSO serving as the defacto way to do a ranged interaction with an item This means careless coders (most of them) may throw stuff in afterattack without realizing how wide reaching it is, which causes bugs. By making two well defined, separate procs for handing adjacent vs ranged interactions, it becomes WAY WAY WAY more easy to develop for. If you want to do something when you click on something else and you're adjacent, use `interact_with_atom` If you want to do something when you click on something else and you're not adjacent, use 'ranged_interact_with_atom` This does result in some instances of boilerplate as shown here:  But I think it's acceptable, feel free to oppose if you don't I'm sure we can think of another solution ~~Additionally it makes it easier to implement swing combat. That's a bonus I guess~~ ## Changelog 🆑 Melbert refactor: Over 200 item interactions have been refactored to use a newer, easier-to-use system. Report any oddities with using items on other objects you may see (such as surgery, reagent containers like cups and spray bottles, or construction devices), especially using something at range (such as guns or chisels) refactor: Item-On-Modsuit interactions have changed slightly. While on combat mode, you will attempt to "use" the item on the suit instead of inserting it into the suit's storage. This means being on combat mode while the suit's panel is open will block you from inserting items entirely via click (but other methods such as hotkey, clicking on the storage boxes, and mousedrop will still work). refactor: The detective's scanner will now be inserted into storage items if clicked normally, and will scan the storage item if on combat mode /🆑	2024-06-11 21:58:09 -07:00
John Willard	aace5f46f4	You can do more things while floored (#81641) ... ## About The Pull Request While on the floor, you can: - Use the UIs of Atmos machinery (except thermomachine and bluespace gas vendor), Holopads, Crayons (spray cans too), radios, and Disposal bins - Close extinguisher cabinets with Right-Click - Click and drag yourself onto a photocopier to climb onto it. I also changed all instances of ``ui_status`` to have all the args it's being passed, I was messing with it a bit but it's gonna be for a later PR. ## Why It's Good For The Game It's an extra layer of harmless realism, also nice QoL for people who do not have functional legs and do not have a wheelchair. ## Changelog 🆑 qol: You can use atmos machines, holopads, crayons, spray cans, and disposal bins while floored. fix: You can close extinguisher cabinets while floored. fix: You can climb onto a photocopier from the floor. /🆑	2024-02-26 18:34:20 +01:00
LemonInTheDark	ae5a4f955d	Pulls apart the vestiges of components still hanging onto signals (#75914) ... ## About The Pull Request Signals were initially only usable with component listeners, which while no longer the case has lead to outdated documentation, names, and a similar location in code. This pr pulls the two apart. Partially because mso thinks we should, but also because they really aren't directly linked anymore, and having them in this midstate just confuses people. [Renames comp_lookup to listen_lookup, since that's what it does](https://github.com/tgstation/tgstation/commit/102b79694fa8eb57ecf7b36032616a9e368ccced) [Moves signal procs over to their own file](https://github.com/tgstation/tgstation/commit/33d07d01fd336726b4f6f6f1b61bb0b3f11a00dc) [Renames the PREQDELETING and QDELETING comsigs to drop the parent bit since they can hook to more then just comps now](https://github.com/tgstation/tgstation/commit/335ea4ad081ec63c42cfa05856e582cca833af6e) [Does something similar to the attackby comsigs (PARENT -> ATOM)](https://github.com/tgstation/tgstation/commit/210e57051df63f88dac3dd83321236da825aae5e) [And finally passes over the examine signals](https://github.com/tgstation/tgstation/commit/65917658fb8a1e7d28ae23c9437a583d646f0302) ## Why It's Good For The Game Code makes more sense, things are better teased apart, s just good imo ## Changelog 🆑 refactor: Pulled apart the last vestiges of names/docs directly linking signals to components /🆑	2023-06-09 06:14:31 +00:00
AnturK	4d6a8bc537	515 Compatibility (#71161) ... Makes the code compatible with 515.1594+ Few simple changes and one very painful one. Let's start with the easy: * puts call behind `LIBCALL` define, so call_ext is properly used in 515 * Adds `NAMEOF_STATIC(_,X)` macro for nameof in static definitions since src is now invalid there. * Fixes tgui and devserver. From 515 onward the tmp3333{procid} cache directory is not appened to base path in browser controls so we don't check for it in base js and put the dev server dummy window file in actual directory not the byond root. * Renames the few things that had /final/ in typepath to ultimate since final is a new keyword And the very painful change: `.proc/whatever` format is no longer valid, so we're replacing it with new nameof() function. All this wrapped in three new macros. `PROC_REF(X)`,`TYPE_PROC_REF(TYPE,X)`,`GLOBAL_PROC_REF(X)`. Global is not actually necessary but if we get nameof that does not allow globals it would be nice validation. This is pretty unwieldy but there's no real alternative. If you notice anything weird in the commits let me know because majority was done with regex replace. @tgstation/commit-access Since the .proc/stuff is pretty big change. Co-authored-by: san7890 <the@san7890.com> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>	2022-11-15 03:50:11 +00:00
Watermelon914	4f56b365a4	Improves proccall admin circuit component. Adds the option to not resolve weakrefs for set variables and proccall admin circuit components. (#64564) ... * Improves proccall admin circuit function	2022-02-12 15:29:24 +01:00
Watermelon914	6e2de00ab4	Fixes an issue with tags for mobs not properly being handled correctly and adds logging to admin circuits (#64821) ... Tags would bug out due to how the 'Save Shell' component would copy all the variables on an object except a few restricted ones, though this proved to be very buggy. The duplicator part has been removed and more proper logging has been added. To compensate for the duplicator part being removed, admin circuit display names will now replace the entire name of the shell.	2022-02-11 01:06:35 -08:00
Jeremiah	9c6fdb567d	TGUI list conversions + bug fixes (#63354) ... About The Pull Request Converts more inputs to TGUI. Possibly all user-facing input lists in the game. Did any surrounding text/number inputs as well Added null choice support so users can press cancel. Added some misc TGUI input fixes Fixed custom vendors while I was there I refactored a lot of code while just poking around. Primarily, usage of .len in files where I was already working on lists. Some code was just awful - look at guardian.dm and its non use of early returns If there are any disputes, I can revert it just fine, those changes are not integral to the PR. Why It's Good For The Game Fixes #63629 Fixes #63307 Fixes custom vendors /again/ Text input is more performant. Part of a long series of TGUI conversion to make the game more visually appealing Changelog cl refactor: The majority of user facing input lists have been converted to TGUI. refactor: Tgui text inputs now scale with entered input. fix: Many inputs now properly accept cancelling out of the menu. fix: Fixes an edge case where users could not press enter on number inputs. fix: Custom vendor bluescreen. fix: You can now press ENTER on text inputs without an entry to cancel. /cl	2021-12-31 11:07:28 +13:00
Y0SH1M4S73R	9653fa06e0	save shell component properly loads shells that come with their own circuit (#63628) ... Attempting to load a BCI or circuit MODsuit module with the save shell component yields an empty circuit. This PR fixes that by making the save shell component check for and delete any pre-existing circuit in the loaded shell.	2021-12-26 22:37:29 +00:00
Watermelon914	44a2af780d	Integrated the component printer into the integrated circuit UI. You can now link integrated circuits to component printers (#62287) ... Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>	2021-10-28 11:42:57 -07:00
Y0SH1M4S73R	a8e01da16f	Adds 2 new signals, adds pre/postattack_secondary signals to circuit signal handler presets (+a proccall component fix) (#62233) ... Adds COMSIG_ITEM_AFTERATTACK_SECONDARY and COMSIG_MOB_ITEM_AFTERATTACK_SECONDARY signals, which are both called by item/proc/afterattack_secondary. Adds COMSIG_ITEM_PRE_ATTACK_SECONDARY and COMSIG_ITEM_AFTERATTACK_SECONDARY to the list of circuit signal handler presets. The proc call, set var, and spawn atom components will resolve any weakrefs passed to them in their parameter port, seeing as the list literal component now converts datums into weakrefs.	2021-10-21 12:41:22 +01:00
Watermelon914	0ebf4891ad	Fixes bugs with admin circuits, expands upon some admin circuit components and fixes duplicator runtiming when a port doesn't exist. (#61948) ... Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>	2021-10-10 03:36:25 -07:00
Watermelon914	f6dfff674f	Fixed animating filters with circuits and added special signal ports for instant circuit execution. (#61851) ... Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>	2021-10-08 05:29:59 -07:00
Watermelon914	d15b305527	Refactors the list datatype to support composite lists. Adapts a lot of circuits to be able to properly use composite lists. Adds the dispenser shell (#61856) ... Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com> Co-authored-by: Colovorat <35225170+Colovorat@users.noreply.github.com>	2021-10-06 22:51:36 -07:00
Jordan Brown	765c7840e2	[s] Cleanup escalation unsafe procs (#61905) ... Fixes admins spawning in atoms and datums without the DF_VAR_EDITED flag	2021-10-06 13:12:50 +01:00
Y0SH1M4S73R	5fc3aa5b3d	Adds Animation and Filter Components for Admin Circuits (#61766) ... Adds a selection of components for animating atoms and manipulating filters. Makes animating atoms and filters using circuits more intuitive. Also Watermelon planned to make these but was too busy with other circuit QOL stuff and asked me if I would be willing to do it.	2021-10-01 21:00:02 +01:00
Y0SH1M4S73R	b7ed43d7a8	Adds a Datum port type for Admin Circuits (#61582) ... Admin circuit components were limited in their utility due to the setvar, getvar, proccall, and signal handler components only being able to operate on atoms. I have improved them by adding the datum datatype, which is used exclusively by the aforementioned components in place of the atom datatype their target port currently uses. Furthermore, an option for the expected output type has been added to the getvar and proccall components. This option defaults to any.	2021-09-22 08:04:05 +01:00
Watermelon914	9295f0d5bd	[s] Fixed admins being able to bypass proccall protections via remote sdql and circuits. (#61482) ... About The Pull Request Admins can bypass IsAdminAdvancedProcCall checks by using these methods of proccall because proccall protection is kinda dumb. This has been tweaked so that there is proper proccall protection for these methods of proccall. Code is hacky, but there's not much of a choice if we want procs to be properly protected from admin proccalls from any sort of remote source. If anyone has a better idea on how to implement this, feel free to hit me up. We need a special global mob that handles proccalls from sources that may not have a usr/client to refer back to. IsAdminAdvancedProcCall() relies usr being defined, so if no usr is defined, then this will always return false. This has been adjusted so that proccalls without a usr/client to refer back to will instead set usr to this special mob, which will then let the IsAdminAdvancedProcCall() return true by comparing whether usr == this special global mob. Why It's Good For The Game Admins can no longer bypass IsAdminAdvancedProcCall checks. Changelog cl admin: Admins are no longer able to bypass proccall protections using remote methods of proccalling. /cl	2021-09-22 12:09:16 +12:00
Watermelon914	515e9a9638	Adds admin input requests circuit component (#61403) ... Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>	2021-09-16 22:57:39 -07:00
Watermelon914	b6df5b0046	Admin signal handler circuit component (#61246) ... * Refactors how components are triggered and refactors how ports are ordered * Fixed trigger problems * Cleanup * Tweaked the code a bit * Fixes compile time errors * Fixes CI * Removed the callback datum that each port had. * Tweaked add_option_port * Fixed sleep problem * Uses regex datums and macros for text-manipulation (#61042) * bane component to element. nullrod now uses it for revenants. (#60640) * bane component to element. nullrod uses it for revenants. * TRUE to FALSE * Update field_generator.dm (#60918) * Automatic changelog generation for PR #60918 [ci skip] * More thermomachine fixes (#60998) fix error when typing the mole efficiency (instead of 0.1 it was 0.001, didn't push the change) fix infinite power consumption (capped) fix efficiency not being tied to laser tiers (issue connected to infinite power consumption) Also fix #61006 (Thermos not working at all because of the efficency stuff added recently) * Automatic changelog generation for PR #60998 [ci skip] * Automatic changelog compile [ci skip] * colossus-type projectiles no longer explode sealed vehicles (#61030) * Automatic changelog generation for PR #61030 [ci skip] * Automatic changelog compile [ci skip] * makes QDEL_IN() not runtime due to using a ternary operator on an arg, fixes several runtimes that happen every emitter firing (#61078) `QDEL_IN(new /obj/effect/projectile_lighting(T, light_color_override, light_range, light_intensity, instance_key), qdel_in > 0? qdel_in : 5)` the use of a ternary here in hitscan code got parsed as `qdel_in > 0? qdel_in : 5 > GC_FILTER_QUEUE ? WEAKREF(item) : item` and since qdel_in is 3 for emitters this was passing only the argument 3 into qdel() when the timer callback was invoked. so every tile that an emitter covers when it fires on master runtimes with a bad del exception and effect doesnt delete * Atmos re-Defined (#60855) This PR takes the atmospherics.dm in _DEFINES and split it into several files to lower the mess, increase readability and improve on the code for later uses Also added some docs here and there * Allows you to cancel TGUI alerts (#61072) This was requested by someone downstream. Some TGUI alerts offer two options e.g. (Kill Bob, Kill Janice), In byond alerts you'd be able to cancel by pressing the X, but tgui alerts don't support this. I've added an option to enable the normal X in the top right, so you can cancel out of alerts if you enable it. * tgui: Silicon Station Alerts (#61070) This PR unifies all Station Alert menus into one datum system. This also means that the old html menus will be converted to tgui, which is a case for cyborg and AI menus. All menus above differ very little, practically only by amount of type of alerts they show except for the AI menu, which also has access to cameras in the alert areas and knows number of the alert sources. * Automatic changelog generation for PR #61070 [ci skip] * Rewords the traitor panel's policy tooltip (#61098) Fulp's spacelaw isn't a suggestion, which makes the upstream comment in the tgui kind of an unintentional griffon. * Automatic changelog generation for PR #61098 [ci skip] * Many smart pipe fixes (#60981) * Smart pipes now actually go over smart pipes This was ostensibly the main feature of smart pipes, so should be fairly important Parentheses are technically not required around the |, but I think it's important to emphasise the importance of parentheses around bitwise operators as this was apparently broken since 3e8407c471 Also purge var/connections and var/connection_num, since it's literally only used for a `machine.connection_num < 3` check which is completely redundant, and we already build a bitfield tracking active directions. * Smart pipes bridge over straight pipe types This improves bridging to now go over most devices where possible, letting you, for example, bridge over a perpindicular layer adapter. * Pipe construction: Better documentation Cleans up smart pipe documentation to match what's actually happening. No functional changes. * Skip pipes on different layers earlier This prevents a pipe being made into a bridge perpindicular to a pipe on a completely different layer, then failing to turn into a bridge perpindicular to a relevant pipe. * Pop superfluous parentheses * Prevent creation of stub pipes Setting the RPD to create a smart pipe that can only connect in one direction would cause it to create invisible pipes that would still block the placement of other pipes. * The RPD can now reprogram smart pipes The RPD can only affect smart pipes in directions that they are not currently connected to. This makes it easier to adjust designs after the fact, including prevening round-start pipes from eagerly linking to a grey layer adapter. * Even smarter pipes No more turning into bridge pipes. We now only try to be smart if placement would fail, and we do our best to find a solution whenever there is at least one smart pipe involved, regardless of whether we're currently placing a smart pipe or not. We never reconfigure any directions that a smart pipe is currently connected, and we never reconfigure a smart pipe to have one or less usable directions. * Smartly go across perpindicular layer adapters Also works when we're placing a layer adapter perpindicular to a promiscuous smart pipe * Pipes: Factor out loops and some bitfiddling Create and use helpers with documented purposes over inline bitfiddling, when it makes sense. Many loops and switch statements were recreating information that was already there. Some relationships between pipe bitfield states were already assumed. This centralises the functionality that relies upon these assumptions, places them where the bits are defined, and documents them. Rewrite some bitwise operations to be more idiomatic. * Smart pipes: Debugging output I normally clean history before pushing changes to any project, but I feel like this should be saved. * Revert "Smart pipes: Debugging output" This reverts commit bb3aa76cf6d08e4d0951113a26fc9d48b6bc1735. * Add trailing comma The lack of this was making the linter sad * Automatic changelog generation for PR #60981 [ci skip] * Small Spider Balance Changes and Tarantula QoL (#60505) * Add Sealed Webs * Add Sealed Web Icon * Spider Changes * Update this dumb var * Make Broodmothers spawn in the same place * Remove unused var * Re-Add Sealed Web Sprite * Automatic changelog generation for PR #60505 [ci skip] * Refactors and improves SDQL spells (#60972) SDQL spells have been improved in several ways: - The behavior of executing SDQL spell queries using datums has been migrated to a component - Projectile SDQL spells can now fire any subtype of /obj/projectile - Touch SDQL spells can use any subtype of /obj/item/melee/touch_attack - More robust parse error detection - Parse errors while loading a file from json are displayed in a modal window, with the option to load whatever parts of the spell were correctly parsed (be forewarned, scrollable sections are scuffed, and the ones that appear in the parse error modal can only be scrolled through by drag-selecting the text within them) - Fixes a bug with the names of variables within lists - Compartmentalizes SDQL spell code into several .dm files. Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> * Automatic changelog generation for PR #60972 [ci skip] * Automatic changelog compile [ci skip] * Give admins the ability to put a popup notice for players in tickets (#61010) Admins can now give players a popup if they are not responding to tickets. Popup is cleared when player replies or ticket is resolved/closed. As more and more of the chat screen is made irrelevant, new players read it less and less. This means that a lot of new players are ignoring ahelps, which is something I've encountered myself. * Automatic changelog generation for PR #61010 [ci skip] * Greentexting as a traitor hardcore random now gives you hardcore random points (#60957) Every time a traitor greentexts with hardcore random, it runtimes and returns. I think it's because of the escape alive objective. I've tested this before and after several times just to be completely sure this fixes it. * Automatic changelog generation for PR #60957 [ci skip] * Objective-specific equipment will always be given. (#60789) * Automatic changelog generation for PR #60789 [ci skip] * Basic Mobs: the cooler simple mobs that run on datum AI. (With reworked cockroach AI as proof of concept) (#60694) Simple_animals / mobs are the biggest lie in this code-base. They're far from simple and have an extreme god-object problem. Especially when you get to /hostile, where there is so many procs, vars, and what not, that you can't make any interesting additions without snowflaking the hell out of the code. This PR hopes to help kill this problem by introducing a new /living subtype, /living/basic. The idea of this refactor is to slowly start moving all old simple_animals to this new system, moving over behaviors like charging and more extravagant mobs like megafauna over bit by bit similar to how newfood was implemented. One of the other big goals of this refactor is to move many of the fringe simple animal behaviors into either AI datums, or components/elements. (Some of which still needs to be done in this PR). As a proof of concept, I created the base mob/living/basic, and moved cockroaches over to the system. Since cockroaches have both a passive, melee and ranged mob. This PR does slightly affect balance as the behavior isn't 1-on-1 due to it no longer running on the janky /hostile behavior, but I tried to keep the effects to a minimum, and the glockroach and hauberoach are not spawnable through many means as far as I know. * Automatic changelog generation for PR #60694 [ci skip] * Naive works correctly on simple animals (#61088) About The Pull Request Innocent clowns now perceive dead animals as asleep, the same as humans. * Automatic changelog generation for PR #61088 [ci skip] * fixes misspellings of "aggressive" in a few areas. (#61092) Fixes the spelling of "aggressive" in a few items, comments and a define. * Automatic changelog generation for PR #61092 [ci skip] * Adds Watermelon914 to wiremod codeowners (#61120) Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com> * Gives brainwashed victims an antag hud (#61077) Gives brainwashed victims an antag hud icon * Automatic changelog generation for PR #61077 [ci skip] * Fix female uniforms not updating color correctly (#61040) Fixes #59235, fixes #59297, fixes #61012, and other similar bugs. The global list of female uniforms now appends the greyscale color of the uniform to the index/name, so all GAGS female uniforms are unique and handled correctly. * Automatic changelog generation for PR #61040 [ci skip] * Automatic changelog compile [ci skip] * fixes translocation define to actually mean translocation (#61105) * Automatic changelog generation for PR #61105 [ci skip] * Fix Sparkler typo (#61102) * Automatic changelog generation for PR #61102 [ci skip] * Fix grammar when attacked by an unknown assailant (#61103) * Automatic changelog generation for PR #61103 [ci skip] * fixes wormhole jaunter portals floating in space. (#61089) * Automatic changelog generation for PR #61089 [ci skip] * Downgrade Juke to 0.8.1 (#61110) A light version of the revert to help builds work on TGS3. (TGS3 builds were locking up on live, causing servers to be unable to testmerge or update things because of something to do with the recent juke build. I don't into the build tool, otherwise I'd be more clear) * Get your protein fix here (for monkey meat). (#60696) Meat steaks now have the material flag to un-link from from material effects, meaning that monkey meat will now have the proper nutrients and reagents it was intended to, primarily that monkey meat will have protein for cytology purposes. (Basically, the meat mat was not adding a food component, but then trying to remove "any" food component regardless of a material_no_effects flag. Kinda a mess, and maybe this could be done in an event based way, but this is a real sane fix. The hard part was tracking down the error anyway. Kudos fictional arcane who will read this commit message) * Automatic changelog generation for PR #60696 [ci skip] * Update balloon_alert.dm (#61035) balloon alerts now have the RESET_COLOR|RESET_ALPHA|RESET_TRANSFORM appearance flags. * Automatic changelog generation for PR #61035 [ci skip] * Fixes antag panel runtime (#61115) uplinks don't always exist for traitors! * Automatic changelog generation for PR #61115 [ci skip] * cannon recipe fix (#61014) Cannons now accept all oxygen tanks, not just red ones * Automatic changelog generation for PR #61014 [ci skip] * Hostile mobs will always face their targets when shooting. (#61069) Added a face_atom call with targeted_atom as arg. * Automatic changelog generation for PR #61069 [ci skip] * Corrects a possessive case in the fluff text of a paper note found in an ice planet ruin. (#61066) Corrected a possessive case in the text of the ancient note found in the ice library ruin. * Automatic changelog generation for PR #61066 [ci skip] * Fixes the anti-drop implant not removing the nodrop trait on held items if they're somehow dropped. (#61068) Title. I have used comsigs to do it. Also I have improved the logic of its ui_action_click. * Automatic changelog generation for PR #61068 [ci skip] * Fixes floored mobs (paraplegia, missing limbs) not being able to stand up in zero G for real. (#61054) Added a old_movement_type argument to the COMSIG_MOVETYPE_FLAG_ENABLED and COMSIG_MOVETYPE_FLAG_DISABLED signal, fixed the check for zero g movespeed and locomotion traits removal and made some statements easier to understand. * small refactor to can_interact() so that borg range is fully respected (#60693) Its a relatively small refactor that changes the previous machinery "can_interact()" proc that literally did a full override despite half of their checks already existing in not one, but TWO parent procs, so i removed the redundant checks, added callbacks to its parents and then added the cyborg range check on the can_interact_with() itself. in doing so i also moved the interaction range var from silicons only, to mobs as a whole and defaulted it to a single tile, silicons override it to 7 (so pAIs and borgs like before) but then set AI and AI.eye to "null", because i have a check in can_interact that if there is no range set, then the range is effectively unlimited. and i even added code for when AI is carded and their wireless transmission is disabled it sets their range to "0" aka, it has no range to do anything even if it could this was really complicated for me so despite my extensive testing it probably would be a bad thing if any of you want to test my code yourself to ensure there isnt a bug with this (theres no runtimes ive come across) note: i did a lot of searching and going through machinery to ensure i caught all the little snowflake overrides and added can_interact() checks to them, but i may have missed one or two things, especially maybe a altclick or ctrlclick somewhere, however i believe i caught most of them one nice side effect of this refactor is that you can actually set another mobs range to something other than 1 tile and they can interact at range, rather than only silicons getting this ability, an admin could VV a human to have a 3 tile arm reach as a meme if they want * Automatic changelog generation for PR #60693 [ci skip] * lava and weather immunities refactor (also jump boots fix) (#61003) In remembrance of all those people who used jump boots to cross lava unaware of an issue c*ders wouldn't fix.... EDIT: This is now a lava and weather immunities refactor: Weather immunities are now status traits since they have a multitude of sources (especially for lava) which might conflict with one another otherwise. The lava burn_stuff proc has also been been refactored in different procs, mostly because of that snowdin subtype with inconsistent, old checks. Weather datums should now use can_weather_act instead of weather_act to check if something can be affected by weather or not, as they should. All movables can protect contained mobs if they have the relative weather immunity traits. This works at any contents depth. No more snowflake weather_protection variable for closets. Removed the weather_immunities list from living mobs (simple animals still have it but it's only for traits assignment on init because way too many child types lack the immunities of their parents). Removed some unused defines. Renamed some variables as per guidelines. It has been tested. And yea, jump boots fixed because that's the original scope of this PR. (Initially just made throwing make you fire immune, that was blocked because it breaks perma stuff, instead it ended up be a refactor to make jumpboots usable with weather immumnity stuff * Automatic changelog generation for PR #61003 [ci skip] * Fix staff of lava not terraforming lava (#61096) Lava staffs were not terraforming regular lava into empty tiles. This is because it was only checking to see if the lava type was the same weak lava the staff spawns. It has now been fixed to check for all lava types. * Automatic changelog generation for PR #61096 [ci skip] * Admins Can Once Again Click Ban Panel Categories to Toggle Their Checkboxes (#60904) * Re-Adds Header Checkboxes - Ban Panel categories can now be clicked to click all the checkboxes in their category - Adds a new js method called header_click_all_checkboxes whichs clicks all the checkboxes whose class is the hidden checkbox's name Re-introduces a function that was lost with #60578 (6c4134d1ea) , closes #60903 (Admins being unable to click on the ban category and check all subcheckboxes). The method was largely copied, but was changed to comply with the toggle_other_checkboxes() method introduced with the aforementioned PR by replacing a .checked assignment with a .click() call to ensure that duplicate entries are properly marked Admins can now click categories to more easily ban people from all entries in that category. Demonstrated below to show that checkboxes are being toggled correctly in all relevant categories Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> * Automatic changelog generation for PR #60904 [ci skip] * fixes html execution with circuits (#61143) Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com> * adds missing APCs to supermatter engine room area (#61046) * Automatic changelog generation for PR #61046 [ci skip] * the Mainetening - Maint area fixes (#61084) * Automatic changelog generation for PR #61084 [ci skip] * Tramstation stampening & additional departmental resupplies (#61129) * lawstamp, aicore module, bookmanuals, xenobio/cyto beakers, RnD experiscanners & some equipment * nevermind, no beakers & glasses/masks for RnD for now * fixed a non-functional shutters tram underpass button * Automatic changelog generation for PR #61129 [ci skip] * Automatic changelog compile [ci skip] * Fixes being able to spam ghost role notifications. (#61085) There are methods that let players spam the everloving shit out of ghosts with BONG BONG BONG BONG BONG BONG BONG etc. through being able to constantly poll ghosts for roles with no restriction or cooldown. Examples are laughter and slaughter demon antag_spawners. It makes no sense to be able to concurrently poll for the same mob. As a result, I've now added a guard against this. The proc has been given a static list of mobs it's polling for ghost roles for. If it's already polling for ghost roles for a given mob, then it just early returns with an empty list, otherwise it adds the mob to the static list when the poll starts and removes it when the poll ends. I've also done a little cleanup in var names and the proc name, with a find-and-replace done. There weren't many things calling it and none used named keywords in the args so should be fine. There is also poll_candidates_for_mobs (also included in my cleanup) - This proc is basically only called by admins via sentience balloons and they have their own guards against spamming (the balloon pops and thus can only be used once) Also fixes an issue in /mob/living/silicon/robot/proc/replace_banned_cyborg() where incorrect args were used in the proc call to poll for candidates. * Automatic changelog generation for PR #61085 [ci skip] * fixes a dumb error with traitor flavor AGAIN (#61119) going postal now uses the correct ui theme and isn't confused with tiger cooperative * Automatic changelog generation for PR #61119 [ci skip] * Fix pass-by-ref issue causing ID card access lists to be incorrectly mutated. (#61117) stored_card.GetAccess() eventually leads to /obj/item/card/id/GetAccess() being called. This proc returns the actual access list associated with the ID card rather than a .Copy() of it. As a result, the line total_access = stored_card.GetAccess() is storing a reference to the stored_card's actual access list. total_access |= card_slot2.stored_card.GetAccess() is then mutating the first ID card's access list via the reference. The result? When /obj/item/computer_hardware/card_slot/GetAccess() is called with 2 ID cards in a modular computer, the second ID card gives all of its accesses to the first ID card thanks to the |= operation. There are a number of ways around this. Some pieces of code do var/list/thing = list() and then |= every GetAccess() since it's guaranteed to return a list. This creates new lists instead. However, I feel GetAccess() for ID cards really shouldn't be returning a ref to the list. Instead, it now returns a Copy() of the list and code implementing behaviour using GetAccess() doesn't need to worry about list mutation at all. * Automatic changelog generation for PR #61117 [ci skip] * changed minor typo in ventcrawling.dm (#61104) changed "You out from the ventilation ducts." to "You scramble out from the ventilation ducts." to match the visible_message. * Automatic changelog generation for PR #61104 [ci skip] * Adds a stack trace for objs with <=0 integ taking damage (#61079) Adds a stack_trace to <=0 integ objs taking damage so instances of people relying on this early return prior can be identified * Fixes some unnecessary attack chain cancels (#61038) Replaced attack chain cancels on some objects with parent calls * Automatic changelog generation for PR #61038 [ci skip] * Fixes a plasmaman autoignition oversight (#61083) Adds a check to see if there are any organic plasmaman limbs or any plasmaburnt limbs (which are obtained by exposure to plasma lava on icebox) before igniting plasmemes so that a plasmeme with fully replaced limbs can stop burning * Automatic changelog generation for PR #61083 [ci skip] * Fixes moths infinitely eating most clothing (#61082) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR #61082 [ci skip] * Automatic changelog compile [ci skip] * Fixed the Bloodcrawl spell not ejecting users if somehow lost. (#61076) * Automatic changelog generation for PR #61076 [ci skip] * large refactor of machine/power code to cut down on processing time and wasted lists (#60317) original pr here: #59789 (Closed because he didn't think it was good enough) came back to this because i realized that all machines were area sensitive, meaning they had a list with at least a reference to themselves (assuming they arent in the contents of another movable which most arent) for the purposes of handling power differences when their area changes pipes are machines there are ~14k machines and ~6k pipes i made this problem worse with a recent pr by making it a nested list so i needed to track what machines needed power, and this pr had work already done that could be used for that purpose. now machines that have use_power == NO_POWER_USE do not have this extra memory overhead for no reason currently every machine that uses power draws that amount from its area from a dynamic channel via auto_use_power() which is called every SSmachines fire(), then in apc/process() the area's dynamic power draw is reset and the power is used. with static power its not calculated then reset every loop, its just taken from the grid. so now machines handle updating their static power usage from their current area (this doesnt touch power machines that require a wire connection). in order to allow this, use_power, idle_power_usage, and active_power_usage have setters to track state correctly and update the static power usage on the machines current area and handle area sensitivity. also goes through a lot of heavy abusers of SSmachine processing time and tries to make it faster. makes airalarm/process() into a signal handler for COMSIG_TURF_EXPOSE since air alarms only need to process for changes. Why It's Good For The Game SSmachines isnt the heaviest hitter in terms of total cpu and certainly not in terms of overtime, but its not a lightweight. it frequently takes > 50ms to complete a run and seems to be in the top 5 or so of subsystem costs looking at some round profilers also gets rid of a few thousand lists since every pipe no longer has two useless lists each (and any other machines that dont use power) Love ya kyler Co-authored-by: Rohesie <rohesie@gmail.com> * Update datum_traitor.dm (#61132) * Automatic changelog generation for PR #61132 [ci skip] * Vents and scrubbers get unique name tags again (#61133) You used to be able to mouse over a vent or scrubber to see its ID tag, in order to match it to its entry in an air alarm panel. However, this id tag is currently missing from the name. * Automatic changelog generation for PR #61133 [ci skip] * Free up smart pipe direction on disconnect (#61135) Previously, a smart pipe that was attached in a given direction would continue to hog that direction even if the attached piece was removed. * Automatic changelog generation for PR #61135 [ci skip] * Update MAPS_AND_AWAY_MISSIONS.md to latest changes (#61024) Indicates what are the current maps in rotation and adds all the outdated, removed or not in rotation maps for record keeping. * [s] Audits object say() uses to make handling text more safe (#61147) Made all say()s deal with encoding, audited all uses of say() to prevent double encoding or like, manually inserting span(). I left some stuff without sanitize that only draws from the code, since it's hell to clean up otherwise. That and I let admins do whatever the fuck they want * Using a soulstone on a construct shell no longer destroys it and the shade if no option is taken. Plus code improvement (#60982) I have split the multi-purpose transfer_soul proc into three smaller procs, each with their own purpose, renamed some variables accordingly to guidelines and added some checks such as CanReach where opportune. * Automatic changelog generation for PR #60982 [ci skip] * Fix dir delay when riding something and turning (#61056) Fixed invalid arguments being passed into vehicle_moved * Automatic changelog generation for PR #61056 [ci skip] * assorted menu fixes (#61023) * Automatic changelog generation for PR #61023 [ci skip] * Adds instant circuit execution * Adds instant circuits and adds an event listener component to airlocks * Added signal handler circuit components * Changes the scrollbar to be on the dynamic sections instead of on the browser as a whole * Fixed all option ports being null when created * Fixed 0 not working when inputted into an any type * Fixes bugs with qdelling * Adds global signals * Fixes to the duplicator for signal_handler * Addressed comments * Fixes bugs * Fixed linter * Update FundamentalTypes.js * Update Dropdown.js * Addresses comments Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com> Co-authored-by: Rohesie <rohesie@gmail.com> Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com> Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com> Co-authored-by: tgstation-server <tgstation-server@tgstation13.org> Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com> Co-authored-by: Changelogs <action@github.com> Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com> Co-authored-by: Kylerace <kylerlumpkin1@gmail.com> Co-authored-by: AMonkeyThatCodes <20987591+AMonkeyThatCodes@users.noreply.github.com> Co-authored-by: Arkatos1 <43862960+Arkatos1@users.noreply.github.com> Co-authored-by: esainane <esainane+github@gmail.com> Co-authored-by: IndieanaJones <47086570+IndieanaJones@users.noreply.github.com> Co-authored-by: Y0SH1M4S73R <legoboyo@earthlink.net> Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Co-authored-by: YakumoChen <king_yoshi42@yahoo.com> Co-authored-by: aaaa1023 <74441292+aaaa1023@users.noreply.github.com> Co-authored-by: dragomagol <66640614+dragomagol@users.noreply.github.com> Co-authored-by: Shroopy <delyth@shroop.net> Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com> Co-authored-by: 小月猫 <alina.r.starkova@gmail.com> Co-authored-by: Tim <timothymtorres@gmail.com> Co-authored-by: Beatrice <83368538+SpaceDragon00@users.noreply.github.com> Co-authored-by: Sealed101 <75863639+Sealed101@users.noreply.github.com> Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk> Co-authored-by: magatsuchi <88991542+magatsuchi@users.noreply.github.com> Co-authored-by: ArcaneDefence <51932756+ArcaneDefence@users.noreply.github.com> Co-authored-by: GoblinBackwards <kinggreenyoshi@gmail.com> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: BraveMole <bsouchu@gmail.com> Co-authored-by: Krysonism <49783092+Krysonism@users.noreply.github.com>	2021-09-16 16:13:38 +03:00
Watermelon914	6497a97a89	Admins can now save custom shells (#61307) ... Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>	2021-09-16 00:11:56 -07:00
Watermelon914	126411f405	Refactors how components are triggered and refactors how ports are ordered (#60934) ... Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>	2021-09-03 02:22:39 -07:00
Gurkenglas	e0fad671fd	Input ports now connect to multiple output ports. Remove combiner. (#60494) ... * tgui bsod * debug disconnections * prelim * recomment * set_value -> put ._. * DAMN IT * reinsert subsystem * prepare * unditch signals * remove combiner * remove combiner some more * how did router.dm get here? deleting. * These two COMSIGS should be one. * critical typo * inline cast * have your signals * Have your set_input & set_output. * make compile * upgrade save/load to n-to-n-wires * have your documentation * have your unsafe proc * pay no attention to the compile errors * unlist the ref * paste my for block back in ._. * fix manual input * oops pushed too soon * Have your !port.connected_to?.length Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com> Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>	2021-08-11 18:48:29 +03:00
Watermelon914	0deb859b3c	Moves most circuit defines to files (#60705) ... Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>	2021-08-07 16:16:18 -07:00
Watermelon914	13296f5f74	Refactors port types completely and adds the option type. Refactors options to use this new type (#60571) ... Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>	2021-08-04 09:06:48 -07:00
Watermelon914	96f1c2abae	Adds the bare minimum admin components and allows admins to define list literals. (#60240) ... Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com> Co-authored-by: carshalash <carshalash@gmail.com> Co-authored-by: tgstation-server <tgstation-server@tgstation13.org>	2021-08-02 01:50:06 -07:00