* Fixes a bug where chunky fingers were preventing roundstart PDA use (#71301)
## About The Pull Request
Fixes#71180#70422 Removed the !allow_chunky check introduced by #66358 ,I've
re-added it.
I've tested this and can confirm PDAs are usable again while modular
consoles remain unusable.
## Why It's Good For The Game
Fixes a rather frustrating bug
## Changelog
🆑
fix: Roundstart PDAs can once again be used by people with chunky
fingers.
/🆑
* Fixes a bug where chunky fingers were preventing roundstart PDA use
Co-authored-by: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>
* Removes Syndicate cyborg's messaging app (#71134)
## About The Pull Request
Syndicate borg apps weren't changed to cyborg subtypes when those were
added in.
## Why It's Good For The Game
Closes https://github.com/tgstation/tgstation/issues/71116
## Changelog
🆑
fix: Syndicate Cyborgs no longer have the PDA messaging app.
/🆑
* Removes Syndicate cyborg's messaging app
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
* Strays away from GLOB.machines when possible (#71100)
## About The Pull Request
This replaces needless GLOB.machines with more precise lists whenever
one existed, plus adding a new one for CTF machines.
## Why It's Good For The Game
GLOB.machines holds every single /obj/machinery in the game, so checking
the whole list for stuff is pretty big. This aims to cut that down by
using smaller lists whenever possible. I also gave CTF a new list
because it checked machines very often.
## Changelog
Nothing player facing.
* Strays away from GLOB.machines when possible
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
* Removes tablet cell parts (#71078)
## About The Pull Request
Removes cell parts and cell part cells, now tablets directly stole a
power cell in them, and uses regular stock cells like every other
machine in the game. This also makes it less confusing because people
are more used to stock cells over computer cells. Because cells
generally hold more power than computer ones, I bumped up the active
power usage from 50 to 75.
## Why It's Good For The Game
We are nearly finished removing all parts, holy cr*p
## Changelog
🆑
balance: Tablets now use regular cells instead of computer cells.
balance: Tablets no longer need a power cell component to hold power
cells.
/🆑
* Removes tablet cell parts
* Feex
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
* Re-adds the clown's PDA virus honking (#71035)
## About The Pull Request
Re-adds the Clown's virus disk's ability to make machines, airlocks, and
computers honk, which was removed in the transition from PDA to modular
computer.
Fun fact: This was broken for a long time, I had fixed it in
https://github.com/tgstation/tgstation/pull/64443 before it got
accidentally wiped off the face of the earth.
To anyone who isn't aware:
- Clown's virus disk has 5 charges
- You can use these charges to install viruses in computers, airlocks,
and machines if they're screwed open (computers dont need to)
- This will make them honk when used.
- You can get charges back by slipping people with the PDA while the
virus disk is installed in it (which it is by default)
- The max charges you can get at once is 5.
## Why It's Good For The Game
A feature that was lost in the PDA to modular computer transition, now
re-added. It's a cool feature and I personally would use it if I played
bad jobs.
Things actually working is a 🛩️
## Changelog
🆑
fix: Clown PDA virus disk can once again be installed in machines,
computers, and airlocks.
/🆑
* Re-adds the clown's PDA virus honking
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
* Easy's Super Omega "unarmed strike based species var moved to limbs" refractor, unarmed strike striking with specific body parts rather than it just being flavor, and brain based attacking limb selection extra chunky edition. And also bodypart traits.
* Removed all the conflicts, and started converting all the arms and legs to the proper typepaths
* Actually makes the game compile :)
* Makes the maps compile too!
* Early mirror of #71143 because it's more relevant to us
Co-authored-by: itseasytosee <55666666+itseasytosee@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
* NtOS Emojipedia - PDA Emoji Messaging For All (#70829)
An Emojipedia app has been added to tablets, given to Mimes and Curators by default, allowing anyone to know all emojis. Additionally, emojis can be used in tablets by every job now.
* NtOS Emojipedia - PDA Emoji Messaging For All
* update emoji list to be valid
* animated emojis
Co-authored-by: san7890 <the@san7890.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
* Fixes the messenger app not being responsive when certain buttons are clicked (#71077)
## About The Pull Request
The buttons to toggle the ringer, to toggle the sending/receiving and
the button to see message history all stopped being responsive, because
the information they were changing when pressed was wrongly kept in
`ui_static_data()` rather than `ui_data()`. Now, they're back in
`ui_data()`, and behave as expected once again.
## Why It's Good For The Game
A non-responsive TGUI interface is probably the saddest thing to see.
## Changelog
🆑 GoldenAlpharex
fix: SpaceMessenger was now updated to 6.4.8, bringing you more
responsiveness than ever (so long as ever is shorter than seven days
ago)!
/🆑
* Fixes the messenger app not being responsive when certain buttons are clicked
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
* Fixes detomatix's name (#71075)
## About The Pull Request
I accidentally replaced it with 'attacking_item' because i am demented
and can't stop abusing my clipboard.
## Why It's Good For The Game
🛩️
## Changelog
🆑
fix: Detomatix cartridges are no longer called attacking items.
/🆑
* Fixes detomatix's name
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
* Adds Station's Date To NTos Window (check the time+date on your tablet!) (#70754)
* The date and time is now displayed in NtOS tablets, showing the in-game date (540 years after current), bringing the feature from old PDAs over.
* Adds Station's Date To NTos Window (check the time+date on your tablet!)
Co-authored-by: san7890 <the@san7890.com>
* Add AltClick removes pAIs for tablets (#68251)
* Add AltClick removes pAIs
* Add context screentips for pAIs to tablets
* Fix screentip context syntax error
* Fix syntax error
* Merge remote-tracking branch 'upstream/master' into patch-10
* Refactor contextual screentips to work
* Fix runtimes
* Apply code review changes
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* Add balloon alert to tablet items
* Refactor screentips to be more robust
* Change add_context to be more robust
* Add more balloon alerts
* Some idiot set user to null so I gotta remove this
* Change pen screentip to display inserted item
* Add screentip to insert items
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* Add AltClick removes pAIs for tablets
Co-authored-by: Tim <timothymtorres@gmail.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* Fixes some inconsistencies with computers (#70679)
* Modular computers now have their initial name if they don't have an idenfitication and job, which previously meant they would have the name ()
* Removes MACHINE modular computer's process, because all it did was update the name, then call computer's process. Now it just does what every computer does, BUT UpdateDisplay on ITEM modular computers will now update the machine's name.
* Additionally, I moved the modular computer processor's New to an Initialize, and removed the shutdown_computer code, because we already register update_icon signal to update the computer's appearance, why do we need to do it twice?
* Fixes some inconsistencies with computers
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
* Misc PDA code improvements (#70555)
* How to conflict with PRs: A guide
* Removes unnecessary support for the now-removed job disks from Tablet's TGUI menu, and tablet's ui_act.
* Adds autodoc comments to computer files
* Removes the unused 'unsendable' var on computer files
* Generally improves code on tablets, now process isn't looping through every idle thread twice!
* Moves the check for program in idle_threads above checking if supported by hardware, because it's already running, so there's no need to check.
* eh
* revert a scipaper change
* Misc PDA code improvements
* updated contract_uplink
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Tastyfish <crazychris32@gmail.com>
* Removes a ton of unused tablet vars, re-organizes the rest (#70344)
* Removes a ton of unused vars, re-organizes the rest
Removes a ton of unused vars from Modular computers
Re-organizes the rest, and adds autodoc comments to most of them
Moved 2 vars (saved_image and invisible) from the tablet to the messenger app, since that's where it was used. I didn't see the point of having these vars be on every computer anyways, only PDAs have the app.
Renames Clown's honk virus var
Makes Messenger app's saved image, actually used.
* static list and NODECONSTRUCT_1 check
* oops
* Removes a ton of unused tablet vars, re-organizes the rest
* cryopod
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
* Modular computer fixes (#70606)
* Moves a lot of modular computer attackbys to the cpu instead, which is what handles it all. This allows their parts to be removed and the console deconstructed/repaired once again.
* Modular computer fixes
Co-authored-by: GoblinBackwards <22856555+GoblinBackwards@users.noreply.github.com>
* Fixes communication being nearly impossible (except over radio) when there's a null client in the global player list (#70404)
* Fixes communication being nearly impossible (except over radio) when there's a null client in the global player list
* Updates our modular play_vox_word() proc
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
* [NO GBP] Fix traitor PDA uplinks to be accessible by illiterate people (#70368)
* Illiterate people can now use a PDA in hand to open their uplink immediately if they are the owner of the uplink.
* [NO GBP] Fix traitor PDA uplinks to be accessible by illiterate people
Co-authored-by: Tim <timothymtorres@gmail.com>
* Fixes the formatting in the Messenger app's message history and makes the current ringtone appear in the input box when trying to change it (#70458)
* Changing your PDA ringtone now has your current ringtone in your input box, like the previous PDAs used to.
* The incoming Messenger messages are now HTML encoded in message history, allowing it to display apostrophes and such.
* The prompt to send a PDA message now shows you the person you're trying to send a PDA message to.
* Fixes the formatting in the Messenger app's message history and makes the current ringtone appear in the input box when trying to change it
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
* The curator's PDA now works in space (#70319)
* The curator's PDA is now long-ranged
The Curator's PDA is now long ranged and allows for it to be used while out in space.
I recently removed the modular computer parts that allowed PDAs to be upgraded to connect to NTNet while on different Z-levels, so thought this would be a good replacement since Curators are a space exploration job, so being able to still talk to other players or use the newscaster app while away, is something I think would be beneficial.
* The curator's PDA now works in space
* Gives vanguard PDA long range as well
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Tastyfish <crazychris32@gmail.com>
* Removes network cards and printers from tablets
* merge tablet_presets
* printer.dm should have been deleted, missed change
* update contractor tablet
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
* Removes AI and Charge parts from tablets, adds support for more later.
* merge conflict
* remove modular tablet loadout item
* fix SR maps referencing tablets, add clear PDA instead of modular tablet loadout
* remove pda loadout item
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
* Demoralization fixes (#69924)
* Demoralization fixes
Blind mobs will no longer be demoralized by posters and graffiti.
Illiterate mobs will no longer be demoralized by the words on posters.
Mobs will no longer be demoralized by posters & graffiti if it's too dark to see them.
Also makes can_read use reading check flags, one for literacy and one for light.
* Demoralization fixes
Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
* Fixes Signal Commander program breaking all signalers on default frequency (#69773)
* Fixes signalcommander program breaking all signalers on default frequency
* Fixes Signal Commander program breaking all signalers on default frequency
Co-authored-by: VexingRaven <msgerbs@users.noreply.github.com>
* [MDB IGNORE] APC controller and Power Monitor/AmpCheck fixes, aka How do I write PR titles (#69146)
About The Pull Request
bgug fix stuff
APC controller UI has its elements section'ed off. The backend has been redone to make the behaviour of the APC controller a bit less janky. The console should be more stable, and all the soul has been removed from the code and the UI.
before this PR stales out from nobody wanting to review my pr, I should probably outline what exactly changed:
APC controller consoles have had their APC code almost entirely reworked. They no longer have to hold a reference to the person using the controller currently, and APCs themselves no longer hold a reference to the controller, instead to the person directly. A lot of code was moved to APC themselves to make it a lot more stable.
APC controller used to call toggle_breaker without passing args, causing a runtime. Fixed in
Fixes the power flow control console not actually being able to toggle breakers #69343
APC controller UI has had the Window.Content tags moved up to the top component, and a lot has been sectioned off to make the UI more sane.
AmpCheck used to look for a wire on it's turf, or as a fallback look for the Area APC. A check to see if the APC has a terminal did so on a weakref, causing a runtime and preventing the program from ever finding a valid APC in it's area, making it show nothing. This has been fixed. On the other hand, the power monitor console did not store the ground wire or APC terminal as a weakref, this has been updated. As a fallback, if there are still no APCs in the powernet, the UI will show a dimmer popup.
There was a "secret" power monitor variation in code so PDAs could not access monitors in hidden places. With the removal of PDAs, this control console is useless.
Why It's Good For The Game
Tiny bit of (much needed) polish on some useful tools in the engineering department.
Changelog
cl
fix: Fixed runtime when using AmpCheck without connecting the console with a wire.
fix: Fixed a few runtimes that could occur when using APC controller consoles.
qol: Sucked soul out of APC controller code and UI.
del: Removed "secret" power monitor console.
/cl
* [MDB IGNORE] APC controller and Power Monitor/AmpCheck fixes, aka How do I write PR titles
* update paths
Co-authored-by: distributivgesetz <distributivgesetz93@gmail.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
* Add check for ordering permissions before using department account as payee for NIRN, also fixes#68765 (#69290)
About The Pull Request
See title
Why It's Good For The Game
Fixes#68765, also currently, while NIRN is meant to parallel the features of the cargo console for non-heads of staff, requests are also paid by the department account instead of the general cargo budget for non-heads of staff
Changelog
cl
fix: Putting a budget card into NIRN now gives the proper error message if you are trying to buy something privately, and treat you as a normal cargo request order by someone without any permissions otherwise
fix: NIRN orders should now charge the department that bought it only if a head of staff ordered it
/cl
* Add check for ordering permissions before using department account as payee for NIRN, also fixes#68765
Co-authored-by: RandomGamer123 <31096837+RandomGamer123@users.noreply.github.com>
* Adds more multiz support (#69420)
* Adds more multiz support by making use of ``is_valid_z_level`` instead of simply checking if z is the same.
* Adds more multiz support
Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
* Paper bins now create paper dynamically, rather than creating thousands of pieces of paper on init every round (#69586)
* Paper bins now create paper dynamically, rather than creating thousands of pieces of paper on init every round
* Fix hard del, fix static initialization
* Fix fire_act not using paper_stack
* Paper bins now create paper dynamically, rather than creating thousands of pieces of paper on init every round
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
* Standardize and improve status display UI's (#68976)
* Standardized and improves status display app, making it share the same UI as the Communication Console's version of it, and moves shared status display screens into global lists instead of vars.
Co-authored-by: John Willard <53777086+JohnFulpWillard@ users.noreply.github.com>
* Standardize and improve status display UI's
Co-authored-by: Tastyfish <crazychris32@gmail.com>
Co-authored-by: John Willard <53777086+JohnFulpWillard@ users.noreply.github.com>
