* Fixes a bug where chunky fingers were preventing roundstart PDA use (#71301)
## About The Pull Request
Fixes#71180#70422 Removed the !allow_chunky check introduced by #66358 ,I've
re-added it.
I've tested this and can confirm PDAs are usable again while modular
consoles remain unusable.
## Why It's Good For The Game
Fixes a rather frustrating bug
## Changelog
🆑
fix: Roundstart PDAs can once again be used by people with chunky
fingers.
/🆑
* Fixes a bug where chunky fingers were preventing roundstart PDA use
Co-authored-by: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>
* Removes Syndicate cyborg's messaging app (#71134)
## About The Pull Request
Syndicate borg apps weren't changed to cyborg subtypes when those were
added in.
## Why It's Good For The Game
Closes https://github.com/tgstation/tgstation/issues/71116
## Changelog
🆑
fix: Syndicate Cyborgs no longer have the PDA messaging app.
/🆑
* Removes Syndicate cyborg's messaging app
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
* Removes tablet cell parts (#71078)
## About The Pull Request
Removes cell parts and cell part cells, now tablets directly stole a
power cell in them, and uses regular stock cells like every other
machine in the game. This also makes it less confusing because people
are more used to stock cells over computer cells. Because cells
generally hold more power than computer ones, I bumped up the active
power usage from 50 to 75.
## Why It's Good For The Game
We are nearly finished removing all parts, holy cr*p
## Changelog
🆑
balance: Tablets now use regular cells instead of computer cells.
balance: Tablets no longer need a power cell component to hold power
cells.
/🆑
* Removes tablet cell parts
* Feex
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
* Re-adds the clown's PDA virus honking (#71035)
## About The Pull Request
Re-adds the Clown's virus disk's ability to make machines, airlocks, and
computers honk, which was removed in the transition from PDA to modular
computer.
Fun fact: This was broken for a long time, I had fixed it in
https://github.com/tgstation/tgstation/pull/64443 before it got
accidentally wiped off the face of the earth.
To anyone who isn't aware:
- Clown's virus disk has 5 charges
- You can use these charges to install viruses in computers, airlocks,
and machines if they're screwed open (computers dont need to)
- This will make them honk when used.
- You can get charges back by slipping people with the PDA while the
virus disk is installed in it (which it is by default)
- The max charges you can get at once is 5.
## Why It's Good For The Game
A feature that was lost in the PDA to modular computer transition, now
re-added. It's a cool feature and I personally would use it if I played
bad jobs.
Things actually working is a 🛩️
## Changelog
🆑
fix: Clown PDA virus disk can once again be installed in machines,
computers, and airlocks.
/🆑
* Re-adds the clown's PDA virus honking
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
* Easy's Super Omega "unarmed strike based species var moved to limbs" refractor, unarmed strike striking with specific body parts rather than it just being flavor, and brain based attacking limb selection extra chunky edition. And also bodypart traits.
* Removed all the conflicts, and started converting all the arms and legs to the proper typepaths
* Actually makes the game compile :)
* Makes the maps compile too!
* Early mirror of #71143 because it's more relevant to us
Co-authored-by: itseasytosee <55666666+itseasytosee@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
* NtOS Emojipedia - PDA Emoji Messaging For All (#70829)
An Emojipedia app has been added to tablets, given to Mimes and Curators by default, allowing anyone to know all emojis. Additionally, emojis can be used in tablets by every job now.
* NtOS Emojipedia - PDA Emoji Messaging For All
* update emoji list to be valid
* animated emojis
Co-authored-by: san7890 <the@san7890.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
* Fixes detomatix's name (#71075)
## About The Pull Request
I accidentally replaced it with 'attacking_item' because i am demented
and can't stop abusing my clipboard.
## Why It's Good For The Game
🛩️
## Changelog
🆑
fix: Detomatix cartridges are no longer called attacking items.
/🆑
* Fixes detomatix's name
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
* Adds Station's Date To NTos Window (check the time+date on your tablet!) (#70754)
* The date and time is now displayed in NtOS tablets, showing the in-game date (540 years after current), bringing the feature from old PDAs over.
* Adds Station's Date To NTos Window (check the time+date on your tablet!)
Co-authored-by: san7890 <the@san7890.com>
* Add AltClick removes pAIs for tablets (#68251)
* Add AltClick removes pAIs
* Add context screentips for pAIs to tablets
* Fix screentip context syntax error
* Fix syntax error
* Merge remote-tracking branch 'upstream/master' into patch-10
* Refactor contextual screentips to work
* Fix runtimes
* Apply code review changes
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* Add balloon alert to tablet items
* Refactor screentips to be more robust
* Change add_context to be more robust
* Add more balloon alerts
* Some idiot set user to null so I gotta remove this
* Change pen screentip to display inserted item
* Add screentip to insert items
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* Add AltClick removes pAIs for tablets
Co-authored-by: Tim <timothymtorres@gmail.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* Fixes some inconsistencies with computers (#70679)
* Modular computers now have their initial name if they don't have an idenfitication and job, which previously meant they would have the name ()
* Removes MACHINE modular computer's process, because all it did was update the name, then call computer's process. Now it just does what every computer does, BUT UpdateDisplay on ITEM modular computers will now update the machine's name.
* Additionally, I moved the modular computer processor's New to an Initialize, and removed the shutdown_computer code, because we already register update_icon signal to update the computer's appearance, why do we need to do it twice?
* Fixes some inconsistencies with computers
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
* Misc PDA code improvements (#70555)
* How to conflict with PRs: A guide
* Removes unnecessary support for the now-removed job disks from Tablet's TGUI menu, and tablet's ui_act.
* Adds autodoc comments to computer files
* Removes the unused 'unsendable' var on computer files
* Generally improves code on tablets, now process isn't looping through every idle thread twice!
* Moves the check for program in idle_threads above checking if supported by hardware, because it's already running, so there's no need to check.
* eh
* revert a scipaper change
* Misc PDA code improvements
* updated contract_uplink
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Tastyfish <crazychris32@gmail.com>
* Removes a ton of unused tablet vars, re-organizes the rest (#70344)
* Removes a ton of unused vars, re-organizes the rest
Removes a ton of unused vars from Modular computers
Re-organizes the rest, and adds autodoc comments to most of them
Moved 2 vars (saved_image and invisible) from the tablet to the messenger app, since that's where it was used. I didn't see the point of having these vars be on every computer anyways, only PDAs have the app.
Renames Clown's honk virus var
Makes Messenger app's saved image, actually used.
* static list and NODECONSTRUCT_1 check
* oops
* Removes a ton of unused tablet vars, re-organizes the rest
* cryopod
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
* Modular computer fixes (#70606)
* Moves a lot of modular computer attackbys to the cpu instead, which is what handles it all. This allows their parts to be removed and the console deconstructed/repaired once again.
* Modular computer fixes
Co-authored-by: GoblinBackwards <22856555+GoblinBackwards@users.noreply.github.com>
* [NO GBP] Fix traitor PDA uplinks to be accessible by illiterate people (#70368)
* Illiterate people can now use a PDA in hand to open their uplink immediately if they are the owner of the uplink.
* [NO GBP] Fix traitor PDA uplinks to be accessible by illiterate people
Co-authored-by: Tim <timothymtorres@gmail.com>
* The curator's PDA now works in space (#70319)
* The curator's PDA is now long-ranged
The Curator's PDA is now long ranged and allows for it to be used while out in space.
I recently removed the modular computer parts that allowed PDAs to be upgraded to connect to NTNet while on different Z-levels, so thought this would be a good replacement since Curators are a space exploration job, so being able to still talk to other players or use the newscaster app while away, is something I think would be beneficial.
* The curator's PDA now works in space
* Gives vanguard PDA long range as well
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Tastyfish <crazychris32@gmail.com>
* Removes network cards and printers from tablets
* merge tablet_presets
* printer.dm should have been deleted, missed change
* update contractor tablet
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
* Removes AI and Charge parts from tablets, adds support for more later.
* merge conflict
* remove modular tablet loadout item
* fix SR maps referencing tablets, add clear PDA instead of modular tablet loadout
* remove pda loadout item
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
* Demoralization fixes (#69924)
* Demoralization fixes
Blind mobs will no longer be demoralized by posters and graffiti.
Illiterate mobs will no longer be demoralized by the words on posters.
Mobs will no longer be demoralized by posters & graffiti if it's too dark to see them.
Also makes can_read use reading check flags, one for literacy and one for light.
* Demoralization fixes
Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
* Removes ComponentInitialize()
* Fixes a leftover merge conflict marker
* Fixes the oversight that came from the upstream merge skew
* Fixes all of the instances where we used ComponentInitialize() when we shouldn't've been
* Fixes CI being broken because of the HEV suits
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
* Removes the "proximity crew pinpointer" (the ones parameds spawn with), paramedic PDAs start with the lifeline app instead (#68993)
* Parameds start with the Lifeline tablet app instead of a proximity pinpointer, with a Calomel bottle replacing their now empty medical belt slot.
* Removes the "proximity crew pinpointer" (the ones parameds spawn with), paramedic PDAs start with the lifeline app instead
* wew
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
* [MDB Ignore][Bounty][Complete Refactor] Papercode Redux: Too Many Damn Files <Map Conflict Edition>
* Fixes merge conflicts and compilation errors, alongside fixing the joker card to make it fully functional again
* Fixed a bunch of info variables in map files
* Alright this is why I wanted this merged yesterday
Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
* Fix: #41250 You can't use a tablet while inside a locker (#68171)
* Fix: #41250 You can't use a tablet while inside a locker
Co-authored-by: Matt <gavxn@zanidrak.com>
* Completely removes `proc_holders` from existence. Refactors all wizard, xeno, spider, and genetics powers to be actions. Also refactors and sorts ton of accompanying code.
* our changes
* yes
* 0
* Update blackmesa.dmm
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
* CARGONIA THE FREE: The Quartermaster is now a head of staff. (#67518)
* The Quartermaster is officially a head of staff, with new accesses, a silver ID, ect ect.
* The HoP lost their cargo-related equipment and access, including the Vault monitor, and frequency.
* wew
Co-authored-by: Iamgoofball <iamgoofball@gmail.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
* Head of Personnel Resprite & New HoP Coat (#67286)
add: Brand new HoP coat!
imageadd: New sprites for HoP's uniform, skirt, cap, and the ID Painter.
* Head of Personnel Resprite & New HoP Coat
Co-authored-by: axietheaxolotl <86872535+axietheaxolotl@users.noreply.github.com>
* Fixes tablet lights (#67315)
* Fixes tablet lights
Makes tablet lights properly be directional lights like PDAs were.
I also replaced some single-letter vars for no particular reason.
* re-adds action button updating
* Fixes tablet lights
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
* Readds Captains fountain pen (#67164)
bout The Pull Request
Was working on a different fix and noticed the Captains Fountain pen was missing so i went through some other jobs on a pre modular PDA build and found that QMs survial pen was also missing. Ignored the fountain pens for all Heads of Staff i presume that was intentional.
Why It's Good For The Game
Minor Fix, gives the Captain back back his Unique Pen and dignity
QM gets their survial pen back as well.
Changelog
Captains and Quartermasters now receive their unique pens in their PDAS again.
cl
fix: Restores Captains pen and QM survial pen in respective Pdas
/cl
* Readds Captains fountain pen
Co-authored-by: Dmeto <75919495+Dmeto@users.noreply.github.com>
* Fixes spray cans and pipes fitting inside of tablets. (#67057)
They were subtypes of crayons and cigarettes which allowed them to be fit inside. To fix this, the tablet can only hold tiny items and spray cans and pipes have been changed from tiny items to small.
* Fixes spray cans and pipes fitting inside of tablets.
Co-authored-by: ReinaCoder <83892995+ReinaCoder@users.noreply.github.com>
* Mass-PDA perms is configured on Wirecarp (#66889)
Lawyers and Captains spawn by-default with the ability to send mass PDA messages, but the Wirecarp app (so Research Director and Captain) can grant/revoke permission to send PDAs to everyone
* Mass-PDA perms is configured on Wirecarp
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
* Fixes the captain's PDA (#66908)
I screwed it up and didn't make the Captain's PDA a subtype of heads, so captain was spawning with the wrong PDA.
* Fixes the captain's PDA
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
* [MDB IGNORE] Removes tablet cartridges + reworks a ton more (#66505)
- All tablets who previously had apps in a cartridge now has them built-into their tablet instead. This means it costs space for it.
- Rebalances the sizes of several apps to help them fit on Command tablets (Cargo ordering costed 20!!)
- Removes tablet cartridges, they've been reworked into a regular old portable disk (the same you use for toxins/borgs)
- Removes Signaller (the module required to run the signaller app) from tablets (likely will remove more in the future)
- Refactors the health/chem scanning app to not be as bad
- Dehardcodes detomatix resistance
- Ability to send PDA's to all is now tied to your access rather than a cartridge
- Moves 'eject disk' button to the very top of the UI
* [MDB IGNORE] Removes tablet cartridges + reworks a ton more
* wew
* wew
* ok
* Update nanotrasen_consultant.dm
* Update nanotrasen_consultant.dm
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
