Commit Graph

35573 Commits

Author SHA1 Message Date
Wayland-Smithy
56529dea50 Fix base lighting appearance inheritance (#62042) 2021-10-12 00:02:45 -07:00
Colovorat
d199a07e13 Fixes ability to extract DNA of species that has no DNA (#61928)
Co-authored-by: Colovorat <lolqwert569@gmail.com>
2021-10-12 00:02:24 -07:00
Seris02
4275870072 runtime fix for reagent instant_react proc (#62030)
Runtime in holder.dm, line 1122: Cannot read 0.purity x 882
2021-10-11 19:30:01 +01:00
Ghom
b78b9fde74 Adds the CIRCUIT_FLAG_REFUSE_MODULE circuit flag. (#62033)
Components like the MMI one can't be added to circuits more than once since they may register signals with same proctype and similar things which make for some tangled up race conditions if more than one is present.
Unfortunately this safety can be bypassed - with little gain alas, an MMI can't be inserted by attacking the component with it. it needs a shell - by using a module component. That's no good. So I'm adding a flag that can be used to stop certain components from being added to module components.
2021-10-11 19:28:08 +01:00
MrMelbert
3a2d33afaa Converts the behavior from suit/toggle to component behavior (#61941) 2021-10-11 03:28:29 -07:00
tralezab
dc38af86c9 Basic mobs can be vareditted again (#62046)
Readds the missing parent call.
2021-10-11 17:05:14 +13:00
Fikou
4663f9afce secret gateway update (#62003)
admins are now notified about a secret gateway load failing, also logs this
secret z levels are protected from incorporeal movement
fixes unpowered ruin areas being powered
adds a bunch of new areas for secret gateways, since var edited areas probably arent a good idea its good to have a few presets
adds cordon turfs and areas, ingame they just look like the z level border, they are completely indestructible, you cant pass them, and if you somehow do, the cordon area kills you (idea from goon but the code and sprites are mine)
adds a z level injector mapping trait, injects a z level trait into the z level its placed on, if you want to add something like ash storms or whatever to your map
adds an anti xray z level trait, you can optionally add this with the z level injector to protect your map against any xray or whatever
2021-10-10 20:20:22 +01:00
Ghom
c9831d2709 Fixes two issues with paper code. (#62016) 2021-10-10 21:15:20 +02:00
Mothblocks
ed89d9fbd4 Add reset keybindings button (#61942) 2021-10-10 14:50:38 +03:00
esainane
724e6e0f56 SM: Prevent unmovable SM variants from moving (#62000)
Previously, a hostile statue could move it by bumping into it. It would
still be dusted, but this left open the possibility of supposedly
immobile engines moving, albeit slowly and expensively.
2021-10-10 04:38:41 -07:00
Watermelon914
0ebf4891ad Fixes bugs with admin circuits, expands upon some admin circuit components and fixes duplicator runtiming when a port doesn't exist. (#61948)
Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>
2021-10-10 03:36:25 -07:00
tralezab
3d5ee892fa toggle random events on/off no longer sends unspanned feedback to user (#61982)
The verb already messages admins and pressing the verb requires you to be an admin. to_chat entirely unneeded!
2021-10-10 08:26:44 +01:00
Arkatos1
cac9a9bbc7 thermomachine design icon fix (#61779) 2021-10-09 04:40:39 -07:00
Krysonism
82e9d894fe mini_arachnid (#61860) 2021-10-09 04:32:27 -07:00
Watermelon914
1590ae1f93 Makes it so that datums can take entity inputs too (#61930)
Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>
2021-10-09 04:31:38 -07:00
Watermelon914
0cc06cf6ec Fixed dispenser and new circuit list components not being available (#61960)
Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2021-10-09 04:31:15 -07:00
LemonInTheDark
e663308b0d Adds SHOULD_NOT_SLEEP to Destroy. Why didn't we do this before. (#61943) 2021-10-09 04:29:33 -07:00
LemonInTheDark
861bf808bc Fixes a few hard deletes and runtimes I either caused, or ran into when trying to fix hard deletes (#61953)
Please don't try and send chat messages if you have nothing to say
Fixes a spurious runtime.
Fixes a runtime caused by my lack of understanding of huds. remove_hud_from is intended for hud watchers, remove_from_hud is intended for hud items. Doesn't really make sense most of the time, and just runtimes out the ass
Fixes a runtime in shapeshifting, restore should not run if the object is not restoring, or if it's deleting. it should run if it's not restoring, and it's not deleted. 4head
Fun fact, if there's two turret control boards they'll override each other. Use weakrefs. Oh also removes a var called cp, nothing good will come of that
Today in: Good lord the stacking machine is an afront to god, we discover that the labor claims console was attempting to act as a console, which of course fails when it comes time to clear it's improperly named var. Disgusting
Attempts to fix potential wound ref hangs in surgeries? maybe?
Fixes a runtime in luminescent stuff I created in my big harddel crusade. owner is a mob, not a species
Fixes a runtime related to headspikes deleting themselves twice. Pain
Fixes hard deletes sourced from the prophet trauma. Good fucking lord this is awful
Offhand item is somehow hard deleting. I have no idea how. Here's hoping signals fixes it, because if it doesn't I'm stumped. It's not a common scenario, but it does happen in spurts that suggest repeated usage
2021-10-09 09:44:21 +01:00
esainane
76a88cdabf HFR ambience: Quieten when out of fuel (#61956)
HFR ambience will no longer play intensely when the HFR is out of fuel.

This has always been a problem, but more cues for the HFR being out of fuel are helpful.
2021-10-09 01:33:08 -07:00
esainane
d6731d9696 Hostile Statue: Fix typo (#61972) 2021-10-09 01:31:46 -07:00
esainane
2d5fec7f25 SM: Prevent unmovable SM variants from moving (#61970)
Previously, a hostile statue could move it by bumping into it. It would still be dusted, but this left open the possibility of supposedly immobile engines moving, albeit slowly and expensively.

Hostile Statues have a move_force of 9000, but continued to be able to bump the SM until move_force was varedited to 1999 or below. This means (at least) immovable rods and all megafauna could all bump an "immobile" SM one tile per life.
2021-10-09 09:30:47 +01:00
esainane
1a6af6d268 APC: Remove a useless null check (#61965)
You literally return if !home 4 lines above aaaaaaaaaaaaaaaaaaaaaaaaaaaa
2021-10-09 01:29:24 -07:00
Watermelon914
7ef01161ed Fixed circuit variables not working because of a null listener in their listener list (#61961)
Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>
2021-10-09 00:58:27 -07:00
Mooshimi
979995f344 Status Displays can be taken down (#61847)
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2021-10-08 17:52:41 -07:00
Ghilker
cc3bf70da9 Rad collectors gone, tesla coils to generate power (#61917)
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2021-10-08 17:03:52 -07:00
esainane
b3db2d6a67 Rename freon_gas_act to freeze_turf (#61958)
This was only used from two places, neither of which involved freon.
2021-10-08 05:31:10 -07:00
Watermelon914
f6dfff674f Fixed animating filters with circuits and added special signal ports for instant circuit execution. (#61851)
Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>
2021-10-08 05:29:59 -07:00
Krysonism
6832084d70 Fixes riding abilities by sharing action buttons (#61854) 2021-10-08 05:06:43 -07:00
Watermelon914
7f0bb743b4 Fixes default FPS and makes it apply to new players (#61957)
Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2021-10-08 05:04:56 -07:00
John Willard
b7c9be2cc4 Adds catburgers, egg with sausage, and sausage bread. (#61894)
expansion: Added 3 new foods: Catburgers, Egg with sausage, and Sausage bread.
2021-10-08 06:12:14 -04:00
Krysonism
0f715b38f9 Cytology Adjacent Update #2: Carp scale crafting. (#61913)
expansion: Adds carp scales, and carp scale crafting.
2021-10-08 06:11:35 -04:00
Ghom
4d84a5b36e The monkey portrait decoration is now a set of random pictures that also act as persistent photo frames. Every station map gets one. (#61844)
spriteadd: Desouled the picture frame sprites.
2021-10-08 06:10:03 -04:00
TiviPlus
17c603f1d0 Remove deprecated preferences/lobby menu proc (#61945) 2021-10-07 23:20:16 -07:00
Burgermancoding
8b9d7da6b6 Adds follow button to families cellphone messages (#61947)
Co-authored-by: unknown <burgercoding@gmail.com>
2021-10-07 23:19:42 -07:00
MrMelbert
270a53e117 Delete seeds whenever a plant is deletes, delete plant genes when a seed is deleted, + refactor various gene adding / deleting (#61747) 2021-10-07 19:27:07 -07:00
NamelessFairy
cb31682d91 Replaces the Mafia button with the Minigames button. Adds tgui panels for selecting minigames and for CTF (#61638)
This PR replaces the Mafia button on the observer HUD with a minigames button that allows you to access both CTF and Mafia.

It also adds a CTF menu that allows you to view current scores, players needed to start a game, and joining a ctf game without needing to move to the spawner.

Co-authored-by: Jared-Fogle <35135081+Mothblocks@users.noreply.github.com>
2021-10-07 16:42:06 +03:00
Invalid
67f9982f36 fixes penetrator rounds phasing through vehicles (#61907)
When I gave vehicles the PASSMACHINE flag in #61793 I forgot that penetrator rounds existed leading to them completely ignoring mechs. This time I created a new flag for vehicles, added it to water particle effects, and excluded it from the penetrator rounds.

Additionally this flag has been added to the heretic's phasing ability.
2021-10-07 11:11:39 +01:00
zxaber
75981a9533 Allows emagged and syndicate borgs to self-detonate (#61915)
Once upon a time, when borgs could access machines from any distance once the window was open, borgs could self-detonate as a combat strategy. At some point, machine access for borgs was confined to being nearby the device, which removed self-detonation (except when near the console) as a side effect. This PR re-adds the ability for emagged and syndicate borgs by placing a confirm-type button into their RoboTact app (Actions section, under the Status tab).

Stunned or locked borgs cannot self-destruct.

Additionally, logging for borg detonations has been moved out of the robot console and into the borg self_destruct() proc, to avoid duplicate code, and emagged borgs now have their tablet theme and icon changed to syndicate versions.
2021-10-07 11:02:52 +01:00
LemonInTheDark
c8684800ba Removes dead code in techwebs, alongside some truly evil macros (#61936)
fuck you kevin
2021-10-06 22:55:07 -07:00
Watermelon914
d15b305527 Refactors the list datatype to support composite lists. Adapts a lot of circuits to be able to properly use composite lists. Adds the dispenser shell (#61856)
Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>
Co-authored-by: Colovorat <35225170+Colovorat@users.noreply.github.com>
2021-10-06 22:51:36 -07:00
zxaber
35a7ebed89 Fixes borg light overlays (#61920) 2021-10-06 06:22:56 -07:00
Peter
462214e9ef Fix bow controlling dropped arrow (#61868)
When loading an arrow into a bow and firing the bow without drawing it, the arrow would drop and still be able to be dropped repeatedly, making the arrow follow the player on the ground. See before clip. Also resulted in cleaning up a pointless if statement.
2021-10-06 13:47:56 +01:00
Jordan Brown
765c7840e2 [s] Cleanup escalation unsafe procs (#61905)
Fixes admins spawning in atoms and datums without the DF_VAR_EDITED flag
2021-10-06 13:12:50 +01:00
Ryll Ryll
ee541f35df fixes multiple spaces breaking asay (#61939) 2021-10-05 22:39:08 -07:00
tralezab
1de7b626f3 RPG titles wizard event (#61579)
* cool 37 files changed- and not a maintainer in sight!

* works for simplemobs too

* misused proc

* FIXED

* WOOOOOOORKS

* better zombie name

* work smarter

* card dmi udpate
2021-10-06 02:21:48 +02:00
kopoba
e14e185462 Fix ebow acceting pka modkits (#61879)
This pull request make ebow think that he has -1% of mod capacity because ebow is not pka but still pka. So you will be unable to slap modkits from pka to ebow. Its not best way to deal with issue but best i can afford.
2021-10-05 23:26:10 +01:00
Ghilker
b95c0366a4 _HELPERS/unsorted.dm has been sorted (#61882)
bring code up to latest standards, move many procs to named files inside _HELPERS
no idea where to put some of these procs, help is appreciated
made more files to contain some unique code, deleted unsorted.dm, we can rest now
2021-10-05 20:22:57 +01:00
John Willard
a84264b189 fixes surgeries that repair organs (#61789) 2021-10-05 10:13:54 -04:00
John Willard
152cee0e0f Update swarmer_objs.dm (#61877)
If you are banned from an antag, but no ghosts take your body, you get to stay in your body.
This means that someone banned from Swarmer can keep trying to join as a Swarmer and hope no one will take over their body, to bypass their ban.
To prevent this, banned people won't be able to form a swarmer body in the first place.
2021-10-05 12:17:25 +01:00
Timberpoes
8593c55c3a Fix disky teleporting itself off the emergency shuttle on transit. (#61786)
Fixes #61782

Did a minor cleanup in the stationloving component to better represent what the proc the destination_in_bounds proc actually did. It is now atom_in_bounds since it's called after the atom has moved and works on the atom's turf. This doesn't fix the problem, but it obfuscated things a bit since it was deceptively named.

The issue is that when the e-shuttle leaves the station, for every turf on the shuttle it first moves the turf's contents to hyperspace, then moves the turf to hyperspace, then changes the area. Since the player holding disky enters Hyperspace first then has the shuttle turf constructed around them, disky teleports back to the station because it enters a non-whitelisted location.

Instead of whitelisting Hyperspace, I changed the order of operations to turf transfer, area transfer and finally atom transfer. This fixes the issue (as now disky moves from z=2 to z=12 /area/shuttle/escape, where escape shuttle is whitelisted instead of z=12 /area/transit, where /area/transit is not whitelisted).
2021-10-04 22:13:33 +01:00