Commit Graph

28 Commits

Author SHA1 Message Date
Zonespace
f7c26bbf25 515 Compat (#17465)
* ONLY SKYRAT CHANGES

* ACTUALLY SKYRAT CHANGES

* yolo, revert later

* Update alternate_byond_versions.txt

Co-authored-by: AnturK <AnturK@users.noreply.github.com>
2022-11-15 06:59:06 +00:00
SkyratBot
b5bd312379 [MIRROR] Add investigate_deaths [MDB IGNORE] (#17424)
* Add investigate_deaths

* merge changes other than giant_spider which deps on tg/70848

* gib

* dust

* death

Co-authored-by: tattle <66640614+dragomagol@users.noreply.github.com>
Co-authored-by: Zonespace <41448081+Zonespace27@users.noreply.github.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
2022-11-11 14:44:33 -05:00
SkyratBot
d3836b90d2 [MIRROR] [NO GBP] Add a 2 second cooldown for ore bag balloon alerts [MDB IGNORE] (#17420)
* [NO GBP] Add a 2 second cooldown for ore bag balloon alerts (#71133)

## About The Pull Request
And removes an extra `to_chat` message for when your ore bag is full and
can't put ore in using the `silent_for_user` system.
## Why It's Good For The Game
I have been moving the chat messages that miners get bombarded every
shift away from their chat bar and into balloon alerts with the goal of
making the chat be a cleaner place for miners, as it is their only way
to interact with the station while down at lavaland.

People have been complaining that it was too much, which is fair. I've
been work on a mini rework on how ore bags function and a cleaner
feedback with ore icons falling into the bag, but I'm just not happy
with how it works now so I will restart on it.

Until I get that sorted, I added a 2 second cooldown on the balloon
alerts for picking up ore as a middle ground, it provides good feedback
for new players while not being as distracting.
## Changelog
🆑 Guillaume Prata
qol: Ore bag balloon alerts have a 2 second cooldown now and a spammy
message (hopefully the last) it send to your chat about being full was
removed
/🆑

* [NO GBP] Add a 2 second cooldown for ore bag balloon alerts

Co-authored-by: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com>
2022-11-09 01:59:25 +00:00
SkyratBot
156d2a425a [MIRROR] Adds a silent_for_user var to mute storage messages only for the user. [MDB IGNORE] (#17347)
* Adds a `silent_for_user` var to mute storage messages only for the user. (#70941)

## About The Pull Request
We have a `silent` var that makes storing/removing items from a backpack
not send a message to anyone's chat.
This adds a midway point, silent messages only for the user to cut on
spam/unnecessary messages while other players still keep them to prevent
free stealth shenanigans.

For now the only storage item I have given this new variable is the ore
bag for miners, as even with #70487 miners still have to deal with a lot
of pointless messages getting in the way of radio chatter.
## Why It's Good For The Game
Less pointless spam.
You mined the ore, you stepped on it, you get a balloon alert explaining
what happened.
There is no reason to also send the default storing/removing message to
your chat.

it can also be easily ported to other backpack/boxes/bags, I personally
would want it on basically any storage but that would hurt on new
player's feedback, so it is a conversation for another PR.
## Changelog
🆑 Guillaume Prata
qol: Ore bags are "silent" for the wearer and won't send pointless chat
messages about what has been stored/removed from it. Other players will
still get a chat message, so miners can't get away with surprise plasma
ore bombs.

/🆑

* Adds a `silent_for_user` var to mute storage messages only for the user.

Co-authored-by: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com>
2022-11-04 11:06:09 -07:00
SkyratBot
62c02030e3 [MIRROR] Convert mouse and rat to basic mobs [MDB IGNORE] (#17215)
* Convert mouse and rat to basic mobs

* run the UpdatePaths script you borb

* packs and nests

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
2022-10-28 21:27:47 -04:00
SkyratBot
614dea1b4b [MIRROR] Allows flasks to be stored in shoe pockets [MDB IGNORE] (#17082)
* Allows flasks to be stored in shoe pockets (#70680)

* Added flasks to pocket.dm shoes

Adds flasks to the valid item storage list for jackboots, clown shoes, and other similar shoes

* Added flasks to pockets.dm shoes

Adds flasks to the valid item list for storage inside jackboots, clown shoes, and similar shoes

Co-authored-by: AeronaDF <aeronadf@ gmail.com>

* Allows flasks to be stored in shoe pockets

Co-authored-by: DannyBoy3642 <98357253+DannyBoy3642@users.noreply.github.com>
Co-authored-by: AeronaDF <aeronadf@ gmail.com>
2022-10-21 19:23:02 -04:00
SkyratBot
43865ef790 [MIRROR] Fixes mining modsuit storage breaking after recharging it with plasma [MDB IGNORE] (#16997)
* Fixes mining modsuit storage breaking after recharging it with plasma (#70558)

* Adds QDELETED check to inserting items to storage

* Fixes mining modsuit storage breaking after recharging it with plasma

Co-authored-by: GoblinBackwards <22856555+GoblinBackwards@users.noreply.github.com>
2022-10-19 18:57:47 +01:00
SkyratBot
9bf006d189 [MIRROR] Multiz Rework: Human Suffering Edition (Contains PLANE CUBE) [MDB IGNORE] (#16472)
* Multiz Rework: Human Suffering Edition (Contains PLANE CUBE)

* skyrat changes

* bodyparts merge

* unres door floorlight fix

* Future upstream fix for blindness

* upcoming upstream airlock fix

* fix button emissive

* Fix FOV markings?

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
2022-10-02 23:30:09 -04:00
SkyratBot
1ce77983df [MIRROR] canUseTopic now uses TRUE/FALSE instead of defines that just say TRUE [MDB IGNORE] (#16586)
* canUseTopic now uses TRUE/FALSE instead of defines that just say TRUE

* etes

* eyes

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-10-02 15:54:46 +01:00
SkyratBot
32db6d2411 [MIRROR] Properly checks flags with & instead of == [MDB IGNORE] (#16487)
* Properly checks flags with & instead of ==

* merge fixed for changeling

* skyrat equipment updated

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Tastyfish <crazychris32@gmail.com>
2022-09-28 16:38:59 -04:00
SkyratBot
1c9d04d357 [MIRROR] fix xenbio bag [MDB IGNORE] (#16099)
* fix xenbio bag (#69518)

A little earlier, it was gone to use bags of xenobiology on reproductive extracts, but now, after this change, the possibility is completely returned.

* fix xenbio bag

Co-authored-by: Yaroslav Nurkov <78199449+AnywayFarus@users.noreply.github.com>
2022-09-06 18:53:54 +01:00
SkyratBot
471760e96a [MIRROR] Fixes storage mass transfer being generally broken, adds mass transferring onto griddles [MDB IGNORE] (#15729)
* Fixes storage mass transfer being generally broken, adds mass transferring onto griddles  (#69084)

* - Fixes storage mass transfer
- Brings some sanity to storage procs
- Implements a griddle feature that never was

* Uncomment this

* Right-click attack fix

* Scoop fix

* Smartfridges use silent

* Restores some lost checks

* Fixes storage implants

* Fixes storage mass transfer being generally broken, adds mass transferring onto griddles

* update modular

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
2022-09-03 18:01:54 +01:00
SkyratBot
a8c10d1659 [MIRROR] Converts a shitload of istypes to their more concise macros [MDB IGNORE] (#15702)
Converts a shitload of istypes to their more concise macros

Co-authored-by: Seth Scherer <supernovaa41@gmx.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2022-08-27 16:23:44 -04:00
SkyratBot
88c85fe1f7 [MIRROR] [MDB IGNORE] Refactors drinks and fixes a lot of food problems [MDB IGNORE] (#15577)
* [MDB IGNORE] Refactors drinks and fixes a lot of food problems

* [MDB IGNORE] Refactors drinks and fixes a lot of food problems

* forgto 2 commit

* im slowly going insane

* why does find and replace not FIND everything

* hnghnnngh

* h

* l

* a

* a

* so close...

* delta fix

* I thought I committed this already, guess not

* this PR has been the bane of my fucking life

* orange juice

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
Co-authored-by: Zonespace <41448081+Zonespace27@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
Co-authored-by: Jolly-66 <70232195+Jolly-66@users.noreply.github.com>
2022-08-25 03:17:10 +01:00
SkyratBot
06ca7f8aa2 [MIRROR] Fixes belts only getting their appearance updated when removing an item from it [MDB IGNORE] (#15460)
* Fixes belts only getting their appearance updated when removing an item from it (#69066)

Fixes storage belts only getting their appearance updated when removing an item from it

* Fixes belts only getting their appearance updated when removing an item from it

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2022-08-08 01:12:36 +01:00
SkyratBot
6016cf97b4 [MIRROR] individual LOG_GAME [MDB IGNORE] (#15401)
* individual LOG_GAME

* e

* Update teleporter.dm

Co-authored-by: Mooshimi <85910816+Mooshimi@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-08-08 01:11:55 +01:00
SkyratBot
5a1d74425f [MIRROR] Converts most storage item chat messages to balloon alerts [MDB IGNORE] (#15376)
* Converts most storage item chat messages to balloon alerts

* Update lockbox.dm

Co-authored-by: Coffee <CoffeeDragon16@gmail.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-08-04 15:49:32 +01:00
SkyratBot
bc2f2d6fe5 [MIRROR] STORAGE STUCK! PLEASE! I BEG YOU! [MDB IGNORE] (#15288)
* STORAGE STUCK! PLEASE! I BEG YOU! (#68711)

initial

* STORAGE STUCK! PLEASE! I BEG YOU!

Co-authored-by: magatsuchi <88991542+magatsuchi@users.noreply.github.com>
2022-07-30 08:12:56 -07:00
SkyratBot
48f015d1ae [MIRROR] Fixes RPEDs being unable to pick up beakers and assemblies [MDB IGNORE] (#15297)
* Fixes RPEDs being unable to pick up beakers and assemblies (#68822)

does the pr

* Fixes RPEDs being unable to pick up beakers and assemblies

Co-authored-by: Coffee <CoffeeDragon16@gmail.com>
2022-07-30 08:11:59 -07:00
SkyratBot
a520d52009 [MIRROR] organ boxes now have a storage type [MDB IGNORE] (#15283)
* organ boxes now have a storage type (#68722)

* Organ boxes now have a storage type and, because of it, will once again prevent organ decay to organs stored inside of it.

* organ boxes now have a storage type

Co-authored-by: magatsuchi <88991542+magatsuchi@users.noreply.github.com>
2022-07-29 17:27:06 -07:00
SkyratBot
1ced8dc527 [MIRROR] fixes not being able to click drag storage containers + rmb fix [MDB IGNORE] (#15160)
* fixes not being able to click drag storage containers + rmb fix (#68557)

* On the storage datum, properly registers secondary singals to their own secondary procs to handle the different stuff they do.
* Fixes click & drag storage containers by calling them on where they are supposed to be moved to using atom_storage.

* fixes not being able to click drag storage containers + rmb fix

Co-authored-by: magatsuchi <88991542+magatsuchi@users.noreply.github.com>
2022-07-24 13:21:23 +01:00
SkyratBot
ed59a31290 [MIRROR] fixes issue with storage item appearances not updating properly [MDB IGNORE] (#15121)
* fixes issue with storage item appearances not updating properly (#68515)

* initial

* Update code/datums/storage/storage.dm

* Update code/datums/storage/storage.dm

Co-authored-by: ShizCalev <ShizCalev@ users.noreply.github.com>

* fixes issue with storage item appearances not updating properly

Co-authored-by: magatsuchi <88991542+magatsuchi@users.noreply.github.com>
Co-authored-by: ShizCalev <ShizCalev@ users.noreply.github.com>
2022-07-22 11:54:33 -07:00
SkyratBot
10ba2c0990 [MIRROR] Nukie Rework Part 2: Nuclear Operative starting gear rework [MDB IGNORE] (#14936)
* Nukie Rework Part 2: Nuclear Operative starting gear rework

* Apply suggestions from code review

* Update _box_magazine.dm

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-07-19 00:43:21 +00:00
SkyratBot
95589e57de [MIRROR] fixes TRAIT_NODROP items being able to be put into storage [MDB IGNORE] (#15035)
* fixes TRAIT_NODROP items being able to be put into storage (#68516)

initial

* fixes TRAIT_NODROP items being able to be put into storage

Co-authored-by: magatsuchi <88991542+magatsuchi@users.noreply.github.com>
2022-07-18 16:08:40 -04:00
SkyratBot
e754d57426 [NO GBP] fixes mass transfer sounds (#14915)
Co-authored-by: magatsuchi <88991542+magatsuchi@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
2022-07-18 16:23:50 +00:00
SkyratBot
b3b7096243 Removes temporary debugging code that can spam admin chat. (#14850)
Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
2022-07-18 15:51:01 +00:00
SkyratBot
3669537ba7 [NO GBP] fixes issue where observers couldn't open storage items (#14859)
Co-authored-by: magatsuchi <88991542+magatsuchi@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2022-07-18 16:36:45 +01:00
magatsuchi
4f9df17cb1 [FIXED MIRROR] Tsu's Brand Spanking New Storage: or, How I Learned to Refactor For Skyrat (#14868)
* Tsu's Brand Spanking New Storage: or, How I Learned To Pass Github Copilot As My Own Code

* Delete storage.dm

* yippee

* shit

* holy shit i am stupid

* more fixes

* fuck

* woops
2022-07-17 21:16:59 -04:00