Commit Graph

198 Commits

Author SHA1 Message Date
Remie Richards
5fc7af7fbf attackby() now has an argument containing the parameters of the click that called it. Items placed on tables now center their icon where the user clicked. this is NOT true for racks, since racks look organised in their sprite.
Items reset their pixel_x and pixel_y values on pickup.
2015-02-19 13:02:43 +00:00
Menshin
a1a8555a45 * Fixes the air stored inside atmos machinery not updating on construction
* Fixes filters and mixers switching off on icon update
* Fixes the RPD not properly setting the flipped variable for flipped mixers/filters
* Fixes using the atmos analyzer on a pipe making you attack it
2015-02-04 21:56:07 +01:00
Menshin
4f9bfeebf0 Fixed HE junctions badly initializing directions. 2015-01-21 18:27:19 +01:00
Remie Richards
17654037db Ports Mloc's Refactor of buckling, All /obj can now buckle things. HE Pipes now change colour based on heat. 2015-01-14 19:07:18 +00:00
tkdrg
a4fa7027bc Merge pull request #6830 from Menshin/atmos_null_parent_fix
Fixes atmos machinery sometimes getting null pipenet.
2015-01-07 00:20:36 -03:00
Remie Richards
f918815bea Merge pull request #6741 from tkdrg/atmoslog
Adds atmos investigate_log
2015-01-06 07:56:17 +00:00
Remie Richards
b798df68ab Merge pull request #6790 from tkdrg/ExhaustedPlumpCamel
Fixes a few RPD painting bugs
2015-01-06 07:20:28 +00:00
Menshin
c63af563bc Fixed binaries and terniary spawning with the same pipenet for all parents when constructed without connecting pipes (fixes #6632) 2015-01-06 00:43:59 +01:00
carnie
a730649167 Fixes breathing (indentation error)
Fixes atmos machinery (old global list snuck back into code)
2015-01-05 19:44:17 +00:00
tkdrg
2eb366de89 Fixes a few RPD painting bugs
Changes RPD colors to be consistent with pipe painter & default pipes.
Makes the RPD properly update its neighbors on painting.
Offloads the neighbor updating logic from pipe_painter to a pipe proc.
Fixes #6783
2015-01-04 04:35:36 -03:00
carnie
a3f5e7ebfd Merge branch 'master' of https://github.com/tgstation/-tg-station into SubSystems
Conflicts:
	code/game/gamemodes/setupgame.dm
	code/modules/mob/living/carbon/human/life.dm
	code/modules/reagents/Chemistry-Machinery.dm
2015-01-04 01:52:14 +00:00
Menshin
910cfdaf6e * Fixed normalize_directions() for valves and simple pipes (fixes #6746)
* Added missing icons for hidden HE pipes and junctions (fixes #6636).
2015-01-02 10:35:12 +01:00
tkdrg
e52ace562c Adds atmos investigate_log
Sort of ported from the /vg/ atmos logging by N3X15
Right now includes opening/closing pumps and opening/closing canisters.
Also adds a message_admins() when a plasma canister is opened.
2015-01-01 21:37:32 -03:00
carnie
a029a49392 SubSystem rewrite
Misc:

+Fixes unreported issue with initializing lighting on a specific zlevel

+Fixes two similar issues with moveElement and moveRange. Where fromIndex or toIndex could be adjusted incorrectly in certain conditions. Potentially causing bad-sorts, or out of bound errors.

+Rewrites listclearnulls(list/L) to no longer iterate through L.len elements for every null in the list (plus 1). i.e. went from L.len*(number_of_nulls+1) list-element reads (best-case), to L.len list-element reads (worst-case)

+New proc/getElementByVar(list/L, varname, value) which finds the first datum in a list, with a variable named varname, which equals value. You can also feed it atoms instead of lists due to the way the in operator functions.

+Fixes an unreported issue with Yota's list2text rewrite. Under certain conditions, the first element would not be converted into a string. Causing type-mismatch runtimes.

+New global map_ready variable. This is not fully implemented yet, but will be used to avoid duplicate calls to initialize() for map objects.

+All turfs now maintain references to all lights currently illuminating them. This will mean higher memory use unfortunately, due to the huge number of turfs. However, it will speed up updateAffectingLights significantly. I've used list husbandry to reduce baseline memory usage, so it shouldn't be any worse than some past atmos modifications memory-wise.

-Removed 'quadratic lighting', can add this back at some point. Sorry.

+modified the way lum() works slightly, to allow turfs to have overridden delta-lumen. i.e. space cannot be illuminated more than its default ambiance. This allowed removal of some iffy special-snowflake lighting areas implemented by somebody else.

+Lighting images in the dmi can now use arbitrary naming schemes. It is reliant on order now. This allows the dmi to be replaced by simply dropping in a new dmi.

-Removed all subtypes of /area/shuttle. Shuttles now create duplicate 'rooms' of /area/shuttle. (More on this later). This will conflict with most maps. Guide on how to fix to follow.

+All verbs/tools relating to world.tick_lag were refactored to use world.fps. However old config text for setting tick_lag will still work (it converts the value to fps for you)

+MC stats improved using smoothing. They now have their own tab so they dont get in the way when you're playing as an admin.

-removed the push_mob_back stuff due to conflicting changes. Sorry Giacom.

_OK, NOW THE ACTUAL INTERESTING STUFF_

Following systems moved over to subsystem datums:
air_master
garbage_manager
lighting_controller
process_mobs (aka Life())
nanomanager
power
sun
pipenets
AFK kick loops
shuttle_controller (aka emergency shuttle/pods), supply_shuttle and other shuttles
voting
bots
radio
diseases
events
jobs
objects
ticker

Subsystems hooks and variables should be commented fairly in-depth. If anything isn't particularly clear, please make an issue.

Many system-specific global variables have been refactored into

All tickers which previously used world.timeofday now use world.time

some subsystems can iterate before round start. this resolves the issue with votes not working pregame
2014-12-31 13:25:41 +00:00
Menshin
567bb27722 * Fixed unwrencheable atmos objects' stored pipe being wrongly created on New() because initialize directions weren't set when instanciating
* Fixed constructed unwrencheable atmos objects having a stored straight pipe , because dirs weren't set on instanciation
Those fixes, at least, bend pipes transforming into straight pipes on wrench/unwrench
* Fixed the digital valve pathing in some places
* Fixed bend pipes appearing as straight pipes when wrenched without connecting to anything

* Pipe colors are now preserved on wrenching/unwrenching
* Various clean-up of unaligned partially connected pipes icons
2014-12-29 20:34:13 +01:00
Swag McYolosteinen
7ee2317ec3 Merge pull request #6207 from phil235/RecursiveHearVisibleMessage
Mob inside something can now see visible_message()'s
2014-12-27 13:20:50 +01:00
tkdrg
a94012b98a Ports the rapid pipe dispenser (RPD) from /vg/
These are pocket devices that dispense unwrenched atmos/disposal pipes.
Despite the admittedly misleading name, these have infinite ammo.
There is no need to reload with matter cartridges or anything like that.

Currently, they spawn in atmos tech lockers, and as an engiborg module.
More can be obtained with the autolathe.
They are also a traitor "steal item" objective.
2014-12-25 22:06:39 -03:00
Menshin
42b701b57e * Fixed runtimes at init with the previous construction method for freezers, heaters and cryo cells
* Made engineers less clumsy when rotating machinery (turn at 90° instead of a random direction)
2014-12-23 18:00:39 +01:00
Menshin
5b50e34e95 * Made manifolds instancing compatible with maploader
* Fixed the runtime which happenend when a pipe was destroyed but not the meter connected to it
2014-12-22 22:11:55 +01:00
Hornygranny
8dee2d9b6e fixes unreported runtime 2014-12-19 15:22:49 -08:00
phil235
c667feeb61 Merge branch 'master' of https://github.com/tgstation/-tg-station into RecursiveHearVisibleMessage
Conflicts:
	code/modules/reagents/Chemistry-Holder.dm
2014-12-19 15:23:16 +01:00
phil235
f3df4e67bd Fixes monkey being able to ventcrawl if stunned after the ventcrawl action is initiated. Also changes ventcrawl messages to use visible_message() and audible_message(). 2014-12-14 19:18:13 +01:00
Daniel Hultgren
f48e9fcc15 Fixed valves 2014-12-12 21:23:44 +01:00
phil235
d545eb7f9f Visible_message() now uses recursive_hear_check so mob inside something can see those messages. Fixes being able to see visible_message w/o seeing the src of it (happened when the src could see us but not the other way around), you no longer see visible_message from mobs inside closets for example.
Fixes pAI being deaf.
Removing some no longer needed occupant_message() in mecha code.
Fixed some typos and span class here and there.
2014-12-04 01:08:04 +01:00
Razharas
5c66d5ba82 Merge pull request #6036 from Aranclanos/pipenetfix
Pipenet hotfix!
2014-11-25 03:12:11 +03:00
hornygranny
6d6835e22a Merge pull request #5910 from Razharas/PipeFix
Fixes qdel kidnapping pipes
2014-11-24 10:41:26 -08:00
hornygranny
cd9a8a5125 Merge pull request #5909 from Razharas/InputFix
Fix of atmos input exploit
2014-11-24 10:40:51 -08:00
Aranclanos
bc0de70e08 Fixes addMember() not adding the pipe brought in the argument if it had no other connections. 2014-11-23 21:17:39 -03:00
Razharas
ebeb3367c2 Merge pull request #5938 from hornygranny/piperuntimes
disposals fixes
2014-11-22 14:50:42 +03:00
Cheridan
1208c48af3 Merge pull request #5652 from Menshin/atmos_z_level_fix
Atmos z level fix + radio controller code sanitization
2014-11-18 17:05:14 -06:00
Razharas
e205c8f2f6 Merge pull request #5857 from paprka/lolnames
Fixes a bunch of capitalization inconsistencies, adds names to vendors
2014-11-18 03:46:26 +03:00
Hornygranny
967689e6dc fixes #5667 remove atmos pipe fix 2014-11-17 14:00:58 -08:00
Hornygranny
2374eb9720 fixes disposals flushing their stored construct
fixes an atmos runtime
fixes a disposal pipe runtime
2014-11-17 11:30:33 -08:00
Razharas
9a0f3f0c12 Fixes pipes and qdel
They dont disappear after multiple clicks anymore
They now show success message only once
Fix #5795
2014-11-16 05:47:30 +03:00
Razharas
2a20c6bcf3 Fix of atmos input exploit
What on tin
2014-11-16 05:18:22 +03:00
Menshin
d17103a2cc Removed an unused variable in valves.dm 2014-11-14 10:24:53 +01:00
Menshin
ec944abfc6 * limit atmos/fire alerts to the current z_level
* atmos/fire alerts are now linked to an object and not its area, as intended
* simplified and full pathed the radio frequency datum
* made radio objects properly clean on del/qdel, instead of letting the radio controller remove nulls at each post_signal()
2014-11-14 10:10:45 +01:00
Cheridan
24456bcc22 Merge branch 'PipenetRevamp' of https://github.com/Aranclanos/-tg-station into Aranclanos-PipenetRevamp
Conflicts:
	_maps/map_files/tgstation.2.1.3.dmm
	code/ATMOSPHERICS/atmospherics.dm
	code/ATMOSPHERICS/components/portables_connector.dm
2014-11-13 18:55:53 -06:00
paprka
fe94f9cab0 Fixes a bunch of capitalization inconsistencies, adds names to vendors 2014-11-12 15:37:21 -08:00
Cheridan
e49e4efe29 Merge pull request #5704 from phil235/TypoFix1
Fixes the ability to beat up a pAI.
2014-11-07 23:52:31 -06:00
phil235
20e90d1168 Fixes typos in message and icon. Fixes the ability to beat up a pAI. Adds a cooldown to attack_animal on mechs. 2014-11-05 14:45:47 +01:00
phil235
74f8a08522 Merge branch 'master' of https://github.com/tgstation/-tg-station into AttackAnimation
Conflicts:
	code/modules/mob/living/living.dm
2014-11-04 18:55:07 +01:00
Hornygranny
b7f0287469 fixes atmospherics not working 2014-11-04 01:10:18 -08:00
Cheridan
df13b0d840 Merge pull request #5591 from hornygranny/OOPgularity3
improved deconstruction, singularity stuff
2014-11-03 20:20:55 -06:00
Aranclanos
8aa5a137c5 Pipenet revamp
-Removed the pipenet network datum, now it will all be done with the pipeline datum
-All atmos pipes and machines will always have a pipeline datum
-Moved the valves to the binary subtype and the portable connectors to the unary subtype
-The pipe vents (who were barely used in three spots of the map) are removed, the map slots will replaced with outlets
-Fixes some bugs of pipenet disconnection, mostly on explosions
-Cleaned a bit the copypaste of construction.dm of pipes
-Removed the ID restrictions of digital valves and the frequency (both unused)
2014-11-03 08:21:31 -03:00
phil235
8b49caa5ee Fixes typos and show messages. Fixes attack animation code. 2014-11-03 01:06:02 +01:00
tkdrg
a97c4de972 Moves m_amt, g_amt, reliability and origin_tech to /obj/item (previously in /obj)
Removes force from pipes
Removes unused turf var icon_old
Moves pass_flags to /atom/movable
2014-11-02 14:10:03 -03:00
Hornygranny
955847de74 defines 2014-10-31 19:00:50 -07:00
Hornygranny
5815d7e011 grilles are now damaged by thrown items
disposalpipes deconstruction
atmos pipes deconstruction
2014-10-31 18:26:42 -07:00
hornygranny
7d02690a94 Merge pull request #5383 from Donkie/atmostankfixes
Fixed tank icons. Fixes #5374
2014-10-22 10:50:16 -07:00