## About The Pull Request
#89099 added Who and Adminwho to OOC, which I think is incorrect (as OOC
is for OOC chat specifically)
So I have moved them to INFO (which is, quote, "Non-urgent messages from
the game and items")
In a similar vein I typed "Tip of the Round" and "Show Server Revision"
as info rather than OOC and untyped respectively
## Why It's Good For The Game
I don't like pressing "who" and having to change to my ooc tab
## Changelog
🆑 Melbert
qol: "Who" and "Adminwho" are typed as "Info" and not "OOC" (so they no
longer go to "OOC" tabs)
qol: "Tip of the Round" and "Show Server Revision" are also typed as
"Info", rather than "OOC" and untyped respectively
/🆑
## About The Pull Request
Before there were two settings for human authority:
`ENFORCE_HUMAN_AUTHORITY` and `ENFORCE_HUMAN_AUTHORITY_ON_EVERYONE`
The first, if enabled, would not let non-humans be heads of staff unless
they had a specific var on their job set to TRUE.
The second, if enabled, would simply ignore that var and reject the
non-human anyways.
This PR replaces both of those settings with a single one,
`HUMAN_AUTHORITY`. You can set it to one of four settings:
* "OFF": human authority will be turned OFF. Non-Humans will be able to
be heads of staff.
* "HUMAN WHITELIST": human authority will be turned OFF, HOWEVER; if a
job has its new `human_authority` variable set to
`JOB_AUTHORITY_HUMANS_ONLY`, then whoever picks that job will be forced
to be human.
* "NON-HUMAN WHITELIST": human authority will be turned ON. However, if
a job has its `human_authority` variable set to
`JOB_AUTHORITY_NON_HUMANS_ALLOWED`, a non-human can become that job.
This is what we have now, it works the same as if
`ENFORCE_HUMAN_AUTHORITY` were turned on. This is also what I've set as
the default value.
* "ENFORCED" human authority will be turned ON. Non-Humans will never be
able to be heads of staff. This is what
`ENFORCE_HUMAN_AUTHORITY_ON_EVERYONE` used to do.
You can also now set the `human_authority` variable through
`jobconfig.toml`!
## Why It's Good For The Game
Allows more configuration options for downstreams, and lets keyholders
and headmins have more options over how to set up human authority.
## Changelog
🆑
config: Both human authority settings were combined into a singular one,
allowing for more flexibility
/🆑
---------
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
## About The Pull Request
123 changed files and multiple crashes after writing broken regex, I
replaced most remains of direct spans with macros. This cleans up the
code and makes it easier to work with in general, see justification for
the original PR. I also fixed a bunch of broken and/or unclosed spans
here too.
I intentionally avoided replacing spans with multiple classes (in most
cases) and spans in the middle of strings as it would impact readability
(in my opinion at least) and could be done later if required.
## Why It's Good For The Game
Cleaner code, actually using our macros, fixes borked HTML in some
places. See original PR.
## Changelog
Nothing player-facing
## About The Pull Request
You can read more about what's introduced in the last four versions
here:
https://github.com/tgstation/rust-g/releases
The immediate effects for us are as follows:
Closes#76549Closes#76514Closes#76502Closes#76490Closes#76398Closes#76798Closes#76921Closes#76934Closes#76950
the updates to install rust_g.sh were to cut down on the copypasta code
and prevent desyncs.
🆑
code: The currently operating rust-g version on a live server is posted
to places like the runtime.log, in the same place where the revision
information and any applicable test merges already were.
/🆑
* Beep beep gamemode removal coming through
* More cleaning
* More cleaning
* Clean up station_was_nuked
* Station nuke source
* Remove name
* More unused functions
* Remove antag rep, which was unused in dynamic
* Remove more antag rep stuff, which was UNUSED IN DYNAMIC
* Station goals outside of mode
* Remove setup_done
* Remove player lists
* Move some older procs
* Fix simulations
* Attempt to fix this stupid case sensitive bullshit
* Revert "Attempt to fix this stupid case sensitive bullshit"
This reverts commit 8693c02d67602543d7d4b92130a7a32cd973e5bf.
* ???
* Delete icons/Testing directory
* Move station_goals global definition
* FINALLY IT IS DONE FUCK
* tip of the round into ooc
* adds cyopod chat messages to the info chat filter
* last one I promise probably, mob spawner messages to info filter
* holoparasite, round will start in x and keybinding conflict to respective filters
* removed motd from constants, made it infoplain surrounded instead
* changed info to infoplain
Fixed and improved the bug report template use when the 'Report Issue' button is used in-game. It now uses the correct template location, as well as automatically filling in the round ID and testmerges.
We also now show [s] PRs that are testmerged, as ok-d by oranges, as this is an unofficial label that anyone can apply and doesn't necessitate hiding. It also makes debugging rounds where this was present but not reported more difficult.
* Unicode support Part 2 -- copytext()
This is the transition of all copytext() calls to be unicode aware and also some nearby calls in the same functions. Most things are just replacing copytext() with copytext_char() as a terrible character limiter but a few others were slightly more involved.
I replaced a ton of
````
var/something = sanitize(input())
something = copytext(something, 1, MAX_MESSAGE_LEN)
````
with a single stripped_input() call. stripped_input() already calls html_encode(), trim(), and some other sanitization so there shouldn't be any major issues there.
This is still VERY rough btw; DNA is a mess, the status displays are complete ass, there's a copytext() in code\datums\shuttles.dm that I'm not sure what to do with, and I didn't touch anything in the tools folder. I haven't tested this much at all yet, I only got it to compile earlier this morning. There's also likely to be weird bugs until I get around to fixing length(), findtext(), and the rest of the string procs.
* Makes the code functional
* Assume color hex strings are always # followed by ascii.
Properly encodes and decodes the stuff in mob_helpers.dm which fixes some issues there.
* Removes ninjaspeak since it's unused
In preparation of pixel movement, I want to refactor our slowdown system to something more modular, and something that doesn't require /quite/ as many proccalls/calculations a tick. The way this works is intended to only have things recalculate when it's necessary, rather than calling it every move.
However, I've left movement_delay() in, as without completely redoing a lot of code it's not /quite/ ready at this point to tear it out completely, but I'm hoping everything can be transitioned over to this system later.
This is primarily a compatibility layer that enables both forward and backward compatibility for all past and future APIs based on the detected running TGS version. It also bundles all it's includes to make future upgrades not have to modify the dme, heck, could even use a submodule if it wanted (not happening). No other changes necessary.
There's an upcoming event system and new chat management functions. Check them out here: 303448457e/DMAPI/tgs.dm
Also added /datum/proc/CanProcCall()
* wip
* wip2
* makes code actually compile on 511 + fixes
* versioning
* s
* adds python conversion script, schema change and removes 'force ' from item_used_for_combat
* fix to compile
* forgot to actually commit this
* New API for service communication
* Safer this way
* Gives the game the ability to kill itself
* tick_lag
* Sanity check
* Updates comment
* Formalization of the server tools API
* Fixes, finishes, and cleanup
* Remove unecessary scoping
* Compile fixes
* Didn't Ctrl+S
* Reimplement chat commands
* Fixup
* Required parameters
* Fax
* Testing
* Fix ON_TOPIC
* The more defines the more better
* That's bass ackwards
* Fix tgs2
* Fuck it, call him pichael
* Do this
* No, we only use the modern methods now
* Remove tgs2 relay support
* Remove kebab
* Kill kill kill
* This is back baby
* Missed a GLOB
* Remove DownloadPRDetails()
* Cache custom commands by name
* Adds "notify" chat command
* Use the official API
* Fix API misuse
* Readme licensing memes
* Fix API
* Moves chat new game announcement to when the API is confirmed compatible
* Add TGS3.json
* Fix the input options
* Removes notify command
* Configuration datum refactor
* More WIP
* New easier on the eyes format
* More WIP
* Finished config.txt
* Fucktons more WIP
* The end of conversion draws near...
* Add all this shit
* Done converting entries finally
* Hunting down compile errors
* More WIP
* MORE CONVERSIONS
* More WIP
* More WIP
* Oh shit only 90 errors this time!
* IT COMPILES!!!
* Fixes world start runtimes
* TGS3
* Fix line endings
* Enable 16-bit long topics
* Cleans up topic socket usage
* Reduces and refines the IRC status throttle
* Increase the CP status delay to a reasonable amount
* Fixes the testmerge command not having a keyword
* Clean up rebooting a bit
* Get error codes from windows when symlinking fails
* Clean up world announces
* Aborting compilation will kill the DD process
* Add support for changing the project name
* Removes the log page
* Add support for compile cancellation
* Version bumps and docs
* Add merge-pr repo CL command
* Fixes DM cancel command's help message
* Refactor command line to show better formatted help text
* Corrects a typo
* Multi-key game options must be manually edited
* Moving of the server installation from the control panel
* Fix a bug with server moving
* Corrects webclient disposal syntax
* Service now handles the PR Json the game uses properly
* PR listing command for CL
* Fixes reversed testmerge and update help entries
* Windows scheduling to help avoid reboot crashes
* Generalization of chat infastructure
* Brings a file name in line with everything else
* Shutdown exceptions no longer keep the service online
* Enable provider switching on the backend. More thread safety
* Support for switching, password encryption and defaults.
* Removes boilerplate on log writing
* Discord integration
* Update the installer dependencies
* Version bump
* Adds support for getting the latest byond version
* Fixes issue with not being able to set discord channels
* Fix being able to reconnect if chat is disabled
* Extra validation for interface types
* Add the Chat page for the control panel
* Various cleanup
* Set read ACL on the data directory
* Remove redundant namespace usage
* Fixes some buttons not updating the server page
* Future proof against upcoming removal of repo data directory
* Normalize Main declaration
* Update the IRC library
* Enables CTCP
* Removes useless hack
* Logging + enable IRC private messages
* Jobs config
* And finally the maps config
* Save the last config panel visited
* Not gonna use these
* Minor formatting cleanup
* Fixes the chat page not refereshing after clicking reconnect
* Fixes server page not initializing correctly
* Repo now defaults to tgstation github when not found
* Revert "Set read ACL on the data directory"
This reverts commit 15b0021ec51532bca14690a884caa81e811fbc46.
* Design the admin config page
* Prep format the repo's admin_ranks.txt
* Add a negative permissions field
* IRC now RFC quits before disconnecting
* Turns out that fixed the disconnect lag
* Updates the admin ranks config api to work for us
* Done with this config shit
* @optimumtact
* Fix this
* Fix the .wxs
* Try to get md5/sha1 working.
* Add FCIV to appveyor
* Generalize the command class
* Revert "Generalize the command class"
This reverts commit 5c61f6df58d66f0fea4170c8aee0cd5beaa99b5d.
* ITS THE FUCKING SEX NUMBER!!!!
* Final touches
* No THESE are the final touches
* Do not advertise
* Revert "Do not advertise"
This reverts commit f64281d486f9ca27e39f19635ab4deacb2d7e1ac.
* Hopefully the last version bump for long time
* Fix line endings
* Fix default dbconfig.txt
* Fix Discord not checking the right admin channel
* Fix discord listening on ALL channels instead of configured ones
* Package the discord fixes for @JamieH
* Format the testmerge data a little better
* Apply 7 character clamping of commit strings
* Fold admin hard reboot into regular reboot list
* Backward ahelp compatibility with the adminbus bot
* Removes an unecessary semicolon
* Fix stray merge conflict in the config
* Fix Newtonsoft being included by the commandline
* Improve byond update logging
* Chat cleanup
* Fixes some setup non-errors from being displayed
* Repository no longer counts being busy as being valid
* Repository no longer valid while cloning
* Fixes a nudge socket change issue
* Frontend cleanup
* Fixes CanStart race condition
* Fixes compile cancel delays
* Various fixes
* More fixes
* Better readme
* More readme
* Fix a config command description
* Add missing repo status command
* Never delete the backups
* Log the compiles
* More logging
* Stuff
* A thing happened, but I'm not sure what
* Tiny
* INB4 second squash
* Version bump
* Shallow clones should speed things up
* Regular clones
* This is how it's set on travis
* Fix this dupe
* Add backup tag support to backend and command line
* Add some missing repo commands, fix GetHead. Fix reset on branches
* Remove the interfaces for commit and push
* Remove that generate changelog checkbox
* Yeah, that's a misunderstanding
* Make changelog pushing a config, with no way to enable for now
* Add Reset and Recompile option
* Update readme
* Repo page cleanup
* Fixed NudgePort message possible repeating
Fixed Reset and Recompile option always being visible
* Fixed compilation copy not overwriting files
Fixed compiler trying to unecessarily delete the whole A/B folder
Improved game folder initialization speed
* Selectively stage the html folder
* Make the restriction a config
* Switch to using LibGit2Sharp+SSH
* WIP SSH support
* Removes some success chat messages
* Make repo authentication purely file based
* Quick IRC fix
* Should all work in theory...
* More fine grained
* Remove the username thing
* Use the right default email for tgstation-server
* Update the readme
* That's worthy of a version bump
* Speling
* Makes it do as the readme says
* Fix testmerge list not having a scrollbar
* Trying out commit message based deployment [TGSDeploy]
* Whoops
* Testing
* Better
* Version Bump [TGSDeploy]
* Need to set the var at parent scope [TGSDeploy]
* Use the commit message
* Try this [TGSDeploy]
* Try just this
* This maybe? [TGSDeploy]
* >like [TGSDeploy]
* Wildcard, bitches [TGSDeploy]
* Saner title [TGSDeploy]
* Readme update
* This should loin ya
* Fix it [TGSDeploy]
* Readme, cleanup, and doc updates
* Improve DD crash handling
* Version bump [TGSDeploy]
* TGS3 Config Changes
* Line endings
* Map config code change
* Missed a few
* Security and Visibility selectors for the Server page
* Fixes OCD
* Fax it
* Fixes
* Version bump [TGSDeploy]
* eh
* The word comment has lost it's meaning to me
* This is a terrible name but whatever
* Support config changes
* This is part of the code so it belongs with the code
* ExportService now has a return value
* Copying of the logs dir during compile for #27674
* Version bump [TGSDeploy]
* Removes some uneedful
* Moves daemon config to BYOND folder, much safer
* Fix a config comment translation miss
* Fix project settings issue
* Fix config apply button not showing up after repo clone
* Fix anchoring for Backup Tags: label
* Version Bump [TGSDeploy]
* Nudge port only listens while server is running
* Fix some instances of the control panel crashing when the service stops
* Add start menu shortcuts
* Remove the actual server
* Remove appveyor
* Fix gitignore
* And this
* Readd HTTPS_Get for now
* Readd legacy support
* Fix
* Fix this stuff
* Last thing
* Line endings
* Final touches
* Dat newline
* More stuff
* Where'd that go?
* Real final touches
