Commit Graph

650 Commits

Author SHA1 Message Date
nemvar
b7134336d7 Fixes the unstable quirk (#49309)
* Fixes mood 100% super duper for real this time

* fixes mood for real, removes a bit of convoluted code.
2020-02-12 19:01:04 -05:00
AnturK
e40e22da6b Another runtime fixes batch. (#49209)
* Slime gland runtime fix.

* Logout ahelp logging runtime.

* Crafting non-items runtime.

* Turret building runtime.

* spacevine runtime.

* forcesay runtime fix.

* One less var
2020-02-10 10:50:36 -05:00
Emmett Gaines
ece3c04ca3 Fixes an issue where you could unregister someone else's signal (#49224) 2020-02-07 19:46:41 +01:00
Dennok
d49b9c369d nanite shock protection respect (#49154)
now other sources of shock protection protect nanites
2020-02-07 11:43:51 -05:00
Fikou
8deeceefb6 [READY] Adds rideable Goliaths (#49003)
* adds rideable goliaths

* stamding on the emdge

* plems work

* this should be it

* FUCK YOU TRAVIS

* primal friendly

* ok athath buddy

* mmm grayons

* sprite gang

* placeholder sprite, works till someone makes a new one maybe haha

* lets do this

* An object tames a monstrous beast somehow. More news at 5.
2020-02-07 17:00:07 +01:00
Jordan Brown
ce9577663a Merge pull request #49173 from ninjanomnom/material-lazy-init
Makes the global materials lookup lazily initialized
2020-02-04 11:05:59 -05:00
Qustinnus
48de09b7a4 Edible component; be gone vile organ code (#48596)
* component

* progress

* stuff

* Makes minor progress on edible component

* Finishes component and applies it to organs

* newline

* forgot to send signal

* domob addition

* wave that organ flag

* return adde

* fixes some minor issues

* fixes

* done

* done

* done

* added last one

* done

* done

* fix
2020-02-04 01:05:55 -05:00
Emmett Gaines
2cf7728494 Removes the bitflag helpers (#49106) 2020-02-03 16:26:00 -05:00
Emmett Gaines
ab3a127295 Makes the global materials lookup lazily initialized 2020-02-03 10:17:13 -05:00
Time-Green
8ecbacc002 fixes item reactions breaking plumbing (#49088)
🆑
fix: fixes reaction chamber breaking with flour-like reactions
/🆑
2020-02-01 20:49:34 +13:00
blessedmulligan
54dc879f19 Cyborg spin throwing now depends on intent (#48891)
Trying this again. When *spin-ing as a cyborg, the way mobs are thrown off you depends on your intent. On help intent, they will be thrown a shorter distance from you and will never be damaged or stunned (they will still be knocked down). On harm intent, they will be thrown the current distance and will be damaged and stunned if they hit a wall or another person.

WHAT THIS ACTUALLY CHANGES:
Currently, whether or not *spin-ing will actually hurt/stun someone depends on whether or not the *spin-ing borg is emagged. This PR also reduces the range of the help intent throw, but since the knockdown happens whether or not the thrown mob hits something this is in most circumstances a cosmetic change. So, in summary, if you are a non-emagged borg in help intent the only thing this changes is you will chuck people a slightly shorter distance.
Why It's Good For The Game

This isn't exactly the most important change, but a borg should be able to control their behavior. Having damage/stun from throwing determined solely by emag-ness seems more like a hacky kludge than a legitimate design choice. Also, having the behavior of borg-throwing determined in the code for carbons is messy.
Changelog

🆑
add: The behavior of cyborg's *spin emote now changes with intent; on harm intent, it will throw its passenger farther and damage and stun them if they hit a wall or another person.
/🆑
2020-02-01 20:30:57 +13:00
81Denton
0a7e819b07 Merge pull request #48882 from XDTM/BepisProgramsPartOne
[Ready][Ready]Adds the Nanite Replication Protocols node to BEPIS
2020-02-01 08:05:00 +01:00
81Denton
14abd06e81 Merge pull request #48779 from Fikou/patch-94
you can only slice aggressive grabs or higher now
2020-02-01 07:58:51 +01:00
Mickyan
4ec3f952f0 proper fix 2020-01-30 20:26:48 +01:00
Mickyan
54edfc27cd sanity fix 2020-01-30 19:43:02 +01:00
ma44
a338b0a584 Refactors the crafting component (#48765)
About The Pull Request

Allows the crafting component to not be limited to just mobs but also able to be put on just about any atom, in addition it also gives a bit more settings to play around with like increasing the range of the ingredients search or choosing what to do with an item before it's placed anywhere.
Why It's Good For The Game

Enables greater functionality and may be a precursor PR before implementing automatic crafting machinery as this PR would allow machines to be able to do such a thing.
Changelog

🆑 ma44
refactor: Crafting has now been refactored and allows non mobs to have the ability to craft, at least that's what would come out of it if someone further developed the idea.
/🆑
2020-01-29 11:44:21 +13:00
AnturK
b7aa7ef4b4 Saves a bit of memory per decal (#48985) 2020-01-27 16:28:23 -05:00
AnturK
3b53192d46 Merge pull request #49011 from AutomaticFrenzy/patch/docslink
Fix docs link in components readme
2020-01-27 13:33:16 +01:00
Time-Green
d7db7c0605 Fixes plumbing ducts appearing disconnected (#48924)
* fixes ducts appearing disconnected

* adds comment to remove connects

* adds newlines for comments and fixes an autodoc typo
2020-01-27 11:25:32 +01:00
Tad Hardesty
906e912a8e Fix docs link in components readme 2020-01-25 15:53:09 -08:00
Rohesie
7bef84f009 Mass-replacement of stat to machine_stat (#48758)
Living and machine stat vars are pretty different, one uses flags and other number-defines.
This should make some other mass-replacements and searches a bit easier.
2020-01-24 12:37:17 +13:00
ArcaneMusic
b62d105228 Adds the Wood Datum Material, giving it to items made from wood. (#48820)
* Initial commit, wood datum mat. Works on my machine.

* Wait this makes baseball bats worthless nevermind

* Review changes, uses the define now, just don't know how bitflags work well enough for that other bit

* Adds the material dependance check

* FINE
2020-01-23 17:36:10 -05:00
skoglol
d61239fa14 Merge pull request #48921 from itseasytosee/Beergoggles
Separates beer googles into science glasses and beer goggles. Sprites for each!
2020-01-23 03:41:31 +01:00
skoglol
b735d25cb6 Swaps boh and ooc confirm dialog button positions (#48905)
* Swaps boh confirm dialog button positions

* and the ooc alert
2020-01-22 12:52:17 -05:00
Flint
c7e7e2ac97 The separation 2020-01-21 16:48:31 -06:00
XDTM
69f19900bc updates 2020-01-19 14:01:52 +01:00
XDTM
c3ad4282a5 Adds a nanite node to BEPIS 2020-01-19 03:34:17 +01:00
MrPerson
f7eb2c905b Unicode awareness Part 2 -- copytext() (#48512)
* Unicode support Part 2 -- copytext()

This is the transition of all copytext() calls to be unicode aware and also some nearby calls in the same functions. Most things are just replacing copytext() with copytext_char() as a terrible character limiter but a few others were slightly more involved.

I replaced a ton of
````
var/something = sanitize(input())
something = copytext(something, 1, MAX_MESSAGE_LEN)
````

with a single stripped_input() call. stripped_input() already calls html_encode(), trim(), and some other sanitization so there shouldn't be any major issues there.

This is still VERY rough btw; DNA is a mess, the status displays are complete ass, there's a copytext() in code\datums\shuttles.dm that I'm not sure what to do with, and I didn't touch anything in the tools folder. I haven't tested this much at all yet, I only got it to compile earlier this morning. There's also likely to be weird bugs until I get around to fixing length(), findtext(), and the rest of the string procs.

* Makes the code functional

* Assume color hex strings are always # followed by ascii.
Properly encodes and decodes the stuff in mob_helpers.dm which fixes some issues there.

* Removes ninjaspeak since it's unused
2020-01-18 13:07:22 +13:00
Fikou
1660a962c5 neck slices now dont work on critical/sleeping people 2020-01-14 19:26:30 +01:00
Fikou
9c5cf98ce8 buff 2020-01-14 00:30:53 +01:00
Fikou
72bc98698d you can only slice neck grabs now 2020-01-14 00:10:05 +01:00
Ghom
1e15900f2d Fixes shock paddles being insertable in BoH (#48643)
* Fixes shock paddles being insert able in BoH

* Redundant.
2020-01-12 19:34:20 -08:00
Fhaxaris
c6759b6ceb Fixes all explicit occurrences of rand() being used incorrectly. (#48732)
It doesn't return non whole numbers just because you gave it a range of non whole numbers. So don't do that.
2020-01-12 00:20:38 -05:00
MrPerson
e22560a346 update_icon() improvements (#48669)
* update_icon() improvements

Fixes some update_icon() calls to properly call parent and use update_overlays() and update_icon_state().

The rest of obj/item fuck it

* Suggested fixes, also passes the linter

* I always forget . = ..() is faster than return ..() FOR SOME FUCKING REASON

* Actually this is better

* Signilzes datum/action to update its icon when its connected item does.
2020-01-11 23:46:43 -05:00
skoglol
284c0fec72 Merge pull request #48702 from LudwigVonChesterfield/tactical_fix
Fixing a small typo in tactical.dm
2020-01-11 05:42:10 +01:00
wesoda25
030303d952 Ethereals now discharge electricity if their charge is too high (#48573)
* if this works i will be happy

* :(

* explosion

* brutemod

* george melons
2020-01-10 23:14:41 +11:00
Dennok
a2fc1614a6 You do not lose the storage window on storage pickup. (#48685)
* do not lose the storage window on pickup

do not lose the storage window on pickup

* Keep update_actions()
2020-01-10 21:35:02 +11:00
LudwigVonChesterfield
4bc7053b73 A small typo in tactical.dm allowed for a funny. 2020-01-10 00:32:04 +02:00
kevinz000
32be60459f living, not mob (#48655) 2020-01-08 18:16:35 -05:00
skoglol
1986466aa7 Fix converting riot shield subtypes to strobe shields (#48541)
Basically this would let you upgrade fake roman bucklers to fully 
fledged riot shields with a flash on them.

Also fixed some inconsistent list indentation.
2020-01-04 22:25:38 -08:00
skoglol
04880ca76c Merge pull request #48556 from ShizCalev/caltrop-fix
Caltrop / glass / lightbulb crossing fixes
2020-01-04 21:56:26 +01:00
Rob Bailey
ba876548f3 Revert "[ready] Smooth-ish move rising: revengeance" (#48156)
Reverts #47817

People are complaining about motion sickness and I don't know what the issue is.
2020-01-04 23:58:31 +13:00
ShizCalev
ea56f83e58 Caltrop / glass / lightbulb crossing fixes 2020-01-03 04:47:06 -05:00
swindly
ee056e6cba fixes check_contents blacklist check (#48520) 2020-01-02 14:53:09 -05:00
81Denton
557d5f3266 Merge pull request #48505 from ninjanomnom/waddle-element
Makes waddling an element
2020-01-01 17:19:17 +01:00
Emmett Gaines
c6e71c5384 Makes forced_gravity an element 2019-12-31 13:00:47 -05:00
Emmett Gaines
119c4ebca3 Makes waddling an element 2019-12-31 12:55:53 -05:00
ShizCalev
9f532650b3 Pin removal recipe turned into proper tool_act. Has examine message informing you that you can do the thing. Now plays proper tool sounds. (#48461)
* Pin removal recipe turned into proper tool_act. Has examine message informing you that you can do the thing. Now plays proper tool sounds.

* fixed message
2019-12-31 09:18:33 -05:00
Jordan Brown
6d50877333 Fix crafting (#48477)
Initializes the instance type list before attempting to add to it.
2019-12-31 11:53:32 +01:00
Jordan Brown
bed37b7bb2 Fixes Intellitater crafting deleting AIs (#48451)
* Adds safety requirement checking to crafting

/datum/crafting_recipe now has check_requirements() which will be called once item instances that will be used are collected. If this fails, the crafting will be aborted.

* Prevent populated AI cards from use in crafting.

- Overrides check_requirements for the aitater crafting_recipe, failing it if there is an AI present in the candidate card.
2019-12-29 13:20:45 -05:00