About The Pull Request
Shuttles no more ruin areas on fly off from moved custom
dock.
If you dock to custom dock, then move custom dock, after fly off shuttle turfs lost its areas, it replaced by space. It ok in space, but bad on lavaland.
Why It's Good For The Game
Gravityless and airless areas on lavalend is bad.
Changelog
cl
fix: Shuttles no more ruin areas on fly off from moved custom
dock.
/cl
About The Pull Request
This PR add "Bluespace Navigation Gigabeacon" that shuttles can use as a target for the jump computer.
You can customize locked status by multitool or name of beacons by multitool with unscrewed beacon.
If you, or emp, lock beacon you are still able see it in choice list like a "Locked" destination, but unable to jump to it.
Why It's Good For The Game
Now any spacemen can construct their own Space station on any Z lvl (that not reserved, centcom, away mission) and dock (by custom dock) his ship to it.
Now we actially have some shuttles that have ability to place custom dock.
That one is whiteship, but only if its not UFO, 4 ships in caravan ambush(for 2 need sindycate access), +1 for nuclear ops(sindycate access), but dont forgot that Admins can spawn "navigation computer" to any shuttle.).
Lavaland safari likers now can land anywhere where they can fit a ship, on lava, basalt, and plating turfs, also asteroid.
I drop some bombs to clear spot and land to lavaland.
http://recordit.co/qN10qfuift
Here i create dry dock near station and dock ship into it.
http://recordit.co/R4kXqN8rnt
all walls and other floors are forbidden to prevent you landing on the station
possibly more random gibberish?)
maybe change plating to reinforced (engine) floor.
Navigation computer now use trait blacklist to filter out z levels to where it can't place custom dock.
This make easy to add new z lvls where it can place dock.
* makes luxury shuttle more user friendly
* Makes it so change is placed in-hand, slimes aren't told to pull something when they can't and dragged IDs override worn IDs so a bank account is looked for on them instead
* Makes it so if the change doesn't go into a human's hands, they will be pulling it behind them instead.
In advance of eventually adding SpacemanDMM's linter to Travis, fix everything it can currently detect.
Some lists, including global lists, are given types so that L[i].foo expressions can be checked.
Some procs are given a new form of return type annotation so that DuplicateObject(O).forceMove()-type invocations can be checked.
Open to syntax suggestions on the return type annotations, and on whether the preprocessor strategy makes sense.
Return type syntax is currently roughly:
<typepath> | <paramname>([_])*(.type)?
* will this work?
* add shuttle console to meta
* add shuttle console to box
* remove glide size from box, add shuttle console to delta
* replace airlocks in lavaland common area
* remove step
* secure the gulag a bit more, add a beer fridge
* restore unix line endings?
* Update code/game/objects/structures/crates_lockers/closets/secure/freezer.dm
Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>
* review
* Removes shuttle manipulator
* oops
* moves ui to ssshuttle
* fuck it lets just remove it.
* ooops
* Revert "fuck it lets just remove it."
This reverts commit 8a95879f21d3f4aad3d56e33fa90ebc1940c1e27.
* re-remove the old admin proc
Cables now autoconnect on cardinal directions. All cable placement has been completely stripped out and replaced with simple single cable per tile logic.
Low effort demo: https://www.youtube.com/watch?v=fXp8s6ORWbA
Yes I am aware that cutting it is not dropping wire, that version was bugged.
Cables no longer need a knot specifically placed to link to power objects. The sprite is automatically changed to represent this.
The only exception to this logic is that on smes units, due to the terminal being next to the output, they will not link there.
On a technical powernet side, this is the same as old cables once actually placed. They still use the existing powernet system, just the placement and connection works differently.
Old cables have been turned into "pipe cleaners" for wire art purposes. they work just like the old ones, just missing all the powernet functionality, and also you can put them on top of the floor.
Why It's Good For The Game
How obnoxious cables were to both map and work with in game has been something that has annoyed me for a really long time now.
This is both easier for new players to learn, and easier for experienced players to work with.
Along with making in game much more intuitive and easier, it makes mapping much easier as well. Mad lad wjohn was able to rip out all the mapping conversion in one day because of how much faster it is to work with.
cl actioninja and wjohn
add: Cables have been completely reworked. Simple per tile connection logic, automatically connects to things above it. Think minecraft redstone.
add: Old cables have been kept as pipe cleaner. They are non-functional in terms of power, but otherwise have the same connection logic. Also can go on top of tiles.
remove: mech cable layer has been removed because it was terrible shitcode nobody used
tweak: (sort of balance) cable stack sized has been reduced to 15.
/cl
Like it says on the tin, mappers no longer need to set the stationary
dock area type as it will use the area type of whatever it starts on.
This is how they all worked anyway, but you can still set it yourself if
you find some very strange usecase for having a different area type.
About The Pull Request
Shuttle sounds previously played PER DOOR AT MAX VOLUME
This fixes that problem by instead playing shuttle sounds from the nearest engine or door if there's no engines.
Also there's distance sounds.
Why It's Good For The Game
it's not because it's actually SOUL for the shuttle sound to horribly ear rape you when it has enough doors.
Changelog
cl
fix: Shuttle sounds should no longer ass blast your ears as they no longer play PER DOOR and instead from the nearest engine, or door if none are available.
soundadd: Distant shuttle sounds.
/cl
* Larger mining shuttle with power connection when docked with the station. Only in use on boxstation right now.
* Whoops, forgot to add the actual shuttle!
* Fixes cable connections across shuttles
* Unlocks the APC in the mining shuttle.
* Initial changes
* I need my scratchpad for another PR real quick
* Access and code shuffling
* First pass at small_item markers
* Second pass at small_item markers
I think I did this right...
* Maybe I should save the files I have open
* small pack additions
* Update tgui.js
* Removing some (imo) redunadant packs.
* removing 1911 pack
press F to pay respects
* missed a debug
* reorganization
* bit of cleanup
* removed some leftover disabled code
* That red X is bullshit and you know it
* Adds toggleable darkmode to the game! (Use the toggle darkmode verb if you want to use light mode)
* Removes a random linechange
* Undo unintentional changes
* Changes some forced font tags to use spans, which won't break darkmode.
* Fixes up some problems I found while testing
Darkmode is no longer default (this caused some issues with people getting a broken chat)
* Darkmode sucks less now
* Darkmode button now works again
* Refactors NODROP flag into TRAIT_NODROP
🆑 coiax
fix: Anti-drop implants can no longer be used to drop objects that they
were not responsible for sticking to a person's hand.
fix: Backfiring with a Barnyard spellbook will now play a spooky horse sound.
refactor: Refactors the way that "NODROP" items work to a new system,
there should be no change in functionality.
/🆑
Various items in the codebase were doing weird hoop jumps in order to
preserve the nodrop flag's state when it also wanted to change it, so I
moved it to a trait system.
I may have gone overboard with the type of unique trait sources, but
those can be changed later. My long term plan is make a general "CURSED"
nodrop origin, which means you can unlock cursed items by being hit with
a bolt of door opening or something. But that's for another PR, this has
no functionality changes, apart from some slightly modified descriptions
on cursed masks.
- Removed a bunch of redundant voice changing code for all the voice
changing animal masks, used two new clothing flags for this purpose.
- Also refactored a bit the animal masks, making new cursed subtypes that play
the sound when created.
* Drop location
* Hardened Syndie Shuttle
* Fixes
* Fuck borgs
* Review
* Syndie turrets are now set to lethal by default
* here's hoping
makes the required changes this time with TGM(?)
* dv cleanup 1
* Cleans up two non-replaced plastitanium walls.
Nobody opens commit descriptions. Except the cutie reading this.
* Cleans up the turf I know I changed but somehow didn't in the final version.
- Normal shuttles that are not emagged will no longer throw things around.
People will still be knocked down.
- Emagged shuttles and poorly designed shuttles will also throw things
around on tables, as well as closets.
Shuttles were not mapped with the idea that their contents would be thrown
around violently every time they moved. This means that things like wheely
chairs, potted plants get chucked about the place. To get around this, the
"magnetic_catch" component was added, to partially bypass this effect in the
first place. But this component is only used in one place, in shuttle loading,
which means if a shuttle is custom built, suddenly and unexpectedly,
everything flies everywhere.
Instead, violent shuttle throwing should be limited to crappy shuttles,
(ie. asteroid with engines) and emagged shuttles. As such, I've removed
the magnetic component from tables and racks, to make shuttle throwing
more violent when it happens.
Basic multiZ mob movement procs (Observers can always move)
Open space, showing what things are below it, and everything that entails. No complex support for dynamic generation just yet.
Decide how openspace should look :/
Atoms falling through open space (NO MOB SUPPORT/DAMAGE/ANYTHING YET.)
//CANCELLED FOR ANOTHER PR - [ ] Being able to see upwards? Downwards is going to be handled by open space.
MultiZ tile atmospherics - EDIT: Working demo! https://puu.sh/B7mUs/3f6274740f.mp4
Bugtest the heck out of this trainwreck.
cl XDTM
add: You can now pay for cargo orders from your account with the cargo requests console. Credits will be detracted from the requester's account instead of the cargo budget. A 10% handling fee on top of the order will be paid to the cargo department budget.
add: Cargo employees must still accept the order for it to be delivered.
add: The delivery will arrive in a locked crate that can only be opened by an id with the paying bank account.
/cl
If you're wealthy, why should you waste your time waiting for cargo to get money? Pay for the stuff yourself; the quartermaster won't have to worry about their budget and will likely just put the order in the next shipment.
* Initial stage
* final changes?
* Tweaks
* removed bad variables
* Fixed more bad vars
* is this map merged?
* spelling fix
* spelling fix
Co-Authored-By: TheDreamweaver <austin.j.rickli@gmail.com>
* Map fix?
* now this is map merger
* Fixed summoning edge cases
* Fixed spelling mistakes, Added better handling of sphere removal, Added sphere to the cargo shuttle blacklist, Made the "mystery" more dynamic
* Added better handling of stored mob summoning
* Removed redundant code.
* Made the jukebox actually accessible
* Tweaked it so that no maps would need to be loaded on Init
* comment commit
* No src
* Fixed spelling and getting trapped in rocks
* Fixed spawned-in hotel checks
* Blacklisted hotel are from blueprints and migrated storage handling from door to area.
* Prevents observing mobs (ghosts, camera entities) from getting stored.
* Condensed an if statement
* The hotel can now be used on another mob to invite them to the hotel. All living mob types can now exit out the hotel door.
* Fixed wrong user getting prompted when hotel was used on someone else.
* Added peepholes to hotel doors that can be used via AltClick.
* For the grammar lovers.
Aiming to implement the framework oranges has detailed in https://tgstation13.org/phpBB/viewtopic.php?f=10&t=19102
Moves canmove to a bitflag in a new variable called mobility_flags, that will allow finer grain control of what someone can do codewise, for example, letting them move but not stand up, or stand up but not move.
Adds Immobilize()d status effect that freezes movement but does not prevent anything else.
Adds Paralyze()d which is oldstun "You can't do anything at all and knock down).
Stun() will now prevent any item/UI usage and movement (which is similar to before).
Knockdown() will now only knockdown without preventing item usage/movement.
People knocked down will be able to crawl at softcrit-speeds
Refactors some /mob variables and procs to /mob/living.
update_canmove() refactored to update_mobility() and will handle mobility_flags instead of the removed canmove
cl
rscadd: Crawling is now possible if you are down but not stunned. Obviously, you will be slower.
/cl
Refactors are done. I'd rather get this merged faster than try to fine tune stuff like slips. The most obvious gameplay effect this pr has will be crawling, and I believe I made tiny tweaks but I can't find it Anything I missed or weird behavior should be reported.
cl XDTM
tweak: Holding an ID in your hands uses it instead of your worn ID for authentication purposes.
tweak: If you don't have an ID in your id slot, the belt slot will be checked as well.
/cl
Fixes#40437
Makes sense if you want to use a specific access card without playing pocket tetris. The get_idcard has an argument for prioritizing worn id over held id, for stuff like identification.
cl XDTM
add: Added credit holochips, a form of semi-physical currency to use in transactions. They can be generated by id cards by drawing from bank accounts and can be used to make payments.
add: There is no limit to the amount of credits that can be stored on a holochip, but being holograms they are vulnerable to electromagnetic pulses, and may disappear if exposed to one!
add: Holochips can be split with alt-click, and can be merged by clicking on another holochip.
/cl
Inserting physical cash into ids and printing it on the go is really jarring, and since we're on a sci-fi universe i think that hard-light hologram chips with encrypted credits sounds more believable.
As a plus, they don't have to deal with messy stack calculations with different denominations, and simply have a credits var that holds their amount. They change color based on the amount of cash for easy recognizability.
