Commit Graph

56136 Commits

Author SHA1 Message Date
MMMiracles
83c841f799 Tramstation: Big Brother Update (#58627)
* tram cameras, science tab on tram, lavaland dock

* adds 2 boxes of beakers + 1 bodybag in the main medical area

* buffers for chem heaters or w/e

* punny puns

* sci stuff
2021-05-06 04:49:53 +02:00
LemonInTheDark
c906c44393 Fixes a fuck ton more harddels (#58779)
Redoes how geese handle eating shit, it was fucking stupid and caused harddels, and while this method is technically slower in the best case, it's a fucking goose
Fixes action related harddels, I hate how they work but at least this way they won't hold refs.
Fixes the hierophont causing its beacon to harddel
Removes the M variable from megafauna actions, it was used like a typed owner and caused harddels, so I burned it
Fixes target and targets_from harddels, replaces all setters of target with LoseTarget and GiveTarget, which should help maintain behavior. I'm not sure if this breaks anything, but if it does we should fix the assumptions that code makes instead of reverting this change
Fixes more area_senstive_contents related harddels, we need to allow the mob to move before clearing out its list.
Fixes marked object harddels (I'm coming for you admin team)
Fixes a language based human harddel
Fixes managed overlay related harddels (This was just emissive blockers, but I think this is a good safety net to have. If we clear the overlay list we should clear this one as well)
Fixes bot core harddels, I hate the fact that this exists but it has no reason to know who its owner is
Adds a walk(src, 0) to simple_animal destroy, it's the best bang for the buck in terms of stopping spurious harddels. Walk related harddels aren't that expensive in the first place, since byond does the same thing I'm doing here, but this makes finding mob harddels easier, so let's go with it
I fixed another source of part harddels, I hate fullupgrade so much
Fixes all the sound loop harddels
2021-05-05 10:57:27 -04:00
Celotajs
978055b90d Warn player about cost of implant uplink (#58872)
Co-authored-by: celotajstg <celotajstg@users.noreply.github.com>
2021-05-05 02:18:23 -07:00
ATH1909
16ae23e0b6 fixes some species trait issues (#58879) 2021-05-05 01:50:33 -07:00
ZeWaka
b86aaf3307 Fixes bitwise flag negation errors. (#58870)
These have been in the codebase for many years. Love, ZeWaka
2021-05-05 01:37:56 -04:00
mandosegua
2a2e784007 Swarmers no longer able to make hullbreaches on the shuttle (#58874) 2021-05-05 01:36:00 -04:00
ATH1909
09a2913717 the backfire effect of killer tomatoes no longer requires the liquid contents trait (#58880)
* e

* accidentally modified the wrong one, whoops
2021-05-05 01:33:40 -04:00
tralezab
905b9b5a2b Component readme file now links to the Signals, Components, and Elements HackMD page instead of the forum (which links to the hackmd page now anyways) (#58876) 2021-05-05 01:32:26 -04:00
LemonInTheDark
4e53d8c4bc Removes some boiler plate from working with atmos code (#58885)
Everything that called turf.assume_air and turf.remove_air was already updating turfs, and all that not tying

the two together did was add more boiler plate, and break things when people forgot about it.

This shouldn't add any overhead outside of hotspots, but I think that's trivial
2021-05-05 01:31:30 -04:00
Seris02
ff2f6abe83 Sort the majority of the rest of the unsorted chat (#58821)
* FINALLY IT IS DONE FUCK

* tip of the round into ooc

* adds cyopod chat messages to the info chat filter

* last one I promise probably, mob spawner messages to info filter

* holoparasite, round will start in x and keybinding conflict to respective filters

* removed motd from constants, made it infoplain surrounded instead

* changed info to infoplain
2021-05-05 05:57:40 +03:00
tralezab
fa83a686c4 Add #cargobus and gauntlets (also modernizes ntchat) (#58609)
* cargobus, start of gloves

* basics of the HAUL gauntlets

* fully mapped in

* almost forgot the gauntlets

* ntnet improvements

* cargo gaunts, tablet cargobus

* excludes body bags

* dmis and map back

* readd icons
2021-05-05 05:56:39 +03:00
Urumasi
187c91fba4 [Ready] *smacks table* Objection! (#57304) 2021-05-04 06:42:51 -07:00
Celotajs
99ce137e6c Convert PDAs to GAGS (#58844)
* Convert PDAs to GAGS

* Leave the clown PDA as it was

Co-authored-by: celotajstg <celotajstg@users.noreply.github.com>
2021-05-04 15:37:01 +02:00
Emmett Gaines
4367cb09bd Adds new wrinkles to monkey brains (#58631)
This does a variety of improvements to monkey ai that I got drawn into after fixing a relatively simple bug with monkeys and guns. This pr is in support of #58565 so that in the rare chance pun pun gets a gun, they know how to use it. Previously #16630 made it so monkeys could use guns but semi-recently that was broken. Now that's fixed and in addition some other monkey ai capabilities were enhanced, read the changelog for the full list.
2021-05-04 08:32:31 +01:00
YakumoChen
756e507453 Love potion grammar fix (#58851)
* Update _potions.dm

* Update _potions.dm
2021-05-04 08:56:25 +02:00
Fikou
0e8e403a5b fixes fake chasms not dropping floortiles and borgs having their floor tiles deleted when reskinning (#58853) 2021-05-03 23:50:15 -07:00
Thunder12345
b7cb5cea16 Converts circuitboards to GAGS (#58841)
Co-authored-by: Thunder12345 <stewart@critar.demon.co.uk>
2021-05-03 16:53:57 -07:00
Jonathan Rubenstein
d79db03bfc Lowers chem gun capacity to 90 units (#58807)
Reduces the capacity of the Reagent Dartgun from 100 to 90.

From Minor Suggestion: https://tgstation13.org/phpBB/viewtopic.php?p=598719#p598719
2021-05-03 21:55:29 +01:00
Celotajs
489d47a4b1 Move give SDQL spell to Debug.Admin (#58825)
Co-authored-by: celotajstg <celotajstg@users.noreply.github.com>
2021-05-03 21:53:44 +01:00
tralezab
8000c7f80e Mutations with class MUT_OTHER can no longer be saved (#58815)
* turns towards camera "bruh"

* actually, lets remove it from being saved, not loaded.
2021-05-03 15:35:37 +02:00
cacogen
db8dd61075 RCD repairs grilles before adding windows to them (#58812)
* RCD repairs grilles before adding windows to them

- Grilles need to be clear of unanchored items for a window to fit on them
- Attempting to build a window on a grille with unanchored items on it will automatically move 20 of them to your tile
- If more than 20 items are on a tile, adding the window will fail (but you can just do it again to move 20 more)
- Grilles no longer rely on a subtype to break

* Uses text macro thing for simpler code
2021-05-03 15:02:03 +02:00
Beatrice
f73b89987a Lighter Grammar Fix (#58813)
* Sing -> Singe Replacement

Self explanatory. Replaces sing with singe

* Removes Scorch, Just In Case
2021-05-03 14:55:55 +02:00
Yenwodyah
8b33b8c03a Move SM sliver to layer above the crystal (#58783) 2021-05-03 14:53:48 +02:00
YakumoChen
65b2d83adf Pierced Reality / Singulo toy NO_PIXEL_RANDOM_DROP (#58837) 2021-05-03 05:25:33 -07:00
LemonInTheDark
9d6a7c7045 Fixes gib code creating more then one rot component per gib (#58838)
Co-authored-by: Fikou <piotrbryla@onet.pl>
2021-05-03 05:24:51 -07:00
Fikou
eb67ebe0f7 chief engis and captains gloves are now not flammable (#58839) 2021-05-03 05:24:11 -07:00
LemonInTheDark
0cd6599e2d Cleans up a use of air_contents in pipeline code, it's not doing anything yet, but if someone wants to change how reactions work they might break it. Adds a proc override to catch taking damage, which fixes the canister not leaking until it's updated (#58829) 2021-05-03 05:22:41 -07:00
Nick
e3b1e3c8c5 Security citations are now logged to the DB (#58827)
Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
2021-05-03 05:17:04 -07:00
ATH1909
39a0b96083 removes an unused sticky tape variable (#58856) 2021-05-03 05:15:39 -07:00
Emmett Gaines
45630da55e Adds canister windows (#58826) 2021-05-03 05:15:14 -07:00
Tom
78cba283e8 PDAs reset the alert overlay when you read your messages (#58820) 2021-05-02 02:11:46 -07:00
Emmett Gaines
b2b15abe6b Allows canister repairs and adds right click tool acts (#58830)
* Allows canister repairs

* Name consistency and some output cleanup
2021-05-02 02:10:54 -07:00
ATH1909
ec0671af2e heretic blade teleports are now invoked by using them in-hand (#58526)
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2021-05-02 02:01:31 -07:00
cacogen
4542430810 RPD can destroy broken disposal pipes (#58814)
Aims to speed up the replacement of broken disposal pipes by making it less demanding on the player. Hopefully this will lead to it happening more often. Does this by:

Allowing the RPD to destroy broken disposal pipes
Automatically destroying broken disposal pipes before trying to secure new ones of the same direction over the top of them
Automatically crowbarring floor tiles while trying to secure disposal pipes over the top of them if a crowbar is held in the offhand

Speeds up the rate at which broken disposal pipes can be replaced.

At the moment to replace a disposal pipe you have to weld each end of the broken pipe. It requires fuel, activation of eye protection and three seconds per end. This becomes time consuming when you have a lot of pipes to replace. It only serves to further disincentivise repair of everything but small breaches.

This PR lessens the requirement to only an RPD and half a second per end. You can also just place a pipe of the same direction over a broken pipe and the ends will be deleted for you. If you place a disposal pipe over a broken pipe that's above a floor tile while holding a crowbar, the floor tile will be removed so the RPD can secure the pipe. All that's left is welding the pipe and replacing the floor tile.

Hopefully this will lead to more people replacing disposals. There's still undesirable difficulty in finding out where pipes went and which ones were used (if you can't figure it out the only solution is making do or looking at the .dmm -- usually it just doesn't get fixed) but that's out of scope for this pull request. Replacing disposal pipes is just one of several jobs involved in repairing hull breaches that players don't want to do. Hopefully this eases the tedium of replacing obvious pipes.
2021-05-01 17:17:48 -07:00
Fikou
c0f9d2e7e8 [READY] Tile Reskinning 2: Epic Winaloo (#58801)
extends the tile reskinning functionality to iron, bronze, plastitanium, carpet and pod floors
makes a bit of tile code better
moves some paths around, like elevator shafts being plating instead of floor
adds rotating as a tile reskinning function available on chapel or side floors for example

lets players customize any rooms they would want much more than it is possible now, allowing for more creativity
2021-05-01 02:20:45 -07:00
Celotajs
574c81a143 Resolve chameleon GAGS item issues (#58808)
This PR fixes issues with the chameleon jumpsuit and sneakers. In addition to that, it properly defines setting for GAGS worn and inhand icons instead of having them be in Initialize() for specific item types. Names for the prisoner jumpsuits and wheelys have also been reverted to how they were before the GAGS PR.
2021-04-30 22:16:18 -07:00
Emmett Gaines
8c6d67ed3b Adds support for dirs and config changing in GAGS debug menu (#58794)
Previously, the menu wouldn't show you the generation steps for icons other than the south dir icons. You can now specify which you want to see. In addition the config type itself can be changed so as to allow previewing of icons that normally are not displayed directly on the map.

Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
2021-04-30 21:31:25 -07:00
LemonInTheDark
27385e9d70 Converts the atmos senstive component over to connect_loc (#58266)
* Makes all uses of atmos_senstive pass in mapload as context

* Converts atmos senstive to connect_loc, does some general cleanup to the element, and makes it check the state of the tile the thing is on assuming creation didn't happen as a part of map loading

* Updates connect loc to match the new arg list
2021-04-30 18:35:47 -07:00
Mothblocks
819726b693 Remove gender-specific preferences (#58785)
Makes hair (which already was, I think?), underwear, facial hair, and undershirts all available to all genders.

Random character generation is not changed. Eventually, I want to remake random characters to look more believable, but that is out of scope.

Gender-specific preferences are an outdated trope that make the code harder to work with.

This change is also important as a total makeover of the preferences menu and the preference internals are going underway. It is significantly easier to work with when a preference can simply be a list of things you can choose, rather than having to depend on another preference to decide what they can show. While I could make this change at that time, it is also important that the new preferences menu keep parity, and avoid bikeshed on a trifling detail.
2021-04-30 18:23:48 -07:00
Iamgoofball
96a9523940 Removes CHECK_TICK from overlays, following the same theory as instant explosions. (#58382)
as we learned with instant explosions, sleeping needlessly between appearance changes results in a heavier sendmaps load, let's see how this performs
2021-04-30 21:08:55 -04:00
Kokonut
cfccfc0bb4 Plants don't get their positions ruined when dropped (#58806)
Tiny atomic one line change that makes plants stay in the same place when you drop them.

What's the point of being able to hide in a plant if anyone with basic object permanence can see that a plant that used to be offset off the tile is now centered?
Also I was tired of seeing all the plants in the bar turn really ugly and offset the second Pun Pun gets to them with no way of centering them again.
2021-04-30 17:20:26 -07:00
Kokonut
e422155475 New carpets & wood, version 2 (#58797)
maxymax13, /vg/station, Citadel Station

I really wanted #58190 (A port of cit tiles, fucking ahewhads) but then nobody gave it mergies so i've redone it except not stale, not merge conflict'd and not using stack crafting instead of tile floofing!
I fully replaced the fugly diagonal one with my own nicer parquet one, adjusted red carpet to be less noisy, and made a damaged state.

Much more customization for wood flooring enjoyers, and it's obtainable ingame, in an out-of-the-way method! Think of the bar remodels you could do with this and some cans of paint! Now all we need is to make the vinyl siding and wood panel siding decals place-able...

3 new variations for wooden tiles are available (large, parquet, and tiled), the same way you color titanium tiles! Remember, use a screwdriver and not a crowbar!
A new red planetary pattern design is available for arcade carpet!
2021-04-30 17:09:38 -07:00
GuillaumePrata
de6e1861d4 Fuel pellets have unique names (#58791) 2021-04-30 16:33:41 -07:00
LemonInTheDark
05935d5ba1 Makes icon2html support mutable appearances again (#58796)
Fixes prayers not having the cute little icon attached to them
2021-04-30 05:09:47 -07:00
Cimika/Lessie/KathyRyals
ac86b15e85 Reworks thermal mutation. (#57899)
This PR reworks the thermal mutation to be a spell that deals eye damage on use.

Offers trade-offs for using thermal, promote inter-departmental cooperations (medical can produce chems to help deal with the after effects of using the mutation).
2021-04-30 13:03:31 +01:00
BluBerry016
a4149d398b Turns constants into variables in the Cargo Console. (#58765) 2021-04-30 03:46:00 -07:00
RandomGamer123
23803741c2 Readded anomaly research (#58790) 2021-04-30 03:45:06 -07:00
Arkatos1
db5420342f Converts space carps to GAGS (#58710) 2021-04-30 03:42:13 -07:00
itseasytosee
a461b44053 Changes a sentence written in first person to second person (#58789) 2021-04-30 03:37:01 -07:00
YakumoChen
773591a7fa what the fuck are nanochips? (#58798) 2021-04-30 03:35:47 -07:00