Creates update_name and update_desc
Creates the wrapper proc update_appearance to batch update_name, update_desc, and update_icon together
Less non-icon handling code in update_icon and friends
Signal hooks for things that want to change names and descriptions
99%+ of the changes in this are just from switching everything over to update_appearance from update_icon
Done using this command sed -Ei 's/(\s*\S+)\s*\t+/\1 /g' code/**/*.dm
We have countless examples in the codebase with this style gone wrong, and defines and such being on hideously different levels of indentation. Fixing this to keep the alignment involves tainting the blames of code your PR doesn't need to be touching at all. And ultimately, it's hideous.
There are some files that this sed makes uglier. I can fix these when they are pointed out, but I believe this is ultimately for the greater good of readability. I'm more concerned with if any strings relied on this.
Hi codeowners!
Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
This PR adds station traits which are essentially small changes to a normal round that can be used to create small variations in how a round might play out, sometimes there might be only one, very simple trait, but you might have a round where they have a somewhat bigger impact, to make rounds feel slightly more different from each other.
The following traits have been added:
Positive:
Lucky winner - Free pizza and beer every 6-12 minutes
Galactic Grant - Larger starting funds for cargo
Premium internals boxes - emergency box has flare + radio as bonus
Bountiful bounties - Bounties pay 20% more
Strong supply lines - Imports 20% cheaper
Filled maint - More loot in maint
Fast shuttle - Cargo shuttle is faster
Free scarves - Free scarfs if a slot is free
Neutral:
Bananium shipment - Clown starts with 5 sheets of bananium (Neutral because this helps noone but the clown)
Unnatural atmosphere - Lava planet can get more restricted gasses
Unique AI - Random lawset at roundstart for AI
Ian adventure - Ian teleports to a random spot on the station
Glitched PDAs - PDA's have a different beep
Announcer intern - Changes the announcement messages to sound like they're from an intern at Centcom
Negative:
Carp infestation - Carp event is more common and can start earlier
Weak supply lines - Imports 20% more expensive
Blackout - Station lights are partially broken around the station
Empty maint - Less loot in maint
Overflow bureacracy mistake - Random overflow job (From a vetted list)
Late Arrivals - Everyone starts in arrivals
Random spawns - Random spawn location (by drop pod)
Slow shuttle - Cargo shuttle is slower
Co-authored-by: Mothblocks <35135081+Jared-Fogle@users.noreply.github.com>
Co-authored-by: coiax <yellowbounder@gmail.com>
Oversight made by @TiviPlus when making #55147
var/hacked wasn't actually used in code and instead, all spawner vendors were instantly hacked.
fixes#56101
* base
* fixes
* crate
* Update code/game/turfs/open/floor/fancy_floor.dm
Co-authored-by: Fikou <piotrbryla@onet.pl>
* adds the crate to the pool.
* the crate is pretty rare, why not let it drop four items?
* Update lootdrop.dm
Newline phone edit
* ungoofed
Co-authored-by: Fikou <piotrbryla@onet.pl>
Implements the ?. operator, replacing code like A && A.B with A?.B
BYOND Ref:
When reading A?.B, it's equivalent to A && A.B except that A is only evaluated once, even if it's a complex expression like a proc call.
Randomly generated arcade machines were getting random boards and initing properly, but they weren't re-built as the appropriate subtype.
This oversight has been remedied. A new subtype has been created for random arcade machines which exists purely to pick a random circuit then create a machine from that circuit's build path before returning that it should be qdel'd.
This new subtype has been appropriately regex find-and-replaced into all maps.
* Objectify
* Case of lower
* More changes
* Ruins the nice 420 diff, brainfart when doing the second batch of conversions
* More changes
* Next batch. I think
* Converts even more paths
* Restarts bots
* Capital Free Zone
* Come on travis, do something
* Renames areas
* Bots, please stop dying
* Updates CONTRIBUTING.md and updates a few paths I missed.
* APC recgarftzfvas
/obj/item/computer_hardware/recharger/apc to /obj/item/computer_hardware/recharger/apc_recharger
Gibspawners and mob_spawn objects now have icons. There's also unique icons for assistant, cook, engineer, miner, etc. corpses. Also sets the invisibility of delayed mob spawns to 101 so it doesn't show up. Also adds a name for basetype mob spawns.
* Minor map fixes part 1
Donut:
- Gave geneticist medical access on donut
- Geneticist can now use genetics maint and South genetic door
- Replaced genetics door with glass door (for aesthetics)
Meta:
- Fixed cell 3 door/timer being linked to cell 2. Now cell 3 is independent from cell 2.
Bar bluespace shelter:
- Gave mining access to bar area (it's sort of redundant otherwise)
* Minor map fixes part 2
- Added "purge" AI module to risky AI module spawner
- Added "reset" AI module to AI chamber on donut
* Fixed trailing newline
* uhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh
* upper staircases, lots of upper floor work
* railings
* ai sat rework, exterior decals
* ass ass ASS ASS fuckin ASSSSS
* oh my god its full of stairs
* forgot a file oop
* railing fix on multiz test, upper atmos, external space dust deterrents
* both-way rail climbing, maint work, 2nd story atmos desk, pipe/wiring/ allow floating over openspace and moving up-down openspace in nograv, trailing ends
* go NORTHWESSSST
* maint work, hull work, gamer time
* upper security, more maint work, eva catwalks, less retarded railings, hiding signs from openspace, elevators suck, wire/pipe work
* more maint work, decal work on 1st floor, called my parents they appreciated it
* multiz test shit
* maint work, hallway work, botany work
* removed cloning, turned into general treatment, added small temp corpse storage next to treatment
* eduititititit
* gamers
* openspace fixes
* os over os fix
* prison rework, hallway work, pr prep
* mapmerge + remove pixel 0s
* bad area and more railings, newline
* unnecessary vis flags and unused computer console
* public mining dock
* oops lol
Co-authored-by: Dennok <Deneles@yandex.ru>
* Removed from code
* Removes cloners from maps
* Some more references, now compiles.
* Reduces availability of replica pods
* DNA scanner and tech disk rebranding
* pubby door name, cargo pack description
* Adds new donk pockets and new donk pockets boxes icons and code!
* Accidentlty didn't add the pastries, oops!
* Adds the new donk pockets to the maint loot table, a donk pocket crate, and fixes a small typo under boxes which caused the honk pocket box to not appear.
* Final commit before PR, fixed a few bugs.
* Fixed a spelling error, and removed Gondola-Pockets from the maint loot table.
* Adds a new donk pocket loot spawner object, and updatesmaps to include it in the kitchen.
* Proper mapmerge, hopefully.
* Removed step_x and step_y, hopefully travis will be happy now.
* Switches out the new donk pocket icons for less noisy ones.
* Removes unnecessary lines of code.
* Adds craftable donk pocket boxes.
* Hopefully makes travis happy by fixing metastation errors.
* More metastation error fixes.
* Changes omnizine of warm honk-pocket to 1.
* Add path variable donktype, removed copy pasted populatecontents() lines of code.
* Fully working with removal of the copy pasted populatecontents() in favor of a path variable.
* Gets rid of component initialize where it does nothing
* Fixed some data loss with food icons.
* Changes loot table to remove syndicate throwing items from gambling drop table
Removes illegal tech from Mateba revolver.
* Okay fine we'll do it this way
* Something something hugbox
* Makes plastitanium windows children of reinforced windows.
* Unanchored variety isn't fully tooled in now.
* Path moved to plasma/reinforced/plastitanium
* Fixes a blunder about neglecting a mapping path change.
About The Pull Request
This PR resprites the D6, adds two money bags and a bag of 5 d6'es to the bardrobe. Be on the look out for the expensive ebony dice.
I have also made code improvement by filling dice bags using PopulateContents() and giving the special dice their own loot spawner.
Why It's Good For The Game
I have recently in anticipation for the roulette update tried playing some simple dice games with my bar patrons to great success. I did however notice that the old d6 sprites were quite bad, so i decided it was time for a resprite,
I have also added money bags to the BarDrobe since those will be needed if more forms of gambling are added to prevent greytiders from stealing all your winnings.
DiceComparasion
EbonyDiceLarge
Changelog
cl
add: Money bags can now be obtained from the BarDrobe.
add: A bag of d6'es is now available in the BarDrone. May contain a rare die.
imageadd: New d6 base sprites and variant.
refactor: Improved the way the normal dice bags is populated.
/cl
About The Pull Request
Converts every single usage of playsound's vary parameter to use the boolean define instead of 1 or 0. I'm tired of people copypasting the incorrect usage.
Also changes a couple of places where a list was picked from instead of using get_sfx internal calls
This was done via regex:
(playsound\(.+,.+,.+, ?)1( ?\)| ?,.+\)) to match 1
(playsound\(.+,.+,.+, ?)0( ?\)| ?,.+\)) to match 0
full sed commands:
/(playsound\(.+,.+,.+, ?)1( ?\)| ?,.+\))/\1TRUE\2/ 1 to TRUE
/(playsound\(.+,.+,.+, ?)0( ?\)| ?,.+\))/\1FALSE\2/ 0 to FALSE
I'm not very good with regex and these could probably be optimized, but they worked.
Why It's Good For The Game
Code usability
About The Pull Request
repaths clothing/under to be more sane
Also fixed a couple of bugs relating to pathing being incorrect, and modified a couple of bad descriptions and names
Also adds a map path updating script, which also helps show the full repath.
Why It's Good For The Game
improves maintainability, makes mapping easier, stages for a clothing dmi split
Changelog
cl
refactor: repathed all under clothing, keep an eye out for errors
/cl
* Makes the abductor healing gland more interesting
* Implant rejection
* .
* no vomit for blood regen
* Update code/modules/antagonists/abductor/equipment/glands/heal.dm
Co-Authored-By: moo <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>
* Adds the rasta beanie
* Added Bishop Mitre
* Added some more religious headgear
Clown Mitre (Hat of the Honkmother)
Kippah
White and Red Taqiyahs
Medieval Jewish Hat
* Fixes icon_state for the Hat of the Honkmother
* Added some new chaplain outfits
Bishop Robe
Monk's Frock (with hood)
Eastern Monk's Robe
White Robe
* Added Robes of the Honkmother
* Added new religion hat icons
Bishop Mitre
Clown Mitre
Kippah
Red and White Taqiyahs
Medieval Jew Hat
Rasta Beanie
* Added new religion suit icons
Bishop Robe
Monk's frock
Eastern Monk's Robe
White robe
* Added new religious suits
* Added new religious headgear
* Added in-hand sprites for new religious suits
* Added new religious clothing to the chaplaindrobe
Includes new premium and contraband objects.
* Added clown priest's robes to premium
* Added some religion follower hats
Kippah
Taqiyah (red)
* Added rastacap to the chaplain vendor
* Fixed obj directory for red taqiyah
* Fixed spelling of "dreadlocks
* Allowed clown robes to hold prank items
* Created .dm for chaplain suits
For easy organization
* Removed clown priest robes
Put them in chaplainsuits.dm
* Moved new chaplain suits
To chaplainsuits.dm
* Moved holiday priest
to chaplainsuits.dm
* Moved holiday priest to chaplainsuits.dm
* Updated suit obj defines, added monk's frock
* Updated obj defines for chaplain suits
* Updated holiday priest obj define
* Updated chaplainsuit obj defines, added white robes
* Fixed subtype define
Man, that was an embarrassing spelling mistake
* Fixed subtype define
For real this time I hope
* Added chaplainsuits.dm
* Fixed clown robes
* Updated holiday priest path
* Updated path for chaplainsuits
* Re-added prank items to clown robe storage
* Updated pathing for chaplain suits on Pubby
* Added comments
Hopefully this will help the AppVeyor check go through
