Commit Graph

773 Commits

Author SHA1 Message Date
SkyratBot
65b8082678 [MIRROR] Harddel Fix Pack #42 + Better Live Reftracking Support [MDB IGNORE] (#10639)
* Harddel Fix Pack #42 + Better Live Reftracking Support

* awooga

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-01-12 21:57:49 +00:00
SkyratBot
2054f35fd3 [MIRROR] Fixes not being able to say ahelp in dchat [MDB IGNORE] (#10622)
* Fixes not being able to say ahelp in dchat (#63988)

* fix

* better code

* Fixes not being able to say ahelp in dchat

Co-authored-by: Seth Scherer <supernovaa41@gmx.com>
2022-01-12 03:52:31 +00:00
SkyratBot
61ca3472ea [MIRROR] PURE Code Improvements to the Shuttle Subsystem [MDB IGNORE] (#10609)
* PURE Code Improvements to the Shuttle Subsystem

* modular updates

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-01-12 02:47:57 +00:00
SkyratBot
e149c9653d [MIRROR] Kills all unneeded uses of spawn() [MDB IGNORE] (#10594)
* Kills all unneeded uses of spawn() (#63876)

Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>

* Kills all unneeded uses of spawn()

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
2022-01-11 17:15:27 +00:00
SkyratBot
4bcd964ae3 [MIRROR] Fixes runtimes when admin ghosting out of a camera eye [MDB IGNORE] (#10488)
* Fixes runtimes when admin ghosting out of a camera eye (#63838)

observetarget is not guaranteed to exist

* Fixes runtimes when admin ghosting out of a camera eye

Co-authored-by: Seth Scherer <supernovaa41@gmx.com>
2022-01-07 11:42:54 +00:00
SkyratBot
1868bf6181 [MIRROR] Remove the auto updating in the orbit menu and bring back manual refresh [MDB IGNORE] (#10460)
* Remove the auto updating in the orbit menu and bring back manual refresh (#63790)

* Remove the auto updating in the orbit menu and bring back manual refresh

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2022-01-05 10:43:48 -05:00
SkyratBot
092e534e75 [MIRROR] TGUI list conversions + bug fixes [MDB IGNORE] (#10355)
* TGUI list conversions + bug fixes

* Fixing conflicts

* Maintaining a few modular files while we're at it...

Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2022-01-03 22:53:58 +00:00
Gandalf
49a1a276e7 CROSSLINK + Population control cap (#9979)
* Ew

* Update login.dm

* Update code/modules/mob/dead/new_player/login.dm

Co-authored-by: OrionTheFox <76465278+OrionTheFox@users.noreply.github.com>

* Oogleboogle

* E

* EEE

* Update client_procs.dm

* E

* E

* E

* Update communications.dm

* Update communications.dm

* E

* Update chat_link.dm

* EEEE

* EEE

* Update communications.dm

* EEE

* 0

* E

* Update skyrat_config.txt

* EEEE

* E

* E

* E

* E

* 0

* Update code/modules/admin/verbs/adminhelp.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Update modular_skyrat/master_files/code/_onclick/hud/new_player.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Update modular_skyrat/modules/server_overflow/code/client_procs.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Update tgui/packages/tgui/interfaces/ServerControlPanel.js

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* You missed one

Co-authored-by: OrionTheFox <76465278+OrionTheFox@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2021-12-25 19:08:27 +00:00
SkyratBot
32bc1eea41 [MIRROR] More standard tgui input conversions [MDB IGNORE] (#10238)
* More standard tgui input conversions

* More standard tgui input conversions

Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
2021-12-24 21:33:32 +00:00
SkyratBot
a526c6070a [MIRROR] Makes all default job titles, defines. [MDB IGNORE] (#10080)
* Makes all default job titles, defines.

* Makes all default job titles, defines.

* whitespace

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
2021-12-18 16:54:03 +00:00
nevimer
a2fb4eb5ab [SEMI-MODULAR]Require flavour text to join the round. (#9969)
* Place 1 missing distro pipe segment

* Revert "[MIRROR] Gasmaks tint and tint calculation update (Oranges approved edition) [MDB IGNORE] (#9817)"

This reverts commit d0987f545e.

* Revert "Revert "[MIRROR] Gasmaks tint and tint calculation update (Oranges approved edition) [MDB IGNORE] (#9817)""

This reverts commit df2c3caa41f60a6711ff59e290edc835154fcd9f.

* Require flavour text to enter the round.

* Update code/__DEFINES/jobs.dm

Co-authored-by: Seris02 <49109742+Seris02@users.noreply.github.com>

* 150 min

* request for unicode

Co-authored-by: SkyratBot <skyratcommunity@gmail.com>
Co-authored-by: nevimer <foxmail@protonmail.com>
Co-authored-by: Seris02 <49109742+Seris02@users.noreply.github.com>
2021-12-13 10:43:09 +00:00
SkyratBot
d604846209 [MIRROR] TGUI list input conversions [MDB IGNORE] (#9996)
* TGUI list input conversions (#63315)

Co-authored-by: tralezab <40974010+tralezab@ users.noreply.github.com>
Co-authored-by: Sealed101 <75863639+Sealed101@ users.noreply.github.com>

* TGUI list input conversions

Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
Co-authored-by: tralezab <40974010+tralezab@ users.noreply.github.com>
Co-authored-by: Sealed101 <75863639+Sealed101@ users.noreply.github.com>
2021-12-10 18:10:25 +00:00
SkyratBot
463c2fc71d [MIRROR] multiz movement refactor redux [MDB IGNORE] (#9925)
* multiz movement refactor redux (#62132)

* multiz movement refactor redux

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
2021-12-07 08:27:12 -05:00
SkyratBot
108b9585dc [MIRROR] Ghosts can have colorful hair again! [MDB IGNORE] (#9856)
* Ghosts can have colorful hair again! (#63129)

The PR that updated the codebase to no longer use legacy colors didn't check this specific proc, which is to my knowledge only used by ghosts lightening their hair color. That's it.

* Ghosts can have colorful hair again!

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2021-12-03 20:47:01 +00:00
Tastyfish
4eefadc8b4 Alternative job titles in the Occupations screen actually used in-game (#9420)
* Added alt jobs names actually doing something.

* Also add late join announcements.

* Fix custom roles showing up first in crew monitor

* Cleanup to match upstream changes

* Updates from review, also improve both tgui manifests

* Compromise for Skyrat edit notes vs JSX vs linter

* Compromise for optimization vs not making a horrible mess of passing client around

* Follow module rules

* Revert no longer true changed to customization readme

* Update dme

* Fixed comments for alt titles
2021-11-27 22:18:45 -05:00
SkyratBot
747a8273d8 [MIRROR] Gradients can now be applied to facial hair too. [MDB IGNORE] (#9719)
* Gradients can now be applied to facial hair too.

* Fixing dem conflicts

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2021-11-27 20:22:36 +00:00
magatsuchi
3183d29126 removed observer msg (#9706) 2021-11-25 17:21:39 -05:00
SkyratBot
c1ca55382d [MIRROR] Fixes ghosts' boo ability going on cooldown when the light they tried to flicker didn't flick [MDB IGNORE] (#9672)
* Fixes ghosts' boo ability going on cooldown when the light they tried to flicker didn't flick

* Update code/modules/power/lighting/light.dm

Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2021-11-23 21:35:02 -05:00
SkyratBot
9c6890ecc1 [MIRROR] Exempts non-deadminned admins from all the chat filters so they can break the server rules and get banned if they want to. [MDB IGNORE] (#9582)
* Exempts non-deadminned admins from all the chat filters so they can break the server rules and get banned if they want to. (#62944)

Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>

* Exempts non-deadminned admins from all the chat filters so they can break the server rules and get banned if they want to.

Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
2021-11-20 08:50:20 -05:00
SkyratBot
08bd01ea3d [MIRROR] Overhauls job eligibility checking and improves job debug logging. [MDB IGNORE] (#9348)
* Overhauls job eligibility checking and improves job debug logging.

* Fixing conflicts

* Makes Veteran the first check since it's the most likely.

Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2021-11-10 16:39:42 -05:00
SkyratBot
c9b3accbac [MIRROR] Adminwho and the status panel now shows when fellow admins are readied up in pre-game lobby [MDB IGNORE] (#9341)
* Adminwho and the status panel now shows when fellow admins are readied up in pre-game lobby (#62670)

* Adminwho and the status panel now shows when fellow admins are readied up in pre-game lobby

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
2021-11-09 09:41:43 -05:00
SkyratBot
e598a0dd33 [MIRROR] Beepsky refactor and Bot code improvement [MDB IGNORE] (#9304)
* Beepsky refactor and Bot code improvement

* Feex

* Fixing the maps so they work :)

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2021-11-08 21:28:35 -05:00
SkyratBot
7954d664a8 [MIRROR] removes double spaces before symbols [MDB IGNORE] (#9117)
* removes double spaces before symbols (#62397)

This can apparently cause some bugs on occasions, so I thought I might as well try to kill them all.

* removes double spaces before symbols

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2021-10-29 04:14:00 +01:00
SkyratBot
fad38d8c24 [MIRROR] Adds the ability to soft filter words, also fixes some word filter bugs [MDB IGNORE] (#9062)
* Adds the ability to soft filter words, also fixes some word filter bugs (#62158)

* Adds the ability to soft filter words, also fixes some word filter bugs

* Fixing linters (you're welcome Jake!)

* Punctuation is my passion!1!!111!

Co-authored-by: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>
Co-authored-by: GoldenAlpharex<jerego1234@hotmail.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2021-10-27 20:06:23 -04:00
SkyratBot
1bd02b0148 [MIRROR] fixes a slight issue with the hair color not being visible on ghosts after the legacy color removal [MDB IGNORE] (#9029)
* fixes a slight issue with the hair color not being visible on ghosts after the legacy color removal (#62225)

* fixes a slight issue with the hair color not being visible on ghosts after the legacy color removal

Co-authored-by: Seris02 <49109742+Seris02@users.noreply.github.com>
2021-10-25 13:40:38 -04:00
SkyratBot
f0db07b17d [MIRROR] makes it so the sanitize_hexcolors' default is 6 characters rather than 3 and gets rid of color_legacy [MDB IGNORE] (#8840)
* makes it so the sanitize_hexcolors' default is 6 characters rather than 3 and gets rid of color_legacy

* Feex

* Feex some more

* Final feex

* Please no more I'm tired

* <<<<<<< HEAD

Co-authored-by: Seris02 <49109742+Seris02@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2021-10-17 00:30:28 -04:00
SkyratBot
fa519bdde3 [MIRROR] cleanup _HELPERS/_lists.dm and all the necessary files [MDB IGNORE] (#8783)
* cleanup _HELPERS/_lists.dm and all the necessary files

* Epbic

Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-10-13 21:07:35 +01:00
Lyroy
99893bd8a8 [SEMI-MODULAR] Brings back custom Ash Walkers and Primal Podpeople, also fixes job banned species checks (#8665)
* initial commit

* whoops hahah you don't need that comment

* species check on the prefs menu

* species check actually works now, podpeople quirks

* goof was right
2021-10-13 20:32:37 +01:00
SkyratBot
f39eb86480 [MIRROR] better fix for some runtimes with clients in player_list (maybe) [MDB IGNORE] (#8778)
* better fix for some runtimes with clients in player_list (maybe) (#62028)

* better fix for some runtimes with clients in player_list (maybe)

Co-authored-by: Seris02 <49109742+Seris02@users.noreply.github.com>
2021-10-13 19:08:49 +01:00
Seris02
1d2f7e2f2e [semi-modular] fixes a runtime when there role restricted glasses aren't spawned, and hopefully if any other loadout items in the future also use post equip (#8733)
* runtime fix

* oof

* Update code/controllers/subsystem/ticker.dm

Co-authored-by: Gandalf <jzo123@hotmail.com>

* Update code/modules/mob/dead/new_player/new_player.dm

Co-authored-by: Gandalf <jzo123@hotmail.com>

Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-10-12 19:19:20 -04:00
SkyratBot
b365a52a96 [MIRROR] secret gateway update [MDB IGNORE] (#8747)
* secret gateway update (#62003)

admins are now notified about a secret gateway load failing, also logs this
secret z levels are protected from incorporeal movement
fixes unpowered ruin areas being powered
adds a bunch of new areas for secret gateways, since var edited areas probably arent a good idea its good to have a few presets
adds cordon turfs and areas, ingame they just look like the z level border, they are completely indestructible, you cant pass them, and if you somehow do, the cordon area kills you (idea from goon but the code and sprites are mine)
adds a z level injector mapping trait, injects a z level trait into the z level its placed on, if you want to add something like ash storms or whatever to your map
adds an anti xray z level trait, you can optionally add this with the z level injector to protect your map against any xray or whatever

* secret gateway update

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
2021-10-11 16:16:36 +01:00
SkyratBot
7ea5f77947 [MIRROR] Remove deprecated preferences/lobby menu proc [MDB IGNORE] (#8676)
* Remove deprecated preferences/lobby menu proc (#61945)

* Remove deprecated preferences/lobby menu proc

Co-authored-by: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
2021-10-08 08:19:19 -04:00
SkyratBot
3c20b53bd3 [MIRROR] Replaces the Mafia button with the Minigames button. Adds tgui panels for selecting minigames and for CTF [MDB IGNORE] (#8659)
* Replaces the Mafia button with the Minigames button. Adds tgui panels for selecting minigames and for CTF (#61638)

This PR replaces the Mafia button on the observer HUD with a minigames button that allows you to access both CTF and Mafia.

It also adds a CTF menu that allows you to view current scores, players needed to start a game, and joining a ctf game without needing to move to the spawner.

Co-authored-by: Jared-Fogle <35135081+Mothblocks@ users.noreply.github.com>

* Replaces the Mafia button with the Minigames button. Adds tgui panels for selecting minigames and for CTF

Co-authored-by: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>
Co-authored-by: Jared-Fogle <35135081+Mothblocks@ users.noreply.github.com>
2021-10-07 12:55:09 -04:00
SkyratBot
322cff5a78 [MIRROR] Use ckeys instead of keys in key name helper proc and new_player login. [MDB IGNORE] (#8601)
* Use ckeys instead of keys in key name helper proc and new_player login. (#61857)

* Use ckeys instead of keys in key name helper proc and new_player login.

Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
2021-10-03 23:44:26 -04:00
SkyratBot
425c5bb100 [MIRROR] cleanup of _HELPERS/game.dm [MDB IGNORE] (#8593)
* cleanup of _HELPERS/game.dm (#61859)

some more cleanup, game.dm this time

* cleanup of _HELPERS/game.dm

* E

* Update oneclickantag.dm

Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-10-04 00:28:22 +01:00
SkyratBot
09c2297ad1 [MIRROR] Secret Gateways: Config loaded Away Missions + Anti-observing Z level traits [MDB IGNORE] (#8437)
* Secret Gateways: Config loaded Away Missions + Anti-observing Z level traits

* 0

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-10-04 00:11:28 +01:00
Iamgoofball
68e84c432e Skyrat Prefs Menu: Fixing everything to work correctly (#8350)
* Skyrat Prefs Menu: Fixing everything to work correctly

* whoops haha

* Examine menu!

* haha whoops

* Mutant Parts in tgui prefs

* fug

* LIMBS, MARKINGS, LANGUAGES

* EEEE FUCK

* Update tgui_prefs_migration.dm

* Update tgui_prefs_migration.dm

* FUCK

* Proper migration

* Update preferences.dm

* Final fixes for this shit

* Update LoadoutManager.js

* adds cursed shit

* e

* Update preferences.dm

* fixes examine panel

* adds // SKYRAT EDIT to bullshit

* sabshesgawgzxghsv

* wargesthgeargfea

* stegresgdytfrw

* EEE

* Update species_features.tsx

* EEE

* Update cursed_shit.tsx

* fixed taurs

* body size is now a 0.01 step

* Fixes some bugs

* Some required changes.

* Update examine.dm

* actually nekked

* Update code/modules/client/preferences/middleware/jobs.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Update code/modules/client/preferences/middleware/limbs_and_markings.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Update code/modules/client/preferences/middleware/limbs_and_markings.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Update code/modules/client/preferences/middleware/limbs_and_markings.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Update modular_skyrat/master_files/code/modules/client/preferences/erp_preferences.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Update modular_skyrat/modules/loadouts/loadout_ui/loadout_manager.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Update tgui/packages/tgui/interfaces/PreferencesMenu/preferences/features/character_preferences/skyrat/species_features.tsx

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* More fixes

* Donator items no show

* EEE

* fixes rapier sheaths

* gender =/= body type

* Loadout fixes

* Skintone

* Update skin_tone.dm

* Slick it up

* Update loadout_manager.dm

* Fixes typing indicator

* SSD indicator fixes

* fixes

* oops

* Fix this.

* Fixing the Occupations Menu

* Fixing NT Rep's alt-titles

* Update tgui/packages/tgui/interfaces/PreferencesMenu/jobs/jobs/janitor.ts

Co-authored-by: death and coding <58394696+thestubborn@users.noreply.github.com>

* Update code/controllers/subsystem/language.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Update tgui/packages/tgui/interfaces/PreferencesMenu/jobs/jobs/research_director.ts

Co-authored-by: death and coding <58394696+thestubborn@users.noreply.github.com>

Co-authored-by: Gandalf <jzo123@hotmail.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
Co-authored-by: death and coding <58394696+thestubborn@users.noreply.github.com>
2021-09-29 15:24:30 +01:00
GemInee
ae2111bfc0 organic ui fix (#8457)
* organic ui fix

Reimplementing UI fixes

* fuc u, i won

* some skyrat buerocracy stuff

Co-authored-by: Lamella-0587 <76873041+Lamella-0587@users.noreply.github.com>
2021-09-28 18:05:06 +01:00
SkyratBot
93675c6c6f [MIRROR] Changes a bunch of New()s to Initialize()s (#8408)
* Changes a bunch of New()s to Initialize()s (#61626)

* Changes a bunch of New()s to Initialize()s

Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
2021-09-26 14:27:27 +01:00
Gandalf
3d68c061ac EEEE 2021-09-26 02:58:16 +01:00
SkyratBot
571ae2299e [MIRROR] Added Two New Moustache Styles on the Character Setup. (#8391)
* Added Two New Moustache Styles on the Character Setup. (#60721)

* Added Two New Moustache Styles on the Character Setup.

Co-authored-by: MetalClone <metalclone@protonmail.com>
2021-09-25 14:35:21 +01:00
SkyratBot
c23bd1cb8c [MIRROR] every case of initialize that should have mapload, does (#8374)
* every case of initialize that should have mapload, does

* E

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-09-24 23:07:53 +01:00
SkyratBot
e8d78089fc [MIRROR] [TM Candidate] Overhauls orbit and POI code to fix part of issue #61508 where players could observe /mob/living/new_player on the lobby. (#8339)
* [TM Candidate] Overhauls orbit and POI code to fix part of issue #61508 where players could observe /mob/living/new_player on the lobby.

* E

* Missed merge

Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-09-24 18:16:17 +01:00
SkyratBot
ff27725d05 [MIRROR] Remove unused var (#8341)
* Remove unused var (#61637)

* Remove unused var

Co-authored-by: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
2021-09-23 01:47:48 +01:00
SkyratBot
124ddd7cca [MIRROR] tgui Preferences Menu + total rewrite of the preferences backend (#8153)
* tgui Preferences Menu + total rewrite of the preferences backend

* nah, we dont need to ping those people

* trying to remove the funny stuff

* unmodularizing this

* prefs reset

* this may need to be reverted, who knows

* okay, this part

* perhaps

* EEEEEEEEE

* unsanitary

* E

* Stage 1 + loadout system

* more fixes

* E

* I mean, it launches?

* More fixes and reorganisation

* E

* customisation code is spaget.

* disable ERP prefs

* Update erp_preferences.dm

* Update erp_preferences.dm

* E

* Slowly getting there

* It may be time for help :)

* tri...colors... help

* preferences now pass preferences

* Update dna.dm

* Fuck this man

* missing savefile return, set_species works, removed dumb stuff from updateappearance

* https://github.com/Skyrat-SS13/Skyrat-tg/pull/8199

* https://github.com/Skyrat-SS13/Skyrat-tg/pull/8224

* https://github.com/tgstation/tgstation/pull/61519

* https://github.com/Skyrat-SS13/Skyrat-tg/pull/8278

* e

* le butonAZARAK HELLO

* hhh

* Proper recognition where it's due, MrMelbert!

* EEEE

* examine block

* Better gen hit sounds from whitedream

* final loadout touches, more bug fixes im sure to come

* i said there would be bugfixes

* Update LoadoutManager.js

* Missing preferences in the html menu

* LIVE TESTING PHASE BABY

* Update LoadoutManager.js

* EEE

* LAUNCH TEST FIRE

* Update job.dm

* Update new_player.dm

* 50gb DAY ONE PATCH

* EEE

* Update preferences.dm

* buggle fixes

* Update examine.dm

* >LOOC starts on

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: jjpark-kb <55967837+jjpark-kb@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
Co-authored-by: Azarak <azarak10@gmail.com>
2021-09-23 00:40:37 +01:00
SkyratBot
2c682cf83e [MIRROR] Things that love the station may no longer leave the station, even when Dr. Anomaly says they should. (#8254)
* Things that love the station may no longer leave the station, even when Dr. Anomaly says they should. (#61335)

Bluespace anomalies detonating Move() things. When something is Move()d, none of the logic in forceMove() or doMove() is called, and thus stationloving things can't tell when they've left the z-level (since that's where the logic for it is).

There are a number of approaches I could have taken: Refactoring anomalies to use different movement code. Refactoring Movement code to send more signals in various scenarios. Refactoring the stationloving component.

I settled on two steps. First, refactoring the component to bring it up to modern code standards. Second, moving the logic for COMSIG_MOVABLE_Z_CHANGED to Moved() so the signal always fires regardless of if Move() or forceMove() or doMove() is used, with an optional var for whether the z-change is communicated to contents. This means the ore box was changed to actually send the signal instead of just returning with no parent call or signal sent. Stationloving ore boxes when?

stationloving procs no longer call SIGNAL_HANDLERs directly. Var names are now more descriptive. Things are renamed and documented. At least for the parts of the code I know.

Probably some other code cleanups.

* Things that love the station may no longer leave the station, even when Dr. Anomaly says they should.

Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
2021-09-18 21:45:42 +01:00
SkyratBot
8f2aa7598d [MIRROR] observe button uses alert instead of tgui alert (#8165)
* observe button uses alert instead of tg alert (#61404)

observe button uses alert instead of tg alert

if your tgui is broken you literally cant join the game other than spawning as a job and ghosting out, id say its a critical enough button to keep as old alert

* observe button uses alert instead of tgui alert

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
2021-09-15 03:30:40 +01:00
SkyratBot
e510e35167 [MIRROR] [READY] Adds memory system, and engraving walls with chisels (#8066)
* [READY] Adds memory system, and engraving walls with chisels

* EEE

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-09-13 23:36:51 +01:00
SkyratBot
ec70f7ad15 [MIRROR] Adds in asexual-themed socks. (#7943)
* Adds in asexual-themed socks. (#61175)

Adds in the asexual socks, called the ace socks because i like the abbreviation as it makes it sound cooler.
Also fixes bee socks being ordered improperly in the code.

* Adds in asexual-themed socks.

Co-authored-by: CRITAWAKETS <sebastienracicot@hotmail.com>
2021-09-03 03:57:14 +01:00
GoldenAlpharex
31b3a9331e [MIRROR] Replaced the lobby menu (with actual art) (#60953) (#7748)
* Replaced the lobby menu (with actual art) (#60953)

* a

* a

* Update new_player.dm

* Update new_player.dm

* Update new_player.dm

* a

* a

* Update new_player.dm

Co-authored-by: AMonkeyThatCodes <20987591+AMonkeyThatCodes@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-09-01 17:07:48 +01:00