* Map load unit testing and directory whitelisting - Mojave Sun is a really cool downstream, like and subscribe for longer PR names. oranges was here and made this github PR name much longer, thereby proving once and for all that upstreams do add value to the downstream not just endless amounts of refactoring because we can't write any api's in a modular fashion the first time around so have to update them later to be modular. Anyway do you think a taco counts as a sandwich? (#62620)
About The Pull Request
This is a fix for map not load anymore because of security changes
Why It's Good For The Game
Maps are good as they encourage gameplay and differentiate ss13 from a classic MUD game
Changelog
cl
add: unit test for map load
add: directory param to map load + whitelist for data and _maps
add: advertising for mojave sun in tg commit logs
/cl
* Map load unit testing and directory whitelisting - Mojave Sun is a really cool downstream, like and subscribe for longer PR names. oranges was here and made this github PR name much longer, thereby proving once and for all that upstreams do add value to the downstream not just endless amounts of refactoring because we can't write any api's in a modular fashion the first time around so have to update them later to be modular. Anyway do you think a taco counts as a sandwich?
Co-authored-by: AndrewL97 <andrewjlove97@gmail.com>
* [s] Security vulnerability patch (#62568)
About The Pull Request
In my personal, subjective opinion; trialmins should not, in fact, be able to read and delete server/box configuration files on a whim.
cl
server: Patches multiple(?) arbitrary file related vulnerabilities
/cl
* [s] Security vulnerability patch
Co-authored-by: TheFakeElon <59686430+TheFakeElon@users.noreply.github.com>
* Fix Map JSON loading errors (#54563)
Also fixes that one runtime everyone runs into when they first load in
* Fix Map JSON loading errors
Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
* Out of repo maps part 1: JSON Improvements (#53663)
Replaces the map job changes code system with a JSON based one.
Added map versioning to the config JSON.
Formats map config JSONs.
* Out of repo maps part 1: JSON Improvements
Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
Allows map configs to set how many ruin levels (def. 7) and how many empty levels (def. 1) that will be created. Most useful for landlocked stations, event/one-off stations with unusual composition, or testing situations such as RuntimeStation.
* Remove ZLEVEL_STATION_PRIMARY
* Add Up and Down traits for use by ladders and chasms
* Give map_config creation its own proc
* Combine LoadConfig and ValidateJSON and remove transition_config
* Make space linkage a z-level trait
* Remove ZLEVEL_EMPTY_SPACE
* Update uses of GetFullMapPath
* Handle multi-Z stations and load Lavaland and Reebe at runtime
* Remove unused space maps
* Fix inappropriate z-expansion in map reader, improve logging
* Update comments relating to z-level configuration
* Add Lavaland and Reebe to ALL_MAPS
* Refactors shuttles to be loaded in, rather than be on the station maps
- Shuttles are now loaded in by the shuttle subsystem.
You configure what shuttles are loaded in via
`/obj/configuration/shuttle_load` objects.
* Box arrivals shuttle is now imported from template
* Moves things out of the #ifdef
* Box emergency shuttle is now imported
* Box emergency shuttle is now templated
* Box ferry and whiteship now load from template
* More shuttles on Box done
* Apart from the pods, Box is now completely templated
* Delta now has all non-awkward shuttles loaded in
And Centcom..
* Removes no ops turfs, more error messages
* Fixes slightly chopped off external wall
* Massaging more shuttles into working correctly
* Debug messages are king
* Delta cargo shuttle now docks again
* First pass of Metastation shuttles
* Omegastation first pass
* Metastation now has its own shuttle
* Did most shuttles on Pubby
* Turns out Pubby arrival shuttle is slightly smaller than Box arrival
* Whoops, missed a stationary port
* TGMified the pubby arrival shuttle
* First pass, box is working
* All stations now have roundstart_template and no configuration objects
* Removes roundstart_move
* Why do we even have these unused keys
* Remove unused coded vars
* removes some excessive safety checks
* Missed some Centcom cargo dock stuff
* Got it working again
* That thing that Cyberboss wanted
* Noop turfs the shuttle templates
* And template noop for the area
* Attempts to assuage travis
* Warning!
* Please love me, Travis
* RIP Remie
* Starting on the rework
* Reworks the Ark
* Work on Reebe
* More Ark stuff
* this too
* Removes ark silliness, remaps Reebe a tad
* Spawning mechanics
* Work on gamemode code
* Finishes up ark stuff
* Removes Judgement, and lots of other changes
* New Ark activation sounds, Ratvar text
* Spawn protection!
* Adds the abscondence bijou
* Bijou stuff
* well, this is it
* somewhat absentminded coder
* Remaps the Reebe z
* replica fabricators now work!
* Guide paper!
* Now they're clockwork floors
* Infirmary, tweaks, numbers
* A new thing!
* this is ok for now
* I was gonna whine but it's actually necessary
* Adds damage scaling to ocular wardens
* I missed a thing
* you can go back too
* New clockwork armor sprites
* Weapons, scripture, oh my!
* no! shoo!
* hey, I forgot about you!
* this looks much better, I'll give you that
* no teleporting into the void!
* we have no need of you anymore
* Conflicteroos
* AUTOMATIC SPINNING CHAIRS
* how many times do we have to teach you this LESSON OLD MAN
* flagged!
* last time, meesa promise
* Conflicts 1
* wood filling
* Kindle is a projectile, and other stuff
* Chameleon jumpsuit, some small changes
* 150 hours of testing
* Curious is the trapmaker's art
* Conflicts 1
* naaah
* Fixes an ark sound
* Removes the prolonging prism
* Adds a delay to warping in
* First steps towards changing the power system
* Removes power from sigils, moves to global
* Conflicts 1
* zoom zoom
* Adds the stargazer, re-adds conversion
* conflicts? more like CLOCK-flicts
* get it? clockflicts?
* Daemon tuning
* Scraps components, 1/?
* A grace period, among other things
* You can't get to reebe from space no stop bad
* Adds some cogscarab shells to Reebe - yes, I get the sounds
* FUCK
* Chairs are very important.
* Clock golems, sound improvement, intercoms
* Sounds, floor fixes, conflicts
* Fixes the conflicts
* Prevents intercom use during non-clock rounds
* Wiki, HUD timer, tweaks, golems
* Components, removes unused structures, rep. fab power
* go-time
* Ending the round is not a good idea
* whoops, forgot about you
* ssh is ok
* this works too
* Dynamic map loading prototype
* Get the title screen working
* Fixes the random pod bugs
* map configs
* Add back the asteroid
* Ignore the rotate file
* Fix some shit
* More shit fixes
* Babby's first json
* Cyberboss confirmed shitcoder
* Makes map rotation great again
* Moves the map defines
* Delete tgstation2.dm
* Convert runtimestation
* Convert PubbyStation
* Convert OmegaStation
* Convert Metastation
* Convert Delta Station
* Lol file extensions
* Reee line endings
* Take out the trash
* Fix loadallmaps.dm
* Deltaassssssstation?
* Fix travis
* Did I ASK you to change the line endings?
* Remove votable maps
* Cleanup
* Previous config. Load configs in New. Fix splash
* Fix this
* More generic minetype
* STOP TOUCHING THE LINE ENDINGS!!!
* Add some flexibility to /obj/screen/splash
* Fix the shit
* Update gitignore
* Smooth transition from last map
* Better check
* Missed this map rotate check
* Remove these checks too
* Prep for a future request by @kevinz000
* Fix z2 line endings
* Solution for custom .dms
* Rename some things, trim some fat
* Fixes default map_config
* Remove stale comment
* Delete the previous config after loading
* Don't try to open a non-existent file
* Delete the old rotator script
* And references to it
* Line endings
* More line endings
* Del checks from when m-config may have not existed
* LINE ENDINGS
* Update the default map config
* Map load error checking for what it's worth
* Small cleanup
* For case sensitive
* File systems
* Strip maprotate stuff from build script
* Spruce up the _maps tree. Compile some empty space
* Make travis simpler
* LINEARU ENDARU!!!
* tgstation TWO!!!
* Lowercase mine type
* Dummy dm's for testmerging
* Fixes job ordering
* If ghosts wanna watch the map load so be it
* Let them know what's going on
* Fixes z-transitions
* Optimize z expansion further
* Remove this old var
* Fix wiznerd teleportation
* Rmove butt
* Does the thing
* Moved temp configs to the data dir
* Un-touch gitignore
* Forgot templates.dm
* Forgot to include the includer
* Fair enough
* SILENCE IMBECILE!
* @Cyberboss still a fuckboi
* Speed things up a bit
* Fix a potential bug with the error message
* Whatever
