* Fixes the admin log when adding a new admin from the permissions panel not displaying the ckey of the new admin (#78245)
## About The Pull Request
It was just displaying nothing, which was only a mild annoyance, but
after tolerating it for a few years, today I've had enough and fixed it.
## Why It's Good For The Game
Finally others can know who was added to the team without having
`R_PERMISSIONS` themselves.
## Changelog
🆑 GoldenAlpharex
fix: The message sent to admins when a new admin has been added via the
Permissions Panel will now properly show the new admin's ckey.
/🆑
* Fixes the admin log when adding a new admin from the permissions panel not displaying the ckey of the new admin
---------
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
* Adds lag compensation for the supermatter zaps and some antagonists. (#78174)
## About The Pull Request
Adds delta time scaling for changeling chemical generation, xenomorph
plasma generation, xenomorph resin healing (up to 8 seconds per tick to
prevent weird instant heal phenomena in extreme cases), and revenant
essence generation. This delta time scaling is based on the world's time
and the respective subsystem's last fire. This will help keep these
generation smooth even when their respective subsystem lags, preventing
lag from ruining the antagonists rounds. This can still slow down if the
actual world is slowing down, but that's fine because the rest of the
world will typically be slowing down proportionately so it's fair.
Fixes supermatter zap rate not scaling with its internal energy
properly. Ghilker forgot to scale the time reduction by seconds. It
should be much faster at higher energy levels, making the transition
between 0 and 5 GeV more smooth.
Supermatter zap power generation will scale by the world's delta time
between the supermatter's last zap, making power generation more
consistent even when atmos lags. Also prevents the supermatter zap rate
scaling from also scaling the power generation by extreme amounts,
keeping it linear and consistent for the first 5 GeV (>5GeV has cringe
power multipliers, but I'm going to ignore that for this PR, because I
want this to mainly be a consistency thing rather than a balance thing).
A 1.5GeV supermatter will be able to generate around 800kW* of power. I
forgot exactly what goal of power we want the roundstart SM to produce,
so I might change the scale if I find the target power generation.
* - By generate 800kW of power I mean the energy the actual zaps
contain. Tesla coils don't collect 100% of it. I'll test later to see
how much an actual roundstart SM will output to grid (ignoring SMES),
and I'll try to keep it as close as possible to what it was before this
PR assuming no lag.
## Why It's Good For The Game
Subsystems can disproportionately lag a lot more compared to the rest of
the subsystems and game. This can ruin antagonist rounds as it can slow
their chemicals, plasma or whatever generation grinding to a halt. The
delta time scaling will significantly reduce the impact of lag for these
antagonists, allowing them to play more normally even while the
subsystems their generators run on are lagging.
Supermatter zap rate was supposed to fire every 2.5 or something seconds
at 1.5GeV according to comments on older commits. I just assume they
accidentally forgot to scale their time reduction by seconds, as doing
that made it work accordingly.
For supermatter zap power generation delta time scaling, kinda same
reasoning as for the antagonists. We don't want power generation to stop
because atmos ss is being slow. Scaling between the zaps also prevents a
nonlinear boost to power generation making it even more absurd at higher
energy levels.
## Changelog
🆑
balance: Supermatter zap power generation scales with the delta time
between its last zaps, preventing faster zapping from scaling power
generation to extreme levels.
fix: Fixes supermatter zap rate not scaling properly. It should zap much
faster at higher energy levels as intended.
qol: Changeling chemical generation scales with the world's delta time,
making its rate independent of subsystem lag.
qol: Revenant essence generation scales with the world's delta time,
making its rate independent of subsystem lag.
qol: Xenomorph plasma generation and resin healing scales with the
world's delta time, making their rates independent of subsystem lag.
/🆑
* Adds lag compensation for the supermatter zaps and some antagonists.
---------
Co-authored-by: Pickle-Coding <58013024+Pickle-Coding@users.noreply.github.com>
* Stops the Vorpal Scythe harming you even when sated (#78233)
## About The Pull Request
As it says on the tin. Fixes
https://github.com/tgstation/tgstation/issues/78218
## Why It's Good For The Game
Broke in a recent refactor.
## Changelog
🆑
fix: The vorpal scythe is no longer as greedy about you murdering
people, and will once again accept striking any living creature to be
sated.
/🆑
* Stops the Vorpal Scythe harming you even when sated
---------
Co-authored-by: necromanceranne <40847847+necromanceranne@users.noreply.github.com>
* Polymorph belt blacklists several biotypes instead of allowing only organics (#78229)
## About The Pull Request
Title; this makes the belt able to morph into _more_ mobs, but _less
problematic/abusable_ mobs hopefully. It still only functions on
basic/simple_animals, however.
~~Headslugs get a `MOB_UNDEAD` bioflag to prevent morphing into them
completely. Though catching a sentient ling slug and morphing everyone
into it is funny, it's only funny the first 5 times someone does it.
(disclaimer: this is an approximation, i did not actually see a
polymorph belt in-game because i currently play miner and like 10 games
a week tops)
Arguably, this isn't ideal, but it's the closest we get unless we rename
`MOB_EPIC` or something into `MOB_SPECIAL` and let that one be the go-to
bioflag for mobs we don't want **fun** things happen to.~~
`MOB_EPIC` is now `MOB_SPECIAL`. Headslugs get that.
I think the alternative methow could use whatever the gold cores use to
determine what to spawn but that would shift the mobs available for the
belt even more and I can't be assed to figure out how _much_ of a shift
that would be. Dragons or slimes or lavaland mobs would be out, for
example. Don't really vibe with that.
Fixes headslug's description bit that discerns a sentient slug from an
AI one showing up on a dead slug. It can't move while it's dead, no
matter its mind/AI.
Also adds simple dmdoc comments to the defines to help discern a few of
them more easily. Non-quip text suggestions welcome.
## Why It's Good For The Game
- Resolves#77756
- Resolves#78227
More mobs available for the funny belt but less _fun_ mobs should allow
for more stable use of the damn thing. Arguably, some of the mobs that
have been found to be incompatible with the belt are simply lacking a
`MOB_ORGANIC` flag, some of them with no apparent reason. However,
blacklisting potentially problematic biotypes should be easier to design
the unwanted mobs around.
Also consistency, less all-ling stations, code clarity. Whatever.
## Changelog
🆑
balance: polymorph belt now blacklists mobs that are undead, humanoid,
robotic or spiritual (in nature, not religiously), as well as megafauna
balance: however, this means that it works with more mobs that it should
logically work with, like slimes/bugs/lightgeists etc
fix: fixed headslug shenanigans with the polymorph belt hopefully for
good this time
fix: fixed headslug description mentioning its movement despite the slug
being dead
/🆑
* Polymorph belt blacklists several biotypes instead of allowing only organics
---------
Co-authored-by: Sealed101 <cool.bullseye@yandex.ru>
* Update clothing appearance following species change (#78185)
## About The Pull Request
Fixes#78179
Monkey clothes didn't fit following black charged slime transformation
(I hate xenobiology)
Moved the proc call which updated the clothing appearance from turning
into or returning from being a monkey into generic `on_species_gain` on
the basis that this would effect any species with weird clothing offsets
(such as transforming into a golem from the same source) and we don't
want a bunch of specific checks against it.
Also I just tidied up that proc a little bit.
## Changelog
🆑
fix: Your clothes and such should correctly reposition themselves if a
black charged slime extract turns you into a monkey.
/🆑
* Update clothing appearance following species change
---------
Co-authored-by: Jacquerel <hnevard@gmail.com>
* Makes the Haunted Eight Ball work(?) (better?) (#78196)
## About The Pull Request
From my recollection the haunted eight ball has been "broken" for like 3
or 4 years. So uh... yea
Makes the Haunted Eight Ball actually, like, work good.
- Fixes all votes counting to 0
- Fixes votes being reported as their vote key and not a flavor message
- Allows ghosts to change their vote
- General small code cleanup
- Calls parent in topic so stat panel clicks work
- Fixes#41718 , again? If it was actually ever fixed, not sure
## Changelog
🆑 Melbert
qol: Haunted 8-ball no longer requires the ghost orbit the petitioner to
submit votes
qol: Haunted 8-ball ghosts can now change their vote after submitting it
fix: Haunted 8-ball no longer always reports "yes"
fix: Haunted 8-ball no longer always reports default "yes", "no", or
"maybe" and now gives a proper eight ball response
fix: Haunted 8-ball can be picked up via the stat panel
/🆑
* Makes the Haunted Eight Ball work(?) (better?)
---------
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
* Fixes mortars grinding and juicing (#78212)
## About The Pull Request
Mortal and pestle failed to grind items, as the proc passed over the
item itself, instead of the reagent holder. This PR fixes that.
## Why It's Good For The Game
Its good to have a way to grind some chemicals and fruits without an
All-in One Grinder.
Fixes#78205
## Changelog
🆑
fix: Mortar and pestle can grind stuff again
/🆑
* Fixes mortars grinding and juicing
---------
Co-authored-by: Profakos <profakos@gmail.com>
* Service borg extra apparatus upgrade (#78077)
## About The Pull Request
Adds an upgrade similar to the extra beaker storage for mediborgs to
service borgs, which adds an additional drink apparatus (that also
doesn't do the weird drink refilling thing)
## Why It's Good For The Game
This can allow the service borg to carry a wider variety of drinks, also
considering they specialize in chemistry, they should get an apparatus
upgrade like mediborgs.
## Changelog
🆑
add: Added the service borg "drink apparatus" upgrade, which adds an
extra drinking apparatus to the borg, up to a maximum of 5 extra.
🆑
* Service borg extra apparatus upgrade
---------
Co-authored-by: Teagarden <124026007+Vincent983@users.noreply.github.com>
* humpback emergency shuttle (#78021)
## About The Pull Request
adds that thing
has a medbay, brig is at the air supply controls, air supply is there to
make sure the shuttle doesnt get depressurized when people go to the
outside part to see spess
also has a bar
also forces a carp shuttle event but it should be usually the passive
carp one
## Why It's Good For The Game
it could probably bring another cool layout to the shuttle roster
## Changelog
🆑
add: humpback emergency shuttle
/🆑
---------
Co-authored-by: Time-Green <7501474+Time-Green@ users.noreply.github.com>
* humpback emergency shuttle
---------
Co-authored-by: jimmyl <70376633+mc-oofert@users.noreply.github.com>
Co-authored-by: Time-Green <7501474+Time-Green@ users.noreply.github.com>
* Bloodchiller and ling tentacle work with antimagic (#78200)
## About The Pull Request
Fixes#78198
Tentacle and bloodchiller had antimagic flags that they inherited from
`gun/magic` and were unusable if you had magic immunity. I set those
flags to `NONE`
## Why It's Good For The Game
Fixes a bug
## Changelog
🆑
fix: Changeling tentacle and bloodchiller from xenobio will no longer
stop working if you have antimagic
/🆑
* Bloodchiller and ling tentacle work with antimagic
---------
Co-authored-by: cnleth <113535457+cnleth@users.noreply.github.com>
* Rice Dough can be made in a beaker (#78062)
## About The Pull Request
Rice dough can be made in a beaker using 20u of Rice Flour and 10u of
Water. 10u of Rice Flour is made from 5u of Rice and 5u of Flour. Rice
dough can still be crafted manually using the crafting menu and the
original recipe.
## Why It's Good For The Game
Cooks can sometimes get swamped with work, especially on a high-pop
shift or when there are no botanists. By making rice dough more
convenient to make, cooks don't need to spend as much time in the
crafting menu.
Rice Flour is made from mixing equal parts Rice and Flour. Since no
recipe other than Rice dough uses both Rice and Flour in it's Recipe, it
should be fine to turn those regents into the intermediate reagent "Rice
Flour".
Fixes#77966
## Changelog
🆑
qol: Rice Dough may be made in beaker instead of being crafted, but the
rice and flour must be added first
/🆑
* Rice Dough can be made in a beaker
---------
Co-authored-by: blueDev2 <89804215+blueDev2@users.noreply.github.com>
* Desouls Hivelord (#78213)
## About The Pull Request
Replaces the sprite of the hivelord with a new one, in my continuing
quest to annihilate the old asteroid mob sprites.
A (never completed) asteroid mob resprite was actually my first PR, this
one is my 200th.
I am also planning on fucking with basic mob versions of these mobs some
time but the sprites can be atomised out.
In addition to replacing the old-ass MSPaint sprites, this PR also adds
a short death animation effect to the hivelord brood (from hivelords or
legions) which looks nicer than them just vanishing instantly upon
death.
Look at this video for an example of the animation:
https://www.youtube.com/watch?v=cKaskN5-y2A
## Why It's Good For The Game
Looks nicer.
## Changelog
🆑
image: Hivelords have a new sprite.
image: Hivelord and Legion brood have a death animation.
/🆑
* Desouls Hivelord
---------
Co-authored-by: Jacquerel <hnevard@gmail.com>
* Allows you to smoke cigarettes while not wearing a space helmet (#78202)
## About The Pull Request
Fixes#78199
PR #78122 (ef44be8506) was intended to allow you to smoke cigarettes in space if you
have an oxygenated helmet on.
What it _actually_ did was make it so you can _only_ smoke cigarettes if
you have an oxygenated helmet on, regardless of whether or not you are
in space (or if you inject them with liquid oxygen).
I moved the shared check into a proc to reduce duplicate code and fixed
the logic.
## Changelog
🆑
fix: It is now possible to smoke cigarettes even if you aren't wearing a
safety helmet
/🆑
* Allows you to smoke cigarettes while not wearing a space helmet
---------
Co-authored-by: Jacquerel <hnevard@gmail.com>
* Allow spawner component to be instantiated with an empty list (#78188)
## About The Pull Request
Supplementary to ffd3edc22bFixes#78172
The spawner component could be added to arbitrary items by admins but
would always throw an error because it was passed an empty list. Admins
were not capable of providing anything _other_ than an empty list to it
on init, due to limitations in our interface.
We (I but I had help) broke this in #73645 by removing the default
"spawns carp" list.
It is still silly for it to default to spawning carp, but instead it can
now be instantiated with an empty list without breaking, and an admin
can then VV it to further modify the list to what they actually want it
to do.
## Changelog
🆑
admin: Admins can add/remove the spawner component from arbitrary items
again.
/🆑
* Allow spawner component to be instantiated with an empty list
---------
Co-authored-by: Jacquerel <hnevard@gmail.com>
* The Create Command Report verb has the option to prevent printing reports now (#78208)
## About The Pull Request
Title summarizes all.
## Why It's Good For The Game
<details>
</details>
Prevents this nightmare on a comms console during an event with
particularly high centcom announcement traffic.
No, don't come at me with "it's soul", it's just highly annoying to deal
with and having the option to prevent it is better. If you leave a
downvote and tell me in the comments that I'm "taking" soul out of the
game then I will come find you and actually take your soul out of your
body.
## Changelog
🆑
admin: The "Create Command Report" verb now has the option to not print
report papers at communications consoles.
/🆑
* The Create Command Report verb has the option to prevent printing reports now
---------
Co-authored-by: distributivgesetz <distributivgesetz93@gmail.com>
* Exploration drones can no longer be used to get to centcom (#78197)
## About The Pull Request
Fixes#73417
Implements a check for exploration drones to make sure that containers
inside the storage don't have blacklisted items in them before launch.
Now you won't able to hide beacons and living beings inside bluespace
body bags.
Also adds exploration drone launchers to cargo shuttle's blacklist to
prevent potential shenanigans in the future.
[I suck at explaining, so here's a poorly made video that shows how to
do this](https://www.youtube.com/watch?v=U45ifQGQxzI)
~also, why does it take 10 hours to get the "Time Waster" achievement.
how did 6 people even get it??~
## Why It's Good For The Game
centcom is scary and exploits are bad
## Changelog
🆑
fix: Exploration drones can't be used to reach Centcom anymore.
/🆑
* Exploration drones can no longer be used to get to centcom
---------
Co-authored-by: leaKsi <59278564+leaKsi@users.noreply.github.com>
* Fixes traitor objective brainwashing deadchat broadcast double-punctuation and doubles the number of default directives (#78161)
## About The Pull Request
This fixes the double-period at the end of brainwashing deadchat
broadcasts. If you know what I'm talking about, you know, but I didn't
want to go back to get screenshots to show what I mean.
The broadcast would automatically put a period at the end of the
compiled message, and the default brainwashing directives already came
with a period at the end. Not content with removing the period at the
end of the directives or the automatic period, I made something that
works both ways.
This also adds some more default directives (the ones given by the
brainwash surgery objective). These objectives aren't too direct or
commanding but still open up opportunities to run with the prompt.
## Why It's Good For The Game
The double punctuation was really annoying me.
The new directives are meant to give variety to the same boring-ish 6
directives by turning 6 into 12. Hopefully they're flexible enough for
more creative spessmen to work with.
## Changelog
🆑
qol: adds some more traitor objective brainwashing default objectives.
spellcheck: fixes the double-punctuation on traitor objective
brainwashing broadcasts.
spellcheck: brainwashing deadchat broadcasts will now auto-punctuate.
/🆑
* Fixes traitor objective brainwashing deadchat broadcast double-punctuation and doubles the number of default directives
---------
Co-authored-by: Rhials <28870487+Rhials@users.noreply.github.com>
* Collected food fixes (#78190)
I went through the code and tried to find all of the remaining places we
forgot to update the arguments passed into `item/food/Initialize` after
more arguments were added to it, because there were a couple and they
caused things to stop working.
Most notably, golems were unable to eat anything because nothing would
correctly spawn "golem food".
_Additionally_ we were using a bunch of named arguments in new whenever
crafting or cooking food. This runtimed, causing the food not to init
properly.
_On top of that_ a late code review on a recent PR processed a list into
a string_assoc_list twice causing it to become null.
Finally, we were trying to check the food preferences of examining
ghosts or dogs or other non-human mobs. We shouldn't do that.
I also added a unit test for moth and golem food in the hopes that we'll
notice them breaking.
* Collected food fixes
---------
Co-authored-by: Jacquerel <hnevard@gmail.com>
* Martian foodtype corrections (#78002)
## About The Pull Request
Due to the size of the Martian food update, it was inevitable that
there'd be a few hiccups with food types. I reviewed everything and
updated everything to the best of my ability.
I'd prefer it if EOB himself gave everything a glance over in approval
before any potential merging.
## Why It's Good For The Game
I said so.
## Changelog
🆑
fix: Corrects various food types from the martian food expansion
/🆑
* Martian foodtype corrections
---------
Co-authored-by: carshalash <carshalash@gmail.com>
* Increases midround traitor starting reputation (#78189)
## About The Pull Request
Reputation for traitors serves two goals:
_Primarily_ it is a timelock. Secondarily, it can drive interaction with
secondary objectives by giving you a little reward.
The way that progression traitors work is that reputation is earned
every minute, so that when a developer is adding a new item for the rep
cost they can just write "30 MINUTES" and it means that the item will be
available when 30 minutes have passed, or a little earlier if the
traitor does some secondary objectives.
_Currently_ when traitors arrive on the station they get reputation
equal to _60%_ of the reputation that they would have had if they became
a traitor at the start of the round and then had hidden in a locker
until the current time.
This PR increases that to 100%, so if you are activated as a sleeper
agent 30 minutes into the round you will immediately have 30 minutes of
reputation. With this and your standard 20TC you can buy almost anything
in the uplink, such as a syndicate bomb.
## Why It's Good For The Game
Given that it is primarily supposed to be a time lock to prevent people
from immediately accessing items which can rapidly pivot the round, it
doesn't make sense that late joining traitors are "penalised" in this
way. If we're ok with a roundstart traitor having a bomb right now, we
should be ok with a latejoin one having one too.
As far as I am concerned secondary objectives should be something you do
for a _bonus_, and anything which can drag people away from being 100%
mechanically focused in order to chase the increasing number in favour
of just being able to do their damn gimmick is a good thing.
## Changelog
🆑
balance: Traitors who are activated as sleeper agents or arrive late on
the arrivals shuttle will begin with more reputation and likely be able
to immediately access most of the uplink catalogue.
/🆑
* Increases midround traitor starting reputation
---------
Co-authored-by: Jacquerel <hnevard@gmail.com>
* You can now send PDA messages when resting (#78154)
## About The Pull Request
No longer must you stand up when sending messages over the PDA! Do it
all comfortably, laying down in your bed!
Computers are automatically inaccessible when resting, so this only
affects PDA's, TABLETS, and LAPTOPS
## Why It's Good For The Game
Why wouldn't I be able to use a PDA laying down, heck everyone uses
their phone laying on their back, using your PDA like that only makes
sense
## Changelog
🆑
fix: The messenger app can now be used when laying down.
/🆑
Co-authored-by: John Willard <53777086+JohnFulpWillard@ users.noreply.github.com>
* You can now send PDA messages when resting
---------
Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
Co-authored-by: John Willard <53777086+JohnFulpWillard@ users.noreply.github.com>
* [Icebox] Remaps Arrivals and a bit of surrounding maintenance, feat. actually functioning disposals mass driver. Also nukes the Aux Base. (#78048)
## About The Pull Request
- Remaps Icebox Arrivals
- I added some weather radios as flavor in arrivals someone tell me if I
shouldn't.
- Removes the Aux Base, for it serves no purpose
- Removes the whiteship dock, it serves no purpose. Centcom Ferry now
docks at where the whiteship dock once did.
- Remaps a bit of maintenance around it, specifically disposals
- Remaps a bit of the laundry room and locker room
- Disposals now actually dumps its waste into plasma/lava when using the
mass driver
- Adds a barometric radio to Icebox Mining office
<Details>
<Summary> PICTURES HERE PICTURES HERE PICTURES HERE PICTURES HERE
PICTURES HERE PICTURES HERE PICTURES HERE PICTURES HERE PICTURES HERE
PICTURES HERE PICTURES HERE PICTURES HERE PICTURES HERE PICTURES HERE
</Summary>
</Details>
## Why It's Good For The Game
Icebox Arrivals hasn't changed since Boxstation and as soulful as it is,
it can better integrate into the map's new identity.
To start, the Aux base: Serves no purpose on the Icemoon. Literally
useless besides having an extra stack of Plasteel for cultists to steal
and an extra PKA for tiders to steal.
It's gone. In its place is a small emergency EVA room / an external
airlock access.
Disposals. Literally hasn't been touched since Box, just DUMPED trash 10
tiles away onto the Icemoon. Kinda lame.
I moved it to the lower floor and made the mass driver dump its trash
into the river of plasmalava below.
Whiteship dock. Useless, no whiteship exists on Icebox. If badmins want
to mess around with docking shuttles they have the Centcom Ferry, or for
the more adept, they can manually place a dock.
Otherwise, the changes are just general modernizing. Brings it a bit
closer to how Delta's arrivals is set up.
## Changelog
🆑 Melbert
add: [Icebox] Remaps arrivals and the maintenance around it. Aux base
out, mass driver into a plasma lake in.
/🆑
* [Icebox] Remaps Arrivals and a bit of surrounding maintenance, feat. actually functioning disposals mass driver. Also nukes the Aux Base.
* Updating automapper
* Automapper placement
* Update icebox_arrivals.dmm
* Arrivals shuttle fix
* Update icebox_arrivals.dmm
---------
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com>
* Canonizes Robot Yawns (#78175)
## About The Pull Request
Closes#77592
I agree that it's silly that robots shouldn't be able to yawn, but I
think that instead of removing the potential for this interaction to
occur outright (which can be done with moving around a check), it should
be embraced instead.
## Why It's Good For The Game
Robots fake-yawning to make them feel more realistic to the workers of
the station (and if they aren't station based, their once-creators
(which is fine because we removed swarmers)) and not being exempt from a
really cutesy niche interaction greatly appeals to me.
## Changelog
🆑
add: Ever see a robot yawn? Don't worry, it makes sense now.
/🆑
* Canonizes Robot Yawns
---------
Co-authored-by: san7890 <the@san7890.com>
* Supermatter delam common radio alert cooldown (#78104)
## About The Pull Request
Changes the supermatter radio alert to be less spammy while the crystal
is healing during recovery.
If the crystal is in a state of fast healing (defined as 3% per minute,
about half of a crystal's 6%/min recovery at 293K) we're in a situation
where the engineers have prevented the delam and the crystal is
returning to normal.
In these situations the Common radio channel doesn't need to be reminded
every 60 seconds that the crystal is more than fine and on its way back
to 100, a cooldown is started for the Common channel alerts. Engineers
continue to get the integrity update every 60 seconds as usual on their
departmental channel.
The cooldown is only applicable to when the crystal is healing, if
integrity starts dropping again below the emergency point Common will be
alerted.
The command span is added for the final countdown only (from
https://github.com/tgstation/tgstation/pull/77996)
## Why It's Good For The Game
The SM alerting on Common every 60 seconds as it heals leads to alarm
fatigue and you tune it out. It should only be alerting Common when
there is imminent danger to the crew or that the danger has passed.
## Changelog
🆑 LT3
qol: Supermatter common channel alerts are less frequent if the
crystal's integrity is rising rapidly
/🆑
* Supermatter delam common radio alert cooldown
---------
Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
* Cauteries have heat, you can smoke with a space helmet (#78122)
## About The Pull Request
Cauteries now have 'heat', like lighters, welders, etc.
You can smoke with a space helmet as long as you have internals on.
## Why It's Good For The Game
> Cauteries now have 'heat', like lighters, welders, etc.
Seems like an oversight. If an esword can do it so can a implement meant
to sear wounds shut.
> You can smoke with a space helmet as long as you have internals on.
Space smoking is awesome.
## Changelog
🆑
fix: Cauteries now have 'heat', like lighters, welders, etc.
qol: You can smoke with a space helmet as long as you have internals on.
/🆑
* Cauteries have heat, you can smoke with a space helmet
---------
Co-authored-by: carlarctg <53100513+carlarctg@users.noreply.github.com>
* Change gas mixer to mix by molar instead of volumetric (#78034)
## About The Pull Request
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
Gas mixer output now accurate to set ratio regardless of mismatched
input temperatures
Input
Mixer
Output
## Why It's Good For The Game
We can start by looking at what gas mixers are actually good for. First
we have air supply mix and burn mixes, these are the main uses for a
mixer, but the resulting mix becomes inaccurate if one of your gas
supply tanks is cooler or warmer than another (this often happens when
someone adds a bunch of cold n2 or o2 to wastes). A gas mix for the HFR
or crystallizer, usually these are set up with a constant supply of
gasses with temperature of an input often varying, eventually clogging
if the mix becomes inaccurate. Finally we have bomb and internal mixes,
I would argue that this is the most important reason to keep things the
way they are, but are actually currently the easiest to manage. All of
these uses require molar precision, something the gas mixer doesn't
really provide on its own, making it almost useless if two inputs do not
match in temperature.
In my experience, in order to mix gasses accurately, you must do one of
three things. First, you must use a combination of heat gates and
thermomachines to equalize the temperatures before mixing. Second, you
can combine the mixtures into one to equalize the temperature, filter
the gasses apart, and mix again with your desired ratios. Or the third
option, you could create a custom calculator to take in your desired
ratio and the current temperatures of your input and plug the resulting
ratio into the mixer.
The way gas mixers work currently serves no real purpose outside of
tripping up new players and providing 'busy work' for the experienced
ones. Many newer players expect gas mixers to provide the set ratio to
the output, not knowing that the temperatures on the input mixes must
match. It requires a lot of additional effort and knowledge to
accurately mix gasses, something that should just be provided by the
tool itself.
This change is good because it helps makes atmos a bit simpler and more
intuitive. Unfortunately we will lose complexity in setups and make
atmos a bit easier, but maybe these are good things
## Changelog
🆑
balance: gas mixer output now accurate to set ratio regardless of input
temperatures
/🆑
* Change gas mixer to mix by molar instead of volumetric
---------
Co-authored-by: Redbert <109347230+Deadgebert@users.noreply.github.com>
Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com>
* GAGS, recolorable and actually glowing glow shoes. (#78071)
## About The Pull Request
I've converted the gags_recolorable component into an element (it has no
var of its own) and the glow shoes icons to greyscale, added emissive
icon states for the shoes, both for its own sprite or when worn, and the
ability to recolor them with a spraycan (tbh a lot of clothing should be
recolorable with a spraycan in general but that's beyond the scope of
this PR)
Oh yeah, if you examine an item with the gags_recolorable element twice,
it now tells you can use a spraycan to recolor it.
## Why It's Good For The Game
They are called glow shoes yet don't glow, and the supposed glowing
stripes only come in a single flavor of blue. Truly the definition of
lame.
Overall, it looks as goofy as ever: I didn't put much effort into the
grayscale icons beyond the necessary:
## Changelog
🆑
image: The glow shoes from the ClothesMate now actually glow and can be
recolored, even with a spraycan.
/🆑
---------
Co-authored-by: san7890 <the@ san7890.com>
* GAGS, recolorable and actually glowing glow shoes.
* Modular stuff
---------
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Co-authored-by: san7890 <the@ san7890.com>
Co-authored-by: Giz <13398309+vinylspiders@users.noreply.github.com>
* [NO GBP] Name-wise, the telescopic fishing rod is no longer just a fishing rod (#78130)
## About The Pull Request
Gives the telescopic fishing rod its own name.
## Why It's Good For The Game
Guess why.
## Changelog
🆑
spellcheck: Corrected the name of the telescopic fishing rod to
"telescopic fishing rod" from the more generic "fishing rod"
/🆑
* [NO GBP] Name-wise, the telescopic fishing rod is no longer just a fishing rod
---------
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
* Fixing this dead mouse related harddel (#78150)
## About The Pull Request
Fixes https://github.com/tgstation/tgstation/issues/78085
Fixes https://github.com/Skyrat-SS13/Skyrat-tg/issues/23510
Fixes https://github.com/Skyrat-SS13/Skyrat-tg/issues/23506
When the foodening added some args to the constructor of
`/obj/item/food` some instances of the constructor being passed stuff
got overlooked and were not updated.
This resulted in a mob ref potentially being passed in to
`starting_reagent_purity` in some cases, ultimately resulting in this
harddel.
@ SyncIt21 this is exactly the reason I was being so paranoid with #77946
the other day. Tracking constructor uses down can be such a pain when
they aren't prefaced with a type, and are almost guaranteed to get
overlooked during refactors if the compiler does not say anything about
it.
I hate DM.
edit: and I just tested this only to find a second bug with the ice
cream. I can confirm that it is in fact working now after fixing that
one too.
<details><summary>evil ice cream</summary>
</details>
## Why It's Good For The Game
Fixing a harddel that was causing many CI failures
## Changelog
🆑
fix: fixes creamatorium not producing any suspicious ice cream, and
fixes a dead mouse related harrdel
/🆑
---------
Co-authored-by: MrMelbert <51863163+MrMelbert@ users.noreply.github.com>
Co-authored-by: Jacquerel <hnevard@ gmail.com>
* Fixing this dead mouse related harddel
---------
Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com>
Co-authored-by: MrMelbert <51863163+MrMelbert@ users.noreply.github.com>
Co-authored-by: Jacquerel <hnevard@ gmail.com>
* Meteor turfs typecache (#78152)
## About The Pull Request
When looking why meteors randomly explode sometimes, the check has it
taking damage and exploding from turfs that it should just be flying
over. This creates a typecache of turfs the meteor shouldn't deplete
health from flying over. Most commonly openspace and asteroid baseturf.
## Why It's Good For The Game
Meteor is more likely to explode when it actually hits something vs
flying into an openspace tile.
## Changelog
🆑 LT3
fix: Meteors no longer take damage from crossing certain unoccupied
turfs
/🆑
---------
Co-authored-by: san7890 <the@ san7890.com>
* Meteor turfs typecache
---------
Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
Co-authored-by: san7890 <the@ san7890.com>
* Colossus' Titan's Finale ability has a 0.5 seconds delay before starting the attack (#78171)
## About The Pull Request
ided pls nerf
## Why It's Good For The Game
This motherfucker is horrid to fight with a crusher because the first
attack that he does in this action is a shotgun blast, which you just
eat with your face and die. The only reasonable way to trigger this
attack is with a ranged weapon or with a hiero's trophy, the former
being antithetical to the challenge/playstyle that is crusher mining and
the latter being wildly uncontrollable.
Half a second should be ample time to dodge out of harm's way before
server-lagging touhou begins.
## Changelog
🆑
balance: colossus' near-death attack now starts after a 0.5 seconds
delay
/🆑
* Colossus' Titan's Finale ability has a 0.5 seconds delay before starting the attack
---------
Co-authored-by: Sealed101 <cool.bullseye@yandex.ru>
* fix basic mobs ranged burst attacks (#78163)
## About The Pull Request
the burst attacks wasnt working because a cooldown in the ranged
component qwas added recently. this now moves the burst attacks option
to the component itself so even sapiant player mobs can use these burst
ranged attacks
## Why It's Good For The Game
fix basic mobs ranged burst attacks
## Changelog
🆑
fix: basic mobs can now use ranged burst attacks
/🆑
* fix basic mobs ranged burst attacks
---------
Co-authored-by: Ben10Omintrix <138636438+Ben10Omintrix@users.noreply.github.com>
* Adds special lung sprites for smoker quirk (#78119)
## About The Pull Request
What it says on the tin, adds special sprites for ethereal, plasmaman,
and regular lungs for if you use the smoker quirk.
Top is normal lungs, bottom is lungs if you use the smoker quirk
Adds some cool flavor and a visual difference between regular and smoker
lungs. Previously, smoker lungs looked identical to normal ones but had
less health and healed slower.
## Why It's Good For The Game
Details are nice, and it was weird there was no visual difference before
since realistically, smoking constantly makes your lungs very visually
different and deteriorate over time.
## Changelog
🆑
image: adds special sprites for lungs when you use the smoker quirk
/🆑
---------
Co-authored-by: san7890 <the@ san7890.com>
* Adds special lung sprites for smoker quirk
---------
Co-authored-by: die_amond <58376695+dieamond13@users.noreply.github.com>
Co-authored-by: san7890 <the@ san7890.com>
* Removed an inexplicable Cyrillic letter from the code. (#78148)
## About The Pull Request
Resolves#77906
I've mercilessly torn the soul from the game and rendered it
functionally unplayable. The icon state for caramel popcorn, for
whatever reason, used a Cyrillic "с" in its name, which I've cruelly
rendered into a Latin "c" instead.
## Why It's Good For The Game
It's not pronounced "saramel".
## Changelog
No player-facing changes.
* Removed an inexplicable Cyrillic letter from the code.
---------
Co-authored-by: lizardqueenlexi <105025397+lizardqueenlexi@users.noreply.github.com>
* Fixed snow legion corpse spawning. (#78147)
## About The Pull Request
Resolves#77973
Due to a pair of oversights, snow legions erroneously drop two corpses
when killed, and both of these corpses use the spawnlists for Lavaland
legions. The duplicate has been removed, and the snow legion corpse
spawner is no longer a subtype of the regular one - which was causing
the issue. Now the new corpses will actually spawn.
## Why It's Good For The Game
Makes #76898 actually work.
## Changelog
🆑
fix: Snow legions now drop only one corpse, and no longer drop Lavaland
corpses.
/🆑
* Fixed snow legion corpse spawning.
---------
Co-authored-by: lizardqueenlexi <105025397+lizardqueenlexi@users.noreply.github.com>
SkyratBot