Commit Graph

16 Commits

Author SHA1 Message Date
SkyratBot b234fb6396 [MIRROR] [no gbp] Fixes runtime in SSstation [MDB IGNORE] (#22791)
* [no gbp] Fixes runtime in SSstation (#77231)

No excuse, just dumb. Random layer is the randomly generated parallax
layer, which is null 30% of the time, so this would runtime in SSstation
setup in 30% of rounds

Also another thing where I added extra params and didn't add them to the
proc, fucking parallax for some roundstart clients and latejoins

🆑
fix: fixes a runtime in SSstation setup
fix: fixes parallax not rendering correctly for latejoins
/🆑

![image](https://github.com/tgstation/tgstation/assets/7501474/650242f7-bc33-49eb-98d9-d8e3619ab808)

* [no gbp] Fixes runtime in SSstation

---------

Co-authored-by: Time-Green <7501474+Time-Green@users.noreply.github.com>
2023-07-31 20:05:46 -04:00
SkyratBot 0532392092 [MIRROR] Starlight colors with parallax, small parallax code clean-up [MDB IGNORE] (#22764)
* Starlight colors with parallax, small parallax code clean-up (#77020)

The space gas parallax now colors starlight in the color of the gas:

![image](https://github.com/tgstation/tgstation/assets/7501474/18b5554f-6357-473e-8f43-64aad1517be0)

<details>
  <summary>Others</summary>

![image](https://github.com/tgstation/tgstation/assets/7501474/1599795f-f76d-479d-a1c3-aa19390ad403)

![image](https://github.com/tgstation/tgstation/assets/7501474/fb992df0-ee85-4afc-a546-f28e739ea923)

![image](https://github.com/tgstation/tgstation/assets/7501474/ed64a01c-c104-4177-bf63-b82288251aa9)

</details>

I also cleaned up parallax random code a bit, making it easier to add
new parallaxes and add minor effects to them

The radioactive nebula parallax thing has also been moved to SSparallax
to make it easier and a bit more sane to change

🆑
add: Starlight will color with space gas parallax
code: Cleans up random parallax code / radioactive nebula parallax code
/🆑

## Why it's good for the game

We can change the starlight color now (mostly thanks to @ LemonInTheDark
making light code easier to work with), so I thought it'd be fun to
actually do! If people hate it, I'll turn it off and we can just call
this a code clean-up PR

* Starlight colors with parallax, small parallax code clean-up

---------

Co-authored-by: Time-Green <7501474+Time-Green@users.noreply.github.com>
2023-07-29 15:58:27 -04:00
SkyratBot 38dc811b6b [MIRROR] NEW STATION TRAIT: Radioactive Nebula [MDB IGNORE] (#22614)
* NEW STATION TRAIT: Radioactive Nebula

* Update job_boxes.dm

* Increase the intensity increment time so that shields will last longer

---------

Co-authored-by: Time-Green <7501474+Time-Green@users.noreply.github.com>
Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com>
2023-07-24 02:07:40 -04:00
SkyratBot 05b494e15e [MIRROR] Station traits won't roll twice [MDB IGNORE] (#19177)
* Station traits won't roll twice (#73174)

## About The Pull Request

Station traits can't roll twice in the same round.
They currently have blacklist for traits that can't roll together, this
makes them not roll with themselves too.

## Why It's Good For The Game

Closes https://github.com/tgstation/tgstation/issues/61873
Station traits are not made with rolling twice in the same round in
mind, and is just a waste of trait points, or will just be annoying
(like in the issue report's case)

## Changelog

🆑
fix: There will no longer have 2 of the same station trait roll twice in
the same round.
/🆑

* Station traits won't roll twice

---------

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2023-02-05 12:43:22 +00:00
nevimer 8dee2e45cd [CORRECTING A MIRROR] Makes station traits less common (#56726) (BYE INTERN) (#18867)
Makes station traits less common (#56726)

The chance for station traits overall has been reduced, while the
weight of some traits have been changed.
# Conflicts:
#	code/datums/station_traits/neutral_traits.dm

Co-authored-by: Qustinnus <Floydje123@hotmail.com>
2023-01-21 22:18:39 -08:00
SkyratBot 26274a342c [MIRROR] Add config for station traits [MDB IGNORE] (#18468)
* Add config for station traits

* Update station.dm

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: Zonespace <41448081+Zonespace27@users.noreply.github.com>
2023-01-09 07:13:20 +00:00
SkyratBot a00cad0164 [MIRROR] Clean up subsystem Initialize(), require an explicit result returned, give a formal way to fail (for SSlua) [MDB IGNORE] (#16248)
* Clean up subsystem Initialize(), require an explicit result returned, give a formal way to fail (for SSlua)

* [PR for MIRROR PR] Changes for 16248 (#16277)

* Merge skyrat changes, update SR SS's, and remove lobby_eye

* Apply suggestions from code review

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Update modular_skyrat/modules/autotransfer/code/autotransfer.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* restore lobby_cam for now

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

Co-authored-by: Tastyfish <crazychris32@gmail.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2022-09-24 17:32:40 -04:00
Zonespace ea00d48c4f Fixes linter (#12622) 2022-04-09 02:55:44 +00:00
Gandalf 5918489c0a [Salt PR] Stops station traits running on LOWMEMORYMODE as well as allowing admins to bypass flavour text (#12615)
* fuck you

* Update station.dm
2022-04-08 23:17:21 +00:00
Tom b3f03c7c14 https://github.com/tgstation/tgstation/pull/64417 (#11309) 2022-02-06 21:21:34 +01:00
SkyratBot b8c2c18dd9 [MIRROR] Adds roundstart logging for station traits [MDB IGNORE] (#10606)
* Adds roundstart logging for station traits (#63985)

* Adds roundstart logging for station traits

Co-authored-by: Seth Scherer <supernovaa41@gmx.com>
2022-01-12 02:23:14 +00:00
SkyratBot fa519bdde3 [MIRROR] cleanup _HELPERS/_lists.dm and all the necessary files [MDB IGNORE] (#8783)
* cleanup _HELPERS/_lists.dm and all the necessary files

* Epbic

Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-10-13 21:07:35 +01:00
SkyratBot 28d0220ead [MIRROR] Add admin panel for station traits (#8337)
* Add admin panel for station traits

* Update admin_verbs.dm

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-09-23 02:03:44 +01:00
SkyratBot fb5576ee8f [MIRROR] Add new Wallets! station trait (#6704)
* Add new Wallets! station trait

* Update wallets.dm

Co-authored-by: coiax <yellowbounder@gmail.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-07-04 23:59:42 +01:00
SkyratBot b7da8c2269 [MIRROR] Adds new station traits that gives departments / everyone death rattle implants (#3683)
* Adds new station traits that gives departments / everyone death rattle implants

* Update jobs.dm

Co-authored-by: Qustinnus <Floydje123@hotmail.com>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
2021-02-28 19:40:35 +00:00
SkyratBot cc67a133e5 [MIRROR] [READY] Adds station traits: Small modifiers that can randomly be chosen each round (#3132)
* [READY] Adds station traits: Small modifiers that can randomly be chosen each round

* conflicts

Co-authored-by: Qustinnus <Floydje123@hotmail.com>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
2021-02-08 23:07:24 +00:00