* Fix telekinesis letting you grab people at a distance, and teleport them to you by strangling them (#84546)
## About The Pull Request
Was told that apparently recent changes have made it possible to grab
and strangle people at a distance with telekinesis... which then
teleports them to you.
Looking into it, it seems to be a missing flag in the following check
preceding pulling living things:
fe7da20ea3/code/_onclick/click_ctrl.dm (L37-L38)
Adding `FORBID_TELEKINESIS_REACH` fixes this.
## Why It's Good For The Game
I recall telekinesis isn't supposed to let you grab people from a
distance.
"Supposed to"s aside, being able to grab and obstruct people from a
distance with no difficulties in doing so is annoying at best and awful
at worst. The strangle teleporting is obviously just plain broken.
## Changelog
🆑
fix: Fixed telekinesis letting you grab people at a distance, and
teleport them to you by strangling them.
/🆑
* Fix telekinesis letting you grab people at a distance, and teleport them to you by strangling them
---------
Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com>
* Some alt & ctrl click improvements (#84203)
## About The Pull Request
Improved code quality of both so they resemble each other. Some of the
new specs are as follows
1. Moved` COMSIG_CLICK_ALT` & `COMSIG_CLICK_ALT_SECONDARY` up i.e.
before `can_perform_action()` making them pure hooks not bound by any
action checks giving components full control over them
2. Removed range check(`CAN_I_SEE`) & view check(`is_blind()`) out of
the base alt click proc. They now only apply to living mobs and don't
apply to ghosts(ghosts don't get blind & see everything) & revenants
(the range check still applies for revenants though).
This was actually a bug because these 2 checks were only meant to see if
the loot panel could be opened (as stated in
https://github.com/tgstation/tgstation/pull/83736#discussion_r1628097941)
but because they are at the top of the proc they also apply to all alt
click actions which is not intended. Also, by moving these checks down
to mob subtype levels some of the snowflake checks like this
7579e0e173/code/_onclick/click_alt.dm (L23)
can be removed. We should not check for subtypes within the parent type
proc but instead have subtypes override their parent procs to implement
custom behaviour
3. Removed redundant signals like` COMSIG_XENO_SLIME_CLICK_ALT` in
favour of just `COMSIG_MOB_ALTCLICKON`
4. While looking for alt click signal overrides I found alt click for
style meter was run timing, that's fixed now
## Changelog
🆑
fix: alt click runtime no more when using style meter
code: improved alt & ctrl click code
/🆑
* Some alt & ctrl click improvements
---------
Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com>
* Improvements for `can_perform_action()` (#84006)
## About The Pull Request
The proc `can_perform_action()` now
- Accepts atoms & not just movables without runtiming. Fixes#83985
- It now uses `CanReach()` instead of `Adjacent()`. Allows you to
- Check if the target object is placed on top & not hidden
- Is the object inside another storage atom & such
- Properly checks for recursive locs. Before we were passing the direct
atom & not the type to `recursive_loc_check()` causing this proc to
always return true & giving us false positives. Now this proc has been
adjusted to accept both type paths & real atoms
- Removes `can_perform_turf_action()` since its now obsolete
## Changelog
🆑
fix: no more runtimes when dragging turfs onto other stuff
code: most actions now properly check for recursive locs & better
adjacency
/🆑
* Improvements for `can_perform_action()`
---------
Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com>
