Commit Graph

14 Commits

Author SHA1 Message Date
SkyratBot
164edf5fa0 [MIRROR] [no gbp] some medbot fixes [MDB IGNORE] (#25472)
* [no gbp] some medbot fixes (#80150)

## About The Pull Request
medbots now drop hats when tipped closes #80134
medbots now drop their items when they explode
player controlled bots now have their normal speed back

## Why It's Good For The Game
they will now correctly drop their hats when tipped

## Changelog
🆑
fix: medbots now drop hats when tipped and drop their items when they
explode
/🆑

---------

Co-authored-by: san7890 <the@ san7890.com>

* [no gbp] some medbot fixes

---------

Co-authored-by: Ben10Omintrix <138636438+Ben10Omintrix@users.noreply.github.com>
Co-authored-by: san7890 <the@ san7890.com>
2023-12-06 22:00:04 -05:00
SkyratBot
5072a5de13 [MIRROR] Adds sanity checking to the tippable component [MDB IGNORE] (#24140)
* Adds sanity checking to the tippable component (#78771)

## About The Pull Request

The tippable component doesn't actually have any sanity checking for if
the tippable thing has already been tipped. This means that if two
people try to tip something over at the same time, it will appear
untipped but be immobilized as though it were tipped. The sprite will
also stay permanently flipped until the bug is preformed again. Now that
doesn't happen. Closes #64232.
## Why It's Good For The Game

As funny as it is to see upside-down borgs running around, its still a
bug.
## Changelog
🆑
fix: Borgs will no longer become permanently upside-down if tipped over
by multiple people at the same time.
/🆑

* Adds sanity checking to the tippable component

---------

Co-authored-by: GPeckman <21979502+GPeckman@users.noreply.github.com>
2023-10-06 14:44:13 -07:00
SkyratBot
25fb2e098b [MIRROR] Adds error on qdeling callback, fixes errors this causes [MDB IGNORE] (#23271)
* Adds error on qdeling callback, fixes errors this causes (#77850)

## About The Pull Request

You shouldn't ever qdel a callback. If you don't want to own it free
your ref (remove it from a list/set it to null). When all refs are
cleared it'll get cleaned up by byond itself

* Adds error on qdeling callback, fixes errors this causes

* Update cell_component.dm

* Update acid.dm

---------

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: Giz <13398309+vinylspiders@users.noreply.github.com>
2023-08-23 04:43:34 -04:00
SkyratBot
7415526265 [MIRROR] You can tip flashed borgs [MDB IGNORE] (#21339)
* You can tip flashed borgs (#75539)

## About The Pull Request

Fixes tippable not working on flashed mobs by letting it work on those
who are forced standing even if they aren't conscious, then gives that
trait to borgs.
I thought this would be the best fix for it because borgs technically
are just forced standing anyways, and I didn't want to just add an
issilicon check.

## Why It's Good For The Game

Fixes an old bug that I should've fixed a long time ago, makes tipping
something that can realistically happen in-game.

## Changelog

🆑
fix: Borgs can be tipped over while flashed.
/🆑

* You can tip flashed borgs

---------

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2023-05-21 22:49:08 -07:00
Zonespace
f7c26bbf25 515 Compat (#17465)
* ONLY SKYRAT CHANGES

* ACTUALLY SKYRAT CHANGES

* yolo, revert later

* Update alternate_byond_versions.txt

Co-authored-by: AnturK <AnturK@users.noreply.github.com>
2022-11-15 06:59:06 +00:00
SkyratBot
6016cf97b4 [MIRROR] individual LOG_GAME [MDB IGNORE] (#15401)
* individual LOG_GAME

* e

* Update teleporter.dm

Co-authored-by: Mooshimi <85910816+Mooshimi@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-08-08 01:11:55 +01:00
SkyratBot
96f52e3a83 [MIRROR] Adds logging for when you fail to tip something over [MDB IGNORE] (#15219)
* Adds logging for when you fail to tip something over (#68712)

* adds failed tip logging

* Adds logging for when you fail to tip something over

Co-authored-by: Coffee <CoffeeDragon16@gmail.com>
2022-07-30 08:23:31 -07:00
SkyratBot
06fb73a84f [MIRROR] Adds documentation the tippable component [MDB IGNORE] (#10916)
* Adds documentation the tippable component (#64312)

I forgot to add this in my PR.. sorry :)

* Adds documentation the tippable component

Co-authored-by: Seth Scherer <supernovaa41@gmx.com>
2022-01-23 01:56:23 -05:00
SkyratBot
417f544543 [MIRROR] Allows cyborgs to quicken their self untip time with roleplay [MDB IGNORE] (#10887)
* Allows cyborgs to quicken their self untip time with roleplay (#64228)

(halves their untip timer when they emote, only works once)

* Allows cyborgs to quicken their self untip time with roleplay

* E

Co-authored-by: Seth Scherer <supernovaa41@gmx.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-01-22 05:04:08 +00:00
SkyratBot
0cc6e5367c [MIRROR] Adds logging to the tippable component [MDB IGNORE] (#10855)
* Adds logging to the tippable component (#64210)

* Adds logging to the tippable component
Headmin wanted it. Logs the tippable component if the tippable mob has
an active client (we don't want to log medbot flipping).

* better logging

* Adds logging to the tippable component

Co-authored-by: Seth Scherer <supernovaa41@gmx.com>
2022-01-21 00:57:10 +00:00
SkyratBot
daa38fcf62 [MIRROR] Deletes the tippable's untip timer if someone untips you ahead of time [MDB IGNORE] (#10788)
* Deletes the tippable's untip timer if someone untips you ahead of time (#64168)

* Deletes the tippable's untip timer if someone untips you ahead of time

* Deletes the tippable's untip timer if someone untips you ahead of time

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2022-01-17 23:58:42 +00:00
SkyratBot
a41461c029 [MIRROR] Makes tipping borgs use SECONDARY attack cancel chain [MDB IGNORE] (#10786)
* Makes tipping borgs use SECONDARY attack cancel chain (#64165)

* Tippable returns SECONDARY attack cancel chain

* adds an after_righted proc for silicons to help with downstreams

* Makes tipping borgs use SECONDARY attack cancel chain

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2022-01-17 23:56:00 +00:00
SkyratBot
1856360aca [MIRROR] You can now tip borgs over [MDB IGNORE] (#10740)
* You can now tip borgs over (#64097)

I hate Silicon

Teaches Silicon that they should still live within the Crew rather than above them, otherwise people will tip you over and no one would want to help tip you back up.

The timers also, for the most part, match handcuff timers, so there's already a human counterpart of this. Even if it wasn't intentional.
Changelog

cl JohnFulpWillard and theOOZ
qol: Tipping mobs over all runs on right click, rather than running on both right and left click.
balance: You can now tip Borgs over.
/cl

* You can now tip borgs over

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2022-01-16 22:47:49 +00:00
SkyratBot
dc4877bd74 [MIRROR] Converts tippable behavior from cows and medibots to a component (tip over anything with adminbus) (#6468)
* Converts tippable behavior from cows and medibots to a component (tip over anything with adminbus) (#59705)

This PR converts cow-tipping and medibot-tipping into a component, /datum/component/tippable. Cows and medibots now use the tippable component to control their tipping behaviors.

This PR also goes through a few atom_attack_hand signals and makes them all send the same arguments.

* Converts tippable behavior from cows and medibots to a component (tip over anything with adminbus)

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
2021-06-23 18:59:45 +01:00