* Fixes forensics hard del (#81880)
## About The Pull Request
Should fix this CI error.
`parent` used to be a weakref but since it's not any longer (as of
#81751) we need to manage the ref more carefully.
The forensic datum should be getting `QDEL_NULL`'d in `atom/Destroy()`
but I think what was likely happening was somehow, something was adding
a forensics datum again after the atom was qdeleted. This should
hopefully prevent that from happening.
## Why It's Good For The Game
Less CI errors
## Changelog
Nothing player facing
* Fixes forensics hard del
---------
Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com>
* Removes weakref in forensics datum (#81751)
## About The Pull Request
This doesn't need to use weakrefs, it's a fairly easy to manage
relationship, when the atom goes the forensics goes
* Removes weakref in forensics datum
---------
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: Pinta <68373373+softcerv@users.noreply.github.com>
* Fixes CI runtime/race condition with forensics (#81610)
## About The Pull Request
Just a quick fix for the following CI runtime, and additionally passes
through the rest of this file's weakref instances for any other
potential bugs.
## Why It's Good For The Game
Bugfix
## Changelog
Nothing player facing
---------
Co-authored-by: san7890 <the@ san7890.com>
* Fixes CI runtime/race condition with forensics
---------
Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com>
Co-authored-by: san7890 <the@ san7890.com>
* Half fixes organ blood dna not updating (#81584)
## About The Pull Request
Organs have this mechanic where they store the first mob who owned it's
DNA
Anyways it was broken from the organ nullspace refactor because they
intended a block of code that shouldn't have been indented
But this only *half* fixes the issue, you see a problem here?
Yeah there's an order of operation thing going on here because you get
your organs before you get your species bloodtype
This only affects species with weird blood types (like lizards)
I'm not fixing it in this PR because it was certainly broken before and
needs a bit more unwinding somewhere
## Changelog
🆑 Melbert
fix: Organs have the blood DNA of their owns on them again
/🆑
* Half fixes organ blood dna not updating
---------
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
* Fixes a bad istype src in forensics code (#72296)
## About The Pull Request
`src` is a forensics datum, it'll never be an item
## Why It's Good For The Game
Code works as expected
## Changelog
🆑 Melbert
fix: Did you know items have a 1.2x chance of getting fibers attached?
Well it's been broken, now it's fixed
/🆑
Co-authored-by: Fikou <23585223+Fikou@ users.noreply.github.com>
* Fixes a bad istype src in forensics code
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: Fikou <23585223+Fikou@ users.noreply.github.com>
* Legitimizes BOMBGERs. Add grenades to burgers and assistants will still eat it. (#71552)
## About The Pull Request
Here's the changes to custom food:
- Can now accept grenades
- If you add something larger than the custom food, the custom food
becomes that size
- Biting down on food with grenades in them triggers the grenades
## Why It's Good For The Game
We're trying so hard to remove getting around this whole bombger thing
but wait it's actually based as hell. Why don't we just cut the fat of
what doesn't work (getting around sanity checks with deep frying) and
legitimize what does?
## Changelog
🆑
add: You can add grenades to food
add: Grenades explode when accidentally bitten into
balance: Adding something large to custom food will make it, too, also
large
/🆑
* Legitimizes BOMBGERs. Add grenades to burgers and assistants will still eat it.
Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
* Refactors the forensics component into a datum
* Refactors the forensics component into a datum
* Refactors the forensics component into a datum
Co-authored-by: Seth Scherer <supernovaa41@gmx.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
