Commit Graph

106 Commits

Author SHA1 Message Date
Kyle Spier-Swenson
6d293d078b Webhook: Prevent connection errors to game servers from blocking discord announces (#87179)
Just a guess, but i think basil being down is why this isn't working.
2024-11-16 00:42:14 -08:00
Waterpig
bb70889f6e TG Upstream Part 1
3591 individual conflicts

Update build.js

Update install_node.sh

Update byond.js

oh my fucking god

hat

slow

huh

holy shit

we all fall down

2 more I missed

2900 individual conflicts

2700 Individual conflicts

replaces yarn file with tg version, bumping us down to 2200-ish

Down to 2000 individual conflicts

140 down

mmm

aaaaaaaaaaaaaaaaaaa

not yt

575

soon

900 individual conflicts

600 individual conflicts, 121 file conflicts

im not okay

160 across 19 files

29 in 4 files

0 conflicts, compiletime fix time

some minor incap stuff

missed ticks

weird dupe definition stuff

missed ticks 2

incap fixes

undefs and pie fix

Radio update and some extra minor stuff

returns a single override

no more dupe definitions, 175 compiletime errors

Unticked file fix

sound and emote stuff

honk and more radio stuff
2024-10-19 08:04:33 -07:00
Waterpig
4c4930c71d Merge branch 'master' of https://github.com/tgstation/tgstation into pulls-tg-to-fix-shit 2024-09-08 00:59:39 +02:00
SkyratBot
5cc91a9b23 [MIRROR] Fix in game pr announce. (#29668)
Fix in game pr announce. (#86505)

This php file will auto-update once this pr is merged.

Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
2024-09-08 01:10:02 +07:00
Kyle Spier-Swenson
452c2b3d12 Fix in game pr announce. (#86505)
This php file will auto-update once this pr is merged.
2024-09-07 00:21:49 +00:00
SkyratBot
6c4c965ea4 [MIRROR] Changes occurrences of recieve in code to receive [MDB IGNORE] (#25393)
* Changes occurrences of `recieve` in code to `receive`

* Fix conflict

---------

Co-authored-by: distributivgesetz <distributivgesetz93@gmail.com>
Co-authored-by: SomeRandomOwl <somerandomowl@ratchtnet.com>
2023-12-02 20:40:07 -06:00
distributivgesetz
f8b41f9442 Changes occurrences of recieve in code to receive (#80065)
## About The Pull Request

I've stumbled across this enough to finally go through the entire
codebase and fix it. I left out changelogs simply because rewriting
history logs is bad.
## Why It's Good For The Game

I find it pretty annoying because I stumble across words that are
misspelled for a few seconds, and I'm likely not the only one who feels
like this. Less spelling mistakes in code are better.
## Changelog
🆑
spellcheck: Occurrences of "recieve" has been changed to "receive".
/🆑
2023-12-02 14:50:57 -07:00
SkyratBot
b46e9e7d4f [MIRROR] Clear out some random errors in github webhook processor [MDB IGNORE] (#22027)
* Clear out some random errors in github webhook processor (#76232)

subrequests failing randomly was triggering invalid key errors later on
down the line needlessly.

* Clear out some random errors in github webhook processor

---------

Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
2023-07-01 16:19:07 -04:00
Kyle Spier-Swenson
0772ff423f Clear out some random errors in github webhook processor (#76232)
subrequests failing randomly was triggering invalid key errors later on
down the line needlessly.
2023-06-23 20:13:02 -06:00
SkyratBot
7a0cacdaf2 [MIRROR] Fix Pull Request Auto-Tagging [MDB IGNORE] (#21798)
* Fix Pull Request Auto-Tagging

* restore file to tg default

* oops

---------

Co-authored-by: Jordan Dominion <Cyberboss@users.noreply.github.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
2023-06-18 14:06:49 +00:00
SkyratBot
95c477f49d [MIRROR] Add whitelist to webhook processor PR tagging [MDB IGNORE] (#21749)
* Add whitelist to webhook processor PR tagging (#75943)

I hate this script. Actions my beloved...

This is to get it away from my beautiful tgstation-server garden.

Fixes https://github.com/tgstation/tgstation-server/issues/1520

* Add whitelist to webhook processor PR tagging

---------

Co-authored-by: Jordan Dominion <Cyberboss@users.noreply.github.com>
2023-06-15 15:06:34 +01:00
Jordan Dominion
98ebf92689 Fix Pull Request Auto-Tagging (#76010)
I hate this dead language
2023-06-12 13:06:49 -05:00
Jordan Dominion
dafb6eefcc Add whitelist to webhook processor PR tagging (#75943)
I hate this script. Actions my beloved...

This is to get it away from my beautiful tgstation-server garden.

Fixes https://github.com/tgstation/tgstation-server/issues/1520
2023-06-10 10:51:00 -07:00
SkyratBot
3bffb503f0 [MIRROR] Combined soundadd/sounddel and imageadd/imagedel [MDB IGNORE] (#20685)
* Combined soundadd/sounddel and imageadd/imagedel (#74865)

## About The Pull Request
Combines
```
soundadd: added a new sound thingy
sounddel: removed an old sound thingy
```
into "sound," and
```
imageadd: added some icons and images
imagedel: deleted some icons and images
```
into "image" in the changelog.

I don't think we need to have both; `sound` and `image` can represent
any kind of change to their respective medium.

---------

Co-authored-by: tattle <article.disaster@ gmail.com>

* Combined soundadd/sounddel and imageadd/imagedel

---------

Co-authored-by: tattle <66640614+dragomagol@users.noreply.github.com>
Co-authored-by: tattle <article.disaster@ gmail.com>
2023-04-21 16:43:04 -04:00
tattle
aeed75d72f Combined soundadd/sounddel and imageadd/imagedel (#74865)
## About The Pull Request
Combines
```
soundadd: added a new sound thingy
sounddel: removed an old sound thingy
```
into "sound," and
```
imageadd: added some icons and images
imagedel: deleted some icons and images
```
into "image" in the changelog. 

I don't think we need to have both; `sound` and `image` can represent
any kind of change to their respective medium.

---------

Co-authored-by: tattle <article.disaster@gmail.com>
2023-04-21 13:10:26 -06:00
SkyratBot
4539dfe50d [MIRROR] April fools PRs can now be marked with [april fools] to automatically tag them as april fools PRs. [MDB IGNORE] (#20218)
* April fools PRs can now be marked with [april fools] to automatically tag them as april fools PRs. (#74401)

## About The Pull Request

Really minor change that should make the April fools PR experience
better for PR creators/maints. Not sure if this has any notable
performance implications with the git bot going over its normal stuff,
if it does close this since this is pretty minor.

## Why It's Good For The Game

Its not, anything that encourages april fools PRs makes the game so much
worse.

* April fools PRs can now be marked with [april fools] to automatically tag them as april fools PRs.

---------

Co-authored-by: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>
2023-03-31 15:41:39 -07:00
NamelessFairy
bdd4978d00 April fools PRs can now be marked with [april fools] to automatically tag them as april fools PRs. (#74401)
## About The Pull Request

Really minor change that should make the April fools PR experience
better for PR creators/maints. Not sure if this has any notable
performance implications with the git bot going over its normal stuff,
if it does close this since this is pretty minor.

## Why It's Good For The Game

Its not, anything that encourages april fools PRs makes the game so much
worse.
2023-03-31 16:44:11 +00:00
SkyratBot
e399afdef7 [MIRROR] Github hook for adding "Logging" tag to logging PRs [MDB IGNORE] (#17877)
* Github hook for adding "Logging" tag to logging PRs (#71633)

## About The Pull Request
Github hook to add the Logging tag to PRs with "log/logs/logging" in the
title.

## Why It's Good For The Game
Computers doing my dirty work for me

## Changelog
No player-facing changes

Co-authored-by: tattle <article.disaster@ gmail.com>

* Github hook for adding "Logging" tag to logging PRs

Co-authored-by: tattle <66640614+dragomagol@users.noreply.github.com>
Co-authored-by: tattle <article.disaster@ gmail.com>
2022-12-01 20:33:51 -08:00
tattle
bb3e874841 Github hook for adding "Logging" tag to logging PRs (#71633)
## About The Pull Request
Github hook to add the Logging tag to PRs with "log/logs/logging" in the
title.

## Why It's Good For The Game
Computers doing my dirty work for me

## Changelog
No player-facing changes

Co-authored-by: tattle <article.disaster@gmail.com>
2022-12-01 19:40:48 -08:00
SkyratBot
470ea238cb [MIRROR] Fix github not announcing new prs [MDB IGNORE] (#17216)
* Fix github not announcing new prs

* Resets github_webhook_processor.php to upstream version, with our minor modification

* Adds the whole pull_request_hooks folder that we also missed from upstream

Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2022-11-09 17:47:14 +00:00
Kyle Spier-Swenson
dee5f8f58a Fix github not announcing new prs (#70853) 2022-10-28 08:48:32 -04:00
Mothblocks
8bb8ca9d67 Move auto changelog generation into its own workflow (#70652)
I wanted to move auto labeling into its own workflow, but realized that it and changelog generation were coupled. So I'm detaching that first, and then will work on auto labeling later. Includes general code for a changelog parser so that I can reuse it by that point.

GitHub actions are great for downstreams, as setting up a PHP server for the webhook is not trivial, compared to Existing and getting it for free. They are also much more straightforward to test and update than the webhook. I was able to verify this was working trivially with an empty repository.

Tested and working: Mothblocks/ss13-workflow-testing@0a2de4d
2022-10-27 16:52:32 +13:00
SkyratBot
f6725c2373 [MIRROR] [webhook] treat github api errors when validating users better. [MDB IGNORE] (#16625)
* [webhook] treat github api errors when validating users better. (#70219)

Proper fix is to make apisend handle retrying but i can't pr that from in bed when i remember i forgot to look into this so here we are

* [webhook] treat github api errors when validating users better.

Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
2022-10-04 09:46:19 -04:00
Kyle Spier-Swenson
23a58ba321 [webhook] treat github api errors when validating users better. (#70219)
Proper fix is to make apisend handle retrying but i can't pr that from in bed when i remember i forgot to look into this so here we are
2022-10-03 23:16:06 -04:00
SkyratBot
2da0e28b04 [MIRROR] Renamed Balance/Rebalance to Balance, and removes unused rebalance tag [MDB IGNORE] (#15103)
* Renamed Balance/Rebalance to Balance, and removes unused rebalance tag (#68485)

* Renamed Balance/Rebalance to Balance, and removes unused rebalance tag

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2022-07-22 13:09:00 -04:00
Mothblocks
e26d76a479 Renamed Balance/Rebalance to Balance, and removes unused rebalance tag (#68485) 2022-07-21 19:47:37 -04:00
SkyratBot
7f53578900 removes the Content Expansion tag, replaces Mechanic with Feature, and lowers its gbp cost from 10 to 6 (#13056)
Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
2022-04-24 19:13:12 +01:00
Kylerace
93f39af8ac removes the Content Expansion tag, replaces Mechanic with Feature, and lowers its gbp cost from 10 to 6 (#66425) 2022-04-24 01:08:39 -07:00
SkyratBot
82dab14169 [MIRROR] Add GBP: No Update label when PR title includes [no gbp] [MDB IGNORE] (#12403)
* add GBP: No Update label when title includes [no gbp] (#65739)

Co-authored-by: tattle <article.disaster@ gmail.com>

* Add GBP: No Update label when PR title includes [no gbp]

Co-authored-by: dragomagol <66640614+dragomagol@users.noreply.github.com>
Co-authored-by: tattle <article.disaster@ gmail.com>
2022-03-30 22:23:31 -07:00
dragomagol
b6f021195d add GBP: No Update label when title includes [no gbp] (#65739)
Co-authored-by: tattle <article.disaster@gmail.com>
2022-03-30 20:07:19 -07:00
jjpark-kb
eb8af98ddf auto host request (#11803) 2022-03-05 10:10:26 -05:00
SkyratBot
22fd8eca10 [MIRROR] Fix GitHub webhook [MDB IGNORE] (#9792)
* Fix GitHub webhook (#63182)

* Fix GitHub webhook

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2021-11-30 21:42:39 -05:00
SkyratBot
20bdfe4f97 [MIRROR] Limit repository announcements to a whitelist, Discord announces to a blacklist [MDB IGNORE] (#9791)
* Limit repository announcements to a whitelist, Discord announces to a blacklist (#63179)

About The Pull Request

Limits the game announcers only to arrays in a fixed whitelist.

Discord announcements, as they're more for those interested in the technical side, are on a blacklist of patterns. This is set to blacklist anything starting with event-*.

This stops a lot of internal repos from clogging chat, but more importantly is going to be used as events will now be hosted on the tgstation organization, and we want to limit spoilers/confusion on that for people who don't go looking for it.

* Limit repository announcements to a whitelist, Discord announces to a blacklist

* Update tools/WebhookProcessor/github_webhook_processor.php

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2021-11-30 21:42:29 -05:00
Mothblocks
b8a42f1393 Fix GitHub webhook (#63182) 2021-12-01 14:59:30 +13:00
Mothblocks
6ca3dac322 Limit repository announcements to a whitelist, Discord announces to a blacklist (#63179)
About The Pull Request

Limits the game announcers only to arrays in a fixed whitelist.

Discord announcements, as they're more for those interested in the technical side, are on a blacklist of patterns. This is set to blacklist anything starting with event-*.

This stops a lot of internal repos from clogging chat, but more importantly is going to be used as events will now be hosted on the tgstation organization, and we want to limit spoilers/confusion on that for people who don't go looking for it.
2021-12-01 14:53:48 +13:00
SkyratBot
9c738967a1 [MIRROR] Fixes an issue with changelog generation where the default lines would be included in the logs (#7465)
* Fixes an issue with changelog generation where the default lines would be included in the logs (#60736)

* In theory this should fix a bug MSO had in coderbus

* Apparently I am a very stupid cat

* Fixes an issue with changelog generation where the default lines would be included in the logs

Co-authored-by: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>
2021-08-08 22:05:29 +01:00
NamelessFairy
c17da35970 Fixes an issue with changelog generation where the default lines would be included in the logs (#60736)
* In theory this should fix a bug MSO had in coderbus

* Apparently I am a very stupid cat
2021-08-08 12:05:13 -07:00
SkyratBot
0b66913bec Adds content expansion PR type (#6277)
Co-authored-by: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>
2021-06-13 02:47:31 +01:00
NamelessFairy
3d9180c33f Adds content expansion PR type (#59152)
* Adds content and "jobtent" PR tags

* Adds Semicolons

* Changes temporary GBP value for jobtent to -2

* Renames content to expansion

* Updates PR to follow ninjanomnom's guidelines
2021-06-12 14:11:48 -04:00
Gandalf
c437a34fe0 TGUI hardset (#5252)
* FFFF

* AAA

* FUCK WE MISSED THIS PR

* Update interface.dm
2021-04-27 17:13:22 +01:00
Celotajs
76fb2e1712 Convert changelog to TGUI (#58593)
This pull request converts the changelog to TGUI. 
Note: Old unused changelog files will be automatically removed on the next changelog run
Why It's Good For The Game

More consistent UI, ability to view all historic logs.
Changelog

cl Celotajs
refactor: Converted the changelog popup to TGUI
/cl
2021-04-27 08:41:56 +12:00
SkyratBot
3038bfcbc7 [MIRROR] Remove the PR balances part of the webhook (in favor of the action) (#3772)
* Remove the PR balances part of the webhook (#57299)

The action has been working fine, and every bug its had has been solved not with disabling it, but with me resolving it. There's no reason to keep around the old system anymore. Viva la actions.

* Remove the PR balances part of the webhook (in favor of the action)

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2021-03-03 01:59:49 +00:00
Mothblocks
99075269ff Remove the PR balances part of the webhook (#57299)
The action has been working fine, and every bug its had has been solved not with disabling it, but with me resolving it. There's no reason to keep around the old system anymore. Viva la actions.
2021-03-02 18:21:07 -05:00
SkyratBot
d2221bc210 [MIRROR] Removes tweak and replaces it with a tag for QoL and Atomic prs (#3374)
* Removes tweak and replaces it with a tag for QoL and Atomic prs (#56890)

* Removes tweak and replaces it with a tag for QoL and Atomic prs

Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com>
2021-02-14 03:40:19 +00:00
Emmett Gaines
c97a360b23 Removes tweak and replaces it with a tag for QoL and Atomic prs (#56890) 2021-02-13 18:45:10 -08:00
SkyratBot
cd2cf79c55 [MIRROR] Skip first whitespace only lines in changelog PR parser (#3051)
* Skip first whitespace only lines (#56534)

Parser won't crash on first empty lines anymore.

* Skip first whitespace only lines in changelog PR parser

Co-authored-by: AnturK <AnturK@users.noreply.github.com>
2021-02-03 22:32:56 +00:00
AnturK
7eeba95ff2 Skip first whitespace only lines (#56534)
Parser won't crash on first empty lines anymore.
2021-02-03 17:21:39 -05:00
SkyratBot
f8f8c9e393 [MIRROR] Use draft pull requests instead of the 'Work In Progress' and 'Needs Review' labels. (#2728)
* Use draft pull requests instead of the 'Work In Progress' and 'Needs Review' labels. (#56168)

* Use draft pull requests instead of the 'Work In Progress' and 'Needs Review' labels.

Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
2021-01-17 13:06:05 +01:00
Jordan Brown
96d5f6a85e Use draft pull requests instead of the 'Work In Progress' and 'Needs Review' labels. (#56168) 2021-01-15 16:06:52 -08:00
SkyratBot
600e8ba592 [MIRROR] You now get 1 GBP for sound and sprite PRs (#2361)
* You now get 1 GBP for sound and sprite PRs (#55611)

* You now get 1 GBP for sound and sprite PRs

Co-authored-by: Qustinnus <Floydje123@hotmail.com>
2020-12-29 02:39:16 +00:00