Commit Graph

8 Commits

Author SHA1 Message Date
Majkl-J
e59d8ba64b Merge commit '179a607a90ad7ec62bdaff4e6fe72af60ee56442' of https://github.com/tgstation/tgstation into upstream-24-10b 2024-10-23 23:27:16 -07:00
Bloop
23df383e7a Fixes autochangelog just dying if fed an invalid changelog entry (#86670)
## About The Pull Request

Something that really has annoyed me for a while, if a user puts
something invalid in their changelog body like:
`tweak: something something` (a common one I encounter)

then this results in the autochangelog script crashing and not creating
a changelog at all. So many changelogs get dumpstered because of this
and it is stupid.

This PR changes it so the changelog parser is able to continue past the
invalid lines and complete the action.

It would be nice to have the ci bot comment on the user's pr if it
detects bad input to inform them of it but that's beyond what I have the
time and skills for right now.

This was tested downstream and confirmed to work.

## Why It's Good For The Game

<details><summary>Less changelogs getting lost to the void.</summary>


![image](https://github.com/user-attachments/assets/a82e746f-d6ea-4234-af79-e432be5d21af)

</details>

## Changelog

Nothing player-facing
2024-09-16 09:15:42 -04:00
Waterpig
07e790a87f Merge branch 'master' of https://github.com/Skyrat-SS13/Skyrat-tg into upstream-2405b 2024-05-13 17:42:53 +02:00
SkyratBot
bb5f7de817 [MIRROR] fixes autochangelog erroring on an empty pr body https://github.com/tgstation/tgstation/actions/runs/8977813552/job/24657813451 the changelog workflow errors when theres nothing in the pr body, which causes a useless notification. now it should be fixed (#27629)
* fixes autochangelog erroring on an empty pr body https://github.com/tgstation/tgstation/actions/runs/8977813552/job/24657813451 the changelog workflow errors when theres nothing in the pr body, which causes a useless notification. now it should be fixed (#83122)

* fixes autochangelog erroring on an empty pr body https://github.com/tgstation/tgstation/actions/runs/8977813552/job/24657813451 the changelog workflow errors when theres nothing in the pr body, which causes a useless notification. now it should be fixed

---------

Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
2024-05-08 20:58:36 +02:00
Kylerace
135bf597a1 fixes autochangelog erroring on an empty pr body https://github.com/tgstation/tgstation/actions/runs/8977813552/job/24657813451 the changelog workflow errors when theres nothing in the pr body, which causes a useless notification. now it should be fixed (#83122) 2024-05-07 17:35:26 -04:00
Cyprex
7544bc8c1e Update changelogParser.js (#747)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->

## Why It's Good For The Game

<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑
add: Added new mechanics or gameplay changes
add: Added more things
del: Removed old things
qol: made something easier to use
balance: rebalanced something
fix: fixed a few things
sound: added/modified/removed audio or sound effects
image: added/modified/removed some icons or images
spellcheck: fixed a few typos
code: changed some code
refactor: refactored some code
config: changed some config setting
admin: messed with admin stuff
server: something server ops should know
code: One of probably many tests to try and fix the changelog bot
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->
2023-11-21 19:06:15 +01:00
SkyratBot
470ea238cb [MIRROR] Fix github not announcing new prs [MDB IGNORE] (#17216)
* Fix github not announcing new prs

* Resets github_webhook_processor.php to upstream version, with our minor modification

* Adds the whole pull_request_hooks folder that we also missed from upstream

Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2022-11-09 17:47:14 +00:00
Mothblocks
8bb8ca9d67 Move auto changelog generation into its own workflow (#70652)
I wanted to move auto labeling into its own workflow, but realized that it and changelog generation were coupled. So I'm detaching that first, and then will work on auto labeling later. Includes general code for a changelog parser so that I can reuse it by that point.

GitHub actions are great for downstreams, as setting up a PHP server for the webhook is not trivial, compared to Existing and getting it for free. They are also much more straightforward to test and update than the webhook. I was able to verify this was working trivially with an empty repository.

Tested and working: Mothblocks/ss13-workflow-testing@0a2de4d
2022-10-27 16:52:32 +13:00