Commit Graph

3 Commits

Author SHA1 Message Date
SkyratBot
1787cc4d69 [MIRROR] Updates the Mafia UI [MDB IGNORE] (#25214)
* Updates the Mafia UI (#79856)

## About The Pull Request

The player currently on the stand has a yellow color behind their name.
Players who have had their roles revealed now has that stated in the
player list
Votes no longer show up to people who are on trial

![image](https://github.com/tgstation/tgstation/assets/53777086/7b3b6128-4aa0-4a83-b7f6-54c9e9cde4d9)

Minor edit: It no longer says 'ON STAND', it instead has their name in
yellow background

![image](https://github.com/tgstation/tgstation/assets/53777086/d149a881-04ab-4a75-91e1-1e5f53dd1c7f)

## Why It's Good For The Game

Mafia UI's a little better now.

## Changelog

🆑
qol: Mafia panel no longer shows vote buttons if you're on stand, shows
the roles of revealed players, and list out who is on the stand, if any.
/🆑

---------

Co-authored-by: Jeremiah <42397676+jlsnow301@ users.noreply.github.com>

* Updates the Mafia UI

---------

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Jeremiah <42397676+jlsnow301@ users.noreply.github.com>
2023-11-23 15:53:37 -05:00
SkyratBot
dc37aa5825 [MIRROR] Mafia panel fixes [MDB IGNORE] (#24935)
* Mafia panel fixes (#79573)

* Mafia panel fixes

---------

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2023-11-12 11:26:32 -05:00
SkyratBot
f48008411c [MIRROR] Mafia now starts without admin intervention [MDB IGNORE] (#24793)
* Mafia now starts without admin intervention (#79348)

## About The Pull Request

Mafia should now start without the need of admin intervention.
I made a unit test that should always have a PDA and a ghost spawning in
a game of Mafia and having it run through basic setup to confirm they
both successfully sign up and the game starts.

I had to change a lot of things in order to get this working, such as
giving unique ckeys to mock clients, fixing harddels in Mafia, and
plenty of minor fixes. This is the first time any of this code is put in
CI, so a lot of uncaught errors are now showing their faces.

Because loading maps mid-round runtimes due to smoothing, I have mafia
their own unit test-only map that doesn't use smoothing.

I also split the mafia ui code into its own file, and moved a single
helper that was sitting around in mafia's file into a helpers file.

I also added some comments to explain why certain things are the way
they are, because I wrote some undocumented code previously and forgot a
few things, leading to self-inflicted wasted time.

## Why It's Good For The Game

^

## Changelog

🆑
fix: Mafia games can now start properly.
/🆑

---------

Co-authored-by: Ghom <42542238+Ghommie@ users.noreply.github.com>

* Mafia now starts without admin intervention

---------

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Ghom <42542238+Ghommie@ users.noreply.github.com>
2023-11-04 23:56:03 -04:00