* Fixes duffelbag curse and curse of hunger code in general (#60290)
Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
* Fixes duffelbag curse and curse of hunger code in general.
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
* rebalance fuel, moderators and cooling (#60246)
Fuel have a max amount before the machine start taking more damage (10k moles, it gains 1 damage every 1000 moles exceeding 10k. this damage overseed the capped one)
Moderators have the same treatment, but instead of adding damage, they'll crack open the machine releasing gases (depends on the pressure achieved) there is a small explosion or a big one.
Cooling volume has been added, that way the cooling can be made stronger or weaker based on the current situation and need
added downsides to shoving too much fuel/moderator inside the machine, the cooling volume can be adjusted in the GUI to make it stronger/weaker based on the user needs
* HFR rebalance fuel, moderators and cooling
Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com>
* Wizard gets bonus points if they go random. (#60288)
Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
* Wizard gets bonus points if they go random.
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
* fixes ghosts not being included in get_hearers_in_view(), AGAIN! (#60297)
thanks to shaps for reporting this
turns out mob/dead/Initialize() doesnt call parent, and mobs are made hearing sensitive in mob/Initialize(), so ghosts yet again werent included in get_hearers_in_view(). now they are!
now actually tested this time by attacking pun pun then ghosting, on master the red attack text doesnt show for ghosts in view but now it does
with the first pr the issue was because when target was a mob, view() only includes what the mob can see, so i made it always use a turf like it was previously. but the refactor done in the same pr meant that ghosts didnt become hearing sensitive so whoops
* fixes ghosts not being included in get_hearers_in_view(), again!
Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
* Fixes light explosions having 0 chance to delimb someone if they have no bomb resist (#60261)
Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
* Fixes light explosions having 0 chance to delimb someone if they have no bomb resist
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
* Fixes charlie station supermatter fluff paper and makes it's code not terrible (#60176)
Yes apparently you can code fluff paper badly. Whoever updated it to the supermatter version did the update in the map file for some reason. Fixes#60171.
A Charlie station fluff paper about the Supermatter is no longer misnamed "singularity generator". THERE WAS NEVER SUCH A THING AS A SINGULARITY GENERATOR. OCEANIA HAD ALWAYS BEEN AT WAR WITH EASTASIA.
* Fixes charlie station supermatter fluff paper and makes it's code not terrible
Co-authored-by: interestingusernam3 <51925758+interestingusernam3@users.noreply.github.com>
* Circuit submodules (#60109)
Adds the module component that is basically a subroutine. Allows you to compact your logic into a bunch of functions.
* Circuit submodules
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
* Only blend areas when it's actually needed (#60237)
* Only blend areas when it's actually needed
* Respect varedits
* Only blend areas when it's actually needed
Co-authored-by: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
* Improves item's action button updating code (#60149)
This PR improves item action button updating code by introducing a proc to update all item's associated action buttons, which simplifies the process and reduces code duplication.
I also fixed a relevant bug where a PDA's action button icon did not properly update upon light toggle because it did not force the button update. Forcing the button update is needed in this case due to how light overlay operates, where the button icon state stays the same, so the code thought updating the action button icon was unnecessary.
* Improves item's action button updating code
* Mirror!
Co-authored-by: Arkatos1 <43862960+Arkatos1@users.noreply.github.com>
Co-authored-by: Funce <funce.973@gmail.com>
* Replace a number of New() overrides with Initialize() (#60223)
* Replace a number of New() overrides with Initialize()
Co-authored-by: coiax <yellowbounder@gmail.com>
* Rework hot sprint double dipping prevention to be trait based (#60213)
Instead of having a global list of minds that have used the hot spring,
we use a trait on the mind datum instead.
* Rework hot sprint double dipping prevention to be trait based
Co-authored-by: coiax <yellowbounder@gmail.com>
* fixes hyperspace connect_loc_behalf bug (#60231)
turns out my move_stacks var doesnt work asynchronously since this bug made things with connect_loc_behalf runtime on every movement unless you somehow moved it back to the transit turf and off without it doing the runtime special.
(The sleep and hell the whole bit of code in space/Entered was unneeded, since it just happens normally as a part of move. Life is pain) -Lemon
also does misc code improvements i found while investigating ANOTHER c_l_b bug with stacks i found while testing this one, which i did NOT manage to fix unfortunately
* fixes hyperspace connect_loc_behalf bug
Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
* gravity filter now gets removed if gravity is normal (#60220)
* gravity filter now gets removed if gravity is normal
Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
* adds a suicide for space helmets, fixes some other suicides (#60173)
* adds a suicide for space helmets, fixes some other suicides
Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>
* Gives Revenant the ability to orbit adjacent things with secondary attack (#60200)
Leverages right click to give Revenant something I felt it should have had when first implemented, but I can understand now it's not a low effort undertaking with the snowflakeness of incorporeal jaunt code that only runs on Move() 🤮
I put a lot of care into making sure this won't break or bypass jaunting counters like holy water and salt.
* Gives Revenant the ability to orbit adjacent things with secondary attack
Co-authored-by: Wayland-Smithy <64715958+Wayland-Smithy@users.noreply.github.com>
* Corrects the grammar of spectral blade ghost notifications (#60189)
Uses src.name instead of src in the spectral blade's ghost notifications so that you see "his/her/their spectral blade" instead of "his/her/their the spectral blade".
* Corrects the grammar of spectral blade ghost notifications
Co-authored-by: Y0SH1M4S73R <legoboyo@earthlink.net>
* Remove the refresher crystal as a possible lavaland anomalous crystal (#60192)
Removes the "refresher" crystal as a possible lavaland loot item.
This crystal allows people to abuse limited-use items to be used infinitely, and also instantly recharge items such as laser guns.
The other crystals are nowhere near as good as this one.
This crystal makes limited-use items infinite, which goes against the point of a limited-use item.
For example, holoparasite injectors and wands can be recharged by this. Antagonist combos have been done with the fireball wand from lavaland that allow them to wipe the entire station stronger than a wizard ever could.
Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
* Removes the refresher crystal as a possible lavaland anomalous crystal
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
* fixes the rat king's abilities being usable while dead. (#60127)
Fixed the rat king's abilities being usable while dead.
Fixed the rat king's Domain ability being usable on cooldown.
* fixes the rat king's abilities being usable while dead.
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
* OH BOY
* Not even dying harder than possible will save you from being revived.
* weh
* more improvements
* more fixes and improvements
* adds le vendor options
* Adds cortical stacks to cargo
* aaaa
* syndie cortical
* oops
* DELACE MACHINE GOES BRRT
* Are you a believer?
* buffs cortical stack remover on traitors
* Update code/game/objects/items/devices/scanners.dm
Co-authored-by: Tom <tomforde4@gmail.com>
* Update code/modules/mining/machine_vending.dm
Co-authored-by: Tom <tomforde4@gmail.com>
* Update code/game/objects/items/devices/scanners.dm
Co-authored-by: Tom <tomforde4@gmail.com>
* Update code/modules/mob/living/carbon/death.dm
Co-authored-by: Tom <tomforde4@gmail.com>
* Update modular_skyrat/modules/neural-lacing/code/delacer.dm
Co-authored-by: Tom <tomforde4@gmail.com>
* Update modular_skyrat/modules/neural-lacing/code/implanter.dm
Co-authored-by: Tom <tomforde4@gmail.com>
* Update modular_skyrat/modules/neural-lacing/code/stack.dm
Co-authored-by: Tom <tomforde4@gmail.com>
* Update modular_skyrat/modules/neural-lacing/code/stack.dm
Co-authored-by: Tom <tomforde4@gmail.com>
* Update modular_skyrat/modules/neural-lacing/code/stack.dm
Co-authored-by: Tom <tomforde4@gmail.com>
* Update modular_skyrat/modules/neural-lacing/code/stack.dm
Co-authored-by: Tom <tomforde4@gmail.com>
* Update delacer.dm
* aa
* a
* Update stack.dm
* weh
* More featureees
* Believer bundle
* i am deranged
* Update implanter.dm
Co-authored-by: Yawet330 <memeusniceus@gmail.com>
Co-authored-by: Tom <tomforde4@gmail.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
* makes a bunch of lists that use typecacheof() static. doesnt find out why its overtiming at all but what the hell it helps (#60147)
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* makes a bunch of lists that use typecacheof() static. doesnt find out why its overtiming at all but what the hell it helps
Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* The great pumpkin resprite. (featuring new blumpkin hats!) (#59853)
This PR resprites the pumpkin, blumpkin and the carved pumpkin hat.
It also adds a blumpkin variety of the carved pumpkin.
To avoid duplicate code, blumpkins and now children of pumpkins, this means some pumpkin recipes will also accept blumpkins.
* The great pumpkin resprite. (featuring new blumpkin hats!)
Co-authored-by: Krysonism <49783092+Krysonism@users.noreply.github.com>
* Optimizes the slowest Life proc in the game to make it not do 81x as much work as it needs to (#59980)
view(n, obj) is O(n^2). it is a bad idea to make n bigger than it needs to. making it range 9 and then completely throwing away the result if the thing it found is more than 1 range away is exactly doing this.
* Optimizes the slowest Life proc in the game to make it not do 81x as much work as it needs to
Co-authored-by: Putnam3145 <putnam3145@gmail.com>
* Fix honkstaff not being affected by antimagic (#60164)
* Fix honkstaff not being affected by antimagic
* Update special.dm
removes a line that doesnt do anything
* Fix honkstaff not being affected by antimagic
Co-authored-by: 小月猫 <alina.r.starkova@gmail.com>
* Fixes stationary tanks starting out with 5000L instead of 2500L (#60001)
Prior to this, the first stationary tank in a group you placed down would have 5000L, while the second, third, etc. would add 2500L each to make it 7500L and 10000L for two and three tanks respectively.
* Fixes stationary tanks starting out with 5000L instead of 2500L
Co-authored-by: RandomGamer123 <31096837+RandomGamer123@users.noreply.github.com>
* Makes roundstart stationary air tanks actually have a ratio that is breathable and matches normal air (#59965)
See title. Prior to this roundstart stationary air tanks had a ratio of 1:5 between oxygen and nitrogen, ie 16.667% oxygen and 83.333% nitrogen. This fixes that and makes it have 21% oxygen and 79% nitrogen.
* Makes roundstart stationary air tanks actually have a ratio that is breathable and matches normal air
Co-authored-by: RandomGamer123 <31096837+RandomGamer123@users.noreply.github.com>
* Venus human traps and swarmers are now numbered. (#60151)
"This is terrible for logs and ahelps as people can't report the number of the mob, which I'm pretty sure is part of why we number spiders, monkeys, and blobbernauts." - RaveRadbury.
* Venus human traps and swarmers are now numbered.
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
