* Clear out some random errors in github webhook processor (#76232)
subrequests failing randomly was triggering invalid key errors later on
down the line needlessly.
* Clear out some random errors in github webhook processor
---------
Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
* Combined soundadd/sounddel and imageadd/imagedel (#74865)
## About The Pull Request
Combines
```
soundadd: added a new sound thingy
sounddel: removed an old sound thingy
```
into "sound," and
```
imageadd: added some icons and images
imagedel: deleted some icons and images
```
into "image" in the changelog.
I don't think we need to have both; `sound` and `image` can represent
any kind of change to their respective medium.
---------
Co-authored-by: tattle <article.disaster@ gmail.com>
* Combined soundadd/sounddel and imageadd/imagedel
---------
Co-authored-by: tattle <66640614+dragomagol@users.noreply.github.com>
Co-authored-by: tattle <article.disaster@ gmail.com>
* April fools PRs can now be marked with [april fools] to automatically tag them as april fools PRs. (#74401)
## About The Pull Request
Really minor change that should make the April fools PR experience
better for PR creators/maints. Not sure if this has any notable
performance implications with the git bot going over its normal stuff,
if it does close this since this is pretty minor.
## Why It's Good For The Game
Its not, anything that encourages april fools PRs makes the game so much
worse.
* April fools PRs can now be marked with [april fools] to automatically tag them as april fools PRs.
---------
Co-authored-by: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>
* Github hook for adding "Logging" tag to logging PRs (#71633)
## About The Pull Request
Github hook to add the Logging tag to PRs with "log/logs/logging" in the
title.
## Why It's Good For The Game
Computers doing my dirty work for me
## Changelog
No player-facing changes
Co-authored-by: tattle <article.disaster@ gmail.com>
* Github hook for adding "Logging" tag to logging PRs
Co-authored-by: tattle <66640614+dragomagol@users.noreply.github.com>
Co-authored-by: tattle <article.disaster@ gmail.com>
* Fix github not announcing new prs
* Resets github_webhook_processor.php to upstream version, with our minor modification
* Adds the whole pull_request_hooks folder that we also missed from upstream
Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
* [webhook] treat github api errors when validating users better. (#70219)
Proper fix is to make apisend handle retrying but i can't pr that from in bed when i remember i forgot to look into this so here we are
* [webhook] treat github api errors when validating users better.
Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
* Renamed Balance/Rebalance to Balance, and removes unused rebalance tag (#68485)
* Renamed Balance/Rebalance to Balance, and removes unused rebalance tag
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
* add GBP: No Update label when title includes [no gbp] (#65739)
Co-authored-by: tattle <article.disaster@ gmail.com>
* Add GBP: No Update label when PR title includes [no gbp]
Co-authored-by: dragomagol <66640614+dragomagol@users.noreply.github.com>
Co-authored-by: tattle <article.disaster@ gmail.com>
* Limit repository announcements to a whitelist, Discord announces to a blacklist (#63179)
About The Pull Request
Limits the game announcers only to arrays in a fixed whitelist.
Discord announcements, as they're more for those interested in the technical side, are on a blacklist of patterns. This is set to blacklist anything starting with event-*.
This stops a lot of internal repos from clogging chat, but more importantly is going to be used as events will now be hosted on the tgstation organization, and we want to limit spoilers/confusion on that for people who don't go looking for it.
* Limit repository announcements to a whitelist, Discord announces to a blacklist
* Update tools/WebhookProcessor/github_webhook_processor.php
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
* Fixes an issue with changelog generation where the default lines would be included in the logs (#60736)
* In theory this should fix a bug MSO had in coderbus
* Apparently I am a very stupid cat
* Fixes an issue with changelog generation where the default lines would be included in the logs
Co-authored-by: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>
* Remove the PR balances part of the webhook (#57299)
The action has been working fine, and every bug its had has been solved not with disabling it, but with me resolving it. There's no reason to keep around the old system anymore. Viva la actions.
* Remove the PR balances part of the webhook (in favor of the action)
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
* Removes tweak and replaces it with a tag for QoL and Atomic prs (#56890)
* Removes tweak and replaces it with a tag for QoL and Atomic prs
Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com>
* Skip first whitespace only lines (#56534)
Parser won't crash on first empty lines anymore.
* Skip first whitespace only lines in changelog PR parser
Co-authored-by: AnturK <AnturK@users.noreply.github.com>
* Use draft pull requests instead of the 'Work In Progress' and 'Needs Review' labels. (#56168)
* Use draft pull requests instead of the 'Work In Progress' and 'Needs Review' labels.
Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
* Merge pull request #55618 from tgstation/Jared-Fogle-patch-1
Don't auto apply unit tests label
* Don't auto apply unit tests label
Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
* Replace deprecated PHP syntax in webhook processor (#55546)
Line 17 of the Run Linters job of the CI Suite workflow:
> PHP Fatal error: Array and string offset access syntax with curly braces is
> no longer supported in ./tools/WebhookProcessor/github_webhook_processor.php
> on line 972
Something, something the PHP version updated to 7.x and dropped curly brackets support.
* Replaces deprecated access syntax in github_webhook_processor.php
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
* GBP Tweaks (#55441)
Some rescaling since the stakes are 10x higher now:
Fix: +3
Tweak: -2
Performance: +12
Priority: High: +15
Priority: Critical: +20
Feedback: +2
Code Improvement: +2
The intention with the formula tweak is for the highest absolute value of the label set (favoring the negative) to be applied.
* GBP Tweaks
Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
* Working on unit test related issues grants 6 GBP, automatically add tag (#55199)
Unit tests (a label I recently added) will now give 6 GBP. This label should be added to anything that adds a new unit test, even on features.
* Working on unit test related issues grants 6 GBP, automatically add tag
Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
* Nerfs GBP gain (#55038)
Basically no one ever hits the lower limit and people have fucking bank at this point.
* Nerfs GBP gain
Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
* Adds discord webhook support to the github webhook processor.
* Fix odd bug
* Add discordwebhook config to secrets with example urls
* Forgot a semicolon
* Remove debug lines
* Hide html comments inside pr bodies.
* Add a bunch of configs to announcement endpoints
include_repos
exclude_repos
exclude_events
announce_secret
announce_unvalidated
embed
no_text
* Add support for those configs.
* Fix minor bug
* Fix no embed messages not working
* Adds spoiler support to discord_sanitize
By disabling multiline mode, $ becomes the end of the string, so we can match either \Rdiff or $, so that the lazy modifier must match the rest of the string if it can't find \Rdiff
It's not that different from other subsystems to justify the huge extra point cost, and the people who make atmos related changes have attained a great number of points.
Tweak is for small things that shouldn't affect the point balance either way
* Webhook now comments its diff instead of its dump
* Fixes variable access in webhook
* Fixes webhook regex flaw
* Missing semicolon in webhook
well... I don't have much to say to you
this is... i mean... 😀😀😁😁😁😁😂😂😂😂😂😂😂😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭
* Fixes anoher webhook regex issue
* Re-adds content to webhook update
* Encapsulates webhook diff in <details>
