Commit Graph

687 Commits

Author SHA1 Message Date
SkyratBot
7920839dcd [MIRROR] Small player-facing text improvements (2 pill bottles, 1 recycler note) [MDB IGNORE] (#14141)
* Small player-facing text improvements (2 pill bottles, 1 recycler note) (#67452)

Nothing special, honestly - exactly what it sounds like.

Two grammar fixes to pill bottles (missing spaces).
A little grammar tuning on a note I'm pretty sure literally nobody ever reads, at any point, ever.

Just words fixes now but we might as well get them while we're here

* Small player-facing text improvements (2 pill bottles, 1 recycler note)

Co-authored-by: Pandarsenic <101627558+Pandarsenic@users.noreply.github.com>
2022-06-06 22:07:23 +01:00
SkyratBot
1eb891cabb [MIRROR] The Great Species Food Rebalance, Part One: Nutriment, Chemical Recipes, Cargo Orders, Baking Times, Oh My! [MDB IGNORE] (#14100)
* The Great Species Food Rebalance, Part One: Nutriment, Chemical Recipes, Cargo Orders, Baking Times, Oh My! (#67227)

the great rebalance, part one

A comprehensive rebalance of food, including cooking times, nutriment values, crafting recipes, and cargo orders

* The Great Species Food Rebalance, Part One: Nutriment, Chemical Recipes, Cargo Orders, Baking Times, Oh My!

Co-authored-by: EOBGames <58124831+EOBGames@users.noreply.github.com>
2022-06-06 00:04:57 +01:00
SkyratBot
85147efc66 [MIRROR] Head of Personnel Resprite & New HoP Coat [MDB IGNORE] (#13974)
* Head of Personnel Resprite & New HoP Coat (#67286)

add: Brand new HoP coat!
imageadd: New sprites for HoP's uniform, skirt, cap, and the ID Painter.

* Head of Personnel Resprite & New HoP Coat

Co-authored-by: axietheaxolotl <86872535+axietheaxolotl@users.noreply.github.com>
2022-05-28 13:17:09 +01:00
SkyratBot
a92cf8bdc7 [MIRROR] Belts are now Bulky and do not fit in bags. [MDB IGNORE] (#13949)
* Belts are now Bulky and do not fit in bags. (#66927)

* Belts are bulky and therefore do not fit in bags, solely the belt slot.

* Belts are now Bulky and do not fit in bags.

Co-authored-by: Iamgoofball <iamgoofball@gmail.com>
2022-05-27 17:56:59 +01:00
SkyratBot
9aca883902 [MIRROR] Scrubber Clog Random Event Spiritual Successor -- New janitor content! [MDB IGNORE] (#13817)
* Scrubber Clog Random Event Spiritual Successor -- New janitor content! (#67023)

Adds a brand new random event as a spiritual successor to the long-lost scrubber overflow event! Scrubbers (that is, a single one on the station) may now randomly become clogged with mobs, and after an alert, will begin pumping out mobs at a steady rate. The infestation can be fixed by either welding the scrubber shut and waiting for the infestation to clear, or you can use a plunger on the scrubber to clear it manually.

* Scrubber Clog Random Event Spiritual Successor -- New janitor content!

Co-authored-by: Rhials <Datguy33456@gmail.com>
2022-05-22 12:41:07 -07:00
SkyratBot
60f584fad8 [MIRROR] belt.dm lists are in alphabetical order now. [MDB IGNORE] (#13606)
* `belt.dm` lists are in alphabetical order now.

* Update belt.dm

Co-authored-by: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
2022-05-18 19:59:50 +01:00
SkyratBot
af93d350cc [MIRROR] Repaths /obj/item/clothing/mask/animal/rat to make more sense [MDB IGNORE] (#13558)
* Repaths `/obj/item/clothing/mask/animal/rat` to make more sense (#66860)

* Repaths `/obj/item/clothing/mask/animal/rat` to make more sense
It was used as the parent for a lot of other small animal masks simply
because of its flags and a single proc, so i repathed it to
`/obj/item/cltohing/mask/animal/small/...` to make more sense

* adds an updatepaths

* fixes the got damned maps

* Repaths `/obj/item/clothing/mask/animal/rat` to make more sense

* Repaths `/obj/item/clothing/mask/animal/rat` to make more sense

Co-authored-by: Seth Scherer <supernovaa41@gmx.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
2022-05-17 21:25:29 +01:00
SkyratBot
4f50cf7b46 [MIRROR] bags.dm lists are in alphabetical order now. [MDB IGNORE] (#13601)
* `bags.dm` lists are in alphabetical order now. (#66951)

* `bags.dm` lists are in alphabetical order now.

Co-authored-by: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com>
2022-05-15 12:00:19 -07:00
SkyratBot
c0f6eff272 [MIRROR] Advanced tools are medium sized, toolboxes can carry medium sized items. [MDB IGNORE] (#13593)
* Advanced tools are medium sized, toolboxes can carry medium sized items. (#66900)

* Advanced tools are medium sized now.

* Moves `w_class` 1 line down

* Moves `w_class` MORE DOWN

* Syndie Jaw pocket edition.

* Toolboxes can carry medium items, pocket syndie jaw in desc.

* Advanced tools are medium sized, toolboxes can carry medium sized items.

* fix APT

Co-authored-by: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com>
Co-authored-by: John Doe <gamingskeleton3@gmail.com>
2022-05-13 16:10:06 -07:00
SkyratBot
81db26ba94 [MIRROR] [MDB IGNORE] Removes tablet cartridges + reworks a ton more [MDB IGNORE] (#13539)
* [MDB IGNORE] Removes tablet cartridges + reworks a ton more (#66505)

- All tablets who previously had apps in a cartridge now has them built-into their tablet instead. This means it costs space for it.
- Rebalances the sizes of several apps to help them fit on Command tablets (Cargo ordering costed 20!!)
- Removes tablet cartridges, they've been reworked into a regular old portable disk (the same you use for toxins/borgs)
- Removes Signaller (the module required to run the signaller app) from tablets (likely will remove more in the future)
- Refactors the health/chem scanning app to not be as bad
- Dehardcodes detomatix resistance
- Ability to send PDA's to all is now tied to your access rather than a cartridge
- Moves 'eject disk' button to the very top of the UI

* [MDB IGNORE] Removes tablet cartridges + reworks a ton more

* wew

* wew

* ok

* Update nanotrasen_consultant.dm

* Update nanotrasen_consultant.dm

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-05-11 22:40:06 +01:00
SkyratBot
c1a1683db6 [MIRROR] removes permeability, rolling it into bio armor [MDB IGNORE] (#13435)
* removes permeability, rolling it into bio armor

* e

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-05-09 01:16:27 +01:00
SkyratBot
694a0740dc [MIRROR] Parallax but better: Smooth movement cleanup [MDB IGNORE] (#13414)
* Parallax but better: Smooth movement cleanup (#66567)

* Alright, so I'm optimizing parallax code so I can justify making it do a
bit more work

To that end, lets make the checks it does each process event based.
There's two. One is for a difference in view, which is an easy fix since
I added a view setter like a year back now.

The second is something planets do when you change your z level.
This gets more complicated, because we're "owned" by a client.
So the only real pattern we can use to hook into the client's mob's
movement is something like connect_loc_behalf.

So, I've made connect_mob_behalf. Fuck you.

This saves a proc call and some redundant logic

* Fixes random parallax stuttering

Ok so this is kinda a weird one but hear me out.

Parallax has this concept of "direction" that some areas use, mostly
the shuttle transit ones. Set when you move into a new area.
So of course it has a setter. If you pass it a direction that it doesn't
already have, it'll start up the movement animation, and disable normal
parallax for a bit to give it some time to get going.

This var is typically set to 0.

The problem is we were setting /area/space's direction to null in
shuttle movement code, because of a forgotten proc arg.

Null is of course different then 0, so this would trigger a halt in
parallax processing.

This causes a lot of strange stutters in parallax, mostly when you're
moving between nearspace and space. It looks really bad, and I'm a bit
suprised none noticed.

I've fixed it, and added a default arg to the setter to prevent this
class of issue in future. Things look a good bit nicer this way

* Adds animation back to parallax

Ok so like, I know this was removed and "none could tell" and whatever,
and in fairness this animation method is a bit crummy.

What we really want to do is eliminate "halts" and "jumps" in the
parallax moveemnt. So it should be smooth.

As it is on live now, this just isn't what happens, you get jumping
between offsets. Looks frankly, horrible. Especially on the station.

Just what I've done won't be enough however, because what we need to do
is match our parallax scroll speed with our current glide speed. I need
to figure out how to do this well, and I have a feeling it will involve
some system of managing glide sources.

Anyway for now the animation looks really nice for ghosts with default
(high) settings, since they share the same delay.

I've done some refactoring to how old animation code worked pre (4b04f9012d). Two major
changes tho.

First, instead of doing all the animate checks each time we loop over a
layer, we only do the layer dependant ones. This saves a good bit of
time.

Second, we animate movement on absolute layers too. They're staying in
the same position, but they still move on the screen, so we do the same
gental leaning. This has a very nice visual effect.

Oh and I cleaned up some of the code slightly.

* Parallax but better: Smooth movement cleanup

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
2022-05-07 23:33:34 +01:00
Zonespace
2a3d60a2a6 Mirror of tgstation/tgstation#66726 (#13383)
* [MDB IGNORE] You can have your cake and eat it too. Remake of #66406 (Splitting up areas.dmi + code related stuff) (#66726)

Areas.dmi right now houses all of our mapped turfs icons (which is roughly 400 icons). Not an issue, but it's incredibly large and clunky to navigate right now. This isn't an issue for the average coder and/or player code diving, but it is for mappers wanting to add new turfs. Currently, the file has some organization, but its still an overall mess. This PR aims to slice the behemoth with multiple .dmi files corresponding to specific areas.

I also plan to repath /area/* -> /area/station/* for station turf only. This is to clean it up, as most other turfs follow this format (that being /area/turf_zone/*).

I'm also writing an update paths file as I go along.

* fixbatch 1

* fug

Co-authored-by: Jolly <70232195+Jolly-66@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-05-07 22:41:23 +01:00
SkyratBot
df34160f53 [MIRROR] Segregate blindness code out of reading [MDB IGNORE] (#13241)
* Segregate blindness code out of reading check (#66383)

* Segregate blindness code out of reading

Co-authored-by: Tim <timothymtorres@gmail.com>
2022-05-01 00:04:17 +01:00
SkyratBot
a732669e71 [MIRROR] readds the chameleon gun [MDB IGNORE] (#13224)
* readds the chameleon gun (#66569)

Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>

* readds the chameleon gun

Co-authored-by: magatsuchi <88991542+magatsuchi@users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
2022-04-29 22:57:53 -07:00
SkyratBot
044d75253c [MIRROR] Arconomy: The bigger balance PR (REVISED EDITION) [MDB IGNORE] (#13164)
* Arconomy: The bigger balance PR (REVISED EDITION)

* yes

* wew

* Update multitool.dm

* yers

Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-04-27 21:29:22 +01:00
Zonespace
874fa41650 Fixes briefcase departmental order access for guncargo (#13148)
* finally

* comment

* fix to another bug
2022-04-27 20:51:28 +01:00
magatsuchi
dc8adc2924 Modular Tablets: Converting PDAs to the NtOS System (SKYRAT VERSION) (#12920)
* hot-patch 1

* hot patch 2

* hot patch 3

* slight issue
2022-04-20 16:55:49 +01:00
SkyratBot
82c37a6d74 [MIRROR] [MDB IGNORE] makes ebows and kinetic accelerators share a parent [MDB IGNORE] (#12902)
* [MDB IGNORE] makes ebows and kinetic accelerators share a parent

* wew

* wew

* Update blackmesa.dmm

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-04-19 19:58:49 +01:00
SkyratBot
3916ea03de [MIRROR] Kapulimbs [MDB IGNORE] (#12497)
* Kapulimbs

* conflicts

* part one of fixes

* more fex

* ugh

* more fix

* eee

* e

* more fix

* Well it compiles, but we need to get digi legs working

* more fixes

* https://github.com/tgstation/tgstation/pull/65887

* https://github.com/tgstation/tgstation/pull/65904

* https://github.com/tgstation/tgstation/pull/65923

* more fix

* now uses dna specific icon overrides.

* species code no longer dictates what icon the limbs use

* digitigrade legs implemenation

* more fixes, species indexing, species bodyparts

* remaining mutant bois

* 0

* okay this work!

* IPC stuffs

* inv file uses

* optimisation and limb string rendering digitigrade stuff

* wew

* partial vox support

* bodymarkings are now stored on the bodypart

* limb key caching

* Update carbon_update_icons.dm

* Update carbon_update_icons.dm

* Moves our mutant variance to the new system and makes shoes squash.

* all legs do it

* https://github.com/tgstation/tgstation/pull/65918

* https://github.com/tgstation/tgstation/pull/65899

* https://github.com/tgstation/tgstation/pull/65990

* teshari bodytype

* them teshari's aren't humans

* bandaid for future proper teshari implementation

* Update vox_bodyparts.dm

* fixes chests and teshari implementation

* fixes

* fex

* Update mutant_zombie_bodyparts.dm

* oops

* Update synthetic_lizard_bodyparts.dm

* Update code/modules/mob/living/carbon/human/human_update_icons.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/human_update_icons.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/human_update_icons.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Update modular_skyrat/master_files/code/modules/surgery/bodyparts/species_parts/ghoul_bodyparts.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Update modular_skyrat/master_files/code/modules/surgery/bodyparts/species_parts/ghoul_bodyparts.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Update modular_skyrat/master_files/code/modules/surgery/bodyparts/species_parts/ghoul_bodyparts.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Update modular_skyrat/master_files/code/modules/surgery/bodyparts/species_parts/ghoul_bodyparts.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/species.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Update scissors.dm

* wound stuff

* Update carbon_examine.dm

* more stuff

* Delete human_update_icons.dm

* begone thot

* https://github.com/tgstation/tgstation/pull/66065

* Update _external_organs.dm

Co-authored-by: Kapu1178 <75460809+Kapu1178@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2022-04-11 02:40:05 +01:00
SkyratBot
07e6768659 [MIRROR] Refactor and improve antimagic to be more robust [MDB IGNORE] (#12619)
* Refactor and improve antimagic to be more robust (#64124)

This refactors the antimagic component to use and have bitflags, documentation, defines, code comments, named arguments, and renames variable names for clarity.

- /obj/effect/proc_holder/spell/aoe_turf/conjure/creature/cult is not used anywhere and has been removed
- /obj/effect/proc_holder/spell/targeted/turf_teleport/blink/cult is not used anywhere and has been removed

- New sound effects are played when magic is blocked. Depending on the type of magic being used it will be either:

- Equipping antimagic now properly updates the magic buttons
- Any magic being blocked or restricting casting now displays a message
- MAGIC_RESISTANCE_MIND now properly blocks telepathy effects
- Removes blood splatter when fireball is blocked
- Magic projectiles for staff of locker no longer spawn lockers when blocked by antimagic
- Fire breath is no longer blocked by antimagic
- Spellcards are now blocked by antimagic

Any antimagic on a mob blocks that magic type from being casted. (certain spells such as mime abilities completely ignore antimagic)

- Foilhats prevent someone from casting mind magic (telepathy, mindswap, etc.)
- Bibles, ritual Totems, nullrods, holymelons, and TRAIT_HOLY prevent someone from casting unholy magic (cult spells, etc.)
- Nullrods, ritual totem, and holymelons prevent someone from casting wizard magic (fireball, magic missile, etc.)
- Immorality talismans, berserker suits, and TRAIT_ANTIMAGIC prevents all types of magic (except stuff like mime abilities)
- Touch of Madness and Mindswap is now blocked with MAGIC_RESISTANCE and MAGIC_RESISTANCE_MIND
- Voice of god is now blocked with MAGIC_RESISTANCE_HOLY and MAGIC_RESISTANCE_MIND

* Refactor and improve antimagic to be more robust

* Update tiedshoes.dm

Co-authored-by: Tim <timothymtorres@gmail.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-04-11 00:54:16 +01:00
Gandalf
0b6fb03562 Batch pr 2 (#12558)
* https://github.com/tgstation/tgstation/pull/65766

* Update ert.dm

* https://github.com/tgstation/tgstation/pull/65771

* https://github.com/tgstation/tgstation/pull/65868

* Update space_station_13_areas.dm

* https://github.com/tgstation/tgstation/pull/65894

* https://github.com/tgstation/tgstation/pull/65903

* https://github.com/tgstation/tgstation/pull/65908

* https://github.com/tgstation/tgstation/pull/65914

* https://github.com/tgstation/tgstation/pull/65926

* https://github.com/tgstation/tgstation/pull/65930

* https://github.com/tgstation/tgstation/pull/65915

* maps

* icons
2022-04-06 20:48:02 +01:00
Zonespace
1118b4175a Adds a bunch of PRs that the Mirror bot missed (#12535)
* aaAAA

* fix-maps
2022-04-06 17:50:47 +01:00
Zonespace
b995fbe31b Contractor Expansion 2 (#12311)
* weh!

* fuck you linter

* very important

* Update modular_skyrat/modules/contractor/code/datums/midround/event.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Update modular_skyrat/modules/contractor/code/datums/midround/outfit.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* requested changes

* also this

* requested + cleanup

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2022-04-03 22:25:42 -04:00
SkyratBot
cc0894c155 [MIRROR] re-adds the assistant traitor toolbox [MDB IGNORE] (#12431)
* re-adds the assistant traitor toolbox (#65703)

* re-adds the assistant traitor toolbox

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2022-04-01 00:28:32 +01:00
OrionTheFox
b0f9698d69 Removes most sec reskins so that its all one style instead of 3 conflicting ones (#12175)
* begone, vile palette (redo red scrubs)

* begone, sprite issues! (redo one of the sec-sunglasses)

* begone, unused sprites/items!

* (same as last)

* makes more sense

* no more skirts

* no longer needed

* re-does the security vendor overrides better

* adds old alts of sec gear (for admims/mappers)

* emissives fun!!

* secmed gives me aneurisms

* digi-tize

* commits the cardinal sin

* also fix some palettes while im here

* these are broken anyways

* oops

* Revert "these are broken anyways"

This reverts commit 4941f14b3141e7e78cae1a88908d40a597c3af9d.

* missing icons + reskin fix + adjust fix + blue cap variant

* reskin woes

* i hate medic

* begone, redsec

* iconsss

* Apply suggestions from code review that I did so I can see my changes better

* icon fixes

* removes redundant HoS Formal Suits

* i hate maps

* sec medic kiiinda better

* fix eror

* tgu===

* conflict fix 2

* woo woo woo fix3

* what a silly funny little typo

* red to redsec, easy to search

* fuck you CDO

* i need to stop trying to sprite

* goodbye redsec vendors!!

* one spray of red-away

* bye red! (sprites nyi so not bye yet)

* conflict fix

* few more redsec killings

* what do i even say about this its literally peter griffin

* bye red bye red bye red

* Apply suggestions from code review

* repair icons

* Apply suggestions from code review

* i forgor
2022-03-27 23:01:49 +01:00
Seris02
fa6efe2813 [semimodular] fixes the hop winter coat because I can't trust other people to do it (#12097)
* fixes the hop winter coat because I can't trust other people to do it

* almost forgot about this

Co-authored-by: Seris02 <sereweh@gmail.com>
2022-03-23 00:43:04 -04:00
SkyratBot
4c0719fcb4 [MIRROR] Belt sprites for the syndie screwdriver and alien tools [MDB IGNORE] (#12078)
* Belt sprites for the syndie screwdriver and alien tools (#65400)

* update

* makes the alien toolbelt use the sprites

* Revert "makes the alien toolbelt use the sprites"

This reverts commit caea9f52741e4f1553f3b3812336b3a4a235b6aa.

* Revert "Revert "makes the alien toolbelt use the sprites""

This reverts commit c60276e7aac93169a036bfe0bc42fb9c736d1d99.

* please check gods

* check pass?

* forgot that

* tabs

* Belt sprites for the syndie screwdriver and alien tools

Co-authored-by: Ebb-Real <95765134+Ebb-Real@users.noreply.github.com>
2022-03-14 13:01:31 +00:00
Gandalf
1715b30d92 TG MAP RESET 12/03/22 (#12063)
* Mapdate

* fu

* Update medkit.dm

* fs

* Update DeltaStation2_skyrat.dmm

* Update _basemap.dm
2022-03-13 22:20:08 +00:00
SkyratBot
58e94861c2 [MIRROR] [MDB IGNORE] 3/4th medkit sprites + firstaid > medkit [MDB IGNORE] (#12034)
* [MDB IGNORE] 3/4th medkit sprites + firstaid > medkit

* Update storage.dm

Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-03-13 22:07:44 +00:00
SkyratBot
17e4f6ad76 [MIRROR] Converts SFX keys into DEFINES [MDB IGNORE] (#11990)
* Converts SFX keys into DEFINES

* fixes and updates

Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
Co-authored-by: John Doe <gamingskeleton3@gmail.com>
2022-03-11 16:43:39 -07:00
RatFromTheJungle
16a472aae5 m,nm,hjk (#11987) 2022-03-10 09:51:55 -05:00
SkyratBot
e80a382570 [MIRROR] Janitorial cart improvements [MDB IGNORE] (#11945) 2022-03-07 15:20:03 -07:00
nevimer
0e7777d3f1 removes it. (#11644)
Co-authored-by: nevimer <foxmail@protonmail.com>
2022-03-05 14:20:38 -05:00
SkyratBot
d4569eea4a [MIRROR] Resprites the Chief Medical Officer [MDB IGNORE] (#11759)
* Resprites the Chief Medical Officer (#65161)

imageadd: overhauling the visual aesthetic of the Chief Medical Officer

* Resprites the Chief Medical Officer

Co-authored-by: Imaginos16 <77556824+Imaginos16@users.noreply.github.com>
2022-02-28 11:34:28 -05:00
SkyratBot
4461887970 [MIRROR] Updates all storage bag icons [MDB IGNORE] (#11749)
* Updates all storage bag icons (#64978)

imageadd: Changes all storage bag sprites

* Updates all storage bag icons

Co-authored-by: Wallem <66052067+Wallemations@users.noreply.github.com>
2022-02-26 02:55:46 -05:00
SkyratBot
ddfc30c89c [MIRROR] Adds Moth Fashion [MDB IGNORE] (#11612)
* Adds Moth Fashion

* skyrat fix

Co-authored-by: Mickyan <38563876+Mickyan@users.noreply.github.com>
Co-authored-by: jjpark-kb <55967837+jjpark-kb@users.noreply.github.com>
2022-02-20 21:10:39 +00:00
SkyratBot
ef9a141145 [MIRROR] Adds some contextual screentips to botany related things [MDB IGNORE] (#11586)
* Adds some contextual screentips to botany related things (#64954)

* Adds some contextual screentips to botany related things

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
2022-02-20 06:19:08 -05:00
SkyratBot
b8a09b4f73 [MIRROR] Pepper spray module for sec modsuits, Atmos resin module and nukie pyro bundle flamethrower made into module [MDB IGNORE] (#11543)
* Pepper spray module for sec modsuits, Atmos resin module and nukie pyro bundle flamethrower made into module (#64934)

Pyro bundle was broken as when you brought it you would get modsuit and pyro backpack forcing you to either use armor or use backpack without fire protection(which modsuit has). Thanks to Fikou work it became a module
Anti-Tider on the other hand is rarely used(i have never seen it used when i was playing sec or observing) and needed a little buff so now it will also became a module while i will make normal Anti-Tider stream wider(still working on it).

* Pepper spray module for sec modsuits, Atmos resin module and nukie pyro bundle flamethrower made into module

Co-authored-by: Cursed <47064429+Amrabol@users.noreply.github.com>
2022-02-16 21:18:53 +00:00
SkyratBot
7c2e83bfc3 [MIRROR] Adds a sprite for rubbershot and the rubbershot box [MDB IGNORE] (#11387)
* Adds a sprite for rubbershot and the rubbershot box (#64562)

Gives rubbershot and rubbershot boxes a new sprite to differentiate them from beanbags.

* Adds a sprite for rubbershot and the rubbershot box

Co-authored-by: necromanceranne <40847847+necromanceranne@users.noreply.github.com>
2022-02-09 00:46:55 +00:00
SkyratBot
ccb0aaea1a [MIRROR] Ballistic to Energy: Autorifles for Thermal Pistols; Adds .38 Crate to Cargo [MDB IGNORE] (#11340)
* Ballistic to Energy: Autorifles for Thermal Pistols; Adds .38 Crate to Cargo

* eeee

* Update new_player.dm

Co-authored-by: necromanceranne <40847847+necromanceranne@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-02-08 01:59:42 +00:00
SkyratBot
4b2db93b2f [MIRROR] insert items from trash bags to autolathes [MDB IGNORE] (#11271)
* insert items from trash bags to autolathes

* Update code/game/objects/items/storage/bags.dm

Co-authored-by: jjpark-kb <55967837+jjpark-kb@users.noreply.github.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
2022-02-06 14:23:08 +00:00
SkyratBot
abf7e98baa [MIRROR] Removes useless defines for mutation paths [MDB IGNORE] (#11138)
* Removes useless defines for mutation paths (#64512)

* Removes useless defines for mutation paths

* Update cortical_borer_abilities.dm

* Update cqcplus.dm

* Update clown.dm

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
2022-01-30 15:56:08 +00:00
SkyratBot
6498f493c8 [MIRROR] Some Command Resprites [MDB IGNORE] (#10978)
* Some Command Resprites

* Feex

Co-authored-by: Imaginos16 <77556824+Imaginos16@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2022-01-26 19:13:17 +00:00
SkyratBot
c91e2d2430 [MIRROR] Make more use of <tool>_act [MDB IGNORE] (#10981)
* Make more use of <tool>_act

* conflicts

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: jjpark-kb <55967837+jjpark-kb@users.noreply.github.com>
2022-01-25 17:51:36 -05:00
SkyratBot
a64e6df548 [MIRROR] Resprites toolboxes [MDB IGNORE] (#10904)
* Resprites toolboxes (#64298)

New sprites. Do I need to say anything more? Goon folder begone.

* Resprites toolboxes

Co-authored-by: Riggle <27156122+RigglePrime@users.noreply.github.com>
2022-01-22 22:22:56 +00:00
SkyratBot
0acc853c91 [MIRROR] Adds a movement looping system, replaces inbuild procs and spacedrift with it [MDB IGNORE] (#10749)
* Adds a movement looping system, replaces inbuild procs and spacedrift with it (#62567)

* Adds a subsystem to handle automated directional movement, replaces all instances of walk_towards with it. Makes meteors and immovable rods not drift in space, and makes immovable rods more destructive. Note, I've opted not to use byond's method of moving towards something, which is effectively Move(src, get_step(src, get_dir(src, target))) as it's cringe and doesn't make a smooth line. I've replaced it with a autoupdating rise over run setup, read the code for more details

* woop forgot the subsystem

* Documentation, contributing.md entry, and some cleanup

* Makes the moveloop datum more oop friendly, sets us up for a lot of conversions

* Converts the curseblob and walk_away() to the subsystem

* Changes the default for override from FALSE to TRUE

* converts walk() over, still need to add a replacement proc for it, but we didn't actually have anything that used the raw proc

* converts the rest of walk_to() over, nearing the end now

* cleans up some errors

* Fully documents everything, fills in some missing movement types, uses the power of oop to make things cleaner, and typepaths longer

* Finishes the contributing.md stuff

* Done

* Fefaults -> Defaults, can you tell I wrote this at 1AM?

* resolves bubblegum issues

* Roh's suggestions

Co-authored-by: Rohesie <rohesie@ gmail.com>

* Cleanup

* Hey lemon, did you know that Destroy() lives on datums? ahhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh

* Converts over the discrepencies created in my absense

* HAHA FUCK YOU I PAY MY DUES

* Whoops lost some stuff in the merge

* Converts the system from seconds to deciseconds to make dealing with the api more sane

* Some stuff I missed

* Makes movement an inheritable subsystem type, splits the moveloop file into two, one for the subsystem, and one for the datums

* Makes a subsystem that handles directing movers out to other subsystems. It's a bit bad right now, but it's a
good first step. I think I'll move the move loop datum to a lazy var on mobs instead of an assoc list, don't
like lists.

Also makes the movement procs global, I'll move em to the /movement subsystem at some point or something like
that

* Converts the existing uses of the procs over to the new format

* Adds support for subsystem precedence, so a type of A can override type B.
General cleanup, still kinda in debug mode but it's getting better

* I'll admit I'm not too familiar with this, but I think it will work

* Adds starting logic so movement types "pausing" makes any sense
Redoes how waiting is handled to make it based on world.time directly. I don't remember why. I think it's better
this way.

Adds a drifting movement type, moves space drift over to it.
Needs severe work before it's ready, too much info stored and modified on the moving object, see comment
Starts work on making drifting smooth

* Moves almost all space drifting vars over to signals on the movement datum
Properly implements glide size stuff for both the subsystem and the loops. Space drift will be smoother now.
It's not perfect, but it'll work just fine for now

Adds a way to override a client'd mob's glide size mid move, uses it to make entering a spacedrift look right
Adds a way to delay a client move outside of just move_delay, meant to be used for long periods, and setup such
that it doesn't make inputs persist

Adds flags to movement loops, alongside MOVELOOP_OVERRIDE_CLIENT_CONTROL, which blocks client movements while
the loop is firing, and for it's visual delay after

This means you can't exit a space drift until you hit the actual wall. This feels a lot better

Some general logic stuff, move() will return true/false if it succeeded or failed
Adds a stop_loop() proc that's called when a move loop is no longer active

Suck my nuts

* Moves precedence to the loop instead of the subsystem

* Moves drifting into a component, this lets me explictly block input after the move loop ends, so people can't
move the moment they functionally move onto a new tile
This is a bit underdeveloped currently, but that's a problem for another day

Cleans up some uses of move procs, fixes runtimes in metoer and curseblob code
Adds signals for stopping/starting a move loop, sending one for destroy is redundant.
Moves existing event signals from the movable being acted on to the loop itself, makes more sense this way
Makes the move handler return the created loop up the chain so we can register to it
Fixes a logic error in loop contesting code that lead to loops never actually being removed from subsystems
because they didn't know they should be.
Properly changes lifetime from a time to stop, to functionally an amount of moves to complete before stopping
Adds some new signals for pre/post loop process. This is to better tie into components.

I decided I didn't like the idea of tying all functionality to the loops themselves
The loop decides functionally how to move, components or just tied in signals can decide when/when not to move
and can modify properties of the loop

Making a new loop for things like atmos drift, something I'm interested in tackling in the future, seemed silly

* Moves movement procs directly to the subsystem for better namespacing or whatever

* Moves movement packets onto /atom/movable, no longer need the debugging
I've decided to not just put their contents fully onto atom movable, since it makes debugging on live much
harder, can't sdql for them anymore.

Fixes a runtime in meteor code, properly this time
Fixes a logic error in stop_looping
Makes move manager NO_INIT, because well, it doesn't init

* Commits human sin, makes Recover() work properly for movement subsystems

* Fixes immovable rod orbits not always working, they were returning too early in moved and fucking up the var we use to track move count, and thus not sending a signal properly

* Reworks the curseblob to use signals more, and to not use override

* Missed this in the movement ss commit

* Removes override, makes having a higher or equal precedence take its place

* Updates documentation

* Cleans up some unused defines

* Nukes the unused flags option

* Whoops forgot to qdel check

* Removes an unused var I had for client move prevention before I started using a component

* Let's do this properly

* Modernizes meteor code to better match how explosions actually work currently

* Some more cleanup

* Cleans up effect code a little bit
Nukes the effect system's sleep loop, we use movement loops instead
As a part of that, instead of 1 timer per effect spawned, we react to loop failure and make it 1 timer per
effect system
This should reduce the amoumt of slowdown we see after mass lighting break

It's not everything, we're still making a timer per spark effect, but it cuts things down significantly

* Updates explosions to not sleep

* Adds support for modifying a loops delay post process, makes extinguisher code suck less then it does currently, nukes some more sleeps and timer loops

* Converts water tank resin over to move loops rather then sleeps, minor behavior change mind, the cooldown starts on fire rather then on land, but I think that makes more sense anyway

* compile and runtime fix

* Fixes some runtimes, cleans up some code, ensures feature parity when it comes to logging

* Prevents resin foam from space drifting

* Adds support for flags back into the system, I need it for reasons

* Updates move_towards to fix some bugs and resolve some inconsistent behavior, implements a flag that makes a loop's first move start instantly

* Fixes extinguishers not actually transfering any reagents

* Converts sprays to the new system. This does actually minorly change behavior, in that I've changed the order of spray actions from step -> sleep -> wash to step -> wash -> sleep, but I'm not terribly torn up about it because frankly I think it feels better

* Converts grav catapults over to the new system

* Converts trays over to moveloops

* Converts robot streaking to move loops, the other two coming soon

* Compile you won't. Also fixes a behavior issue with oil streaks

* Does directional step_to properly, cleans up the other two streaking types

* Converts step_trigger over, not that it's actually used anywhere. Changes how stoping a move works, you need to explicitly qdel, other the step is just considered to be ignored. This will make life easier later

* Adds a jps movement loop. It's a bit bloaty, id is stupid, but it'll work just fine

* Makes the system support passing in a datum that's just used as extra context for the move. The hope is this makes signalizing things less of an absolute headache

* Begins the conversion of ai movement datums to movement loops

* These two are reasonably simple, only weird thing I'm doing is A: Not allowing target hotswapping, which I hope none is doing, and B: passing the controller into the move loop as extra context so things work properly

* JPS is a bit more complex, partially because the old implementation was a bit weird. 2 major things. 1: I'm dropping what I think was a redundant behavior minimum distance check from the premove bit of logic, since I'm pretty sure it didn't do anything. 2, instead of just stoping the step in an error state like being pulled, we count it against our max move total

* Audit

* Moves most forced movement to the framework, adds some components to make things nicer

* Implements a flag that makes the loop always operate, regardless of precedence and without impacting any other loops

* Moves movement subsystems into the right folder

* Hey potato what if you had two procs that did the same thing and one called the other? Wow it's useless

* Merges slipping and force movement

* Converys conveyors over to the system. It's a bit fragile, but I think it's totally worth it to save the sleep loop

* Precedence -> Priority, cleans up some logic errors, makes priority highest to lowest instead of lowest to highest, straight cleans some code up

* Makes poly and bubbles ignore spacedrift, now that precedence actually functions properly. I'm likely missing cases of this, will deal with it later

* Depression, thy name is linter

* Fixes linter, and hopefully fixes the runtimes in ci too

* Wew

* Sets sprays and extinguishers back to legacy, since people do actually seem to have noticed

* Spelling errors my beloved

Co-authored-by: Kylerace <kylerlumpkin1@ gmail.com>

* More detail, moves return descriptions

* Converts transit tubes to the system?

* Adds the glide size modifier. Not honestly sure that this should be default, considering how crummy it makes things look for normal walking, but it's useful as hell here

* Adds a force move in dir template, actual support for fast initial steps (wtf old me) and a helper proc for setting delay

* Cleans up displosal code a bit, I thought about adding it to the system but it would functionally be just 'disposal loops'. Maybe I'll make a template subtype? not sure how I want to handle stuff like this

* Cleans up mob movement a bit

* Let's use the controller's visual delay

* Makes the resin thrower nicer, cries

* Cleans up some comments, replaces an implicit world.icon_size with an explicit one, fixes up a typecheck

* typecache instead of double istype. Can't do much about the !atom/movable, list would be too big I feel

* hhh

* bro wtf

* Documents the why of SS_TICKER

* Puts SSmovement on SS_TICKER. Lets us support tick steps

* Cleans up the charge action. Makes it use moveloops

* Fixes CI? kinda worried that this just got dropped

* Converts disposal pipes to move loops. They stutter a bit more then usual as of now, hoping that's a me thing, if it's not I'ma look at uping the priority of the base subsystem

* Moves the move subsystems off background, puts some on ssticker

* Prevents some things that shouldn't move in space from moving in space

* Documents the general form and usage of the system

* Virgin one vs chad once

Co-authored-by: Kylerace <kylerlumpkin1@ gmail.com>

* Removes unneeded check

* Moves appropriate movement subsystems into SS_BACKGROUND. Removes redundant SS_KEEP_TIMINGs

I do want the behavior of SS_TICKER, which at this point is tick based waits, and ignoring overtime when
calculating next fire.
Since honestly, these subsystems should ignore overtime in regards to next fire, the cost of moving A may be
nothing compared to the cost of moving B.

* Makes the MODULUS macro use floor. I knew our coders would never let me down, glad this exists, thanks ninja
Fixes teleporting caused by shitty round() behavior, adds a "you hit your target" case to homing loops

* Converts blood splatters to move loops, that'll do it

Co-authored-by: Rohesie <rohesie@ gmail.com>
Co-authored-by: Kylerace <kylerlumpkin1@ gmail.com>

* Adds a movement looping system, replaces inbuild procs and spacedrift with it

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: Rohesie <rohesie@ gmail.com>
Co-authored-by: Kylerace <kylerlumpkin1@ gmail.com>
2022-01-18 00:54:06 +00:00
SkyratBot
43bd14062a [MIRROR] Moves the toolbox sprites to the goon folder. [MDB IGNORE] (#10787)
* Moves the toolbox sprites to the goon folder. (#63930)

The toolbox sprites have been moved from the regular icon folder to the goon folder.
Why It's Good For The Game

The toolbox sprites that we currently use originally came from Goon, and were ported over by @ dannno (#23938).

Therefore, they belong in the goon folder, where they won't possibly be confused for a CC-BY-SA licensed asset.

I have no clue who made the original toolbox sprites on Goon (If someone who does know happens to read this, please let me know so i can give them proper credit), but i do know that dannno made another PR that modified them to how they look today (#24001).

* Moves the toolbox sprites to the goon folder.

Co-authored-by: sergeirocks100 <31294280+sergeirocks100@users.noreply.github.com>
2022-01-17 23:57:58 +00:00
SkyratBot
e39b509cd8 [MIRROR] Safe code documentation [MDB IGNORE] (#10758)
* Safe code documentation (#64096)

Adds better documentation and variable naming to safe code. Also removed one variable that hasn't done anything in years.

* Safe code documentation

Co-authored-by: dragomagol <66640614+dragomagol@users.noreply.github.com>
2022-01-17 00:02:26 +00:00
SkyratBot
51b112b91d [MIRROR] Adds medical department medals (updated sprites) [MDB IGNORE] (#10699)
* Adds medical department medals (updated sprites) (#64076)

* initial sprites and code work

* Update accessories.dmi

* changed color to blue and made worn sprites smaller, testing

* updated sprites, made them much smaller and color scheme is fixed

* Adds medical department medals (updated sprites)

Co-authored-by: RaidenKoizuma <80659327+RaidenKoizuma@users.noreply.github.com>
2022-01-15 16:24:35 +00:00