Commit Graph

4436 Commits

Author SHA1 Message Date
tralezab
9e4856d55d [READY] dilutes the staff of chaos pool with some more bolts (#42719)
* staves

* projectiles

* sapped event

* last of the staves (need to sprite and get sounds)

* last of the projectiles

* Squash is a single-use plant in Plants vs. Zombies and returns as a premium plant in Plants vs. Zombies 2.

* removes staff of cooperation, adds fly magic status effect

* a couple things with flight + tweaks

* removes old bolts/staves, finishes and adds parts of the new set

* fixes

* fetching + flying fixes, added chill and wipe

* and done

* cobblestone's review
2019-03-08 08:24:57 -05:00
ShizCalev
62f141ae3e Merge pull request #43020 from TerraGS/virus-fix
Fixes voice change symptom bug
2019-03-08 03:24:00 -05:00
ShizCalev
75be9026eb Merge pull request #42978 from pubby/viro
Important virus fixes
2019-03-07 09:57:33 -05:00
Tad Hardesty
990e2c7bc2 Fix a few junk type annotations (#42985) 2019-03-07 10:58:05 +01:00
tralezab
0a51e7e1b9 [PROBABLY READY? REVIEW WITH SCRUTINY] New event: Fugitives (#42554)
* fugitives

* lets make this a bit cleaner

* cultists and the beginnings of security detail, lots of wip

* wip security

* WALDO (and some more work on yalp, of course)

* adding antagonist teams for both hunter and fugitives, roundend report beginnings

* this whole file is shit, but hopefully a little better

* it compiles (+ space police)

* some more work

* S.E.L.F. fluff

* grammar and icon fixes

* lets finish yalp elor, give it the justice it deserves

* moves hunter spawns to ship pods + russians P1

* moves hunter spawns to ship pods + russians P2

* fugitives and hunters now recognize eachother

* hunter spawning finished(?)

* missed this

* ATH's review

* runtime fixed, added yalp's transport ability

* anturk's review

* makes hunter.dm better trust me

* oopsies

* INVOKE_ASYNC

* russian ship + finally a (bad) sprite for the capture machine

* step > pixel, thanks travis

* mooshroom review p1

* mooshroom review p2

* improper use of /improper

* waldo's radio doesn't stick, police id

* candidate picking is more flexible + minor things
2019-03-06 10:17:46 -05:00
oranges
0267bce949 Turns out a bunch of components do not properly transfer because of (#42691)
one of three things.

    1. They don't use RegisterWithParent or UnregisterFromParent to unregister
       and register signals

    2. They use callbacks which refer to a source object, which is usually deleted
       on transfer, or lost in some manner, or simply makes no sense at all to be
       transferred

    3. the component was never designed to be transferred at all

TransferComponents gave no shits about any of this and just blindly transferred
all components, if they were actually capable of it or not.

I only noticed this because it was causing chairs to break as they would not register signals
and verbs correctly for rotation after being picked up and then placed down, and a player
reported that issue via ahelp.

Luckily we caught it before the rot got anywhere, only chairs and the shuttle subystem
tend to use this proc (Shuttle uses it on turfs), can you imagine if everything was using
this LMAO

Which is good because it's more dangerous than a loaded gun

I have added a can_transfer var, that is true when a component is valid to
actually transfer, which means the dev has actually thought about what happens when
you take the parent object away and swap it for another and all the crazy that is entailed
by this

I have done my best to audit what components are actually
transferable, but things are basically a hot mess (Thanks @Cyberboss )

The following components required edits:
Forensics:
did not register/deregister the clean_act signal properly, did not checkblood on new parent

Rotation:
did not use RegisterWithParent or UnregisterFromParent, turned out
to not be transferable anyway due to having callbacks that can be
passed in to the parent with unknown sources that we can't feasibly
reuse (i.e if you're transferred from a chair to a bed, your old rotation
call backs are no longer valid). Turns out the use case it was for (just chairs)
didn't need it anyway, so I just made it non valid for transfer.

Wet Floor:
Honestly this one is just a hot mess, it should be a subtype of the slippery
component with the extra wet turf handling.

As it is it basically manages a slippery component on top of it's own extra
functionality, so that's a major code smell.

I added registration/unregistration of the signals, and made it's pretransfer
remove the slippery component and the posttransfer add it back (via update_flags)

Components that seem transferable without issues
mirage_border
orbiter
decal
spill
storage (I hope to earth)
2019-03-05 20:27:29 +01:00
TerraGS
261ea2818e Fixes voice change symptom bug 2019-03-05 12:06:02 -06:00
pubby
56137444e8 Remove stat change 2019-03-03 09:48:17 -06:00
pubby
0c1ba0e177 Fix beard growth (ATH1909) 2019-03-03 09:47:56 -06:00
Militaires
5ff56fb39e Correct CQC help instructions (#42980) 2019-03-02 13:57:24 -08:00
pubby
34cc294cea Buff undead viruses 2019-03-02 06:30:25 -06:00
pubby
0a9893b8a8 Fix cough clobbering spread_flags 2019-03-02 06:22:09 -06:00
pubby
0fc075badb Reduce beard speed 2019-03-02 06:21:48 -06:00
pubby
01f8f8ea55 Allow dead people to get dead viruses 2019-03-02 06:21:06 -06:00
Jordie
34a6197169 Merge pull request #42959 from SouDescolado/Runtimes-fix
Fixes spawner menu runtime
2019-03-02 22:43:42 +11:00
pubby
04d0105f97 Fix beard virus 2019-03-02 05:17:45 -06:00
Time-Green
ad1dd38655 Adds snailpeople as a rare genetic meltdown effect (#42889)
Meant to be part of #42864 , but got a little big so I'll add it to wichever gets merged last.
[Snailcrawl demonstration](https://youtu.be/IL7WFpfRo4c)

PROS

- Gets snailcrawl, wich makes them greatly faster and gives them a lube trail

- Their blood is spacelube

- They get a cool armored nodrop snail shell

- They don't slip

CONS

- Very slow

- Punch is pathetic

- Tttaaalllkkk llliiikkkeee ttthhhiiisss

- Extremely vulnerable to salt

- Can't wear glasses

Adds gastrolisis, wich is pretty much [this](https://www.youtube.com/watch?v=lFbPi8o0OEU) spongebob episode where they slowly turn into snails

You can also get gastrolisis by random_reagent_id, so maintpills and botany

🆑
add: Adds snailpeople as a rare genetics accident.
sprite: Snailshell sprites by nickvr628
/🆑
Snailshell sprites by @nickvr628

Why: It's a silly gimmicky race and it's a rare occurence. Also extremely highly requested for some reason
2019-03-02 09:40:56 +13:00
Kamparauta
8789c1d7e3 Changes the PAI loudnessBooster to a piano_synth, allows choosing of instrument. (#42910) 2019-03-01 13:50:16 +01:00
tralezab
7762e72405 New trait: Unstable (#42904)
* nice.

*  They exist to cease.

*  "They've got eyes inside my head!"

* frick

* unstable insanity

* Just try taking this bull by the horns. (eyeballs)

* It's a thankless job, and you'll probably die in an explosion. But the pay is pretty good.

* "The best denials are simply that: a beginning and end unchanged, a dream with no memory."

* fixes the dme
2019-02-28 10:35:13 -05:00
SouDescolado
e7cc56dbe9 fix runtimes 2019-02-28 11:14:04 -03:00
tralezab
86a6ead838 My summoning begins your debt, reviewer. 2019-02-26 09:03:36 -08:00
oranges
c9d2b8c5f8 Logging tweaks and fixes (#42817)
* Add a virus log, plus a log for facehuggers

Logs each infect event and contains detailed descriptions of the virus

I also added a log message for printing virus culture bottles including
who printed them

Finally i tacked on a change to adding a game log entry for facehuggers
because why not

* Further logging fixes and updates

Medbots now combat log

combat log no longer tries to run keyname on an object because that
doesn't make much sense

* Dead say no longer logs twice

* tabs to spaces
2019-02-26 21:13:36 +11:00
Time-Green
2f5a9ad416 Adds more genetic meltdown effects (#42864)
* makes genetic meltdown a little more interesting

* uses SLIME toxin and maybe melting your skin doesnt kill

* adds more genemelt effects

* removes accidental snail

* fixes .dme

* dir to dirextion and splits the spawn into a seperate proc
2019-02-26 20:53:30 +11:00
Jordie
5dc5e59431 Merge pull request #42898 from ShizCalev/jaunt-squeek-fix
Fixes jaunting mobs squeeking things.
2019-02-26 20:46:11 +11:00
Jordie
a3f557ebc6 Merge pull request #42901 from optimumtact/regexshit
Hypnosis code improvements
2019-02-26 20:45:14 +11:00
ShizCalev
c4c5ece3ba Fixes jaunting mobs squeaking things. 2019-02-25 09:31:28 -05:00
Jordie
d8b69235d8 Merge pull request #42791 from Mickyan/honkmeariver
Ends the Great Clown Shoes Debate of 2019
2019-02-25 22:19:45 +11:00
oranges
fca3d16576 Hypnosis code improvements
Hypnosis no longer runtimes forever if it can't generate a valid regex
from the user phrase

Hypnosis also no longer constantly regenerates the regex and instead
just matches using the existing regex
2019-02-25 05:31:44 +00:00
ShizCalev
a43c4acabc Fixes some minor speech replacement stuff (#42783)
cl ShizCalev
fix: Corrected slime mutation not correctly replacing the word douchebag.
fix: Fixed Elvis speech mutation inserting the word "getting" when saying "muh valids"
/cl
2019-02-25 15:01:28 +13:00
nero1024
327d8fbd40 fix footstep sounds from being played while buckled (#42788)
Fixes the crawling sound from being played from moving buckled/mounted mobs.
## Why It's Good For The Game

Apparently I didn't catch the crawling sounds being played from buckled mobs that are moving. Examples include the Janitor on their pimpin' ride or some assistant piggy-backing off of a cyborg.
2019-02-25 15:00:40 +13:00
Tad Hardesty
5fb918ebe4 Fix some variables with 'list' in the wrong place 2019-02-21 19:32:53 -08:00
Time-Green
3be9f4c165 removes double paraplegic (#42858) 2019-02-21 10:53:10 -05:00
ShizCalev
e8630127f5 Fix junkie quirk (#42844)
Junkies will now spawn with their pills correctly filled with their appropriate
drug.
2019-02-19 22:11:33 -08:00
ShizCalev
c1e77440b8 Fix neet quirk runtime (#42825) 2019-02-18 19:56:20 -08:00
Jordie
06fe123a34 Merge pull request #42785 from ShizCalev/deaf-disease-fix
Deaf disease fix
2019-02-17 20:55:52 +11:00
Jordie
5ccf30b50e Merge pull request #42795 from 4dplanner/crusher
Blood drunk eye fix
2019-02-17 20:04:57 +11:00
ShizCalev
77071fbc4b Fixes missing mutation arguments 2019-02-15 20:47:11 -05:00
4dplanner
32814aab11 CRUSHER MAKES YOUR ARMIES HARDER 2019-02-15 22:47:26 +00:00
Mickyan
c7389a1ecd honk me a river 2019-02-15 16:07:19 +01:00
ShizCalev
af2c950e04 Deaf disease fix 2019-02-14 23:08:05 -05:00
Shadowflame909
92113f7e9c Makes the Meteor Shuttle way more expensive (#42730)
* Update shuttles.dm

* Update shuttles.dm
2019-02-12 23:20:06 -05:00
Kierany9
14fa6040e5 Assimilation 2.0: Not quite a big enough PR to be worthy of the 2.0 title but almost (#42607)
* one

* ???

* big

* sprites

* it is done

* oofs

* no more bad jokes

* location -> reception

* i forgot a feature lmao

* yo lemme nerf this op power

* adjust removal and makes panic less insane

* hey i forgot another feature

* one mind removals

* *laser eyes meme*

* Disables multiple one minds for real this time
2019-02-12 20:02:23 -05:00
imsxz
d5abf90113 pacifist antags retain pacifism (#42674)
* pacifism forever

* oops

* plan z can't possibly fail
2019-02-12 19:55:24 -05:00
granpawalton
7ebd0ad09b tweaks tissue hydration to meet description and holy water added to desc (#42745) 2019-02-12 19:53:55 -05:00
PKPenguin321
12f0ec568f [Ready] [Could Use Sprites] add Antenna and Mind Reader powers, paranoia disability to genetics (#42443)
* adds the antenna power to genetics
it gives you an innate radio

* adds paranoia and mind reader

* foil hat interaction, sprites, tweaks

* upstream change
never webedit, kids

* fixes conflict-fixing error
2019-02-12 13:21:07 -05:00
IndieanaJones
0937264f1e [READY]New Side Antagonist: Space Dragon (#42551)
* Add files via upload

* Rename space_dragon.dm to code/modules/events/space_dragon.dm

* Adds Space Dragon

* Adds Space Dragon Event

* Remove Copied File

* Put antagonist definition in proper location for space dragon

* Update space_dragon.dm

* Removed passive health regen from space dragon

* Updated Weight and Earliness for Space Dragon

* Added Objective to Space Dragon, Updated Starting Blurb

* Cleaned Up the Objective Determiner

* Actually fix the space dragon objectives

* Fix the objective display for the space dragon's target

* Updated Space Dragon Intro Blurb

* Updated Centcom Message When Space Dragon Spawns

* Updated Space Dragon's description with new lore

* Clean Up Space Dragon's OnFire()

* Add Space Dragon Sprites

* Sprite in wrong location

* Properly adds Space Dragon Sprites

* Adds Space Dragon Tiny Sprite to be Carp

* Space Dragon Uses New Sprites, Tiny Form Updated

* Increased Time Til' Dragon Spawn

* Drake's Tail Sweep Now Uses Prebuilt Spell

Thanks to Cobblestone for the head's up on this.
2019-02-10 21:12:17 -05:00
Time-Green
acfd3f8253 [GOONETICS] Chromosomes (#42151)
* adds chromosomes

* Makes the framework nice and functional

* Adds chromosome interaction

* Makes chromosomes work

* removes the double instability update

* Apply suggestions from code review

Co-Authored-By: Time-Green <timkoster1@hotmail.com>

* more review stuff

also fixed some inconsistencies in chromosomes

* unfucks defines

* Fixes saved mutations runtiming with empty pods

* Adds stability to the dna console and advanced health scanner

* removes a random bug i stumbled upon

* Update code/game/machinery/computer/dna_console.dm

Co-Authored-By: Time-Green <timkoster1@hotmail.com>

* makes chromosomes harder to get

fixes double mutations, adds reinforcer and nerfs stabilizer

* fixes edge case where fireballs would be harmless

* cleans up find/replace all mess and 1 in 10 trillion chance of fireball breaking
2019-02-10 20:45:09 -05:00
nero1024
e949346cfd Fixes footstep sounds for downed/lying mobs (#42704)
Nobody made a report but I noticed this issue: Downed players being dragged are playing footstep sounds, specifically the bare footstep sounds via their hands from what I noticed.

Fixes (hopefully) footstep sounds from being played from incapacitated mobs that are being moved (via dragging for example). Instead, lying mobs will play a crawling sound when moving.
## Why It's Good For The Game

Footstep sounds shouldn't be played when mobs are being dragged.
2019-02-10 12:43:55 +13:00
Vile Beggar
313db3ad8b Tweaks the drill hat to be a bit less annoying (#42655)
* does the tweaking

* indent fix

* adds more canadian variety

* no longer mr politeman

* adds cobby's review suggestion

* gets rid of mutation defines

* makes it use speechmod

* removes accidental letters

* gets rid of unneeded comma in .json

* changes magic number into defines

i hope it's supposed to be like this

* compile fix

* gets rid of yelling define in dna.dm

* removes unneeded line in .json
2019-02-09 22:26:49 +11:00
tralezab
43ecae6fa2 sleeping carp now deflects projectiles in random directions (#42647)
* bad ass shit

* durr

* nice

Co-Authored-By: tralezab <40974010+tralezab@users.noreply.github.com>
2019-02-08 11:56:25 -05:00