Commit Graph

51257 Commits

Author SHA1 Message Date
ArcaneMusic
eca190ab9c Adds a new modular computer app, the Shipping Scanner App. (#50431)
* Had to put this on hold due to critical FUCK from hydriponics

* Another thing I'm being dragged away from

* Finally finished and happy with the result

* Merge issues: IRRADICATED.

* Made the UI a Labeled List per Stylesugestion

* Apply suggestions from code review

Co-Authored-By: Bobbahbrown <bobbahbrown@gmail.com>

* Fixes up compile issues and tweaks tooltip/disable

* Rebuild tgui

Co-authored-by: Bobbahbrown <bobbahbrown@gmail.com>
Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
2020-04-09 05:32:16 +03:00
ArcaneMusic
04187f7363 Ports the Bot Control PDA program to Modular Computers. (#50351)
* Startwork.

* Time to break this later

* How do I map lists again

* So close I can almost TASTE ITTTT I GOTTA GET A MOVE ON WITH MY LIIIIFE

* Hey, it almost works!

* Finally actually ready to PR

* Nothing to see here but documentation and dead code

* Take 2.

* Revert "Take 2."

This reverts commit 0882d96a30ba79ebead4b5dd3e6f32e65bbf2a76.

* Cleans up tgui compile errors.

* WIP changes, still not happy with this for now.

* I am satisified.

* Rework that UI

Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
2020-04-09 05:21:21 +03:00
ArcaneMusic
531760d19d Introduces Gene Shears to Botany, and several other QOL tweaks. (#50387)
* Beaker go splash, plants mutate good

* Hard committing to this for the time being.

* Clean up.

* Not sure what I forget here.

* As yes right, I did do this.

* Avoids chemical conflicy my making it uranium, frost oil, potassium.

* More informational, and uncaps removed genes per cut, at the cost of plant health each time.

* Moved to a more critical node to enable gameplay earlier.

* Committing suggestion.

Co-Authored-By: moo <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>

* Very valid point about iterating down loops, ngl

* Fixes fixes, and other fixes.

* Fixes up documentation, and removes unused code.

* Adjusts Nutridrain to be calculated on the process side.

* Prevents Non-Extractable and Non-Removable genes from being removed, as originally intended.

Co-authored-by: moo <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>
2020-04-08 17:18:39 -04:00
Fikou
ca7415657c hop moves from supply positions to service positions (#50235) 2020-04-08 16:03:28 -04:00
ArcaneMusic
55ae1ceb70 Instability is now shown on the seed extractor. (#50413)
* Instability is now shown on the seed extractor.

* Adds doccumentation.

* Adds class level documentation to seed_pile datums
2020-04-07 15:46:26 -04:00
Kyle Spier-Swenson
b2872fa6bc Hubstuff (#50422)
cl Qustinnus
add: Hub visibility can now automatically turn on/off based on population (config-based)
/cl

did this for the headmins
2020-04-07 16:14:12 +12:00
XDTM
a4c838b8b2 Fixes Cortex Folding Surgery (#50414)
* gps

* Fixes cortex folding

* manual revert

* other manual revert

Co-authored-by: spookydonut <github@spooksoftware.com>
2020-04-06 20:35:51 -04:00
TiviPlus
8bf449ca67 Ports Not-Uno and changes card stacks (#50357)
* I GOT MINE ON DAY ONE

* I have the oldest xbox known to man

* e

* whee

* shits broke

* lol

* Update code/game/objects/items/toys.dm

Co-Authored-By: Bobbahbrown <bobbahbrown@gmail.com>

Co-authored-by: Bobbahbrown <bobbahbrown@gmail.com>
2020-04-06 19:39:04 -04:00
Tetr4
fddc87d165 Silicons can alt-click and ctrl-click pumps and filters wirelessly (#50356)
* Update thermomachine.dm

* Update thermomachine.dm

* Update cryo.dm

* Update mixer.dm

* Update filter.dm

* Update volume_pump.dm

* Update pump.dm

* Update passive_gate.dm

* Update outlet_injector.dm

* Update outlet_injector.dm

* Update outlet_injector.dm

* Update passive_gate.dm
2020-04-06 19:34:05 -04:00
Jordan Brown
833446fd1f Merge pull request #50420 from ArcaneMusic/slowerprocessing
Properly removes the leftovers of the gene modifier from the techtree.
2020-04-06 19:33:35 -04:00
Jordan Brown
1ca4502644 Merge pull request #50378 from antropod/medigel-skins
New skins for medical gels
2020-04-06 19:28:38 -04:00
tmtmtl30
c63971d50f adds monkey cube suicide (#50125)
* monkey cube suicide

* fuck

i used True instead of TRUE

* fixes indentation

it returned early

* adds delay

stops suicide from being instant

* fixes visible_message

it was called on src, which was qdeleted

* removes disfiguration

now everyone can see what you've done

* revises suicide

adds qdeleted checks, switches to do_after, hides cube

* commit suggestion #1

it is what it is

Co-Authored-By: Jordan Brown <Cyberboss@users.noreply.github.com>

* commit suggestion #2

i'm just going to assume this works and if travis yells at me that'll be how it goes

Co-Authored-By: Jordan Brown <Cyberboss@users.noreply.github.com>

* switches sleep call to timer + callback

splits off the end of the suicide into a finish_suicide proc

* monke

i typed "monkecube" instead of "monkeycube". this fixes that

Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
2020-04-06 19:23:52 -04:00
Kyle Spier-Swenson
8a9a6c3f49 [s] Fixes unsanitized input for Bluespace Navigation Gigabeacon (this time without unrelated changes to hold it up) (#50441)
closes #50435
2020-04-07 09:35:15 +12:00
Rohesie
0738549b5b Client loss on Login() handling (#50073)
The client variable can be nulled at any point between proc calls during Login(), at the very least between parent calls for sure. That can produce dirty additions to mob lists among other less problematic runtimes.
This attempts to handle it.
2020-04-07 08:13:38 +12:00
Jordie
2fe48855c8 Basic pagination for library visitor console (#50427)
Fixes #45284

Some simple pagination for the library visitor console to stop it from hanging the server by trying to retrieve too much data.

The UI hasn't been made any better, I just wanted to stop us needing #49065 to be testmerged indefinitely. I went into this thinking I'd improve the UI and code but that was before I had read any of it and lost my motivation.

Bonus points for this code having allowed unsanitized arbitrary queries for at least 10 years.
2020-04-07 08:11:16 +12:00
necromanceranne
09831566b2 Bags of Holding: Rarity Edition (#50290)
* Bags of holding require a bluespace anomaly to create.

* now it uses a recipe aw ye
2020-04-06 15:58:47 -04:00
itseasytosee
4522ff45f5 + (#50403) 2020-04-06 15:31:13 -04:00
Rob Bailey
c20a04543b Port of Replays from Yogstation (#48579)
* demos (ported from yogstation)

rustg update + write with no format

use external hook for logging

use proper log vars

fix + clarifying comment

don't start the log

release build of rust-g

fix something caught by the lint

Update code/__DEFINES/subsystems.dm

Co-Authored-By: Jordan Brown <Cyberboss@users.noreply.github.com>

Update code/controllers/subsystem/demo.dm

Co-Authored-By: JJRcop <jrubcop@gmail.com>

Update code/controllers/subsystem/demo.dm

Co-Authored-By: JJRcop <jrubcop@gmail.com>

moves hooks out of a dedicated file

len = 0 to Cut(), remove semicolons

untyped loop

* updated rust_g

* 513 updates
2020-04-06 13:15:48 -04:00
Timberpoes
bf6039215e tgui: DNA Console Overhaul Project (#50225)
* Initial work on tgui conversion for DNA Consoles

* Some initial button logic complete

TODO: Scanner Open button should disable while scanner is locked
TODO: Scramble DNA should disable while on cooldown

* Tabs for the tab God

* Dropdown changes, genetic sequencer modifications

* Mutation and genetic sequencer functionality

Almost complete. Need to implement Advanced Injectors still.

* Mostly done, converted most of genetic makeup code

* Tactical pocket linting

* More changes

* Everything except advanced injectors complete

* First complete alpha version

* Fixed debug/testing change

* Removal of more debugging code

* Fix pulse bug

* Bugbusters

* Fix for accidental changes

* Fix broken genetics disk changes, fix list of lists

* Squash tgui tab-key bugs and clean up attackby

* Code documenting, refactoring, bugfixing, spellcheck

* Documentation and misc bug squashes and runtime error fixes

* Fixes, features and tweaks

* Special check for those who have shuffled off this mortal coil

* New interface concept for console storage

* Mini code refactor

* Massive refactoring of DnaConsole interface (WIP)

- De-spaghettifying of LawyerCode
- Fixed the flex-basis bug, and removed ForcedBox since it's no
longer needed.
- Added a Divider component.

* Implemented requested changes.

Removed list() versions of strings.
Removed used TGUI-exclusive constants from data object. Currently unused ones still remain, can be removed if they're no longer necessary.
Fixed other DM data structures to serialise as JS Arrays instead of Objects.
Minor TGUI logic fixes for various edge cases.
Added some comments in DnaConsole.js outlining some minor notes and TODOs.

* Fixes "Save to X" being disabled.

* Included 2px outline CSS

* Additional minor logic patches

Don't want certain buttons active unless the mutation relation to them is also active

* Makes these transforms use a timer

* Fixed transformation race condition and stuff.

* Mutation source defined in DM. Conditional formatting improvements.

* Custom cache directory with BYOND_CACHE env var

* Fix gene cycler on index of -1

* Framework and TODO for next interface element. Cleared TODO list a bit.

* Fix 1px shift in gene cycle buttons

* Pass raw event with GeneCycler

* More robust combining logic

* Fix some cycler bugs, start working on enzymes

* Conditional highlighting for unsolved mutations and X'd genes.

* Lint for the Lint God

* Enzyme UI and more refactoring incoming

* Finish tgui refactoring, enzymes injectors done

* Whack-a-Bug

* Unlinted. Advanced injectors moved and improved. Implemented disk genetic data readout.

* Partial linting

* Assorted bug fixes

* Remove debugging code

* DNA Consoles are now more conversational. Initial state set.

* Final tweaks, implemented mutation combining, complete?

* Fixes tooltop, re-enables delayed enzyme transfer, cleans up some data params

* 10 Fix a bug, 20 make a bug, 30 goto 10

* The definition of irony

* Don't drink and derive, kids || How I learned to stop coding while drunk and rely on stylemistake to Flex on my formatting.

* uniqBy

* Add support for dropdowns with disabilities.

* Cleanup

* Remove current mutation from combinations

* Dividing

* Document BYOND_CACHE env var

* Outline cleanup

* Declare radiation constants since they were removed in DM

* Combine mutations only after checking for null

* Advanced Injectors actually work now.

* Comment cleanup, DMDOC, stard and end processing at appropriate times

* Pressing Ctrl-S occasionally helps things

* Fix enzyme mutator timeout bug, added injector timeout display.

* Rebuild tgui

* Rebuild tgui

Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
Co-authored-by: spookydonut <github@spooksoftware.com>
2020-04-06 19:00:19 +03:00
spookydonut
1fd8692738 Merge pull request #50407 from Timberpoes/defibfix
Fix defib mount runtime error.
2020-04-06 21:08:58 +08:00
spookydonut
de996f7cc3 Merge pull request #50388 from necromanceranne/scarp_cleanup
Just some small fixes for scarp
2020-04-06 17:52:47 +08:00
Timberpoes
3767bee2b2 Correct get_cell() 2020-04-06 10:47:47 +01:00
Timberpoes
4f0dae9942 Every day's a school day 2020-04-06 10:44:56 +01:00
necromanceranne
587edddf82 yeeeeep
Co-Authored-By: spookydonut <github@spooksoftware.com>
2020-04-06 19:42:07 +10:00
Akrilla
2cd1bb7cb8 XSS fix (#50429) 2020-04-06 02:33:54 -07:00
Timberpoes
02b2442e73 Replace all instances directly accessing the defib cell with the defib's get_cell() proc 2020-04-06 10:31:31 +01:00
Timberpoes
b4f042557b Fixes the underlying problem properly 2020-04-06 10:20:08 +01:00
spookydonut
0f304ca016 Merge pull request #50380 from LemonInTheDark/staring-at-the-void
Outlaws negative molar counts
2020-04-06 17:01:33 +08:00
spookydonut
5cb83ce64e Merge pull request #50401 from Mickyan/curtain_opaque
Makes certain curtains block your view when closed, new curtain type
2020-04-06 16:52:36 +08:00
spookydonut
bbc9d7bfe1 piggybacks and fireman carry doesnt work on not aggrograbs (#50386) 2020-04-06 16:50:55 +08:00
Tad Hardesty
e699211c8a Fix editor icon state of layer 3 cables (#50400) 2020-04-06 16:50:20 +08:00
ArcaneDefence
c3a65e551d Strange reagent with slimepeople bugfix (#50408)
* h

* eol
2020-04-06 16:43:59 +08:00
Timberpoes
b3b196aca8 Guns that init with magazines now start chambered with full magazines (#50410)
* Guns that init with magazines now start chambered with full magazines

* I somehow screwed up a one word fix.
2020-04-06 16:40:35 +08:00
zxaber
4d3ae6a68c Adds a Cyborg Remote Monitor program for modular computers. (#50389)
* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* tablet good

* forgot something

* restoring what was lost

* hoping for the best

expecting the worst

* Why review when you can edit in place?

* Additions and fixes

* Here's hoping

* Why is this still here?

Co-authored-by: Changelogs <action@github.com>
Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
2020-04-06 11:18:10 +03:00
cacogen
6298203cf0 Material wall/floor and floor tile name/desc changes (#50203)
* Renames material "plating" to floor, changes material wall desc to match regular walls

* floor tile

* Custom descs for walls and floor tiles based on material

* material tile throwforce 1 -> 5

* switch order of material flags on material tile

* Removes material flag and check

- Simplifies floor tile desc throwforce check

* Moves the throwforce message to examine()

* Gives more nuance to tile throwforce examine() messages

* Simplifies tile examine throwforce code

- Fixes problem with radioactive item examine of outputting a single period when too far away
- Adds spans to tile throwforce examine and radioactive item examine

* logic 10

Co-Authored-By: Rohesie <rohesie@gmail.com>

* Adds throwforce message to examine return

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-04-05 21:31:42 -03:00
Qustinnus
5f8233037c Families wanted stars now only show up when you are involved in it, and announcements for wanted level changes (#50283)
* Wanted level stuff

* fuck

* Update code/game/gamemodes/gang/gang.dm

Co-Authored-By: Rohesie <rohesie@gmail.com>

* Update code/_onclick/hud/families.dm

Co-Authored-By: Rohesie <rohesie@gmail.com>

* Update code/game/gamemodes/gang/gang.dm

Co-Authored-By: Rohesie <rohesie@gmail.com>

* Update code/modules/antagonists/gang/gang.dm

Co-Authored-By: Rohesie <rohesie@gmail.com>

* Update code/modules/antagonists/ert/ert.dm

Co-Authored-By: Rohesie <rohesie@gmail.com>

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-04-05 21:27:11 -03:00
Ghilker
5d64a90618 Hot ice fix (#50353)
* fixed the burning oh the sheets

* finish touches

* properly fixes the hot ice component

* runtimes are bad

* Update code/game/objects/obj_defense.dm

Co-Authored-By: Rohesie <rohesie@gmail.com>

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-04-05 21:06:45 -03:00
TiviPlus
b6711991f7 I fix a thing noone wants fixed but the orang man (#50384) 2020-04-05 19:13:46 -04:00
ArcaneMusic
624e5ed1c8 Whoops. 2020-04-05 19:07:14 -04:00
Akrilla
37f9ba480e Fixes resting and small projectile change (#50348)
About The Pull Request

Fixes resting so you're now not dense - can fit inside containters etc. Projectiles also once again hit resting players, but will pass through corpses. If you're not able to move, use items, or stand, or you're just dead, bullets go over you.
Why It's Good For The Game

Fixes #50332
Fixes #50322
Fixes #50236
Fixes #50076
Fixes #50370
Changelog

cl
fix: Fixes resting and projectiles.
/cl
2020-04-06 10:20:41 +12:00
RiskySikh
93b61be2c9 fixes a mispelling in taste description for lean #50309
About The Pull Request

It's nothing major, its just fixes a spelling mistake for the taste description. I accidentally put opoid instead of opioid.
Why It's Good For The Game

Just a minor fix, it just fixes a spelling mistake for lean.
Changelog

cl
spellcheck: fixes a spelling mistake in taste description for lean
/cl
2020-04-06 10:19:12 +12:00
Arkatos1
ecb197bcbf Mining and Service borgs now use a radial menu to choose their skins (#50310)
About The Pull Request

This PR makes Mining and Service cyborgs use a radial menu to choose their module skin, instead of swimming in the input menu with no preview of how given skin even looks like.

Example image:

RadialMining
Why It's Good For The Game

Better cyborg skin choosing method.
Changelog

cl Arkatos
add: Mining and service borgs now use a radial menu to select their module skins.
/cl
2020-04-06 10:17:47 +12:00
Fikou
7138c067fd laughter demons now use the honk demon sprite on april fools (#50341) 2020-04-06 10:16:34 +12:00
Ryll Ryll
49970407fa Buffs the circle game, adds an achievement (#50145)
About The Pull Request

Examining someone holding a circled hand from using the *circle emote while next to them can now alert said person, and if you don't act fast, they'll bop you! You'll have a split second to move away before this happens. Losing the circle game to a hulk will result in a very forceful bop.

Bopping someone will award an achievement, "HA, GOTTEM"

Also adds COMSIG_PARENT_EXAMINE to carbon and human's examines, cause they never had that set, and adds TRAIT_HULK to being hulk since I forgot to actually give it its own trait when I added said trait in another PR
Why It's Good For The Game

Enhances pranking. It's honestly amazing to me that this functionality wasn't built in when this was first made.
Changelog

cl Ryll/Shaps
add: The *circle emote now has additional functionality! Go prank your friends!
/cl
2020-04-06 10:12:08 +12:00
Tetr4
9c127ed56c [READY] Passive vents still mix gases when pressures are equal (#50150)
* Add remove_specific helper proc to gas_mixture.dm

Removes moles of a specific gas type from a gas mix

* Passive vents use individual partial pressures

* gas_list list operators

* KISS

* Remove unused var

* Remove unneeded holding gas mixutre

* Only gc specific gas_id in remove_specific

* Fix missed structure change

* Add remove_specific comments

* Remove extra spaces

* Add gas_mixture equalize proc

* Change passive vent to use equalize()

* Improve equalize comment

* Fix equalize partial pressure if check

* no magic numbers
2020-04-05 18:03:03 -03:00
Mickyan
218dc6f6af crafting 2020-04-05 15:36:39 +02:00
spookydonut
e13539a4c5 Update to spacemandmm 1.4 (#50405)
* Update to spacemandmm 1.4

* Now at 513.1514
2020-04-05 19:37:18 +12:00
zxaber
5f3220f2ad Clarke mech now damages floor tiles (#50141)
* rip and tear (the floor)

* whoops

* Update code/game/mecha/working/clarke.dm

Co-Authored-By: Rohesie <rohesie@gmail.com>

* Update code/game/mecha/working/clarke.dm

Co-Authored-By: Rohesie <rohesie@gmail.com>

* better good

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-04-05 04:36:58 -03:00
ATH1909
84e24d5872 Makes Clown Ops Great Again (#50105)
* clown op fixes

* description shortening

* fixes the locations of some items

* fuck off, travis

* Update code/modules/uplink/uplink_items.dm

Co-Authored-By: Rohesie <rohesie@gmail.com>

* removes one comma

* web edit web edit

* removes fun

* reduces the number of checks for user.mind

* clown ops can buy chameleon kits again

* Update code/modules/projectiles/pins.dm

Co-Authored-By: Rohesie <rohesie@gmail.com>

* accidentally deleted a comment

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-04-05 04:32:23 -03:00
Timberpoes
4835c1128e Guard against null comparisons 2020-04-05 05:07:15 +01:00