Commit Graph

7 Commits

Author SHA1 Message Date
tattle
aeed75d72f Combined soundadd/sounddel and imageadd/imagedel (#74865)
## About The Pull Request
Combines
```
soundadd: added a new sound thingy
sounddel: removed an old sound thingy
```
into "sound," and
```
imageadd: added some icons and images
imagedel: deleted some icons and images
```
into "image" in the changelog. 

I don't think we need to have both; `sound` and `image` can represent
any kind of change to their respective medium.

---------

Co-authored-by: tattle <article.disaster@gmail.com>
2023-04-21 13:10:26 -06:00
Mothblocks
0576bad2b1 Fix flaky test report bot (#72942)
It's `includes` in JavaScript, not `contains`. Not sure how I missed
this one
2023-01-24 10:49:00 -08:00
Mothblocks
400dec78d1 Fix rerun flaky tests expecting a prefix that is not there (#71627) 2022-11-30 01:12:24 -08:00
Mothblocks
4552de36fa Rerun flaky tests automatically, and create issue reports for them (#71519)
Adds a new workflow that will try to automatically detect and rerun
flaky tests, and create an issue report for them.

The detection mechanism is heuristic: if exactly ONE job fails in the CI
Suite, then it is assumed to be flaky, and will be rerun. If the next
run succeeds, then it will create an issue report for that flaky test if
one does not already exist. It will do its best to create a unique but
consistent identifier, aided by PRs like #71515. You can find an example
here: https://github.com/Mothblocks/ss13-workflow-testing/issues/20.
Maintainers can also rename the issue if they wish, it will still be
able to find it.

While there is a chance for this mechanism to go wrong and create bogus
issue reports, it IS possible to easily disable actions, I did it for
the stale one just a bit ago. Most likely, this mechanism going wrong is
going to be the result of randomness leaking in tests, like random human
names, so this can be solved in the tests themselves. I find it
extremely unlikely, but in the worst case scenario where this happens
often, we can add a way for maintainers to edit the issue report and
include a regex to match for runtimes. Just an idea.

Includes a few large-ish downloaded logs from past failures that are
interesting in unique ways. These are used for tests of the title
generator.
2022-11-30 16:50:13 +13:00
san7890
cf59b0bba1 Null-checks PR Body in removeGuideComments (#71043)
This is what #71041 was supposed to be.

## About The Pull Request
Hey there,

I was looking at #71028, and I noticed that this workflow failed because
oranges left the PR body blank. I think that's silly, so let's just
include an early return so the whole thing doesn't throw.

This is the error:


![image](https://user-images.githubusercontent.com/34697715/199852746-24b2ed53-442d-4c40-b81d-902236183328.png)
via:
https://github.com/tgstation/tgstation/actions/runs/3382875608/jobs/5618241641

Here's an example PR where I fixed it (on my fork, just expand the
"Remove guide comments" step):
https://github.com/san7890/bruhstation/actions/runs/3389994395/jobs/5633658300

## Why It's Good For The Game

It hurts my heart to see checks red out in trivial situations like this.
## Changelog
Literally nothing here concerns players.

Ignore the commit history I was testing this PR the wrong way and was
effectively gaslighting myself (we're good now though)
2022-11-04 01:26:43 -07:00
Mothblocks
acd034f967 Remove guide comments action (#70739)
Removes all default comments after a PR is opened (and only when it is opened).

Means that I can turn on the pr body merge option without keeping all the cruft
2022-10-30 01:46:48 -07:00
Mothblocks
8bb8ca9d67 Move auto changelog generation into its own workflow (#70652)
I wanted to move auto labeling into its own workflow, but realized that it and changelog generation were coupled. So I'm detaching that first, and then will work on auto labeling later. Includes general code for a changelog parser so that I can reuse it by that point.

GitHub actions are great for downstreams, as setting up a PHP server for the webhook is not trivial, compared to Existing and getting it for free. They are also much more straightforward to test and update than the webhook. I was able to verify this was working trivially with an empty repository.

Tested and working: Mothblocks/ss13-workflow-testing@0a2de4d
2022-10-27 16:52:32 +13:00