* Prevent players who get booted back to the lobby on shiftstart from getting broken antag status on latejoin (#59377)
* Prevent players who get booted back to the lobby on shiftstart from getting broken antag status on latejoin
* Mirrored
* oop
Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Co-authored-by: Funce <funce.973@gmail.com>
* Stops carpotoxin from removing temporal scars. (#59382)
# About The Pull Request
Hopefully simply removes the feature of carpotoxin where it deletes temporal scars.
# Why It's Good For The Game
We already have a "Clear Slots" button in the character setup window that lets you delete temporal scars for the given character. This is just meant to prevent accidental scar removals so people don't lose them by, for example, accidentally drinking a spiked drink.
* Stops carpotoxin from removing temporal scars.
Co-authored-by: rasepretep <85033934+rasepretep@users.noreply.github.com>
* Makes the surgery mask, the muzzle breathmask, not block surgeries. (#59378)
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* Makes the surgery mask, the muzzle breathmask, not block surgeries.
Co-authored-by: FlamingLily <80451102+FlamingLily@users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* Starlight condensation fixes (#59091)
Changes the criteria for starlight condensation to heal you to reflect glass (and transparent) tiles (although at the weakened rate) and multi-z stations as well as on lavaland and unroofed structures in space.
* Starlight condensation fixes
Co-authored-by: RandomGamer123 <31096837+RandomGamer123@users.noreply.github.com>
* - fixed not being able to add telecomms frequency filters (#59350)
- changed GHz to hHz in telecomms GUI to be consistent with headset GUI
- changed color of command frequency from blue to yellow to match chat color
Co-authored-by: norill <4>
* Fixed not being able to add telecomms frequency filters
Co-authored-by: norill <norill@wp.pl>
* Fixes AND/OR gates ignoring a port if it has a null value but it is still connected to another port (#59348)
Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
* Fixes AND/OR gates for Integrated Circuits
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
* makes invisible powder white (#59356)
messing with alpha made you invisible and it didn't wash off
* Restores old mime crayon functionality
Co-authored-by: RaveRadbury <3204033+RaveRadbury@users.noreply.github.com>
* Fixes cigarettes making you so lame that they spill the spaghetti from your pockets (and also keep falling off) (#59352)
Wack
Fixes#59342
Changelog
🆑
fix: Smoking no longer spills spaghetti from your pockets
fix: Lit cigarettes no longer keep falling off
spellcheck: Removed extra "the" from item knockdown messages
/🆑
* Fixes cigarettes making you so lame that they spill the spaghetti from your pockets (and also keep falling off)
Co-authored-by: Mickyan <38563876+Mickyan@users.noreply.github.com>
* fixes bug with holodecks referencing self deleting atoms in spawned (#59355)
decals were hard deleting whenever you loaded a holodeck program with them because it wasnt taking them out of the spawned list, now it does that. also goes around holodeck code and changes for loops to as anything and puts in better var names.
also since its been a while since i looked at holodeck code, the thing could really use a better rewrite one of these days.
* fixes bug with holodecks referencing self deleting atoms in spawned
Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
* Adds a unit test for icon states on GAGS items and fixes some inhand sprites (#59330)
This adds a unit test which goes through all items and makes sure all the icon states needed are in the greyscale configurations, if it has one.
* Adds a unit test for icon states on GAGS items and fixes some inhand sprites
Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com>
* Fixes human burgers not naming after the meat donor (#59286)
- Adds custom materials to result of grilling
- Adds custom materials to result of atom processing
- Adds source name and job to mob_meat material if available
- Makes processed atoms have same pixel offsets as their source but randomise with each subsequent one
* Fixes human burgers not naming after the donor
Co-authored-by: cacogen <25089914+cacogen@users.noreply.github.com>
* Fixes runtimes related to forensic components on deleted things. (#59315)
* Fixes runtimes related to forensic components on deleted things.
Co-authored-by: AnturK <AnturK@users.noreply.github.com>
* Stops giving you organ damage messages if you arent conscious (#59311)
* Stops giving you organ damage messages if you arent conscious
Co-authored-by: skoglol <33292112+kriskog@users.noreply.github.com>
* Fixes an issue in how processing is done for gas leaks (#59322)
Couple issues fixed that were found in testing along side the stationary canister rework. Not sure how I missed this but I should have done thorough testing again after changing the processing list used after I had finished an earlier round of testing.
I don't think it will have any visible effects? Just runtime and hard dels.
How did I miss this
* Fixes an issue in how processing is done for gas leaks
Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com>
* [READY]Updates knockoff component and adds it to prescription glasses (#59006)
* [READY]Updates knockoff component and adds it to prescription glasses
Co-authored-by: Mickyan <38563876+Mickyan@users.noreply.github.com>
* Some associated move fixes (#59299)
* Moves the loc assignment for null doMove target locations to before exited() is called, making it consistent with other uses of the proc, and fixing a harddel caused by deleting something inside of an open storage component. The component assumes that the removed object has already exited its contents, and so readds it to the screen, causing PAIN
Co-authored-by: Kylerace <kylerlumpkin1@ gmail.com>
* Some associated move fixes
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: Kylerace <kylerlumpkin1@ gmail.com>
* Prevents a forced qdel from fucking with things that expect more then one arg from Detach() (#59303)
* Fixes fucked behavior with forced qdels and complex detach elements
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
* Fix jatum (#59048)
Jatum was not hanling non assoc list very well, due to a try not throwing an error like it should. This fixes that
Note that jatum still cannot be 100% trusted with datum serialisation, as it bugs out in this specific case:
datum/a
var/datum/b/a_datum
var/list/datum/b/a_list_of_datum_b
if a_datum is in a_list_of_datum_b, jatum will not correctly deserialise the full list (as the reference is already seen)
The fix was tested for : https://github.com/tgstation/TerraGov-Marine-Corps/pull/6599
* Fix jatum
Co-authored-by: BraveMole <bsouchu@gmail.com>
* Makes canister leaking and blowing up use a component and element respectively (#59075)
I want to use this behavior on some other things so into a component and element it goes. Gas leaking is handled by a component so it can process whereas the object breaking and causing an explosion is handled by an element. Some minor changes were made so canisters were more consistent in leaking.
* Makes canister leaking and blowing up use a component and element respectively
Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com>
* Makes washing machines support GAGS recoloration (#59292)
* Makes washing machines support GAGS recoloration
Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com>
* I hate TGUI even if its better than what we had before
* this is why linters exist
* you need to be a Head or the Warden to get items
* does this please you linter?
* foundation
* basic interactions
* yea I can spell okay?
* linters please leave me alone
* begone debug code
* if you are dead, no interacting
* linters leave me alone
* linters are stealing my soul
* forgot to do this
* sound framework, probably wont work though
* max length, and interaction cooldowns
* message can now be a list and minor code improve
* I am a slave and linters are my master
* fix improper static reference
* add json loading/saving functionality
* default for message is now a list
* jsonize def interactions; implement requirements
* bad
* bug fix; CtrlShiftClick to interact
* minor qol fix
* fix CtrlShiftClick and remove debug code
* haha docker has security measures
* this was painful
* why are you in this branch
* begone
* bruh
* begone
Co-authored-by: Matthew <matthew@tfaluc.com>
Co-authored-by: Matthew J <GoldenKeyboard@users.noreply.github.com>
* Makes greyscale configs check for a name and output more errors at once (#59271)
* Makes greyscale configs check for a name and output more errors at once
Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com>
* use SIGNAL_HANDLER REEEEEE (#59242)
makes as many procs as i can find use the SIGNAL_HANDLER define which i assumed they all already did
* USE SIGNAL_HANDLER REEEEEE
Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
* Fixed backpack firefighter tank nozzle refilling not working in extinguisher mode (#59216)
Also removed useless local var from /obj/item/extinguisher/proc/AttemptRefill
* Fixed backpack firefighter tank nozzle refilling not working in extinguisher mode
Co-authored-by: norill <norill@wp.pl>
* Slaughter demons use right-click to Slam rather than CtrlShiftClick (#59225)
Moves the slam function of slaughter demons to right-click rather than have it use Ctrl+shift+click.
* Slaughter demons use right-click to Slam rather than CtrlShiftClick
Co-authored-by: SgtHunk <68669754+SgtHunk@users.noreply.github.com>
SkyratBot