* Fixes typos in span, other html elements (#63510)
Atomizes a much larger PR for another time...
There are typos in span and other html messages that causes them to not render correctly or at all.
Bug fixes
Converts those instances of span to use the macro
* Fixes typos in span, other html elements
Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
* Field of View and Blindness improvements [bounty + upstream push]
* Update death.dm
* almost done
* Update fov_handler.dm
* Face mouse when in combat mode, fix
* Fixes the category for the fov admin verb. #63401
* Fixes objects with bad planes and FoV bugs #63412
* pain
* there we go
* face pref
Co-authored-by: Azarak <azarak10@gmail.com>
* Basic mobs can be sentience & mind transfer potioned. + simple access component (#63116)
* Basic mobs can be sentience & mind transfer potioned. + simple access component
Co-authored-by: Krysonism <49783092+Krysonism@users.noreply.github.com>
* TGUI input box conversions 2 (#63395)
More text inputs converted to tgui, TGUI text and number input now more sanely handles ENTER key being pressed, you can now press anywhere in the window to enter the input. TGUI text input now considers placeholder text for the default valid state. IE, if there is default text you can press enter immediately without having to rewrite it just to recheck validity. Fixes: useSharedState => useLocalState. not only was sharedstate not needed but it opened up the ui to vulnerabilities
* TGUI input box conversions 2
Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
* Fixes exploded circuit shells attempting to remove a deleted circuit (#63268)
Fixes a runtime that would occur when a circuit shell was inflicted with a devastating explosion and the shell attempted to remove the circuit after it had been deleted.
* Fixes exploded circuit shells attempting to remove a deleted circuit
Co-authored-by: TemporalOroboros <TemporalOroboros@gmail.com>
* Make USB cables attached to locked circuits unable to be modified (#63084)
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* Make USB cables attached to locked circuits unable to be modified
Co-authored-by: RandomGamer123 <31096837+RandomGamer123@users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* Makes the edible component not runtime due to connect_loc_behalf when applied to turfs (#63232)
This makes it so it stops trying to use connect_loc_behalf if the parent of the edible component is a turf, just registering the signal normally instead, which should hopefully be the same functionality.
Runtimes are bad, and even if there's not really any relevant use of that proc in most cases, this is to future-proof things anyway.
* Makes the edible component not runtime due to connect_loc_behalf when applied to turfs
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
* Wethide now dries into leather after burning and grilling (#63198)
You can now dry wet hide (obtainable by skinning and wetting goliath plates or other animal hides) into leather by lighting it on fire (with a bonfire grill especially, though the heat of being on fire will dry it regardless of the origin of the fire)
This also means that ashwalkers will be able to obtain leather without getting power, since drying racks require power, which, as shown in #63195, is apparenly intended and not a bug.
* Wethide now dries into leather after burning
Co-authored-by: Bond <58570888+TheBonded@users.noreply.github.com>
* Fixed spelling of possession, separate, and cemetery (#63203)
Just fixes some spelling for gangs. I also fixed misspellings for "posession" to "possession". Fixed "seperate " to "Separate" Fixed "Cemetary" to "Cemetery"
* Fixed spelling of possession, Separate, and Cemetery
Co-authored-by: Doctor Pope <84367152+Dr-Pope@users.noreply.github.com>
* fullauto now checks for incapacitated instead of stat (#63083)
* fullauto now checks for incapacitated instead of stat
* Fixes our own fullauto
* Tabs indentation moment
Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
* Stops the riding comp from overriding the glide of the parent each time they move and not only when they are ridden/driven. (#63048)
* Stops the riding comp from overriding the glide of the parent each time they move and not only when ridden/driven.
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
* Refactor cult dagger rune drawing and null rod rune clearing into components + minor rune / blood magic tweaks (#62918)
The act of inscribing runes, anchoring / unanchoring cult structures, deconstructing cult girders, and purging cultists of holy water have all been moved off of the cult dagger itself and onto a component, cult_ritual_item.
The act of destroying a cult rune or heretic rune with the null rod have been moved off of their respective items and onto the nullrod itself.
Added a signal, COMSIG_ITEM_ATTACK_EFFECT, for the above purposes.
Various cult spells and dagger interactions have had their code improved slightly.
* Refactor cult dagger rune drawing and null rod rune clearing into components + minor rune / blood magic tweaks
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
* fix message spam for atmos construction (#62796)
About The Pull Request
partial fix to #62783
the check was never meant to have feedback messages added in it because it runs every UI tick. Added the message as additional requirement text.
GBP no update please
Why It's Good For The Game
fix
Changelog
cl
fix: fix message spam for manual pipe crafting
/cl
* fix message spam for manual pipe crafting
Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com>
* Allows shells that requiring anchoring to take power from APCs (#62907)
Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
* Allows shells that requiring anchoring to take power from APCs
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
* Replacing more C-style for loops with the faster, traditional ones. (#62908)
* Replacing more C-style for loops with the faster, traditional ones.
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
* Makes the "Ian's Adventure" station trait more interesting by making the dog deadchat controllable plus extra lives. (#62617)
About The Pull Request
Makes the "Ian Adventure" station trait more interesting by giving him deadchat control (democracy mode, 3 seconds cooldown on inputs) and a couple extra lives* to survive early round tiding.
*Basically, a new component that respawns the critter when he dies. The component itself is simple enough, but it sends a signal each respawn to allow other datums to expand this behavior how they want. I've contemplated adding a signal that can stop death, dusting and gibbing instead of respawning the mob at first but because death(), dust() and gib() were made with the assertion that the mob is always going to die I've quickly realized it'd require a refactor that's way too big and out of scope.
The deadchat control of corgis only include commands to change and drop hats, "speak" (random lines from the speak list of the mob) and spin (other than cardinal movement) for now. I'd have loved to add more complex commands (like, argumented) that can potentially be relayed to the AI controller, but I guess that'll have to wait until the thing gets refactored a little.
Why It's Good For The Game
"Ian's Adventure" is a really bland station trait at the moment. All it does is move Ian somewhere else at the start of the round. Even by the station traits standard of being small things this is insignificant, and also pretty bad considering Ian is not actually going on an adventure since he lacks the initiative to do anything being an npc dog.
This PR aims to breath fresh air into this station trait and push it toward a slighty more engaging direction, though it relies on observers to work, while still being a small """"cute"""" station trait.
Changelog
cl
expansion: The "Ian's Adventure" station trait now makes Ian deadchat controllable and gives him a couple extra lives (to survive early round tiding)
/cl
* Makes the "Ian's Adventure" station trait more interesting by making the dog deadchat controllable plus extra lives.
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
* EFT
* E
* EEE
* E
* INTO TO ORBIT
* I hate this but I'm going to ignore it.
* Seriously, fuck this.
* Update CentCom_skyrat_z2.dmm
* Update tgstation.dme
* oops
* Update positronic_alert_console.dm
* E
* Allow manual crafting of many atmos devices with the crafting menu (#62676)
* Allow manual crafting of many atmos devices with the crafting menu
Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com>
* Made admin circuits more abstract, they no longer end up in the contents of the shell. (#62630)
Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
* Made admin circuits more abstract, they no longer end up in the contents of the shell.
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: Watermelon914 <3052169-Watermelon914@ users.noreply.gitlab.com>
* Spirit holding component won't let you awaken another spirit until it's done (#62340)
* Spirit holding component won't let you awaken another spirit until it's done
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
* Blind can now smell what the Oven is cooking. Plus punctuation. (#62538)
* Blind mobs can now smell what the oven is cooking. Plus punctuation.
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
* [s] Fixes an exploit that allowed players to spawn arbitrary paths (#62561)
* [s] Fixes an exploit that allowed players to spawn arbitrary paths
Co-authored-by: CocaColaTastesGood <47264839+CocaColaTastesGood@users.noreply.github.com>
* Modernizing Radiation -- TL;DR: Radiation is now a status effect healed by tox healing, and contamination is removed
* Fixing conflicts
* Makes it compile, yeet all the RAD armor from everywhere (thanks RegEx!)
* Removing more lingering rad armor (woo)
* Damnit powerarmors
* Bye bye rad collectors!
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
* Refactor /turf/var/intact (#62331)
Turfs have a variable, intact, which conflates three meanings:
Determining whether there's something that can be pried out, such as directly with a crowbar or indirectly with a tile stack and a crowbar off-hand.
Determining whether underfloor pieces are visible.
Determining whether underfloor pieces can be interacted with - by players with tools, through interaction with effects like chemical acid, or foam.
When plating is hit with a stack of tiles, /turf/open/floor/attackby checks whether the turf is intact, and if so, ends the attack chain regardless of whether or not the attempt to hotswap a turf (with a crowbar) is successful or not. However, turfs which want the underfloor to be visible - such as catwalks and glass - set the intact variable to FALSE, and so can be repeatedly placed over one another, as if they were the first tile to be placed over the plating.
This refactors /turf/var/intact into two distinct variables:
/turf/var/overfloor_placed, for whether or not there is something over plating.
/turf/var/underfloor_visible, for whether or not the various underfloor pieces should be invisible, visible, or both visible and interactable.
All references to /turf/var/intact have been replaced with an equivalent overfloor_placed or underfloor_visible reference, depending on which check is appropriate. underfloor_accessibility can take one of UNDERFLOOR_HIDDEN, UNDERFLOOR_VISIBLE, or UNDERFLOOR_INTERACTABLE. This prevents cases such as acid foam or tools phasing through glass floors to affect the underfloor pieces underneath, and covers all kinds of unusual, not-wiring-visiblity usage such as Holodeck completeness, Revenant interaction, or station integrity checking.
* Refactor /turf/var/intact
* Thank
Co-authored-by: esainane <esainane+github@gmail.com>
Co-authored-by: Funce <funce.973@gmail.com>
* removes double spaces before symbols (#62397)
This can apparently cause some bugs on occasions, so I thought I might as well try to kill them all.
* removes double spaces before symbols
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
* removes some ways of making unvaredited custom callbacks (#62345)
* [s] removes some ways of making unvaredited custom callbacks
Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
* Adds a cool pair of salesman shades to the maintenace loot pile (#62141)
Adds a pair of tinted glasses to the maintenance loot pool that has a unique effect when the wearer is at low sanity. Also adds a signal that sends the sanity amount of a mob every time SetSanity is called.
* Adds a cool pair of salesman shades to the maintenace loot pile
Co-authored-by: MMMiracles <lolaccount1@hotmail.com>
* Refactor rolling paper to use customizable reagent holder (#61758)
The component can accept dryable items and food items now. Any instance of the component can be set to use dryable items, just like normally food items are used. To add the dryable item, it's the same as with food. You attack with the item in hand. I am currently thinking about more uses for dryable items and also more ways the component can be used.
* Refactor rolling paper to use customizable reagent holder
Co-authored-by: Jack LeCroy <3073035+jacklecroy@users.noreply.github.com>
* Broken Secways will say it's broken, rather than the component. (#62096)
changes it from
"/datum/component/riding/vehicle/secway sputters and refuses to move!"
to
"The secway sputters and refuses to move!"
* Broken Secways will say it's broken, rather than the component.
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
