Commit Graph

32226 Commits

Author SHA1 Message Date
SkyratBot
f2a4eed6a3 [MIRROR] Fixes Wild Mutation produce being the wrong size. (#473)
* Wild Mutation produce is now the right size. (#53104)

* Fixes Wild Mutation produce being the wrong size.

Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
2020-08-23 20:21:27 +02:00
SkyratBot
d59b60d019 [MIRROR] Fixes invasive spreading not updating plant tray identity. (#472)
* Fixes invasive spreading not updating plant tray identity. (#53101)

* Fixes invasive spreading not updating plant tray identity.

Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
2020-08-23 20:18:50 +02:00
SkyratBot
4943fbefa1 [MIRROR] Fixes plants potentially getting duplicate random reagents. (#471)
* Fixes plants potentially getting duplicate random reagents. (#53111)

* Fixes plants potentially getting duplicate random reagents.

Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
2020-08-23 20:18:05 +02:00
SkyratBot
de1f78d9a0 [MIRROR] Kills bonus ore from the ORM. (#470)
* Kills bonus ore from the ORM. (#53073)

This was a mistake, and I regret doing it.

* Kills bonus ore from the ORM.

Co-authored-by: Iamgoofball <iamgoofball@gmail.com>
2020-08-23 20:17:47 +02:00
SkyratBot
0b65cc596b [MIRROR] Overlay lighting component (#469)
* Overlay lighting component (#52413)

Sparks no longer lag, projectile beams move super smoothly, same with mobs and whatnot. This also allows for easy expansion into directional lights, field-of-view, wee-woo rotating lights or whatever.

It does have a downside: things right-clicked or checked through the alt+click tab will show the light overlay:


This is a BYOND limitation, very well worth it IMO.

🆑
add: Smooth movable lighting system implemented. Projectiles, sparks, thrown flashlights or moving mobs with lights should be much smoother and less laggy.
balance: Light sources no longer stack in range, though they still do in intensity.
/🆑

* Overlay lighting component

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-08-23 20:17:12 +02:00
SkyratBot
c7bc076cef [MIRROR] Jelly person body swap fix (#467)
* Jelly person body swap fix (#53090)

* Jelly person body swap fix

Co-authored-by: NightRed <nightred@gmail.com>
2020-08-22 09:30:32 +01:00
SkyratBot
ac8bf51024 [MIRROR] Moves base_icon_state to the base of atom (#464)
* to the base (#52917)

* Moves base_icon_state to the base of atom

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-08-21 22:36:33 +01:00
SkyratBot
4a62fb4557 [MIRROR] Fixes a thrown damage runtime (#465)
* thrown damage runtime (#52913)

* Fixes a thrown damage runtime

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-08-21 22:36:26 +01:00
SkyratBot
0bafb62a25 [MIRROR] Various virus fixes (#462)
* Various virus fixes (#52899)

* virus fixes

* weird parent call

* Various virus fixes

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-08-21 21:31:01 +01:00
SkyratBot
d3f6e8d49f [MIRROR] Explosions SS runtime fix + code cleanup (#461)
* Explosions SS runtime fix + code cleanup (#52894)

* runtime fix

* turf references are immortal

* Explosions SS runtime fix + code cleanup

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-08-21 21:30:43 +01:00
SkyratBot
a3b1197653 [MIRROR] Adds Plasmamen Command and Centcom suits. (#460)
* Merge pull request #53042 from GuillaumePrata/Plasmamen---Command

Adds Plasmamen Command and Centcom suits.

* Adds Plasmamen Command and Centcom suits.

Co-authored-by: nemvar <47324920+nemvar@users.noreply.github.com>
2020-08-21 21:30:34 +01:00
SkyratBot
6c71d07649 [MIRROR] Adds Time-Based Layering to Runechat Messages + Refactoring (#457)
* Merge pull request #52959 from bobbahbrown/runechat-changes

Adds Time-Based Layering to Runechat Messages + Refactoring

* Adds Time-Based Layering to Runechat Messages + Refactoring

Co-authored-by: nemvar <47324920+nemvar@users.noreply.github.com>
2020-08-21 14:24:04 +01:00
SkyratBot
7b58d32063 [MIRROR] Add an animation for shaking (#456)
* Merge pull request #52975 from Jared-Fogle/shake-animation

Add an animation for shaking

* Add an animation for shaking

Co-authored-by: nemvar <47324920+nemvar@users.noreply.github.com>
2020-08-21 14:23:30 +01:00
SkyratBot
389c4be7d4 [MIRROR] Adds policy text options for Obsessed (#455)
* Adds policy text options for Obsessed (#52962)

* Adds policy text options for Obsessed

Co-authored-by: TheVekter <TheVekter@users.noreply.github.com>
2020-08-21 14:23:18 +01:00
SkyratBot
e7e3e630bd [MIRROR] Attempts to refactor the get_equipped_item proc (#454)
* Attempts to refactor the get_equipped_item proc (#52969)

* Attempts to refactor the get_equipped_item proc

Co-authored-by: Detective-Google <48196179+Detective-Google@users.noreply.github.com>
2020-08-21 14:23:03 +01:00
SkyratBot
31e30dd4bb [MIRROR] You can now activate an away mission's exit gateway regardless of whether or not the station-side gateway is still open (#453)
* You can now activate an away mission's exit gateway regardless of whether or not the station-side gateway is still open (#53058)

* You can now activate an away mission's exit gateway regardless of whether or not the station-side gateway is still open

Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>
2020-08-21 14:22:47 +01:00
SkyratBot
63c6adf633 [MIRROR] Adds a chemical reaction to stabilize plasma (#452)
* Adds a chemical reaction to stablize plasma (#53076)

* Adds a chemical reaction to stabilize plasma

Co-authored-by: Radacitus <xrandomxmanx@gmail.com>
2020-08-21 14:22:23 +01:00
SkyratBot
a8476938b3 [MIRROR] Fix resisting not starting stop, drop, and roll (#450)
* Fix resisting not starting stop, drop, and roll (#53079)

* Fix resisting not starting stop, drop, and roll

Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
2020-08-21 14:17:11 +01:00
SkyratBot
629000e5f5 [MIRROR] Completely remove the blood contract from the game, including the blood contract antag datum. (#449)
* Completely remove the blood contract from the game, including the blood contract antag datum. (#53059)

* Completely remove the blood contract from the game, including the blood contract antag datum.

Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
2020-08-21 14:16:45 +01:00
SkyratBot
b812f42c85 [MIRROR] Makes the flow of gas overlays cleaner (#448)
* Makes the flow of gas overlays cleaner (#53028)

* Makes the flow of gas overlays cleaner

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
2020-08-21 14:16:26 +01:00
SkyratBot
6da6b33009 [MIRROR] Food refactor part 1: Bread destruction and processable element (#447)
* Food refactor part 1: Bread destruction and processable element (#53047)

* Food refactor part 1: Bread destruction and processable element

Co-authored-by: Qustinnus <Floydje123@hotmail.com>
2020-08-21 14:15:57 +01:00
SkyratBot
77abf57467 [MIRROR] Makes vv css work on local (#440)
* Makes vv css work on local (#53067)

* Makes vv css work on local

Co-authored-by: AnturK <AnturK@users.noreply.github.com>
2020-08-20 19:02:43 -04:00
SkyratBot
8c8df2d6e1 [MIRROR] Monkeys are now disarmed like humans (#439)
* Monkeys are now disarmed like humans (#53036)

Previously, monkey disarming was the old system of RNG stun/lose item. This PR makes disarming monkeys the same as disarming humans.

* Monkeys are now disarmed like humans

Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
2020-08-20 17:08:55 +01:00
SkyratBot
6ed7a17f0b [MIRROR] Arconomy Balance Pass 2: Market Tendency (#438)
* Arconomy Balance Pass 2: Market Tendency (#52974)

Price inflation is now based upon averages, and is now uncapped from 5.
Civilian budget is no longer the worst budget to pay out from.
Medical Civilian bounties are no longer chees-able in seconds.


* I'll pick this up later because it's going to need a UI with keyed lists

* Updated market crash and average inflation values.

* Alright, I'm confident now.

* Make the market crash end at the beginning of the event end

* And on the 2nd day, the lord spoke, "Compile"

* Division by zero protection.

* That should have been a max, smhing my smhead

* Arconomy Balance Pass 2: Market Tendency

Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
2020-08-20 17:08:15 +01:00
SkyratBot
626f232601 [MIRROR] Highlander keeps most races (#437)
* Highlander keeps most races (#53006)

Highlander now only humanizes you if the species you currently are doesn't need an outfit to stay alive.

* Highlander keeps most races

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
2020-08-20 17:07:47 +01:00
SkyratBot
8350ff4499 [MIRROR] Voice analyzers will no longer accept any message when nothing is recorded (#435)
* Voice analyzers will no longer accept any message when not recorded (#53033)

* Voice analyzers will no longer accept any message when nothing is recorded

Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
2020-08-20 17:06:54 +01:00
SkyratBot
c721e4015e [MIRROR] Fixes Swarmer Barriers (#432)
* Fixes Swarmer Barriers (#53049)

* Fixes Swarmer Barriers

Co-authored-by: IndieanaJones <47086570+IndieanaJones@users.noreply.github.com>
2020-08-19 23:52:57 -04:00
SkyratBot
b1fd099825 [MIRROR] Prevent duplicate names for vents and scrubbers in the air alarm (#431)
* Prevent duplicate names for vents and scrubbers in the air alarm (#52398)

It is always a pain adding in a new vent or scrubber to an area and suddenly you have duplicate names.
This prevents duplicate names for vents and scrubbers in an area.
Why It's Good For The Game

Makes engineering's life better, duplicate names are bad.
Changelog

cl
fix: Prevent duplicate vent and scrubber names in the air alarm interface.
/cl

* Prevent duplicate names for vents and scrubbers in the air alarm

Co-authored-by: NightRed <nightred@gmail.com>
2020-08-19 20:17:59 -04:00
SkyratBot
e65a48e91f [MIRROR] Adds SIGNAL_HANDLER and SIGNAL_HANDLER_DOES_SLEEP to prevent signal callbacks from blocking (#430)
* Adds SIGNAL_HANDLER and SIGNAL_HANDLER_DOES_SLEEP to prevent signal callbacks from blocking (#52761)

Adds SIGNAL_HANDLER, a macro that sets SHOULD_NOT_SLEEP(TRUE). This should ideally be required on all new signal callbacks.

Adds BLOCKING_SIGNAL_HANDLER, a macro that does nothing except symbolize "this is an older signal that didn't necessitate a code rewrite". It should not be allowed for new work.

This comes from discussion around #52735, which yields by calling input, and (though it sets the return type beforehand) will not properly return the flag to prevent attack from slapping.

To fix 60% of the yielding cases, WrapAdminProcCall no longer waits for another admin's proc call to finish. I'm not an admin, so I don't know how many behinds this has saved, but if this is problematic for admins I can just make it so that it lets you do it anyway. I'm not sure what the point of this babysitting was anyway.

Requested by @optimumtact.
Changelog

cl
admin: Calling a proc while another admin is calling one will no longer wait for the first to finish. You will simply just have to call it again.
/cl

* Adds SIGNAL_HANDLER and SIGNAL_HANDLER_DOES_SLEEP to prevent signal callbacks from blocking

Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
2020-08-19 20:17:28 -04:00
SkyratBot
4a4587b854 [MIRROR] Adds nekomimetic, the felinid language (#429)
* Adds nekomimetic, the felinid language (#52958)

Currently felinids are the only roundstart species without a language, this sees to that.
Changelog

cl Skoglol
add: Adds nekomimetic.
/cl

* Adds nekomimetic, the felinid language

Co-authored-by: skoglol <33292112+kriskog@users.noreply.github.com>
2020-08-19 20:16:38 -04:00
SkyratBot
d2778728a5 [MIRROR] Removes "availible" mispellings in codebase (#427)
* Removes "availible" mispellings in codebase (#53046)

* AVAILABLE

* Rebuild tgui

Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>

* Removes "availible" mispellings in codebase

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
2020-08-19 20:14:11 -04:00
SkyratBot
3ef712a8d4 [MIRROR] [s] sanitizes nanite extra settings (#426)
* [s] sanitizes nanite extra settings (#53065)

/datum/nanite_extra_setting/text/get_value()
return html_encode(value)

HTML injection bad. Brainwashing and potentially happiness programs are all subject to this, unless code has changed for how objective text is rendered. I don't think there's any case where nanites even need to be able to accept raw html.

* [s] sanitizes nanite extra settings

Co-authored-by: silicons <2003111+silicons@users.noreply.github.com>
2020-08-19 20:13:16 -04:00
SkyratBot
23f2d43174 [MIRROR] Small Plasmamen envirosuit spelling fixes (#423)
* Small Plasmamen envirosuit spelling fixes (#53045)

* Small Plasmamen envirosuit spelling fixes

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
2020-08-19 20:11:32 -04:00
SkyratBot
c55bb05cdf [MIRROR] Removes annoying double space from health doll examining. (#422)
* Removes double space from health doll examining. (#53025)

* Removes annoying double space from health doll examining.

Co-authored-by: uomo <51800976+uomo91@users.noreply.github.com>
2020-08-19 20:09:58 -04:00
SkyratBot
d9053be65e [MIRROR] Monkey powder now respects the monkey cap config (#421)
* Monkey powder now respects the monkey cap config (#53024)

* Monkey powder now respects the monkey cap config

Co-authored-by: ArcaneDefence <51932756+ArcaneDefence@users.noreply.github.com>
2020-08-19 20:09:12 -04:00
SkyratBot
d174cbd436 [MIRROR] species now correctly do not include organs they do not use (#420)
* species now correctly do not include organs they do not use (#53030)

* species now correctly do not include organs they do not use

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
2020-08-19 20:08:50 -04:00
SkyratBot
1eecada7ab [MIRROR] Adds Hypernoblium interactions with Plasmamans to stop self combustion. (#416)
* Adds Hypernoblium interactions with Plasmamans to stop self combustion. (#52942)

Plasmamen won't interact with O2 if there is also Hypernoblium in the air and if already on fire, will get extinguished.
Adds Hypernoblium as a reagent when inhaled, having Hypernoblium in your system as a Plasmamen will also stop combustion.

* Adds Hypernoblium interactions with Plasmamans to stop self combustion.

Co-authored-by: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com>
2020-08-19 19:57:57 -04:00
SkyratBot
c023ec87e9 [MIRROR] New breathtaking medical stack: the mourning poultice! (#415)
* New breathtaking medical stack: the mourning poultice! (#52968)

New type of medical stack, obtainable from botany: the mourning poultice.

These poultices convert 10 brute and 10 burn into oxy per application, and can be used on corpses as well as the living.

It takes 20u bungotoxin, 20u aloe juice and 20u cellulose to create one stack.

I have split all the existing medical stacks into their own dmi, stacks_medical.dmi.

* New breathtaking medical stack: the mourning poultice!

Co-authored-by: Krysonism <49783092+Krysonism@users.noreply.github.com>
2020-08-19 19:57:28 -04:00
SkyratBot
1ec8cd6a2d [MIRROR] Plants now show their maximum reagent capacity on plant analyzer examine with reagent mode on. (#414)
* Bam ath happy (#53039)

* Plants now show their maximum reagent capacity on plant analyzer examine with reagent mode on.

Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
2020-08-19 19:56:31 -04:00
SkyratBot
05f58509c0 [MIRROR] Chemistry machines drop beakers on floor if you are not beside them (#413)
* Chemistry machines drop beakers on floor if you are not beside them (#52922)

When ejecting a beaker it would teleport to your hand.
This checks that you are in range, if not the beaker drops at the machine.

Fixes #52882

* Chemistry machines drop beakers on floor if you are not beside them

Co-authored-by: NightRed <nightred@gmail.com>
2020-08-19 19:56:07 -04:00
SkyratBot
8efc495dee [MIRROR] tgui: Yarn Berry (#410)
* tgui: Yarn Berry (#53026)

This pull request upgrades Yarn to version 2 (also known as Yarn Berry).
* Update build validator

* Provide inferno in the root level package

* Remove type module from package.json

* Powershell build script

* tgui: Yarn Berry

Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
2020-08-19 18:18:24 +02:00
SkyratBot
035aebc2a2 [MIRROR] Diagonal macro thingu (#407)
* Diagonal macro thingu (#52927)

* Diagonal macro thingu

Co-authored-by: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
2020-08-19 04:53:44 +02:00
SkyratBot
42da7ac369 [MIRROR] Reworks the Hierophant Club as a general utility item and removes attacks. (#409)
* Reworks the Hierophant Club as a general utility item and removes attacks. (#52880)

This PR reworks the Hierophant Club into a utility item. Mining? Gone. Attacks? Gone.

In their place? 5-tile range point-and-click instant teleport similar to the ninja. Max charge is 1. Recharge time is 15 seconds.

With the removal of this bloat, the item is now small enough to fit in the average backpack.

The hiero club establishes itself as the entry-level megafauna drop from the entry-level megafauna.

* Reworks the Hierophant Club as a general utility item and removes attacks.

Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
2020-08-19 04:53:26 +02:00
SkyratBot
15b881799f [MIRROR] General nanite nerfs. (#406)
* General nanite nerfs. (#52937)

Nanites have recieved a general nerf, mostly in the healing department. This is probably not enough nerfs, actually.

* General nanite nerfs.

Co-authored-by: CRITAWAKETS <sebastienracicot@hotmail.com>
2020-08-19 04:49:32 +02:00
SkyratBot
72c69368b6 [MIRROR] Opacity refactor (#405)
* Opacity refactor (#52881)

    Moves all opacity var manipulation to a proc which sends a signal.
    light_blocker element for movable opaque atoms made, which tracks its movement and updates the affected turfs for proper lighting updates.
    has_opaque_atom boolean replaced by the opacity_sources lazylist to keep track of the sources, and a directional_opacity which serves a similar function but also allows for future expansion with on-border opaque objects (not yet implemented).
    Some opacity-related sight procs optimized as a result of this.
    Some variables moved to the object's definition.
    A define or two added into the mix for clarity.
    Some code cleaning, like turning booleans into their defines.
    One file renamed for clarity.

Changelog

cl
balance: Mechs no longer block sight. It's a non-trivial cost for the lighting system with little to no gain.
/cl

* Opacity refactor

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-08-19 04:48:14 +02:00
SkyratBot
a2fdb31307 [MIRROR] Adds reminders as to which cult structures make which cult items (#404)
* Adds reminders as to which cult structures make which cult items (#52637)

Said reminders are present in both the descriptions of those cult structures and in the stack recipe menu for runed metal.

* Adds reminders as to which cult structures make which cult items

Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>
2020-08-19 04:47:42 +02:00
SkyratBot
f424b7853e [MIRROR] cleanup the corpse file, cleanup stationstuck component, adds stationstuck to the reanimated skeleton (and zombie, why not) (#403)
* cleanup the corpse file, cleanup stationstuck component, adds stationstuck to the reanimated skeleton (and zombie, why not) (#52940)

all living spawners in corpse.dm are now in ghost_role_spawners. I hate having to search two different files to HOPEFULLY find which ghost role I need to edit.

Added a disclaimer about giving guidance or at least stationstuck component to stuff so this doesn't happen again

Cleaned up stationstuck. Man, I know I made this, but damn I did kind of a shit job

* cleanup the corpse file, cleanup stationstuck component, adds stationstuck to the reanimated skeleton (and zombie, why not)

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
2020-08-19 04:46:47 +02:00
SkyratBot
d8f5dc18d4 [MIRROR] Cleaning machines and the cleanbot now scrubs instead of washes, wiping forensics (#402)
* Cleaning machines and the cleanbot now scrubs instead of washes, wiping forensics (#52983)

* Cleaning machines and the cleanbot now scrubs instead of washes, wiping forensics

Co-authored-by: Donkie <daniel.cf.hultgren@gmail.com>
2020-08-19 04:42:48 +02:00
SkyratBot
10eba0fc9f [MIRROR] Fix new player panel not showing if the DB is misconfigured (#400)
* Fix the poll menu from breaking the join menu when the DB is misconfigured (#52949)

The returns if the DB is connected but the query errors mean the new player panel is never shown. This is a problem.

* Fix new player panel not showing if the DB is misconfigured

Co-authored-by: Tad Hardesty <tad@platymuus.com>
2020-08-19 04:11:55 +02:00
SkyratBot
e06d6f577a [MIRROR] Adds an admin force wardec button to the antag panel. (#398)
* Adds an admin force wardec button to the antag panel. (#52967)

If nukies have spawned, the war button exists and war has not been declared, the check antag panel now has a button to force war. This bypasses the crew and time limit. Made by admin request.

* Adds an admin force wardec button to the antag panel.

Co-authored-by: skoglol <33292112+kriskog@users.noreply.github.com>
2020-08-19 03:30:30 +02:00